[Approved] RFR: Use inheritIO for git command to get output

Robin Westberg rwestberg at openjdk.org
Fri Oct 11 08:55:58 UTC 2019


On Fri, 11 Oct 2019 08:54:45 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> this small patch uses a `ProcessBuilder` for `git push --set-upstream` instead of the `Repository.push` function. This is done in order to have to the `git` process inherit the file descriptors from the `java` process, so that the output from `git` will be shown in the terminal.
> 
> Thanks,
> Erik
> 
> ----------------
> 
> Commits:
>  - 1d164cfd: Use inheritIO for git command to get output
> 
> Changes: https://git.openjdk.java.net/skara/pull/199/files
>  Webrev: https://webrevs.openjdk.java.net/skara/199/webrev.00
>   Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod
>   Patch: https://git.openjdk.java.net/skara/pull/199.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/199/head:pull/199

Looks good!

----------------

Approved by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/199


More information about the skara-dev mailing list