[Approved] RFR: 130: Integrating outdated PRs shows an empty error message
Erik Helin
ehelin at openjdk.org
Mon Oct 14 09:28:49 UTC 2019
On Mon, 14 Oct 2019 07:29:12 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
> Hi all,
>
> Please review this change that ensures that an attempt to integrate an outdated PR shows a proper error message instead of just an empty comment.
>
> Best regards,
> Robin
>
> ----------------
>
> Commits:
> - 2f8ae849: Propagate the error message when rebasing fails
>
> Changes: https://git.openjdk.java.net/skara/pull/201/files
> Webrev: https://webrevs.openjdk.java.net/skara/201/webrev.00
> Issue: https://bugs.openjdk.java.net/browse/SKARA-130
> Stats: 116 lines in 5 files changed: 114 ins; 0 del; 2 mod
> Patch: https://git.openjdk.java.net/skara/pull/201.diff
> Fetch: git fetch https://git.openjdk.java.net/skara pull/201/head:pull/201
Nice fix, looks good!
----------------
Approved by ehelin (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/201
More information about the skara-dev
mailing list