[Approved] RFR: Correctly compare the os property when generating launch scripts

Erik Helin ehelin at openjdk.org
Mon Oct 14 09:35:48 UTC 2019


On Mon, 14 Oct 2019 09:29:49 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Previous code was comparing `Propterty<String>` to a `String` -> get the `String` from it first
> 
> ----------------
> 
> Commits:
>  - 15cfc426: correctly compare the os property when generating launch scripts
> 
> Changes: https://git.openjdk.java.net/skara/pull/202/files
>  Webrev: https://webrevs.openjdk.java.net/skara/202/webrev.00
>   Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
>   Patch: https://git.openjdk.java.net/skara/pull/202.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/202/head:pull/202

Looks good, thanks for fixing!

----------------

Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/202


More information about the skara-dev mailing list