[Approved] RFR: 134: BotRunnerConfiguration cannot parse hosts
Robin Westberg
rwestberg at openjdk.org
Fri Oct 18 08:21:39 UTC 2019
On Fri, 18 Oct 2019 08:15:39 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
>
> this patch fixes a bug that was introduced after the `host` module split. We must separate the different kinds of hosts in the bot configuration file, otherwise the `BotRunnerConfiguration` can't do sanity checking on the configuration.
>
> Thanks,
> Erik
>
> ## Testing
> - [x] `sh gradlew test` passes
> - [x] `sh gradlew images` passes
>
> ----------------
>
> Commits:
> - 9e30a6b2: 134: BotRunnerConfiguration cannot parse hosts
>
> Changes: https://git.openjdk.java.net/skara/pull/209/files
> Webrev: https://webrevs.openjdk.java.net/skara/209/webrev.00
> Issue: https://bugs.openjdk.java.net/browse/SKARA-134
> Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
> Patch: https://git.openjdk.java.net/skara/pull/209.diff
> Fetch: git fetch https://git.openjdk.java.net/skara pull/209/head:pull/209
Looks good!
----------------
Approved by rwestberg (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/209
More information about the skara-dev
mailing list