[Approved] RFR: Minor test cleanup

Robin Westberg rwestberg at openjdk.org
Mon Oct 21 11:52:03 UTC 2019


On Mon, 21 Oct 2019 09:47:06 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that properly cleans up a temporary directory from one test in `RepositoryTests` and also sets the `exceptionFormat` to `"full"` for all `test` targets (so that if a test fails we get full stacktraces).
> 
> Thanks,
> Erik
> 
> ## Testing
> - `sh gradlew test` passes on Linux x64
> 
> ----------------
> 
> Commits:
>  - 15085039: Minor test cleanup
> 
> Changes: https://git.openjdk.java.net/skara/pull/216/files
>  Webrev: https://webrevs.openjdk.java.net/skara/216/webrev.00
>   Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod
>   Patch: https://git.openjdk.java.net/skara/pull/216.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/216/head:pull/216

Looks good!

----------------

Approved by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/216


More information about the skara-dev mailing list