[Approved] RFR: No need for locking when using TestHostedRepository

Erik Helin ehelin at openjdk.org
Tue Oct 22 09:23:04 UTC 2019


On Mon, 21 Oct 2019 15:23:55 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that skips creating repository lock files when using the TestHostedRepository, as it uses unique temporary folders anyway. This makes the tests run a little bit faster.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 16446a6e: No need for locking when using TestHostedRepository
> 
> Changes: https://git.openjdk.java.net/skara/pull/219/files
>  Webrev: https://webrevs.openjdk.java.net/skara/219/webrev.00
>   Stats: 9 lines in 1 file changed: 8 ins; 1 del; 0 mod
>   Patch: https://git.openjdk.java.net/skara/pull/219.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/219/head:pull/219

Looks good!

----------------

Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/219


More information about the skara-dev mailing list