[Approved] RFR: 137: Watchdog test can fail to terminate

Erik Helin ehelin at openjdk.org
Wed Oct 23 13:46:02 UTC 2019


On Wed, 23 Oct 2019 10:52:01 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that fixes a problem with the BotRunnerTests.watchdogTrigger test.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 92fda46a: Re-enable for windows
>  - 3af96ddc: Use the real runner loop for watchdog test
> 
> Changes: https://git.openjdk.java.net/skara/pull/221/files
>  Webrev: https://webrevs.openjdk.java.net/skara/221/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/SKARA-137
>   Stats: 9 lines in 2 files changed: 3 ins; 2 del; 4 mod
>   Patch: https://git.openjdk.java.net/skara/pull/221.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/221/head:pull/221

Looks good!

----------------

Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/221


More information about the skara-dev mailing list