RFR: Create forges from service providers

[Erik Helin]

On Thu, 24 Oct 2019 08:51:32 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this refactoring that allows forges to be created from service providers.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 063bcf6b: Create Forges from service providers
> 
> Changes: https://git.openjdk.java.net/skara/pull/223/files
>  Webrev: https://webrevs.openjdk.java.net/skara/223/webrev.00
>   Stats: 2799 lines in 33 files changed: 1446 ins; 1294 del; 59 mod
>   Patch: https://git.openjdk.java.net/skara/pull/223.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/223/head:pull/223

forge/src/main/java/org/openjdk/skara/forge/Forge.java line 60:

> 59:         return Optional.empty();
> 60:     }
> 61: 

Maybe catch `IllegalArgumentException` instead? A bit more meaning than just `RuntimeException` :)

PR: https://git.openjdk.java.net/skara/pull/223