[Approved] RFR: 142: The new_line field of a GitLab review comment can be null

Fri Oct 25 13:24:28 UTC 2019

On Fri, 25 Oct 2019 09:13:48 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this small change that avoids trying to parse a null value as an integer.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 55174654: Use the old_line value if new_line is null
> 
> Changes: https://git.openjdk.java.net/skara/pull/226/files
>  Webrev: https://webrevs.openjdk.java.net/skara/226/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/SKARA-142
>   Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
>   Patch: https://git.openjdk.java.net/skara/pull/226.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/226/head:pull/226

Looks good!

----------------

Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/226