[Approved] RFR: Support review comments on deleted parts of files on GitLab

Erik Helin ehelin at openjdk.org
Mon Oct 28 12:37:59 UTC 2019


On Mon, 28 Oct 2019 10:34:04 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that properly parses GitLab review comments on deleted parts of a change.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 2b9d74c2: Support review comments on deleted parts of files on GitLab
> 
> Changes: https://git.openjdk.java.net/skara/pull/227/files
>  Webrev: https://webrevs.openjdk.java.net/skara/227/webrev.00
>   Stats: 16 lines in 1 file changed: 11 ins; 0 del; 5 mod
>   Patch: https://git.openjdk.java.net/skara/pull/227.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/227/head:pull/227

Looks good!

----------------

Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/227


More information about the skara-dev mailing list