[Approved] RFR: Use a service provider to create issue trackers

Erik Helin ehelin at openjdk.org
Mon Oct 28 12:39:58 UTC 2019


On Mon, 28 Oct 2019 12:00:53 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this refactoring that makes use of a service provider to create issue trackers, similarly to how forges are handled.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 1549c96f: Related whitespace cleanups
>  - 20ee09d3: Use a service provider to create issue trackers
> 
> Changes: https://git.openjdk.java.net/skara/pull/229/files
>  Webrev: https://webrevs.openjdk.java.net/skara/229/webrev.00
>   Stats: 698 lines in 13 files changed: 382 ins; 307 del; 9 mod
>   Patch: https://git.openjdk.java.net/skara/pull/229.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/229/head:pull/229

Looks good. I think this whole refactoring came together very nicely, well done!

----------------

Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/229


More information about the skara-dev mailing list