From duke at openjdk.java.net Mon Sep 2 11:16:39 2019 From: duke at openjdk.java.net (Marc Philipp via github.com) Date: Mon, 2 Sep 2019 11:16:39 GMT Subject: RFR: Upgrade JUnit 5 to 5.5.1 In-Reply-To: References: Message-ID: On Thu, 22 Aug 2019 14:10:58 GMT, Erik Duveblad via github.com wrote: > On Thu, 22 Aug 2019 11:58:43 GMT, Christian Stein via github.com wrote: > >> Upgrade JUnit 5 to Jupiter 5.5.1 and Platform 1.5.1 >> >> - Set Jupiter version number 5.5.1 >> - Introduce Platform Launcher 1.5.1 test runtime dependency >> in order to force Gradle to load the module from the module-path >> - Add missing "requires 'org.junit.jupiter.params'" directives >> in modules: jcheck, storage, vcs, and webrev >> >> Solves https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69 >> >> ---------------- >> >> Commits: >> - 5e253f99: Upgrade JUnit 5 to Jupiter 5.5.1 and Platform 1.5.1 >> - Set Jupiter version number 5.5.1 >> - Introduce Platform Launcher 1.5.1 test runtime dependency >> in order to force Gradle to load the module from the module-path >> - Add missing "requires 'org.junit.jupiter.params'" directives >> in modules: jcheck, storage, vcs, and webrev >> Solves https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69 >> >> Pull request: >> https://git.openjdk.java.net/skara/pull/66 >> >> Webrev: >> https://webrevs.openjdk.java.net/skara/66/webrev.00 >> >> Patch: >> https://git.openjdk.java.net/skara/pull/66.diff >> >> Fetch command: >> git fetch https://git.openjdk.java.net/skara pull/66/head:pull/66 > > build.gradle line 54: > >> 53: >> 54: test { >> 55: useJUnitPlatform() > > Hmm, I don't really follow here - how does adding a test runtime dependency on org.junit.platform:junit-platform-launcher:1.5.1 force Gradle to load the JUnit Platform launcher from the module path? Did you forgot to `git add` a change made to `buildSrc/.../ModulePlugin.java`? > > PR: https://git.openjdk.java.net/skara/pull/66 Gradle always puts the version of the junit-platform-launcher it ships with on the classpath. Adding `org.junit.platform:junit-platform-launcher:1.5.1` to the module path seems to hide that version from the classloader which now loads the version on the module path instead. This version is a proper module and may access the `org.junit.platform.commons.util` package of the junit-platform-commons module. PR: https://git.openjdk.java.net/skara/pull/66 From duke at openjdk.java.net Mon Sep 2 12:55:07 2019 From: duke at openjdk.java.net (Jorn Vernee via github.com) Date: Mon, 2 Sep 2019 12:55:07 GMT Subject: RFR: Coalesce hunks that have overlapping context In-Reply-To: References: Message-ID: <72uuszWey-ItbMlj20g2ddyCIxR6vUlfLEZBSvsQVLg=.0938b599-069c-43fe-968a-b3271986a4a4@github.com> The pull request has been updated with additional changes. ---------------- Added commits: - e879dc36: Add test with non-overlapping hunks Pull request: https://git.openjdk.java.net/skara/pull/113 Webrevs: - full: https://webrevs.openjdk.java.net/skara/113/webrev.01 - inc: https://webrevs.openjdk.java.net/skara/113/webrev.00-01 Updated full patch: https://git.openjdk.java.net/skara/pull/113.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/113/head:pull/113 From duke at openjdk.java.net Mon Sep 2 12:59:42 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Mon, 2 Sep 2019 12:59:42 GMT Subject: RFR: Coalesce hunks that have overlapping context In-Reply-To: References: Message-ID: On Fri, 30 Aug 2019 13:56:52 GMT, Jorn Vernee via github.com wrote: > The `webrev` command can generate patch files with adjacent hunks that have overlapping context. `git apply` rejects these patches. > > This PR coalesces adjacent hunks with overlapping context, which is also what's done by `git diff`. > > Also added a test for `HunkCoalescer` (since it's a pretty complex class I think it deserved it's own tests). > > Resulting webrev applies with both git and hg. > > ---------------- > > Commits: > - 6f5f1071: Coalesce hunks that have overlapping context, since git rejects these otherwise > > Pull request: > https://git.openjdk.java.net/skara/pull/113 > > Webrev: > https://webrevs.openjdk.java.net/skara/113/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/113.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/113/head:pull/113 This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment: This looks fine, but please run some additional manual testing to check that it works. Sorry for the lack of unit tests for this code :( PR: https://git.openjdk.java.net/skara/pull/113 From duke at openjdk.java.net Mon Sep 2 14:07:29 2019 From: duke at openjdk.java.net (duke) Date: Mon, 2 Sep 2019 14:07:29 GMT Subject: git: openjdk/skara: Topological bot tests needs to read org.junit.jupiter.params Message-ID: <488b738e-d860-44a4-9e4d-35e48878b4b0@openjdk.java.net> Changeset: a0e7eda5 Author: Erik Helin Date: 2019-09-02 14:06:48 +0000 URL: https://github.com/openjdk/skara/commit/a0e7eda5 Topological bot tests needs to read org.junit.jupiter.params Reviewed-by: rwestberg ! bots/topological/build.gradle From duke at openjdk.java.net Mon Sep 2 14:58:33 2019 From: duke at openjdk.java.net (Jorn Vernee via github.com) Date: Mon, 2 Sep 2019 14:58:33 GMT Subject: RFR: Coalesce hunks that have overlapping context In-Reply-To: References: Message-ID: On Fri, 30 Aug 2019 13:56:52 GMT, Jorn Vernee via github.com wrote: > The `webrev` command can generate patch files with adjacent hunks that have overlapping context. `git apply` rejects these patches. > > This PR coalesces adjacent hunks with overlapping context, which is also what's done by `git diff`. > > Also added a test for `HunkCoalescer` (since it's a pretty complex class I think it deserved it's own tests). > > Resulting webrev applies with both git and hg. > > ---------------- > > Commits: > - 6f5f1071: Coalesce hunks that have overlapping context, since git rejects these otherwise > > Pull request: > https://git.openjdk.java.net/skara/pull/113 > > Webrev: > https://webrevs.openjdk.java.net/skara/113/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/113.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/113/head:pull/113 @edvbld I tested with the following script: ```powershell for ($i = 1; $i -le 20; $i++) { git webrev -r "HEAD~$i" -N git checkout "HEAD~$i" git apply .\webrev\git-jdk2.patch git checkout master --force } ``` This went alright until about `HEAD~16`, which threw a 'corrupt patch' error. Looking into it, the offending line is: diff a/test/hotspot/jtreg/ProblemList-aot.txt b/test/hotspot/jtreg/ProblemList-aot.txt I thought it might be the hyphen in the name, but `git diff` generates the same, and that patch does apply cleanly. Even when copying over the line from the git diff to the patch file generated by `webrev` it still complains. Not sure what's going on... However, running that script without this PR fails on the first webrev, so I'd say that is a net improvement :), and since the issue seems unrelated, I think we could still move ahead with this PR? PR: https://git.openjdk.java.net/skara/pull/113 From duke at openjdk.java.net Mon Sep 2 20:05:54 2019 From: duke at openjdk.java.net (Jorn Vernee via github.com) Date: Mon, 2 Sep 2019 20:05:54 GMT Subject: RFR: Add tool for importing webrev patches In-Reply-To: <9_jEaW011lAaAzSAWpXvPnqXcL9y_7QmPQYoF2x_muk=.e85bd45a-725d-4ec5-b0df-dc72eb53ee43@github.com> References: <9_jEaW011lAaAzSAWpXvPnqXcL9y_7QmPQYoF2x_muk=.e85bd45a-725d-4ec5-b0df-dc72eb53ee43@github.com> Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 7b037f9c: Redo style of SubCommandSwitch.java Pull request: https://git.openjdk.java.net/skara/pull/32 Webrevs: - full: https://webrevs.openjdk.java.net/skara/32/webrev.05 - inc: https://webrevs.openjdk.java.net/skara/32/webrev.04-05 Updated full patch: https://git.openjdk.java.net/skara/pull/32.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/32/head:pull/32 From duke at openjdk.java.net Tue Sep 3 08:05:29 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Tue, 3 Sep 2019 08:05:29 GMT Subject: RFR: Allow reverse mapping of census namespace users Message-ID: Hi all, Please review this small change that adds the possibility of mapping from a contributor to the corresponding namespace id. Best regards, Robin ---------------- Commits: - 23434d67: Allow reverse mapping of census namespace users Pull request: https://git.openjdk.java.net/skara/pull/115 Webrev: https://webrevs.openjdk.java.net/skara/115/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/115.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/115/head:pull/115 From duke at openjdk.java.net Tue Sep 3 08:34:31 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Tue, 3 Sep 2019 08:34:31 GMT Subject: RFR: Extend the repository configuration syntax Message-ID: Hi all, Please review this change that extends the BotRunner configuration parsing of repository names. Previously, every repository had to be described one time for each host/credential set it was to be used with. Now it is allowed to specify this directly as a string of the form `/`. Additionally, a ref name can optionally be appended of the form `:` at the end of the string. Best regards, Robin ---------------- Commits: - 78bc64f4: Extend the repository configuration syntax, allow fetching an embedded ref name Pull request: https://git.openjdk.java.net/skara/pull/116 Webrev: https://webrevs.openjdk.java.net/skara/116/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/116.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/116/head:pull/116 From duke at openjdk.java.net Tue Sep 3 08:45:33 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Tue, 3 Sep 2019 08:45:33 GMT Subject: RFR: Allow reverse mapping of census namespace users In-Reply-To: References: Message-ID: On Tue, 3 Sep 2019 08:05:29 GMT, Robin Westberg via github.com wrote: > Hi all, > > Please review this small change that adds the possibility of mapping from a contributor to the corresponding namespace id. > > Best regards, > Robin > > ---------------- > > Commits: > - 23434d67: Allow reverse mapping of census namespace users > > Pull request: > https://git.openjdk.java.net/skara/pull/115 > > Webrev: > https://webrevs.openjdk.java.net/skara/115/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/115.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/115/head:pull/115 This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment: Looks good! PR: https://git.openjdk.java.net/skara/pull/115 From duke at openjdk.java.net Tue Sep 3 08:46:32 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Tue, 3 Sep 2019 08:46:32 GMT Subject: RFR: Extend the repository configuration syntax In-Reply-To: References: Message-ID: On Tue, 3 Sep 2019 08:34:31 GMT, Robin Westberg via github.com wrote: > Hi all, > > Please review this change that extends the BotRunner configuration parsing of repository names. Previously, every repository had to be described one time for each host/credential set it was to be used with. Now it is allowed to specify this directly as a string of the form `/`. Additionally, a ref name can optionally be appended of the form `:` at the end of the string. > > Best regards, > Robin > > ---------------- > > Commits: > - 78bc64f4: Extend the repository configuration syntax, allow fetching an embedded ref name > > Pull request: > https://git.openjdk.java.net/skara/pull/116 > > Webrev: > https://webrevs.openjdk.java.net/skara/116/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/116.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/116/head:pull/116 This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment: Obviously correct :smile: Thanks for the tests! PR: https://git.openjdk.java.net/skara/pull/116 From duke at openjdk.java.net Tue Sep 3 08:47:30 2019 From: duke at openjdk.java.net (duke) Date: Tue, 3 Sep 2019 08:47:30 GMT Subject: git: openjdk/skara: Extend the repository configuration syntax Message-ID: <0f89a4cb-ca12-4cfe-8d72-06526e4d64d0@openjdk.java.net> Changeset: 2aa4482c Author: Robin Westberg Date: 2019-09-03 08:47:03 +0000 URL: https://github.com/openjdk/skara/commit/2aa4482c Extend the repository configuration syntax Reviewed-by: ehelin ! bot/src/main/java/org/openjdk/skara/bot/BotConfiguration.java ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java ! bot/src/test/java/org/openjdk/skara/bot/BotRunnerConfigurationTests.java From duke at openjdk.java.net Tue Sep 3 08:48:00 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Tue, 3 Sep 2019 08:48:00 GMT Subject: RFR: Coalesce hunks that have overlapping context In-Reply-To: References: Message-ID: On Mon, 2 Sep 2019 14:58:33 GMT, Jorn Vernee via github.com wrote: > On Fri, 30 Aug 2019 13:56:52 GMT, Jorn Vernee via github.com wrote: > >> The `webrev` command can generate patch files with adjacent hunks that have overlapping context. `git apply` rejects these patches. >> >> This PR coalesces adjacent hunks with overlapping context, which is also what's done by `git diff`. >> >> Also added a test for `HunkCoalescer` (since it's a pretty complex class I think it deserved it's own tests). >> >> Resulting webrev applies with both git and hg. >> >> ---------------- >> >> Commits: >> - 6f5f1071: Coalesce hunks that have overlapping context, since git rejects these otherwise >> >> Pull request: >> https://git.openjdk.java.net/skara/pull/113 >> >> Webrev: >> https://webrevs.openjdk.java.net/skara/113/webrev.00 >> >> Patch: >> https://git.openjdk.java.net/skara/pull/113.diff >> >> Fetch command: >> git fetch https://git.openjdk.java.net/skara pull/113/head:pull/113 > > @edvbld I tested with the following script: > > ```powershell > for ($i = 1; $i -le 20; $i++) { > git webrev -r "HEAD~$i" -N > git checkout "HEAD~$i" > git apply .\webrev\git-jdk2.patch > git checkout master --force > } > ``` > This went alright until about `HEAD~16`, which threw a 'corrupt patch' error. Looking into it, the offending line is: > > diff a/test/hotspot/jtreg/ProblemList-aot.txt b/test/hotspot/jtreg/ProblemList-aot.txt > > I thought it might be the hyphen in the name, but `git diff` generates the same, and that patch does apply cleanly. Even when copying over the line from the git diff to the patch file generated by `webrev` it still complains. Not sure what's going on... > > However, running that script without this PR fails on the first webrev, so I'd say that is a net improvement :), and since the issue seems unrelated, I think we could still move ahead with this PR? > > PR: https://git.openjdk.java.net/skara/pull/113 @JornVernee yeah lets integrate this one since it is an improvement at least PR: https://git.openjdk.java.net/skara/pull/113 From duke at openjdk.java.net Tue Sep 3 08:48:33 2019 From: duke at openjdk.java.net (duke) Date: Tue, 3 Sep 2019 08:48:33 GMT Subject: git: openjdk/skara: Allow reverse mapping of census namespace users Message-ID: <1a2eac81-009c-47ab-b1a5-472382cfdd61@openjdk.java.net> Changeset: ac12500e Author: Robin Westberg Date: 2019-09-03 08:48:14 +0000 URL: https://github.com/openjdk/skara/commit/ac12500e Allow reverse mapping of census namespace users Reviewed-by: ehelin ! census/src/main/java/org/openjdk/skara/census/Namespace.java ! census/src/test/java/org/openjdk/skara/census/CensusTests.java From duke at openjdk.java.net Tue Sep 3 09:40:29 2019 From: duke at openjdk.java.net (duke) Date: Tue, 3 Sep 2019 09:40:29 GMT Subject: git: openjdk/skara: Coalesce hunks that have overlapping context Message-ID: <2f2e3700-cef2-4fbe-b922-815c51224744@openjdk.java.net> Changeset: 4c6b8ae0 Author: Jorn Vernee Date: 2019-09-03 09:39:29 +0000 URL: https://github.com/openjdk/skara/commit/4c6b8ae0 Coalesce hunks that have overlapping context Reviewed-by: ehelin ! webrev/src/main/java/org/openjdk/skara/webrev/HunkCoalescer.java + webrev/src/test/java/org/openjdk/skara/webrev/HunkCoalescerTest.java From duke at openjdk.java.net Tue Sep 3 10:28:32 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Tue, 3 Sep 2019 10:28:32 GMT Subject: RFR: 76: Remove the "ready" label from a PR once it is integrated Message-ID: Hi all, Please review this change that removes the ready (and sponsor) labels from a PR after it has been integrated. Best regards, Robin ---------------- Commits: - ba8a6de6: Remove ready and sponsor labels after integration Pull request: https://git.openjdk.java.net/skara/pull/117 Webrev: https://webrevs.openjdk.java.net/skara/117/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/117.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/117/head:pull/117 From duke at openjdk.java.net Tue Sep 3 14:55:49 2019 From: duke at openjdk.java.net (Jorn Vernee via github.com) Date: Tue, 3 Sep 2019 14:55:49 GMT Subject: RFR: Add tool for importing webrev patches In-Reply-To: <9_jEaW011lAaAzSAWpXvPnqXcL9y_7QmPQYoF2x_muk=.e85bd45a-725d-4ec5-b0df-dc72eb53ee43@github.com> References: <9_jEaW011lAaAzSAWpXvPnqXcL9y_7QmPQYoF2x_muk=.e85bd45a-725d-4ec5-b0df-dc72eb53ee43@github.com> Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 3e1baa7e: Add missing copyright notices Pull request: https://git.openjdk.java.net/skara/pull/32 Webrevs: - full: https://webrevs.openjdk.java.net/skara/32/webrev.06 - inc: https://webrevs.openjdk.java.net/skara/32/webrev.05-06 Updated full patch: https://git.openjdk.java.net/skara/pull/32.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/32/head:pull/32 From duke at openjdk.java.net Tue Sep 3 15:27:42 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Tue, 3 Sep 2019 15:27:42 GMT Subject: RFR: 76: Remove the "ready" label from a PR once it is integrated In-Reply-To: References: Message-ID: On Tue, 3 Sep 2019 10:28:32 GMT, Robin Westberg via github.com wrote: > Hi all, > > Please review this change that removes the ready (and sponsor) labels from a PR after it has been integrated. > > Best regards, > Robin > > ---------------- > > Commits: > - ba8a6de6: Remove ready and sponsor labels after integration > > Pull request: > https://git.openjdk.java.net/skara/pull/117 > > Webrev: > https://webrevs.openjdk.java.net/skara/117/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/117.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/117/head:pull/117 This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment: Looks good! PR: https://git.openjdk.java.net/skara/pull/117 From duke at openjdk.java.net Wed Sep 4 07:08:32 2019 From: duke at openjdk.java.net (duke) Date: Wed, 4 Sep 2019 07:08:32 GMT Subject: git: openjdk/skara: Allow more compact bot configuration Message-ID: Changeset: 418efc96 Author: Robin Westberg Date: 2019-09-04 07:07:33 +0000 URL: https://github.com/openjdk/skara/commit/418efc96 Allow more compact bot configuration Reviewed-by: ehelin ! bot/src/main/java/org/openjdk/skara/bot/BotConfiguration.java ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java ! bot/src/test/java/org/openjdk/skara/bot/BotRunnerConfigurationTests.java ! bots/merge/src/main/java/org/openjdk/skara/bots/merge/MergeBotFactory.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBotFactory.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java From duke at openjdk.java.net Wed Sep 4 07:09:32 2019 From: duke at openjdk.java.net (duke) Date: Wed, 4 Sep 2019 07:09:32 GMT Subject: git: openjdk/skara: 76: Remove the "ready" label from a PR once it is integrated Message-ID: Changeset: 7cf1b083 Author: Robin Westberg Date: 2019-09-04 07:08:48 +0000 URL: https://github.com/openjdk/skara/commit/7cf1b083 76: Remove the "ready" label from a PR once it is integrated Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SponsorCommand.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SponsorTests.java From duke at openjdk.java.net Wed Sep 4 07:29:29 2019 From: duke at openjdk.java.net (duke) Date: Wed, 4 Sep 2019 07:29:29 GMT Subject: git: openjdk/skara: Fix configuration parse error Message-ID: <91f8db5f-00e9-4e8c-a168-a3eadfa03d9c@openjdk.java.net> Changeset: 4cf872ce Author: Robin Westberg Date: 2019-09-04 07:29:14 +0000 URL: https://github.com/openjdk/skara/commit/4cf872ce Fix configuration parse error Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBotFactory.java From duke at openjdk.java.net Wed Sep 4 12:33:31 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Wed, 4 Sep 2019 12:33:31 GMT Subject: RFR: Add tool for importing webrev patches In-Reply-To: <9_jEaW011lAaAzSAWpXvPnqXcL9y_7QmPQYoF2x_muk=.e85bd45a-725d-4ec5-b0df-dc72eb53ee43@github.com> References: <9_jEaW011lAaAzSAWpXvPnqXcL9y_7QmPQYoF2x_muk=.e85bd45a-725d-4ec5-b0df-dc72eb53ee43@github.com> Message-ID: On Fri, 5 Jul 2019 10:01:57 GMT, JornVernee via github.com wrote: > As discussed on the mailing list: https://mail.openjdk.java.net/pipermail/skara-dev/2019-July/000176.html > > This PR adds a tool for importing webrev `.patch` files, either from a webrev url or local file path into a repository. > > I've named the tool `wimport` as short for `webrev-import` (I thought the full name sounded a bit too much like a sub-command of `webrev`). This will first checkout a new branch, then apply the patch, and then create a commit for the patch with the message `Imported patch 'NAME'`, similar to what is done by mq. Afterwards a user can just delete the new branch when they're done with e.g. reviewing the webrev. Although, there is also an option to directly apply the webrev without creating a branch or commit. > > Currently the following options are supported: > > usage: git wimport [options] > -n, --name NAME Use NAME as a name for the patch (default is patch file name) > -f, --file Input is a file path > -k, --keep Keep downloaded patch file in current directory > -d, --direct Directly apply patch, without creating a branch or commit > > ---------------- > > Commits: > - 7b20ce75: Wimport prototype > > Pull request: > http://git.openjdk.java.net/skara/pull/32 > > Webrev: > https://openjdk.github.io/cr/skara/32/webrev.00 > > Patch: > http://git.openjdk.java.net/skara/pull/32.diff > > Fetch command: > git fetch https://github.com/openjdk/skara.git pull/32/head:pull/32 args/src/main/java/org/openjdk/skara/args/MultiCommandParser.java line 41: > 40: if (defaults.size() != 1) { > 41: throw new IllegalStateException("Expecting exactly one default command"); > 42: } `IllegalArgumentException` instead? The `commands` are passed in :) PR: https://git.openjdk.java.net/skara/pull/32 args/src/main/java/org/openjdk/skara/args/MultiCommandParser.java line 70: > 69: } else { > 70: return this::showUsage; > 71: } Shouldn't this return the default command if one is present? Otherwise how will just `git webrev` work? PR: https://git.openjdk.java.net/skara/pull/32 args/src/main/java/org/openjdk/skara/args/MultiCommandParser.java line 61: > 60: if (p != null) { > 61: String[] forwardedArgs = Arrays.copyOfRange(args, 1, args.length); > 62: return () -> p.main(forwardedArgs); This is a nice place for `var` ;) PR: https://git.openjdk.java.net/skara/pull/32 vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java line 940: > 939: apply(patchFile, force); > 940: //Files.delete(patchFile); > 941: } We should probably uncomment this line :) PR: https://git.openjdk.java.net/skara/pull/32 From duke at openjdk.java.net Wed Sep 4 12:44:32 2019 From: duke at openjdk.java.net (Jorn Vernee via github.com) Date: Wed, 4 Sep 2019 12:44:32 GMT Subject: RFR: Add tool for importing webrev patches In-Reply-To: <9_jEaW011lAaAzSAWpXvPnqXcL9y_7QmPQYoF2x_muk=.e85bd45a-725d-4ec5-b0df-dc72eb53ee43@github.com> References: <9_jEaW011lAaAzSAWpXvPnqXcL9y_7QmPQYoF2x_muk=.e85bd45a-725d-4ec5-b0df-dc72eb53ee43@github.com> Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 3e72aabe: Address review comments Pull request: https://git.openjdk.java.net/skara/pull/32 Webrevs: - full: https://webrevs.openjdk.java.net/skara/32/webrev.07 - inc: https://webrevs.openjdk.java.net/skara/32/webrev.06-07 Updated full patch: https://git.openjdk.java.net/skara/pull/32.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/32/head:pull/32 From duke at openjdk.java.net Thu Sep 5 04:33:30 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Thu, 5 Sep 2019 04:33:30 GMT Subject: RFR: Add tool for importing webrev patches In-Reply-To: <9_jEaW011lAaAzSAWpXvPnqXcL9y_7QmPQYoF2x_muk=.e85bd45a-725d-4ec5-b0df-dc72eb53ee43@github.com> References: <9_jEaW011lAaAzSAWpXvPnqXcL9y_7QmPQYoF2x_muk=.e85bd45a-725d-4ec5-b0df-dc72eb53ee43@github.com> Message-ID: On Fri, 5 Jul 2019 10:01:57 GMT, JornVernee via github.com wrote: > As discussed on the mailing list: https://mail.openjdk.java.net/pipermail/skara-dev/2019-July/000176.html > > This PR adds a tool for importing webrev `.patch` files, either from a webrev url or local file path into a repository. > > I've named the tool `wimport` as short for `webrev-import` (I thought the full name sounded a bit too much like a sub-command of `webrev`). This will first checkout a new branch, then apply the patch, and then create a commit for the patch with the message `Imported patch 'NAME'`, similar to what is done by mq. Afterwards a user can just delete the new branch when they're done with e.g. reviewing the webrev. Although, there is also an option to directly apply the webrev without creating a branch or commit. > > Currently the following options are supported: > > usage: git wimport [options] > -n, --name NAME Use NAME as a name for the patch (default is patch file name) > -f, --file Input is a file path > -k, --keep Keep downloaded patch file in current directory > -d, --direct Directly apply patch, without creating a branch or commit > > ---------------- > > Commits: > - 7b20ce75: Wimport prototype > > Pull request: > http://git.openjdk.java.net/skara/pull/32 > > Webrev: > https://openjdk.github.io/cr/skara/32/webrev.00 > > Patch: > http://git.openjdk.java.net/skara/pull/32.diff > > Fetch command: > git fetch https://github.com/openjdk/skara.git pull/32/head:pull/32 This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment: Great work @JornVernee! Just a few tiny comments that you can fix before integrating :+1: PR: https://git.openjdk.java.net/skara/pull/32 args/src/main/java/org/openjdk/skara/args/MultiCommandParser.java line 57: > 56: public Executable parse(String[] args) { > 57: if (args.length != 0) { > 58: var p = subCommands.get(args[0]); Super tiny comment, and you can fix this before integrating, but I always prefer a positive check. In this case it would be `args.length > 0` to show that we can read the first argument. PR: https://git.openjdk.java.net/skara/pull/32 cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java line 300: > 299: .main(GitWebrev::apply) > 300: ); > 301: Since you are using `HttpClient` now we should make a call here to `HttpProxy.setup()` PR: https://git.openjdk.java.net/skara/pull/32 webrev/src/main/java/org/openjdk/skara/webrev/WebrevMetaData.java line 45: > 44: > 45: public static WebrevMetaData fromWebrevURL(String uri) throws IOException, URISyntaxException, InterruptedException { > 46: var sanatizedUri = sanitizeURI(uri); Maybe you want to rename this to `from` and instead take a `java.net.URL` as type for the argument? PR: https://git.openjdk.java.net/skara/pull/32 From duke at openjdk.java.net Fri Sep 6 10:45:31 2019 From: duke at openjdk.java.net (Jorn Vernee via github.com) Date: Fri, 6 Sep 2019 10:45:31 GMT Subject: RFR: Add tool for importing webrev patches In-Reply-To: <9_jEaW011lAaAzSAWpXvPnqXcL9y_7QmPQYoF2x_muk=.e85bd45a-725d-4ec5-b0df-dc72eb53ee43@github.com> References: <9_jEaW011lAaAzSAWpXvPnqXcL9y_7QmPQYoF2x_muk=.e85bd45a-725d-4ec5-b0df-dc72eb53ee43@github.com> Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 18f27687: Address review comments Pull request: https://git.openjdk.java.net/skara/pull/32 Webrevs: - full: https://webrevs.openjdk.java.net/skara/32/webrev.08 - inc: https://webrevs.openjdk.java.net/skara/32/webrev.07-08 Updated full patch: https://git.openjdk.java.net/skara/pull/32.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/32/head:pull/32 From duke at openjdk.java.net Fri Sep 6 10:51:37 2019 From: duke at openjdk.java.net (duke) Date: Fri, 6 Sep 2019 10:51:37 GMT Subject: git: openjdk/skara: Add tool for importing webrev patches Message-ID: <568e5a68-aa6c-4410-853c-adfed6efd6ff@openjdk.java.net> Changeset: 4a88959f Author: Jorn Vernee Date: 2019-09-06 10:51:26 +0000 URL: https://github.com/openjdk/skara/commit/4a88959f Add tool for importing webrev patches Reviewed-by: ehelin + args/src/main/java/org/openjdk/skara/args/Command.java + args/src/main/java/org/openjdk/skara/args/CommandCtor.java + args/src/main/java/org/openjdk/skara/args/CommandHelpText.java + args/src/main/java/org/openjdk/skara/args/CommandMain.java + args/src/main/java/org/openjdk/skara/args/Default.java + args/src/main/java/org/openjdk/skara/args/Executable.java + args/src/main/java/org/openjdk/skara/args/Main.java + args/src/main/java/org/openjdk/skara/args/MultiCommandParser.java ! cli/src/main/java/org/openjdk/skara/cli/GitSkara.java ! cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java ! vcs/src/main/java/org/openjdk/skara/vcs/Repository.java ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java ! webrev/src/main/java/module-info.java + webrev/src/main/java/org/openjdk/skara/webrev/WebrevMetaData.java From duke at openjdk.java.net Mon Sep 9 06:39:51 2019 From: duke at openjdk.java.net (John Rose via github.com) Date: Mon, 9 Sep 2019 06:39:51 GMT Subject: RFR: Escape quotes in shell code stored in gitconfig. Message-ID: https://bugs.openjdk.java.net/browse/SKARA-99 ---------------- Commits: - e263791e: Escape quotes in shell code stored in gitconfig. Pull request: https://git.openjdk.java.net/skara/pull/120 Webrev: https://webrevs.openjdk.java.net/skara/120/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/120.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/120/head:pull/120 From duke at openjdk.java.net Mon Sep 9 13:14:05 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Mon, 9 Sep 2019 13:14:05 GMT Subject: RFR: Escape quotes in shell code stored in gitconfig. In-Reply-To: References: Message-ID: On Mon, 9 Sep 2019 06:39:51 GMT, John Rose via github.com wrote: > https://bugs.openjdk.java.net/browse/SKARA-99 > > ---------------- > > Commits: > - e263791e: Escape quotes in shell code stored in gitconfig. > > Pull request: > https://git.openjdk.java.net/skara/pull/120 > > Webrev: > https://webrevs.openjdk.java.net/skara/120/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/120.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/120/head:pull/120 This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment: Thanks John for contributing, looks good! PR: https://git.openjdk.java.net/skara/pull/120 From duke at openjdk.java.net Mon Sep 9 13:34:00 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Mon, 9 Sep 2019 13:34:00 GMT Subject: RFR: 73: Improve email threading, add separate approval email Message-ID: Hi all, Please review this update to the mailing list bridge bot, that improves threading of messages and also adds a separate approval message. Best regards, Robin ---------------- Commits: - ef0be99b: Improve email threading, add separate approval email Pull request: https://git.openjdk.java.net/skara/pull/121 Webrev: https://webrevs.openjdk.java.net/skara/121/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/121.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/121/head:pull/121 From duke at openjdk.java.net Mon Sep 9 13:54:43 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Mon, 9 Sep 2019 13:54:43 GMT Subject: RFR: Add support for Mercurial Message-ID: Hi all, this patch adds skara.py which makes it quite a bit more convenient to use the Skara tools from Mercurial (hg). I also added `--mercurial` to `git-pr` and `git-fork` so they can be used with [hg-git](https://bitbucket.org/durin42/hg-git). There are still a few minor things to work out, for example `hg pr create` does not work yet and I need to do add some help texts, but it is a start. ## Testing - [x] Manual testing with git token Thanks, Erik ---------------- Commits: - fadd0cd8: Add support for Mercurial Pull request: https://git.openjdk.java.net/skara/pull/122 Webrev: https://webrevs.openjdk.java.net/skara/122/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/122.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/122/head:pull/122 From duke at openjdk.java.net Mon Sep 9 13:58:14 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Mon, 9 Sep 2019 13:58:14 GMT Subject: RFR: Add support for Mercurial In-Reply-To: References: Message-ID: <7-6jYn272jqtWv7ArIWdRwQ_i2N3eauTDSfx7F9v-rY=.4cc752ee-5f94-4334-ac2c-524d5c54ea87@github.com> On Mon, 9 Sep 2019 13:54:43 GMT, Erik Duveblad via github.com wrote: > Hi all, > > this patch adds skara.py which makes it quite a bit more convenient to use the Skara tools from Mercurial (hg). I also added `--mercurial` to `git-pr` and `git-fork` so they can be used with [hg-git](https://bitbucket.org/durin42/hg-git). There are still a few minor things to work out, for example `hg pr create` does not work yet and I need to do add some help texts, but it is a start. > > ## Testing > - [x] Manual testing with git token > > Thanks, > Erik > > ---------------- > > Commits: > - fadd0cd8: Add support for Mercurial > > Pull request: > https://git.openjdk.java.net/skara/pull/122 > > Webrev: > https://webrevs.openjdk.java.net/skara/122/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/122.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/122/head:pull/122 This PR has been reviewed by Robin Westberg via github.com - changes are approved. Review comment: Looks good! Only had some minor comments / suggestions. PR: https://git.openjdk.java.net/skara/pull/122 cli/src/main/java/org/openjdk/skara/cli/GitFork.java line 156: > 155: > 156: System.out.println("path: " + path); > 157: var fork = host.getRepository(path).fork(); Debugging printout? PR: https://git.openjdk.java.net/skara/pull/122 skara.py line 27: > 26: import shutil > 27: > 28: cmdtable = {} Add a testedwith line? PR: https://git.openjdk.java.net/skara/pull/122 From duke at openjdk.java.net Mon Sep 9 20:20:11 2019 From: duke at openjdk.java.net (John Rose via github.com) Date: Mon, 9 Sep 2019 20:20:11 GMT Subject: RFR: Escape quotes in shell code stored in gitconfig. In-Reply-To: References: Message-ID: <3AcP_InEn3ma220nwrgOmckgRK4pJmaPbaU_ddlNU3o=.ad291413-d3b0-4177-8bc7-3030920c8542@github.com> On Mon, 9 Sep 2019 06:39:51 GMT, John Rose via github.com wrote: > https://bugs.openjdk.java.net/browse/SKARA-99 > > ---------------- > > Commits: > - e263791e: Escape quotes in shell code stored in gitconfig. > > Pull request: > https://git.openjdk.java.net/skara/pull/120 > > Webrev: > https://webrevs.openjdk.java.net/skara/120/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/120.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/120/head:pull/120 /integrate (Hey, where are the `/foo` commands documented?) PR: https://git.openjdk.java.net/skara/pull/120 From duke at openjdk.java.net Tue Sep 10 07:38:50 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Tue, 10 Sep 2019 07:38:50 GMT Subject: RFR: Add support for Mercurial In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - c25afe09: Add "testedwith" and remove stray newline Pull request: https://git.openjdk.java.net/skara/pull/122 Webrevs: - full: https://webrevs.openjdk.java.net/skara/122/webrev.01 - inc: https://webrevs.openjdk.java.net/skara/122/webrev.00-01 Updated full patch: https://git.openjdk.java.net/skara/pull/122.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/122/head:pull/122 From duke at openjdk.java.net Tue Sep 10 07:40:25 2019 From: duke at openjdk.java.net (duke) Date: Tue, 10 Sep 2019 07:40:25 GMT Subject: git: openjdk/skara: Add support for Mercurial Message-ID: <19f09861-23f0-42ad-aa80-2ac88cf1aaae@openjdk.java.net> Changeset: d14976eb Author: Erik Helin Date: 2019-09-10 07:39:29 +0000 URL: https://github.com/openjdk/skara/commit/d14976eb Add support for Mercurial Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitFork.java ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java ! cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java + skara.py From duke at openjdk.java.net Tue Sep 10 12:47:15 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Tue, 10 Sep 2019 12:47:15 GMT Subject: RFR: 73: Improve email threading, add separate approval email In-Reply-To: References: Message-ID: <7j45uSQR__dKkoGOFSR7Pm-ap0SdPwr7N6py8nguiOc=.b1aad08e-12bb-4a45-91c0-667cbe84cb44@github.com> On Mon, 9 Sep 2019 13:34:00 GMT, Robin Westberg via github.com wrote: > Hi all, > > Please review this update to the mailing list bridge bot, that improves threading of messages and also adds a separate approval message. > > Best regards, > Robin > > ---------------- > > Commits: > - ef0be99b: Improve email threading, add separate approval email > > Pull request: > https://git.openjdk.java.net/skara/pull/121 > > Webrev: > https://webrevs.openjdk.java.net/skara/121/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/121.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/121/head:pull/121 This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment: Hmmm, this PR is definitely on the larger side, but I see you have it tested it quite thoroughly, so lets integrate it. PR: https://git.openjdk.java.net/skara/pull/121 From duke at openjdk.java.net Tue Sep 10 12:50:22 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Tue, 10 Sep 2019 12:50:22 GMT Subject: RFR: Escape quotes in shell code stored in gitconfig. In-Reply-To: <3AcP_InEn3ma220nwrgOmckgRK4pJmaPbaU_ddlNU3o=.ad291413-d3b0-4177-8bc7-3030920c8542@github.com> References: <3AcP_InEn3ma220nwrgOmckgRK4pJmaPbaU_ddlNU3o=.ad291413-d3b0-4177-8bc7-3030920c8542@github.com> Message-ID: On Mon, 9 Sep 2019 20:20:11 GMT, John Rose via github.com wrote: > On Mon, 9 Sep 2019 06:39:51 GMT, John Rose via github.com wrote: > >> https://bugs.openjdk.java.net/browse/SKARA-99 >> >> ---------------- >> >> Commits: >> - e263791e: Escape quotes in shell code stored in gitconfig. >> >> Pull request: >> https://git.openjdk.java.net/skara/pull/120 >> >> Webrev: >> https://webrevs.openjdk.java.net/skara/120/webrev.00 >> >> Patch: >> https://git.openjdk.java.net/skara/pull/120.diff >> >> Fetch command: >> git fetch https://git.openjdk.java.net/skara pull/120/head:pull/120 > > /integrate > > (Hey, where are the `/foo` commands documented?) > > PR: https://git.openjdk.java.net/skara/pull/120 @rose00 we haven't really had time to write up all the documentation yet, that is coming on the Skara wiki. As for a "review" command, maybe, but all platforms feature review functionality (plus the Skara CLI tooling also supports `git pr approve`). On GitHub the actually not so invisible button appears when you click the "Files changed" tab :smile_cat: PR: https://git.openjdk.java.net/skara/pull/120 From duke at openjdk.java.net Tue Sep 10 12:51:23 2019 From: duke at openjdk.java.net (duke) Date: Tue, 10 Sep 2019 12:51:23 GMT Subject: git: openjdk/skara: Escape quotes in shell code stored in gitconfig. Message-ID: Changeset: 96b71469 Author: John R Rose Committer: Erik Helin Date: 2019-09-10 12:50:39 +0000 URL: https://github.com/openjdk/skara/commit/96b71469 Escape quotes in shell code stored in gitconfig. Reviewed-by: ehelin ! skara.gitconfig From duke at openjdk.java.net Tue Sep 10 12:52:23 2019 From: duke at openjdk.java.net (duke) Date: Tue, 10 Sep 2019 12:52:23 GMT Subject: git: openjdk/skara: 73: Improve email threading, add separate approval email Message-ID: Changeset: 39c51892 Author: Robin Westberg Date: 2019-09-10 12:51:19 +0000 URL: https://github.com/openjdk/skara/commit/39c51892 73: Improve email threading, add separate approval email Reviewed-by: ehelin + bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java = bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CensusInstance.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/PullRequestInstance.java + bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBotTests.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java ! email/src/main/java/org/openjdk/skara/email/Email.java ! email/src/main/java/org/openjdk/skara/email/EmailBuilder.java ! test/src/main/java/org/openjdk/skara/test/SMTPServer.java ! test/src/main/java/org/openjdk/skara/test/TestPullRequest.java From duke at openjdk.java.net Tue Sep 10 13:11:59 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Tue, 10 Sep 2019 13:11:59 GMT Subject: RFR: Add markdown filtering Message-ID: <3uHUSwRSQni0O2ZF4UPpSjF49BvtBmEO6JxAwD8fV9I=.ae0407b1-bc09-4db0-9669-0191545d03b2@github.com> Hi all, Please review this change that adds basic markdown filtering when forwarding hosted comments to mailing lists. This is far from a proper CommonMark parser, but should improve the readability of forwarded comments. Best regards, Robin ---------------- Commits: - ad9ad423: Add emoji support Pull request: https://git.openjdk.java.net/skara/pull/123 Webrev: https://webrevs.openjdk.java.net/skara/123/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/123.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/123/head:pull/123 From duke at openjdk.java.net Tue Sep 10 13:18:40 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Tue, 10 Sep 2019 13:18:40 GMT Subject: RFR: Add markdown filtering In-Reply-To: <3uHUSwRSQni0O2ZF4UPpSjF49BvtBmEO6JxAwD8fV9I=.ae0407b1-bc09-4db0-9669-0191545d03b2@github.com> References: <3uHUSwRSQni0O2ZF4UPpSjF49BvtBmEO6JxAwD8fV9I=.ae0407b1-bc09-4db0-9669-0191545d03b2@github.com> Message-ID: On Tue, 10 Sep 2019 13:11:59 GMT, Robin Westberg via github.com wrote: > Hi all, > > Please review this change that adds basic markdown filtering when forwarding hosted comments to mailing lists. This is far from a proper CommonMark parser, but should improve the readability of forwarded comments. > > Best regards, > Robin > > ---------------- > > Commits: > - ad9ad423: Add emoji support > > Pull request: > https://git.openjdk.java.net/skara/pull/123 > > Webrev: > https://webrevs.openjdk.java.net/skara/123/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/123.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/123/head:pull/123 Looks good, I've been longing for some unicode in my source files :smile: ---------------- Review status set to Approved by ehelin (project role: Reviewer). This PR has been marked as Reviewed by ehelin. PR: https://git.openjdk.java.net/skara/pull/123 From duke at openjdk.java.net Tue Sep 10 13:21:10 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Tue, 10 Sep 2019 13:21:10 GMT Subject: RFR: Add markdown filtering In-Reply-To: References: <3uHUSwRSQni0O2ZF4UPpSjF49BvtBmEO6JxAwD8fV9I=.ae0407b1-bc09-4db0-9669-0191545d03b2@github.com> Message-ID: On Tue, 10 Sep 2019 13:18:40 GMT, Erik Duveblad via github.com wrote: > On Tue, 10 Sep 2019 13:11:59 GMT, Robin Westberg via github.com wrote: > >> Hi all, >> >> Please review this change that adds basic markdown filtering when forwarding hosted comments to mailing lists. This is far from a proper CommonMark parser, but should improve the readability of forwarded comments. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - ad9ad423: Add emoji support >> >> Pull request: >> https://git.openjdk.java.net/skara/pull/123 >> >> Webrev: >> https://webrevs.openjdk.java.net/skara/123/webrev.00 >> >> Patch: >> https://git.openjdk.java.net/skara/pull/123.diff >> >> Fetch command: >> git fetch https://git.openjdk.java.net/skara pull/123/head:pull/123 > > Looks good, I've been longing for some unicode in my source files :smile: > > ---------------- > > Review status set to Approved by ehelin (project role: Reviewer). > > This PR has been marked as Reviewed by ehelin. > > PR: https://git.openjdk.java.net/skara/pull/123 Didn't intend for the approval messages to be collapsed though, guess it needs a bit more polishing. PR: https://git.openjdk.java.net/skara/pull/123 From duke at openjdk.java.net Tue Sep 10 13:22:52 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Tue, 10 Sep 2019 13:22:52 GMT Subject: 01: Fix whitespace In-Reply-To: <3uHUSwRSQni0O2ZF4UPpSjF49BvtBmEO6JxAwD8fV9I=.ae0407b1-bc09-4db0-9669-0191545d03b2@github.com> References: <3uHUSwRSQni0O2ZF4UPpSjF49BvtBmEO6JxAwD8fV9I=.ae0407b1-bc09-4db0-9669-0191545d03b2@github.com> Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - f34f8ce4: Fix whitespace Pull request: https://git.openjdk.java.net/skara/pull/123 Webrevs: - full: https://webrevs.openjdk.java.net/skara/123/webrev.01 - inc: https://webrevs.openjdk.java.net/skara/123/webrev.00-01 Updated full patch: https://git.openjdk.java.net/skara/pull/123.diff Fetch command: git fetch https://gi bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java line 122: > 121: if (last.isEmpty()) { > 122: throw new RuntimeException("Failed to find parent"); > 123: } else { Might as well fix this one at the same time. PR: https://git.openjdk.java.net/skara/pull/123 From duke at openjdk.java.net Tue Sep 10 13:27:32 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Tue, 10 Sep 2019 13:27:32 GMT Subject: RFR: Add markdown filtering In-Reply-To: References: <3uHUSwRSQni0O2ZF4UPpSjF49BvtBmEO6JxAwD8fV9I=.ae0407b1-bc09-4db0-9669-0191545d03b2@github.com> Message-ID: On Tue, 10 Sep 2019 13:22:52 GMT, Robin Westberg via github.com wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - f34f8ce4: Fix whitespace > > Pull request: > https://git.openjdk.java.net/skara/pull/123 > > Webrevs: > - full: https://webrevs.openjdk.java.net/skara/123/webrev.01 > - inc: https://webrevs.openjdk.java.net/skara/123/webrev.00-01 > > Updated full patch: > https://git.openjdk.java.net/skara/pull/123.diff > > Fetch command: > git fetch https://gi > > bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java line 122: > >> 121: if (last.isEmpty()) { >> 122: throw new RuntimeException("Failed to find parent"); >> 123: } else { > > Might as well fix this one at the same time. > > PR: https://git.openjdk.java.net/skara/pull/123 bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java line 123: > 122: throw new RuntimeException("Failed to find parent"); > 123: } else { > 124: return last.get(); Note: this is just a comment to trigger Robin's new mailing list bridge. PR: https://git.openjdk.java.net/skara/pull/123 From duke at openjdk.java.net Wed Sep 11 07:04:22 2019 From: duke at openjdk.java.net (duke) Date: Wed, 11 Sep 2019 07:04:22 GMT Subject: git: openjdk/skara: Add markdown filtering Message-ID: <2a7bb032-08b7-4748-9456-257f7982161a@openjdk.java.net> Changeset: e54f813f Author: Robin Westberg Date: 2019-09-11 07:03:23 +0000 URL: https://github.com/openjdk/skara/commit/e54f813f Add markdown filtering Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java + bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/EmojiTable.java + bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MarkdownToText.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java + bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MarkdownToTextTests.java From duke at openjdk.java.net Wed Sep 11 11:29:00 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Wed, 11 Sep 2019 11:29:00 GMT Subject: RFR: Better Mercurial compatability Message-ID: Hi all, this patch improves the Mercurial (hg) support for `git fork` and `git pr`. Now all subcommands work with `hg pr` _except_ for `hg pr create` which I haven't fixed yet. ## Testing - [x] `sh gradlew test` passes on Linux x86_64 - [x] Manual testing of `hg pr`, `hg fork`, `hg webrev` and `hg jcheck` Thanks, Erik ---------------- Commits: - 790a7d05: Better Mercurial compatability Pull request: https://git.openjdk.java.net/skara/pull/125 Webrev: https://webrevs.openjdk.java.net/skara/125/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/125.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/125/head:pull/125 From duke at openjdk.java.net Wed Sep 11 12:29:40 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Wed, 11 Sep 2019 12:29:40 GMT Subject: RFR: Adjust reply subjects Message-ID: Hi all, Please review this small change that adjust the subjects in replies, to improve mail client threading compatibility. Best regards, Robin ---------------- Commits: - a87fc352: Adjust reply subjects Pull request: https://git.openjdk.java.net/skara/pull/126 Webrev: https://webrevs.openjdk.java.net/skara/126/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/126.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/126/head:pull/126 From duke at openjdk.java.net Wed Sep 11 12:49:11 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Wed, 11 Sep 2019 12:49:11 GMT Subject: RFR: Better Mercurial compatability In-Reply-To: References: Message-ID: On Wed, 11 Sep 2019 11:29:00 GMT, Erik Duveblad via github.com wrote: > Hi all, > > this patch improves the Mercurial (hg) support for `git fork` and `git pr`. Now all subcommands work with `hg pr` _except_ for `hg pr create` which I haven't fixed yet. > > ## Testing > - [x] `sh gradlew test` passes on Linux x86_64 > - [x] Manual testing of `hg pr`, `hg fork`, `hg webrev` and `hg jcheck` > > Thanks, > Erik > > ---------------- > > Commits: > - 790a7d05: Better Mercurial compatability > > Pull request: > https://git.openjdk.java.net/skara/pull/125 > > Webrev: > https://webrevs.openjdk.java.net/skara/125/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/125.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/125/head:pull/125 Review status set to Approved by rwestberg (project role: Reviewer). This PR has been marked as Reviewed by rwestberg. PR: https://git.openjdk.java.net/skara/pull/125 From duke at openjdk.java.net Wed Sep 11 13:05:23 2019 From: duke at openjdk.java.net (duke) Date: Wed, 11 Sep 2019 13:05:23 GMT Subject: git: openjdk/skara: Better Mercurial compatability Message-ID: Changeset: 81c6aae4 Author: Erik Helin Date: 2019-09-11 13:04:54 +0000 URL: https://github.com/openjdk/skara/commit/81c6aae4 Better Mercurial compatability Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitFork.java ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubHost.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java ! skara.py ! vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java From duke at openjdk.java.net Wed Sep 11 13:34:04 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Wed, 11 Sep 2019 13:34:04 GMT Subject: RFR: Add Mercurial mapping for skara command Message-ID: Hi all, this small patch just adds a Mercurial (hg) mapping for the `skara` command (used for help and update). Thanks, Erik PR. This commit for this pull request was pushed with `hg` :smile: ---------------- Commits: - f6fabb17: Add Mercurial mapping for skara command Pull request: https://git.openjdk.java.net/skara/pull/127 Webrev: https://webrevs.openjdk.java.net/skara/127/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/127.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/127/head:pull/127 From duke at openjdk.java.net Wed Sep 11 13:34:07 2019 From: duke at openjdk.java.net (Robin Westberg via github.com) Date: Wed, 11 Sep 2019 13:34:07 GMT Subject: RFR: Add Mercurial mapping for skara command In-Reply-To: References: Message-ID: On Wed, 11 Sep 2019 13:34:04 GMT, Erik Duveblad via github.com wrote: > Hi all, > > this small patch just adds a Mercurial (hg) mapping for the `skara` command (used for help and update). > > Thanks, > Erik > > PR. This commit for this pull request was pushed with `hg` :smile: > > ---------------- > > Commits: > - f6fabb17: Add Mercurial mapping for skara command > > Pull request: > https://git.openjdk.java.net/skara/pull/127 > > Webrev: > https://webrevs.openjdk.java.net/skara/127/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/127.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/127/head:pull/127 Looks good! ---------------- Review status set to Approved by rwestberg (project role: Reviewer). This PR has been marked as Reviewed by rwestberg. PR: https://git.openjdk.java.net/skara/pull/127 From duke at openjdk.java.net Wed Sep 11 13:35:22 2019 From: duke at openjdk.java.net (duke) Date: Wed, 11 Sep 2019 13:35:22 GMT Subject: git: openjdk/skara: Add Mercurial mapping for skara command Message-ID: <6fd1ddb6-d506-4bd3-8544-c9a41d7c0515@openjdk.java.net> Changeset: 409464dd Author: Erik Helin Date: 2019-09-11 13:34:41 +0000 URL: https://github.com/openjdk/skara/commit/409464dd Add Mercurial mapping for skara command Reviewed-by: rwestberg ! skara.py From duke at openjdk.java.net Wed Sep 11 16:07:12 2019 From: duke at openjdk.java.net (Erik Duveblad via github.com) Date: Wed, 11 Sep 2019 16:07:12 GMT Subject: RFR: Adjust reply subjects In-Reply-To: References: Message-ID: On Wed, 11 Sep 2019 12:29:40 GMT, Robin Westberg via github.com wrote: > Hi all, > > Please review this small change that adjust the subjects in replies, to improve mail client threading compatibility. > > Best regards, > Robin > > ---------------- > > Commits: > - a87fc352: Adjust reply subjects > > Pull request: > https://git.openjdk.java.net/skara/pull/126 > > Webrev: > https://webrevs.openjdk.java.net/skara/126/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/126.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/126/head:pull/126 Thanks Robin, looks good! ---------------- Review status set to Approved by ehelin (project role: Reviewer). This PR has been marked as Reviewed by ehelin. PR: https://git.openjdk.java.net/skara/pull/126 From duke at openjdk.java.net Thu Sep 12 05:30:23 2019 From: duke at openjdk.java.net (duke) Date: Thu, 12 Sep 2019 05:30:23 GMT Subject: git: openjdk/skara: Adjust reply subjects Message-ID: <35d8c18b-8ec6-40fe-9790-cfeed9800422@openjdk.java.net> Changeset: a15518e6 Author: Robin Westberg Date: 2019-09-12 05:29:19 +0000 URL: https://github.com/openjdk/skara/commit/a15518e6 Adjust reply subjects Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From rwestberg at openjdk.org Thu Sep 12 07:09:26 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 12 Sep 2019 07:09:26 GMT Subject: RFR: Adjust collapsing of multiple emails Message-ID: Hi all, Please review this change that improves the collapse handling of multiple emails generated in a single archival run. It should only combine multiple review comments, and avoid merging top-level comments. Best regards, Robin ---------------- Commits: - 06329dfe: Improve approval mail handling - 045b1ab1: Avoid extending comments made when the PR is updated with new content Pull request: https://git.openjdk.java.net/skara/pull/128 Webrev: https://webrevs.openjdk.java.net/skara/128/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/128.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/128/head:pull/128 From ehelin at openjdk.org Thu Sep 12 11:55:45 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 12 Sep 2019 11:55:45 GMT Subject: Approved and Reviewed by ehelin In-Reply-To: References: Message-ID: On Thu, 12 Sep 2019 07:09:26 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that improves the collapse handling of multiple emails generated in a single archival run. It should only combine multiple review comments, and avoid merging top-level comments. > > Best regards, > Robin > > ---------------- > > Commits: > - 06329dfe: Improve approval mail handling > - 045b1ab1: Avoid extending comments made when the PR is updated with new content > > Pull request: > https://git.openjdk.java.net/skara/pull/128 > > Webrev: > https://webrevs.openjdk.java.net/skara/128/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/128.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/128/head:pull/128 Looks great, thanks @rwestberg for hanging in there! ---------------- Review status set to Approved by ehelin (project role: Reviewer). This PR has been marked as Reviewed by ehelin. PR: https://git.openjdk.java.net/skara/pull/128 From duke at openjdk.java.net Thu Sep 12 12:00:22 2019 From: duke at openjdk.java.net (duke) Date: Thu, 12 Sep 2019 12:00:22 GMT Subject: git: openjdk/skara: Adjust collapsing of multiple emails Message-ID: Changeset: 80d1e6a1 Author: Robin Westberg Date: 2019-09-12 11:59:26 +0000 URL: https://github.com/openjdk/skara/commit/80d1e6a1 Adjust collapsing of multiple emails Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From ehelin at openjdk.org Thu Sep 12 12:09:19 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 12 Sep 2019 12:09:19 GMT Subject: RFR: Enable Mercurial support for "pr create" Message-ID: <9A2sEn1b0IOIm66I5MBk9M-BbET2VnSxZeaMjOzjPtI=.725207cd-1572-4c0f-86fe-ef3d309accb6@github.com> Hi all, this patch add Mercurial (hg) support for the `pr create` command (this PR was craeted by `hg pr create`). I know the code is a bit messy at the moment, I will clean it up in a later PR (I wanted to get all pieces into place before refactoring). Testing: - [x] `sh gradlew test` passes (otoh there are no tests GitPr.java) - [x] Manual testing with `hg pr create` Thanks, Erik ---------------- Commits: - ae53679c: Enable Mercurial support for "pr create" Pull request: https://git.openjdk.java.net/skara/pull/129 Webrev: https://webrevs.openjdk.java.net/skara/129/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/129.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/129/head:pull/129 From rwestberg at openjdk.org Thu Sep 12 12:18:02 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 12 Sep 2019 12:18:02 GMT Subject: Approved and Reviewed by rwestberg In-Reply-To: <9A2sEn1b0IOIm66I5MBk9M-BbET2VnSxZeaMjOzjPtI=.725207cd-1572-4c0f-86fe-ef3d309accb6@github.com> References: <9A2sEn1b0IOIm66I5MBk9M-BbET2VnSxZeaMjOzjPtI=.725207cd-1572-4c0f-86fe-ef3d309accb6@github.com> Message-ID: On Thu, 12 Sep 2019 12:09:19 GMT, Erik Helin wrote: > Hi all, > > this patch add Mercurial (hg) support for the `pr create` command (this PR was > craeted by `hg pr create`). I know the code is a bit messy at the moment, I will > clean it up in a later PR (I wanted to get all pieces into place before refactoring). > > Testing: > - [x] `sh gradlew test` passes (otoh there are no tests GitPr.java) > - [x] Manual testing with `hg pr create` > > Thanks, > Erik > > ---------------- > > Commits: > - ae53679c: Enable Mercurial support for "pr create" > > Pull request: > https://git.openjdk.java.net/skara/pull/129 > > Webrev: > https://webrevs.openjdk.java.net/skara/129/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/129.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/129/head:pull/129 Looks good! Guess it's hard to create automated tests for this.. ---------------- Review status set to Approved by rwestberg (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/129 From duke at openjdk.java.net Thu Sep 12 12:32:22 2019 From: duke at openjdk.java.net (duke) Date: Thu, 12 Sep 2019 12:32:22 GMT Subject: git: openjdk/skara: Enable Mercurial support for "pr create" Message-ID: Changeset: 2ae213d1 Author: Erik Helin Date: 2019-09-12 12:31:53 +0000 URL: https://github.com/openjdk/skara/commit/2ae213d1 Enable Mercurial support for "pr create" Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java + vcs/src/main/java/org/openjdk/skara/vcs/Bookmark.java ! vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java From rwestberg at openjdk.org Mon Sep 16 08:21:44 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 16 Sep 2019 08:21:44 GMT Subject: RFR: 101: Add support for notifying an RFR thread when a PR is integrated Message-ID: Hi all, Please review this change that allows change integration notifications to be posted to a related RFR thread, if one is found. Best regards, Robin ---------------- Commits: - 0a017c78: Add new notifier modes - eaac7e44: Add basic search for pull requests - 9ac1e608: Move reply support into Email proper Pull request: https://git.openjdk.java.net/skara/pull/130 Webrev: https://webrevs.openjdk.java.net/skara/130/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/130.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/130/head:pull/130 From ehelin at openjdk.org Mon Sep 16 08:38:26 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 16 Sep 2019 08:38:26 GMT Subject: Approved and Reviewed by ehelin In-Reply-To: References: Message-ID: <7vM__bgAQAsPZqcY264oPLyCrt_AvdBW5o35dFeRLhQ=.11b64c0a-9978-47ae-ad51-4c408f4f6f8c@github.com> On Mon, 16 Sep 2019 08:21:44 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows change integration notifications to be posted to a related RFR thread, if one is found. > > Best regards, > Robin > > ---------------- > > Commits: > - 0a017c78: Add new notifier modes > - eaac7e44: Add basic search for pull requests > - 9ac1e608: Move reply support into Email proper > > Pull request: > https://git.openjdk.java.net/skara/pull/130 > > Webrev: > https://webrevs.openjdk.java.net/skara/130/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/130.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/130/head:pull/130 Looks good! ---------------- Review status set to Approved by ehelin (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/130 From rwestberg at openjdk.org Mon Sep 16 08:40:35 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 16 Sep 2019 08:40:35 GMT Subject: RFR: 101: Add support for notifying an RFR thread when a PR is integrated In-Reply-To: References: Message-ID: On Mon, 16 Sep 2019 08:21:44 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows change integration notifications to be posted to a related RFR thread, if one is found. > > Best regards, > Robin > > ---------------- > > Commits: > - 0a017c78: Add new notifier modes > - eaac7e44: Add basic search for pull requests > - 9ac1e608: Move reply support into Email proper > > Pull request: > https://git.openjdk.java.net/skara/pull/130 > > Webrev: > https://webrevs.openjdk.java.net/skara/130/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/130.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/130/head:pull/130 Thanks for the review! PR: https://git.openjdk.java.net/skara/pull/130 From duke at openjdk.java.net Mon Sep 16 08:41:54 2019 From: duke at openjdk.java.net (duke) Date: Mon, 16 Sep 2019 08:41:54 GMT Subject: git: openjdk/skara: 101: Add support for notifying an RFR thread when a PR is integrated Message-ID: <44df60f8-7258-4760-8d13-d381852f30fb@openjdk.java.net> Changeset: 3cece6c3 Author: Robin Westberg Date: 2019-09-16 08:40:50 +0000 URL: https://github.com/openjdk/skara/commit/3cece6c3 101: Add support for notifying an RFR thread when a PR is integrated Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/notify/build.gradle ! bots/notify/src/main/java/module-info.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBotFactory.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java ! email/src/main/java/org/openjdk/skara/email/Email.java ! host/src/main/java/org/openjdk/skara/host/HostedRepository.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubHost.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubRepository.java ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabRepository.java ! test/src/main/java/org/openjdk/skara/test/TestHostedRepository.java ! test/src/main/java/org/openjdk/skara/test/TestMailmanServer.java From rwestberg at openjdk.org Mon Sep 16 12:26:26 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 16 Sep 2019 12:26:26 GMT Subject: RFR: Add tags to subjects instead of replacing them Message-ID: Hi all, Please review this change that aims to make automated RFR reply subject rewrites a little bit less intrusive. Best regards, Robin ---------------- Commits: - 331a3cf0: Tag subjects instead of replacing them Pull request: https://git.openjdk.java.net/skara/pull/131 Webrev: https://webrevs.openjdk.java.net/skara/131/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/131.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/131/head:pull/131 From ehelin at openjdk.org Mon Sep 16 12:31:36 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 16 Sep 2019 12:31:36 GMT Subject: Approved and Reviewed by ehelin In-Reply-To: References: Message-ID: On Mon, 16 Sep 2019 12:26:26 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that aims to make automated RFR reply subject rewrites a little bit less intrusive. > > Best regards, > Robin > > ---------------- > > Commits: > - 331a3cf0: Tag subjects instead of replacing them > > Pull request: > https://git.openjdk.java.net/skara/pull/131 > > Webrev: > https://webrevs.openjdk.java.net/skara/131/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/131.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/131/head:pull/131 Looks good, thanks! ---------------- Review status set to Approved by ehelin (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/131 From ehelin at openjdk.org Mon Sep 16 12:32:27 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 16 Sep 2019 12:32:27 GMT Subject: Approved and Reviewed by ehelin In-Reply-To: References: Message-ID: On Thu, 22 Aug 2019 11:58:43 GMT, Christian Stein via github.com wrote: > Upgrade JUnit 5 to Jupiter 5.5.1 and Platform 1.5.1 > > - Set Jupiter version number 5.5.1 > - Introduce Platform Launcher 1.5.1 test runtime dependency > in order to force Gradle to load the module from the module-path > - Add missing "requires 'org.junit.jupiter.params'" directives > in modules: jcheck, storage, vcs, and webrev > > Solves https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69 > > ---------------- > > Commits: > - 5e253f99: Upgrade JUnit 5 to Jupiter 5.5.1 and Platform 1.5.1 > - Set Jupiter version number 5.5.1 > - Introduce Platform Launcher 1.5.1 test runtime dependency > in order to force Gradle to load the module from the module-path > - Add missing "requires 'org.junit.jupiter.params'" directives > in modules: jcheck, storage, vcs, and webrev > Solves https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69 > > Pull request: > https://git.openjdk.java.net/skara/pull/66 > > Webrev: > https://webrevs.openjdk.java.net/skara/66/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/66.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/66/head:pull/66 @sormuras I _finally_ had a chance to properly review and test this patch. Everything works great, nice job! ---------------- Review status set to Approved by ehelin (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/66 From duke at openjdk.java.net Mon Sep 16 12:36:53 2019 From: duke at openjdk.java.net (duke) Date: Mon, 16 Sep 2019 12:36:53 GMT Subject: git: openjdk/skara: Add currentBookmark method to TestRepository Message-ID: <7716a29a-e7e0-4902-93a7-5039809f6cd7@openjdk.java.net> Changeset: 7ecca5b3 Author: Erik Helin Date: 2019-09-16 12:36:43 +0000 URL: https://github.com/openjdk/skara/commit/7ecca5b3 Add currentBookmark method to TestRepository Reviewed-by: rwestberg ! jcheck/src/test/java/org/openjdk/skara/jcheck/TestRepository.java From duke at openjdk.java.net Mon Sep 16 13:42:48 2019 From: duke at openjdk.java.net (duke) Date: Mon, 16 Sep 2019 13:42:48 GMT Subject: [Integrated] RFR: Add tags to subjects instead of replacing them In-Reply-To: References: Message-ID: Changeset: 2b9e3d54 Author: Robin Westberg Date: 2019-09-16 13:42:31 +0000 URL: https://git.openjdk.java.net/skara/commit/2b9e3d54 Add tags to subjects instead of replacing them Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From ehelin at openjdk.org Mon Sep 16 14:09:21 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 16 Sep 2019 14:09:21 GMT Subject: RFR: Upgrade JUnit 5 to 5.5.1 In-Reply-To: References: Message-ID: On Mon, 16 Sep 2019 13:41:05 GMT, Christian Stein wrote: > On Mon, 2 Sep 2019 11:16:39 GMT, Marc Philipp via github.com wrote: > >> On Thu, 22 Aug 2019 14:10:58 GMT, Erik Duveblad via github.com wrote: >> >>> On Thu, 22 Aug 2019 11:58:43 GMT, Christian Stein via github.com wrote: >>> >>>> Upgrade JUnit 5 to Jupiter 5.5.1 and Platform 1.5.1 >>>> >>>> - Set Jupiter version number 5.5.1 >>>> - Introduce Platform Launcher 1.5.1 test runtime dependency >>>> in order to force Gradle to load the module from the module-path >>>> - Add missing "requires 'org.junit.jupiter.params'" directives >>>> in modules: jcheck, storage, vcs, and webrev >>>> >>>> Solves https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69 >>>> >>>> ---------------- >>>> >>>> Commits: >>>> - 5e253f99: Upgrade JUnit 5 to Jupiter 5.5.1 and Platform 1.5.1 >>>> - Set Jupiter version number 5.5.1 >>>> - Introduce Platform Launcher 1.5.1 test runtime dependency >>>> in order to force Gradle to load the module from the module-path >>>> - Add missing "requires 'org.junit.jupiter.params'" directives >>>> in modules: jcheck, storage, vcs, and webrev >>>> Solves https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69 >>>> >>>> Pull request: >>>> https://git.openjdk.java.net/skara/pull/66 >>>> >>>> Webrev: >>>> https://webrevs.openjdk.java.net/skara/66/webrev.00 >>>> >>>> Patch: >>>> https://git.openjdk.java.net/skara/pull/66.diff >>>> >>>> Fetch command: >>>> git fetch https://git.openjdk.java.net/skara pull/66/head:pull/66 >>> >>> build.gradle line 54: >>> >>>> 53: >>>> 54: test { >>>> 55: useJUnitPlatform() >>> >>> Hmm, I don't really follow here - how does adding a test runtime dependency on org.junit.platform:junit-platform-launcher:1.5.1 force Gradle to load the JUnit Platform launcher from the module path? Did you forgot to `git add` a change made to `buildSrc/.../ModulePlugin.java`? >>> >>> PR: https://git.openjdk.java.net/skara/pull/66 >> >> Gradle always puts the version of the junit-platform-launcher it ships with on the classpath. Adding `org.junit.platform:junit-platform-launcher:1.5.1` to the module path seems to hide that version from the classloader which now loads the version on the module path instead. This version is a proper module and may access the `org.junit.platform.commons.util` package of the junit-platform-commons module. >> >> PR: https://git.openjdk.java.net/skara/pull/66 > > Before making this PR integration-ready, shall I update to JUnit 5.5.2 right away? We fixed two minor bugs: https://junit.org/junit5/docs/5.5.2/release-notes/ > > PR: https://git.openjdk.java.net/skara/pull/66 Lets do that as a separate PR, I will have to test that one as well. Now that I've finally finished testing and reviewing this one lets integrate it :+1: PR: https://git.openjdk.java.net/skara/pull/66 From duke at openjdk.java.net Mon Sep 16 14:19:52 2019 From: duke at openjdk.java.net (duke) Date: Mon, 16 Sep 2019 14:19:52 GMT Subject: [Integrated] RFR: Upgrade JUnit 5 In-Reply-To: References: Message-ID: <06a81ea8-5c62-453e-af16-62197637fd45@openjdk.java.net> Changeset: 3e6357c7 Author: Christian Stein Committer: Erik Helin Date: 2019-09-16 14:19:34 +0000 URL: https://git.openjdk.java.net/skara/commit/3e6357c7 Upgrade JUnit 5 to 5.5.1 Reviewed-by: ehelin ! README.md ! build.gradle ! jcheck/build.gradle ! storage/build.gradle ! vcs/build.gradle ! webrev/build.gradle From cstein at openjdk.org Mon Sep 16 13:41:05 2019 From: cstein at openjdk.org (Christian Stein) Date: Mon, 16 Sep 2019 13:41:05 GMT Subject: RFR: Upgrade JUnit 5 to 5.5.1 In-Reply-To: References: Message-ID: On Mon, 2 Sep 2019 11:16:39 GMT, Marc Philipp via github.com wrote: > On Thu, 22 Aug 2019 14:10:58 GMT, Erik Duveblad via github.com wrote: > >> On Thu, 22 Aug 2019 11:58:43 GMT, Christian Stein via github.com wrote: >> >>> Upgrade JUnit 5 to Jupiter 5.5.1 and Platform 1.5.1 >>> >>> - Set Jupiter version number 5.5.1 >>> - Introduce Platform Launcher 1.5.1 test runtime dependency >>> in order to force Gradle to load the module from the module-path >>> - Add missing "requires 'org.junit.jupiter.params'" directives >>> in modules: jcheck, storage, vcs, and webrev >>> >>> Solves https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69 >>> >>> ---------------- >>> >>> Commits: >>> - 5e253f99: Upgrade JUnit 5 to Jupiter 5.5.1 and Platform 1.5.1 >>> - Set Jupiter version number 5.5.1 >>> - Introduce Platform Launcher 1.5.1 test runtime dependency >>> in order to force Gradle to load the module from the module-path >>> - Add missing "requires 'org.junit.jupiter.params'" directives >>> in modules: jcheck, storage, vcs, and webrev >>> Solves https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69 >>> >>> Pull request: >>> https://git.openjdk.java.net/skara/pull/66 >>> >>> Webrev: >>> https://webrevs.openjdk.java.net/skara/66/webrev.00 >>> >>> Patch: >>> https://git.openjdk.java.net/skara/pull/66.diff >>> >>> Fetch command: >>> git fetch https://git.openjdk.java.net/skara pull/66/head:pull/66 >> >> build.gradle line 54: >> >>> 53: >>> 54: test { >>> 55: useJUnitPlatform() >> >> Hmm, I don't really follow here - how does adding a test runtime dependency on org.junit.platform:junit-platform-launcher:1.5.1 force Gradle to load the JUnit Platform launcher from the module path? Did you forgot to `git add` a change made to `buildSrc/.../ModulePlugin.java`? >> >> PR: https://git.openjdk.java.net/skara/pull/66 > > Gradle always puts the version of the junit-platform-launcher it ships with on the classpath. Adding `org.junit.platform:junit-platform-launcher:1.5.1` to the module path seems to hide that version from the classloader which now loads the version on the module path instead. This version is a proper module and may access the `org.junit.platform.commons.util` package of the junit-platform-commons module. > > PR: https://git.openjdk.java.net/skara/pull/66 Before making this PR integration-ready, shall I update to JUnit 5.5.2 right away? We fixed two minor bugs: https://junit.org/junit5/docs/5.5.2/release-notes/ PR: https://git.openjdk.java.net/skara/pull/66 From rwestberg at openjdk.org Tue Sep 17 09:33:40 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 17 Sep 2019 09:33:40 GMT Subject: RFR: Filter out PR-headers before sending mails Message-ID: Hi all, Please review this change that removes the "internal" PR-headers used by the mailinglist bridge to keep track of certain metadata. This data is used within the internal archives, but does not need to be sent out to actual mailinglists. Best regards, Robin ---------------- Commits: - 838f55b4: Filter out PR-headers before sending mails Pull request: https://git.openjdk.java.net/skara/pull/133 Webrev: https://webrevs.openjdk.java.net/skara/133/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/133.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/133/head:pull/133 From rwestberg at openjdk.org Tue Sep 17 10:35:57 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 17 Sep 2019 10:35:57 GMT Subject: RFR: Avoid quoting footers Message-ID: Hi all, Please review this small change that avoids including the PR link in footers when quoting parent posts. Best regards, Robin ---------------- Commits: - 5ec6e7c8: Avoid quoting footers Pull request: https://git.openjdk.java.net/skara/pull/134 Webrev: https://webrevs.openjdk.java.net/skara/134/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/134.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/134/head:pull/134 From ehelin at openjdk.org Tue Sep 17 10:47:09 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 17 Sep 2019 10:47:09 GMT Subject: [Approved]: RFR: Filter out PR-headers before sending mails In-Reply-To: References: Message-ID: On Tue, 17 Sep 2019 09:33:40 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that removes the "internal" PR-headers used by the mailinglist bridge to keep track of certain metadata. This data is used within the internal archives, but does not need to be sent out to actual mailinglists. > > Best regards, > Robin > > ---------------- > > Commits: > - 838f55b4: Filter out PR-headers before sending mails > > Pull request: > https://git.openjdk.java.net/skara/pull/133 > > Webrev: > https://webrevs.openjdk.java.net/skara/133/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/133.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/133/head:pull/133 Looks good! ---------------- Review status set to Approved by ehelin (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/133 From duke at openjdk.java.net Tue Sep 17 10:49:31 2019 From: duke at openjdk.java.net (duke) Date: Tue, 17 Sep 2019 10:49:31 GMT Subject: [Integrated] RFR: Filter out PR-headers before sending mails In-Reply-To: References: Message-ID: <4c3553e7-3606-4c15-9c17-6b469543da75@openjdk.java.net> Changeset: cd61be82 Author: Robin Westberg Date: 2019-09-17 10:49:22 +0000 URL: https://git.openjdk.java.net/skara/commit/cd61be82 Filter out PR-headers before sending mails Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java ! email/src/main/java/org/openjdk/skara/email/EmailBuilder.java From ehelin at openjdk.org Tue Sep 17 10:50:49 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 17 Sep 2019 10:50:49 GMT Subject: [Approved]: RFR: Avoid quoting footers In-Reply-To: References: Message-ID: On Tue, 17 Sep 2019 10:35:57 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that avoids including the PR link in footers when quoting parent posts. > > Best regards, > Robin > > ---------------- > > Commits: > - 5ec6e7c8: Avoid quoting footers > > Pull request: > https://git.openjdk.java.net/skara/pull/134 > > Webrev: > https://webrevs.openjdk.java.net/skara/134/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/134.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/134/head:pull/134 Ah, very nice enhancement, looks good! ---------------- Review status set to Approved by ehelin (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/134 From rwestberg at openjdk.org Tue Sep 17 11:05:55 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 17 Sep 2019 11:05:55 GMT Subject: RFR: Add thumbs up emoji alias Message-ID: <9Y8BWsOp6FDs-HCluYb6vxTz3XJ6E0vY4xkEBNS9lLI=.14426b0f-e1e4-4e28-9dbc-155598df756e@github.com> Hi all, Please review this minor change that adds an entry for the ???? emoji, which we've recently encountered in the wild. Best regards, Robin ---------------- Commits: - c4bb48a4: Add thumbs up emoji alias Pull request: https://git.openjdk.java.net/skara/pull/135 Webrev: https://webrevs.openjdk.java.net/skara/135/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/135.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/135/head:pull/135 From ehelin at openjdk.org Tue Sep 17 11:56:47 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 17 Sep 2019 11:56:47 GMT Subject: [Approved]: RFR: Add thumbs up emoji alias In-Reply-To: <9Y8BWsOp6FDs-HCluYb6vxTz3XJ6E0vY4xkEBNS9lLI=.14426b0f-e1e4-4e28-9dbc-155598df756e@github.com> References: <9Y8BWsOp6FDs-HCluYb6vxTz3XJ6E0vY4xkEBNS9lLI=.14426b0f-e1e4-4e28-9dbc-155598df756e@github.com> Message-ID: <9o3bsQNfyeBAJ8_FPTcIccgJi2oV7ci8lkuBWjH_gXw=.615d0968-daee-4502-b675-f626ab52f509@github.com> On Tue, 17 Sep 2019 11:05:55 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that adds an entry for the ???? emoji, which we've recently encountered in the wild. > > Best regards, > Robin > > ---------------- > > Commits: > - c4bb48a4: Add thumbs up emoji alias > > Pull request: > https://git.openjdk.java.net/skara/pull/135 > > Webrev: > https://webrevs.openjdk.java.net/skara/135/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/135.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/135/head:pull/135 Haha, yes, I like the "thumbs up" emoji. Nice patch, looks good :+1: ---------------- Review status set to Approved by ehelin (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/135 From duke at openjdk.java.net Tue Sep 17 12:11:29 2019 From: duke at openjdk.java.net (duke) Date: Tue, 17 Sep 2019 12:11:29 GMT Subject: [Integrated] RFR: Add thumbs up emoji alias In-Reply-To: <9Y8BWsOp6FDs-HCluYb6vxTz3XJ6E0vY4xkEBNS9lLI=.14426b0f-e1e4-4e28-9dbc-155598df756e@github.com> References: <9Y8BWsOp6FDs-HCluYb6vxTz3XJ6E0vY4xkEBNS9lLI=.14426b0f-e1e4-4e28-9dbc-155598df756e@github.com> Message-ID: Changeset: 2c1e9ac8 Author: Robin Westberg Date: 2019-09-17 12:11:21 +0000 URL: https://git.openjdk.java.net/skara/commit/2c1e9ac8 Add thumbs up emoji alias Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/EmojiTable.java From rwestberg at openjdk.org Tue Sep 17 13:02:16 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 17 Sep 2019 13:02:16 GMT Subject: RFR: Make subject tags consistent Message-ID: Hi all, Please review this small changes that makes the formatting of subject tags consistent. Best regards, Robin ---------------- Commits: - e21a4549: Make subject tags consistent Pull request: https://git.openjdk.java.net/skara/pull/136 Webrev: https://webrevs.openjdk.java.net/skara/136/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/136.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/136/head:pull/136 From rwestberg at openjdk.org Tue Sep 17 13:03:15 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 17 Sep 2019 13:03:15 GMT Subject: RFR: Simplify review status message Message-ID: Hi all, Please review this minor change that makes the review status footer message a bit simpler. Best regards, Robin ---------------- Commits: - 7a7e02ea: Simplify review status message Pull request: https://git.openjdk.java.net/skara/pull/137 Webrev: https://webrevs.openjdk.java.net/skara/137/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/137.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/137/head:pull/137 From ehelin at openjdk.org Tue Sep 17 13:57:15 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 17 Sep 2019 13:57:15 GMT Subject: [Approved]: RFR: Make subject tags consistent In-Reply-To: References: Message-ID: On Tue, 17 Sep 2019 13:02:16 GMT, Robin Westberg wrote: > Hi all, > > Please review this small changes that makes the formatting of subject tags consistent. > > Best regards, > Robin > > ---------------- > > Commits: > - e21a4549: Make subject tags consistent > > Pull request: > https://git.openjdk.java.net/skara/pull/136 > > Webrev: > https://webrevs.openjdk.java.net/skara/136/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/136.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/136/head:pull/136 Looks good! ---------------- Review status set to Approved by ehelin (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/136 From ehelin at openjdk.org Tue Sep 17 14:00:17 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 17 Sep 2019 14:00:17 GMT Subject: [Approved]: RFR: Simplify review status message In-Reply-To: References: Message-ID: On Tue, 17 Sep 2019 13:03:15 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that makes the review status footer message a bit simpler. > > Best regards, > Robin > > ---------------- > > Commits: > - 7a7e02ea: Simplify review status message > > Pull request: > https://git.openjdk.java.net/skara/pull/137 > > Webrev: > https://webrevs.openjdk.java.net/skara/137/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/137.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/137/head:pull/137 Looks good! ---------------- Review status set to Approved by ehelin (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/137 From duke at openjdk.java.net Tue Sep 17 14:05:08 2019 From: duke at openjdk.java.net (duke) Date: Tue, 17 Sep 2019 14:05:08 GMT Subject: [Integrated] RFR: Make subject tags consistent In-Reply-To: References: Message-ID: Changeset: 7ee97c32 Author: Robin Westberg Date: 2019-09-17 14:04:59 +0000 URL: https://git.openjdk.java.net/skara/commit/7ee97c32 Make subject tags consistent Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From duke at openjdk.java.net Tue Sep 17 14:05:48 2019 From: duke at openjdk.java.net (duke) Date: Tue, 17 Sep 2019 14:05:48 GMT Subject: [Integrated] RFR: Simplify review status message In-Reply-To: References: Message-ID: <6449cc77-beca-4e92-95a9-1bd104f2754c@openjdk.java.net> Changeset: beaa5830 Author: Robin Westberg Date: 2019-09-17 14:05:39 +0000 URL: https://git.openjdk.java.net/skara/commit/beaa5830 Simplify review status message Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From ehelin at openjdk.org Wed Sep 18 06:56:04 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 18 Sep 2019 06:56:04 GMT Subject: RFR: Update to JUnit 5.5.2 Message-ID: Hi all, this small patch updates the JUnit dependency to 5.5.2. ## Testing - [x] `sh gradlew test` passes on Linux x86_64 Thanks, Erik ---------------- Commits: - d968638a: Update to JUnit 5.5.2 Pull request: https://git.openjdk.java.net/skara/pull/138 Webrev: https://webrevs.openjdk.java.net/skara/138/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/138.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/138/head:pull/138 From ehelin at openjdk.org Wed Sep 18 07:18:25 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 18 Sep 2019 07:18:25 GMT Subject: RFR: 9: JDK dependencies should only be in one file Message-ID: Hi all, this patch refactors the initial step of the build a bit. The JDK an Gradle dependencies are now specified in `deps.env` that both `gradlew` and `gradlew.bat` consumes. I also removed the dependency on `unzip` by writing a small Java implementation of unzip ???? ## Testing - [x] `sh gradlew test` passes on Linux x86_64 Thanks, Erik ---------------- Commits: - d6e823c5: 9: JDK dependencies should only be in one file Pull request: https://git.openjdk.java.net/skara/pull/139 Webrev: https://webrevs.openjdk.java.net/skara/139/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/139.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/139/head:pull/139 From rwestberg at openjdk.org Wed Sep 18 07:20:46 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 18 Sep 2019 07:20:46 GMT Subject: [Approved]: RFR: Update to JUnit 5.5.2 In-Reply-To: References: Message-ID: On Wed, 18 Sep 2019 06:56:04 GMT, Erik Helin wrote: > Hi all, > > this small patch updates the JUnit dependency to 5.5.2. > > ## Testing > - [x] `sh gradlew test` passes on Linux x86_64 > > Thanks, > Erik > > ---------------- > > Commits: > - d968638a: Update to JUnit 5.5.2 > > Pull request: > https://git.openjdk.java.net/skara/pull/138 > > Webrev: > https://webrevs.openjdk.java.net/skara/138/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/138.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/138/head:pull/138 Looks good! ---------------- Review status set to Approved by rwestberg (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/138 From rwestberg at openjdk.org Wed Sep 18 07:23:16 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 18 Sep 2019 07:23:16 GMT Subject: [Approved]: RFR: 9: JDK dependencies should only be in one file In-Reply-To: References: Message-ID: On Wed, 18 Sep 2019 07:18:25 GMT, Erik Helin wrote: > Hi all, > > this patch refactors the initial step of the build a bit. The JDK an Gradle dependencies are now specified in `deps.env` that both `gradlew` and `gradlew.bat` consumes. I also removed the dependency on `unzip` by writing a small Java implementation of unzip ???? > > ## Testing > - [x] `sh gradlew test` passes on Linux x86_64 > > Thanks, > Erik > > ---------------- > > Commits: > - d6e823c5: 9: JDK dependencies should only be in one file > > Pull request: > https://git.openjdk.java.net/skara/pull/139 > > Webrev: > https://webrevs.openjdk.java.net/skara/139/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/139.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/139/head:pull/139 Looks good, I hope you have tested it. :) ---------------- Review status set to Approved by rwestberg (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/139 From duke at openjdk.java.net Wed Sep 18 07:24:58 2019 From: duke at openjdk.java.net (duke) Date: Wed, 18 Sep 2019 07:24:58 GMT Subject: [Integrated] RFR: Update to JUnit 5.5.2 In-Reply-To: References: Message-ID: <2b4fe65d-6ae5-4bab-bf9e-adf72a6bad53@openjdk.java.net> Changeset: 36cc70a2 Author: Erik Helin Date: 2019-09-18 07:24:39 +0000 URL: https://git.openjdk.java.net/skara/commit/36cc70a2 Update to JUnit 5.5.2 Reviewed-by: rwestberg ! build.gradle From duke at openjdk.java.net Wed Sep 18 07:26:56 2019 From: duke at openjdk.java.net (duke) Date: Wed, 18 Sep 2019 07:26:56 GMT Subject: [Integrated] RFR: 9: JDK dependencies should only be in one file In-Reply-To: References: Message-ID: Changeset: 5715bf02 Author: Erik Helin Date: 2019-09-18 07:26:46 +0000 URL: https://git.openjdk.java.net/skara/commit/5715bf02 9: JDK dependencies should only be in one file Reviewed-by: rwestberg + Unzip.java + deps.env ! gradlew ! gradlew.bat From rwestberg at openjdk.org Wed Sep 18 07:58:17 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 18 Sep 2019 07:58:17 GMT Subject: [Approved]: RFR: Update to Gradle 5.6.2 In-Reply-To: References: Message-ID: On Wed, 18 Sep 2019 07:58:06 GMT, Erik Helin wrote: > Hi all, > > this patch updates Gradle to version 5.6.2. > > ## Testing > - [x] `sh gradlew images` produces correct images > - [x] `sh gradlew test` passes > - [x] `sh gradlew reproduce` passes > > Thanks, > Erik > > ---------------- > > Commits: > - 058e5b77: Update to Gradle 5.6.2 > > Pull request: > https://git.openjdk.java.net/skara/pull/140 > > Webrev: > https://webrevs.openjdk.java.net/skara/140/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/140.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/140/head:pull/140 Looks good! ---------------- Review status set to Approved by rwestberg (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/140 From ehelin at openjdk.org Wed Sep 18 07:58:06 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 18 Sep 2019 07:58:06 GMT Subject: RFR: Update to Gradle 5.6.2 Message-ID: Hi all, this patch updates Gradle to version 5.6.2. ## Testing - [x] `sh gradlew images` produces correct images - [x] `sh gradlew test` passes - [x] `sh gradlew reproduce` passes Thanks, Erik ---------------- Commits: - 058e5b77: Update to Gradle 5.6.2 Pull request: https://git.openjdk.java.net/skara/pull/140 Webrev: https://webrevs.openjdk.java.net/skara/140/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/140.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/140/head:pull/140 From duke at openjdk.java.net Wed Sep 18 08:02:58 2019 From: duke at openjdk.java.net (duke) Date: Wed, 18 Sep 2019 08:02:58 GMT Subject: [Integrated] RFR: Update to Gradle 5.6.2 In-Reply-To: References: Message-ID: <14e6c1a2-9e8d-45f0-b375-a09f7fe23cbc@openjdk.java.net> Changeset: 91f05bc4 Author: Erik Helin Date: 2019-09-18 08:02:50 +0000 URL: https://git.openjdk.java.net/skara/commit/91f05bc4 Update to Gradle 5.6.2 Reviewed-by: rwestberg ! deps.env ! test.dockerfile From ehelin at openjdk.org Wed Sep 18 08:18:35 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 18 Sep 2019 08:18:35 GMT Subject: RFR: Update to Oracle Linux 7.6 Message-ID: <5iz2-giLCutSfciJE-BZEbxaA5luAIrJJHaLKBeTHn4=.087cc70b-168b-404f-8eb6-5302f43c14e3@github.com> Hi all, this small patch updates the base image in `test.dockerfile` from Oracle Linux 7.5 to 7.6. ## Testing - [x] `sh gradlew reproduce` Thanks, Erik ---------------- Commits: - 1c931299: Update to Oracle Linux 7.6 Pull request: https://git.openjdk.java.net/skara/pull/141 Webrev: https://webrevs.openjdk.java.net/skara/141/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/141.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/141/head:pull/141 From rwestberg at openjdk.org Wed Sep 18 08:21:35 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 18 Sep 2019 08:21:35 GMT Subject: [Approved]: RFR: Update to Oracle Linux 7.6 In-Reply-To: <5iz2-giLCutSfciJE-BZEbxaA5luAIrJJHaLKBeTHn4=.087cc70b-168b-404f-8eb6-5302f43c14e3@github.com> References: <5iz2-giLCutSfciJE-BZEbxaA5luAIrJJHaLKBeTHn4=.087cc70b-168b-404f-8eb6-5302f43c14e3@github.com> Message-ID: On Wed, 18 Sep 2019 08:18:35 GMT, Erik Helin wrote: > Hi all, > > this small patch updates the base image in `test.dockerfile` from Oracle Linux 7.5 to 7.6. > > ## Testing > - [x] `sh gradlew reproduce` > > Thanks, > Erik > > ---------------- > > Commits: > - 1c931299: Update to Oracle Linux 7.6 > > Pull request: > https://git.openjdk.java.net/skara/pull/141 > > Webrev: > https://webrevs.openjdk.java.net/skara/141/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/141.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/141/head:pull/141 ???? ---------------- Review status set to Approved by rwestberg (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/141 From duke at openjdk.java.net Wed Sep 18 08:22:07 2019 From: duke at openjdk.java.net (duke) Date: Wed, 18 Sep 2019 08:22:07 GMT Subject: [Integrated] RFR: Update to Oracle Linux 7.6 In-Reply-To: <5iz2-giLCutSfciJE-BZEbxaA5luAIrJJHaLKBeTHn4=.087cc70b-168b-404f-8eb6-5302f43c14e3@github.com> References: <5iz2-giLCutSfciJE-BZEbxaA5luAIrJJHaLKBeTHn4=.087cc70b-168b-404f-8eb6-5302f43c14e3@github.com> Message-ID: Changeset: 818fff54 Author: Erik Helin Date: 2019-09-18 08:21:56 +0000 URL: https://git.openjdk.java.net/skara/commit/818fff54 Update to Oracle Linux 7.6 Reviewed-by: rwestberg ! test.dockerfile From rwestberg at openjdk.org Wed Sep 18 09:04:15 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 18 Sep 2019 09:04:15 GMT Subject: RFR: Stop throwing when unable to find a matching PR Message-ID: Hi all, Please review this change that stops throwing an exception when failing to match a change to an existing PR in the PR-only mode, as this is not very useful. Best regards, Robin ---------------- Commits: - ae0a90ec: Stop throwing when unable to find a matching PR Pull request: https://git.openjdk.java.net/skara/pull/142 Webrev: https://webrevs.openjdk.java.net/skara/142/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/142.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/142/head:pull/142 From ehelin at openjdk.org Wed Sep 18 11:46:46 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 18 Sep 2019 11:46:46 GMT Subject: [Approved]: RFR: Stop throwing when unable to find a matching PR In-Reply-To: References: Message-ID: <3ge-r8SKqilAMSwlzKvKcEdu2suMZtAaTxqdHOR5G0Y=.79bc8ce6-0efe-452e-ad19-0814e38b5c6f@github.com> On Wed, 18 Sep 2019 09:04:15 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that stops throwing an exception when failing to match a change to an existing PR in the PR-only mode, as this is not very useful. > > Best regards, > Robin > > ---------------- > > Commits: > - ae0a90ec: Stop throwing when unable to find a matching PR > > Pull request: > https://git.openjdk.java.net/skara/pull/142 > > Webrev: > https://webrevs.openjdk.java.net/skara/142/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/142.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/142/head:pull/142 Thanks for fixing, looks good! ---------------- Review status set to Approved by ehelin (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/142 From duke at openjdk.java.net Wed Sep 18 11:53:57 2019 From: duke at openjdk.java.net (duke) Date: Wed, 18 Sep 2019 11:53:57 GMT Subject: [Integrated] RFR: Stop throwing when unable to find a matching PR In-Reply-To: References: Message-ID: <20b30eed-bc63-4a7c-add3-7f05cca77f87@openjdk.java.net> Changeset: 710b796e Author: Robin Westberg Date: 2019-09-18 11:53:49 +0000 URL: https://git.openjdk.java.net/skara/commit/710b796e Stop throwing when unable to find a matching PR Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From rwestberg at openjdk.org Wed Sep 18 12:19:56 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 18 Sep 2019 12:19:56 GMT Subject: RFR: Adjust formatting of RFR email contents Message-ID: Hi all, Please review these changes that adjust the formatting of the RFR email contents, to make it more concise and also add a bit more information. Best regards, Robin ---------------- Commits: - 6194395f: Adjust formatting of RFR email contents Pull request: https://git.openjdk.java.net/skara/pull/143 Webrev: https://webrevs.openjdk.java.net/skara/143/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/143.diff Fetch command: git fetch https://git.openjdk.java.net/skara pull/143/head:pull/143 From ehelin at openjdk.org Wed Sep 18 12:24:57 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 18 Sep 2019 12:24:57 GMT Subject: [Approved]: RFR: Adjust formatting of RFR email contents In-Reply-To: References: Message-ID: On Wed, 18 Sep 2019 12:19:56 GMT, Robin Westberg wrote: > Hi all, > > Please review these changes that adjust the formatting of the RFR email contents, to make it more concise and also add a bit more information. > > Best regards, > Robin > > ---------------- > > Commits: > - 6194395f: Adjust formatting of RFR email contents > > Pull request: > https://git.openjdk.java.net/skara/pull/143 > > Webrev: > https://webrevs.openjdk.java.net/skara/143/webrev.00 > > Patch: > https://git.openjdk.java.net/skara/pull/143.diff > > Fetch command: > git fetch https://git.openjdk.java.net/skara pull/143/head:pull/143 Wow, very nice! ---------------- Review status set to Approved by ehelin (project role: Reviewer). PR: https://git.openjdk.java.net/skara/pull/143 From duke at openjdk.java.net Wed Sep 18 12:26:37 2019 From: duke at openjdk.java.net (duke) Date: Wed, 18 Sep 2019 12:26:37 GMT Subject: [Integrated] RFR: Adjust formatting of RFR email contents In-Reply-To: References: Message-ID: <2faee2a0-9518-4c2c-b783-3263845798cb@openjdk.java.net> Changeset: 59a169cd Author: Robin Westberg Date: 2019-09-18 12:26:30 +0000 URL: https://git.openjdk.java.net/skara/commit/59a169cd Adjust formatting of RFR email contents Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/PullRequestInstance.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From rwestberg at openjdk.org Wed Sep 18 13:26:20 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 18 Sep 2019 13:26:20 GMT Subject: RFR: Fix typ in PR stats summary Message-ID: Hi all, Please review this minor fix of a typo in the stats summary found in RFR emails. Best regards, Robin ---------------- Commits: - bd0ad112: Fix typo Stats: 1 lines in 1 file changed: 0 ins; 0 del; 1 mod Changes: https://git.openjdk.java.net/skara/pull/144/files Webrev: https://webrevs.openjdk.java.net/skara/144/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/144.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/144/head:pull/144 PR: https://git.openjdk.java.net/skara/pull/144 From ehelin at openjdk.org Wed Sep 18 14:00:53 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 18 Sep 2019 14:00:53 GMT Subject: [Approved] RFR: Fix typo in PR stats summary In-Reply-To: References: Message-ID: On Wed, 18 Sep 2019 13:26:20 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor fix of a typo in the stats summary found in RFR emails. > > Best regards, > Robin > > ---------------- > > Commits: > - bd0ad112: Fix typo > > Stats: 1 lines in 1 file changed: 0 ins; 0 del; 1 mod > Changes: https://git.openjdk.java.net/skara/pull/144/files > Webrev: https://webrevs.openjdk.java.net/skara/144/webrev.00 > Patch: https://git.openjdk.java.net/skara/pull/144.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/144/head:pull/144 Looks good :+1: ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/144 From duke at openjdk.java.net Thu Sep 19 05:58:45 2019 From: duke at openjdk.java.net (duke) Date: Thu, 19 Sep 2019 05:58:45 GMT Subject: git: openjdk/skara: Fix typo in PR stats summary Message-ID: Changeset: d25c1f5b Author: Robin Westberg Date: 2019-09-19 05:58:37 +0000 URL: https://git.openjdk.java.net/skara/commit/d25c1f5b Fix typo in PR stats summary Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/PullRequestInstance.java From rwestberg at openjdk.org Thu Sep 19 06:16:54 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 19 Sep 2019 06:16:54 GMT Subject: RFR: Update notifier PR matching pattern Message-ID: Hi all, Please review this small fix that ensures that the notifier finds RFR mails with the updated format. Best regards, Robin ---------------- Commits: - f55dbe28: Update notifier PR matching pattern Stats: 4 lines in 3 files changed: 1 ins; 0 del; 3 mod Changes: https://git.openjdk.java.net/skara/pull/145/files Webrev: https://webrevs.openjdk.java.net/skara/145/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/145.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/145/head:pull/145 PR: https://git.openjdk.java.net/skara/pull/145 From rwestberg at openjdk.org Thu Sep 19 06:18:13 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 19 Sep 2019 06:18:13 GMT Subject: [Rev 01] RFR: Update notifier PR matching pattern In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 2e85a81a: Match the old format as well Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Changes: - all: https://git.openjdk.java.net/skara/pull/145/files - new: https://git.openjdk.java.net/skara/pull/145/files/f55dbe28..2e85a81a Webrevs: - full: https://webrevs.openjdk.java.net/skara/145/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/145/webrev.00-01 Patch: https://git.openjdk.java.net/skara/pull/145.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/145/head:pull/145 PR: https://git.openjdk.java.net/skara/pull/145 From rwestberg at openjdk.org Thu Sep 19 07:46:06 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 19 Sep 2019 07:46:06 GMT Subject: RFR: Improve RFR email formatting Message-ID: Hi all, Please review this small change that updates the RFR email formatting a bit. Best regards, Robin ---------------- Commits: - 3f29541c: Improve formatting Stats: 9 lines in 1 file changed: 3 ins; 3 del; 3 mod Changes: https://git.openjdk.java.net/skara/pull/146/files Webrev: https://webrevs.openjdk.java.net/skara/146/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/146.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/146/head:pull/146 PR: https://git.openjdk.java.net/skara/pull/146 From rwestberg at openjdk.org Thu Sep 19 07:56:11 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 19 Sep 2019 07:56:11 GMT Subject: RFR: Test matching all available emoji patterns Message-ID: Hi all, Please review this minor change that ensures that all existing emoji patterns can be properly matched, as well as correcting the pattern. Best regards, Robin ---------------- Commits: - 4b9ffeed: Test matching all available patterns Stats: 10 lines in 2 files changed: 8 ins; 0 del; 2 mod Changes: https://git.openjdk.java.net/skara/pull/147/files Webrev: https://webrevs.openjdk.java.net/skara/147/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/147.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/147/head:pull/147 PR: https://git.openjdk.java.net/skara/pull/147 From ehelin at openjdk.org Thu Sep 19 08:20:33 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 19 Sep 2019 08:20:33 GMT Subject: [Approved] RFR: Update notifier PR matching pattern In-Reply-To: References: Message-ID: On Thu, 19 Sep 2019 06:16:54 GMT, Robin Westberg wrote: > Hi all, > > Please review this small fix that ensures that the notifier finds RFR mails with the updated format. > > Best regards, > Robin > > ---------------- > > Commits: > - f55dbe28: Update notifier PR matching pattern > > Stats: 4 lines in 3 files changed: 1 ins; 0 del; 3 mod > Changes: https://git.openjdk.java.net/skara/pull/145/files > Webrev: https://webrevs.openjdk.java.net/skara/145/webrev.00 > Patch: https://git.openjdk.java.net/skara/pull/145.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/145/head:pull/145 Looks good, thanks! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/145 From ehelin at openjdk.org Thu Sep 19 08:20:53 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 19 Sep 2019 08:20:53 GMT Subject: [Approved] RFR: Improve RFR email formatting In-Reply-To: References: Message-ID: On Thu, 19 Sep 2019 07:46:06 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that updates the RFR email formatting a bit. > > Best regards, > Robin > > ---------------- > > Commits: > - 3f29541c: Improve formatting > > Stats: 9 lines in 1 file changed: 3 ins; 3 del; 3 mod > Changes: https://git.openjdk.java.net/skara/pull/146/files > Webrev: https://webrevs.openjdk.java.net/skara/146/webrev.00 > Patch: https://git.openjdk.java.net/skara/pull/146.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/146/head:pull/146 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/146 From ehelin at openjdk.org Thu Sep 19 08:21:42 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 19 Sep 2019 08:21:42 GMT Subject: [Approved] RFR: Test matching all available emoji patterns In-Reply-To: References: Message-ID: <-aRHve1bgiHR9XJ-3FrDCeNO6c99fJE0PuUfLWCzP-4=.55e270fb-1d4f-427f-801a-52c8931f8e5f@github.com> On Thu, 19 Sep 2019 07:56:11 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that ensures that all existing emoji patterns can be properly matched, as well as correcting the pattern. > > Best regards, > Robin > > ---------------- > > Commits: > - 4b9ffeed: Test matching all available patterns > > Stats: 10 lines in 2 files changed: 8 ins; 0 del; 2 mod > Changes: https://git.openjdk.java.net/skara/pull/147/files > Webrev: https://webrevs.openjdk.java.net/skara/147/webrev.00 > Patch: https://git.openjdk.java.net/skara/pull/147.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/147/head:pull/147 Thanks, looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/147 From duke at openjdk.java.net Thu Sep 19 08:24:34 2019 From: duke at openjdk.java.net (duke) Date: Thu, 19 Sep 2019 08:24:34 GMT Subject: git: openjdk/skara: Update notifier PR matching pattern Message-ID: Changeset: 8fad696d Author: Robin Westberg Date: 2019-09-19 08:24:25 +0000 URL: https://git.openjdk.java.net/skara/commit/8fad696d Update notifier PR matching pattern Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From duke at openjdk.java.net Thu Sep 19 08:42:52 2019 From: duke at openjdk.java.net (duke) Date: Thu, 19 Sep 2019 08:42:52 GMT Subject: [Integrated] RFR: Improve RFR email formatting In-Reply-To: References: Message-ID: <194f1f51-d96d-4a74-b0e3-8b5a9d457a68@openjdk.java.net> Changeset: ef2e905b Author: Robin Westberg Date: 2019-09-19 08:42:44 +0000 URL: https://git.openjdk.java.net/skara/commit/ef2e905b Improve RFR email formatting Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java From duke at openjdk.java.net Thu Sep 19 08:43:01 2019 From: duke at openjdk.java.net (duke) Date: Thu, 19 Sep 2019 08:43:01 GMT Subject: [Integrated] RFR: Test matching all available emoji patterns In-Reply-To: References: Message-ID: <276df38a-057e-47ec-a75b-467ac0f0eb33@openjdk.java.net> Changeset: 35ba541b Author: Robin Westberg Date: 2019-09-19 08:42:54 +0000 URL: https://git.openjdk.java.net/skara/commit/35ba541b Test matching all available emoji patterns Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MarkdownToText.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MarkdownToTextTests.java From rwestberg at openjdk.org Thu Sep 19 12:11:49 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 19 Sep 2019 12:11:49 GMT Subject: RFR: Add support for adding an issue when formatting the commit message Message-ID: <82F1G_ctj6AilyABXoDCH1KgkoBStsLmgzOQErGBQjw=.2ab17030-4759-456f-8af0-7a66635bf67f@github.com> Hi all, Please review this change that allows setting the issue of a commit through the PR title. Best regards, Robin ---------------- Commits: - 6222eb97: Add support for adding an issue when formatting the commit message Stats: 97 lines in 8 files changed: 78 ins; 4 del; 15 mod Changes: https://git.openjdk.java.net/skara/pull/148/files Webrev: https://webrevs.openjdk.java.net/skara/148/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/148.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/148/head:pull/148 PR: https://git.openjdk.java.net/skara/pull/148 From ehelin at openjdk.org Thu Sep 19 14:59:52 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 19 Sep 2019 14:59:52 GMT Subject: RFR: Add support for adding an issue when formatting the commit message In-Reply-To: <82F1G_ctj6AilyABXoDCH1KgkoBStsLmgzOQErGBQjw=.2ab17030-4759-456f-8af0-7a66635bf67f@github.com> References: <82F1G_ctj6AilyABXoDCH1KgkoBStsLmgzOQErGBQjw=.2ab17030-4759-456f-8af0-7a66635bf67f@github.com> Message-ID: On Thu, 19 Sep 2019 12:11:49 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows setting the issue of a commit through the PR title. > > Best regards, > Robin > > ---------------- > > Commits: > - 6222eb97: Add support for adding an issue when formatting the commit message > > Stats: 97 lines in 8 files changed: 78 ins; 4 del; 15 mod > Changes: https://git.openjdk.java.net/skara/pull/148/files > Webrev: https://webrevs.openjdk.java.net/skara/148/webrev.00 > Patch: https://git.openjdk.java.net/skara/pull/148.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/148/head:pull/148 host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java line 217: > 216: public void setTitle(String title) { > 217: throw new RuntimeException("not implemented yet"); > 218: } Won't this be an issue if we run the unit tests as integration tests against real hosts? host/src/main/java/org/openjdk/skara/host/gitlab/GitLabMergeRequest.java line 259: > 258: public void setTitle(String title) { > 259: throw new RuntimeException("not implemented yet"); > 260: } Same issue here? PR: https://git.openjdk.java.net/skara/pull/148 From ehelin at openjdk.org Thu Sep 19 15:00:02 2019 From: ehelin at openjdk.org (Erik Helin) Date: Thu, 19 Sep 2019 15:00:02 GMT Subject: RFR: Add support for adding an issue when formatting the commit message In-Reply-To: <82F1G_ctj6AilyABXoDCH1KgkoBStsLmgzOQErGBQjw=.2ab17030-4759-456f-8af0-7a66635bf67f@github.com> References: <82F1G_ctj6AilyABXoDCH1KgkoBStsLmgzOQErGBQjw=.2ab17030-4759-456f-8af0-7a66635bf67f@github.com> Message-ID: On Thu, 19 Sep 2019 12:11:49 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows setting the issue of a commit through the PR title. > > Best regards, > Robin > > ---------------- > > Commits: > - 6222eb97: Add support for adding an issue when formatting the commit message > > Stats: 97 lines in 8 files changed: 78 ins; 4 del; 15 mod > Changes: https://git.openjdk.java.net/skara/pull/148/files > Webrev: https://webrevs.openjdk.java.net/skara/148/webrev.00 > Patch: https://git.openjdk.java.net/skara/pull/148.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/148/head:pull/148 Looks good overall, just two minor comments inline. PR: https://git.openjdk.java.net/skara/pull/148 From rwestberg at openjdk.org Fri Sep 20 07:45:20 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 20 Sep 2019 07:45:20 GMT Subject: RFR: Add an issue link to RFR mails if the PR title contains one Message-ID: <20Hh4i56Yj2u4QLI_AfA-maYqVk0h__otP6XmBPQrI4=.933ac788-e248-4d77-b7d8-39074b238c26@github.com> Hi all, Please review this change that adds an issue link to RFR emails if the PR title contains one. It also allows projects to specify their issue key in case it is different from the project name. Best regards, Robin ---------------- Commits: - af1d7158: Add an issue link to RFR mails if the PR title contains one Stats: 84 lines in 11 files changed: 57 ins; 0 del; 27 mod Changes: https://git.openjdk.java.net/skara/pull/149/files Webrev: https://webrevs.openjdk.java.net/skara/149/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/149.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/149/head:pull/149 PR: https://git.openjdk.java.net/skara/pull/149 From ehelin at openjdk.org Fri Sep 20 09:46:18 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 20 Sep 2019 09:46:18 GMT Subject: RFR: Handle binary patches in webrev Message-ID: Hi all, this patch makes `git webrev` generate `.patch` files for binary files. Thanks @rwestberg for the initial reproducer! ## Testing - [x] Added three new unit tests Thanks, Erik ---------------- Commits: - cd9b801d: Handle binary patches in webrev Stats: 221 lines in 7 files changed: 185 ins; 12 del; 24 mod Changes: https://git.openjdk.java.net/skara/pull/150/files Webrev: https://webrevs.openjdk.java.net/skara/150/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/150.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/150/head:pull/150 PR: https://git.openjdk.java.net/skara/pull/150 From rwestberg at openjdk.org Fri Sep 20 09:49:41 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 20 Sep 2019 09:49:41 GMT Subject: RFR: Handle binary patches in webrev In-Reply-To: References: Message-ID: <4DvozWL_1RMEWYP33-FgNxHquyChTLZirjfeHcUHxns=.d82b3d8c-0777-4962-87f0-ab7b3611fc76@github.com> On Fri, 20 Sep 2019 09:46:18 GMT, Erik Helin wrote: > Hi all, > > this patch makes `git webrev` generate `.patch` files for binary files. Thanks @rwestberg for the initial reproducer! > > ## Testing > - [x] Added three new unit tests > > Thanks, > Erik > > ---------------- > > Commits: > - cd9b801d: Handle binary patches in webrev > > Stats: 221 lines in 7 files changed: 185 ins; 12 del; 24 mod > Changes: https://git.openjdk.java.net/skara/pull/150/files > Webrev: https://webrevs.openjdk.java.net/skara/150/webrev.00 > Patch: https://git.openjdk.java.net/skara/pull/150.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/150/head:pull/150 webrev/src/test/java/org/openjdk/skara/webrev/WebrevTests.java line 133: > 132: new Webrev.Builder(repo, tmp.path().resolve("webrev")).generate(hash1, hash2); > 133: } > 134: } Perhaps add some sort of sanity-checking validation (like the other tests)? PR: https://git.openjdk.java.net/skara/pull/150 From rwestberg at openjdk.org Fri Sep 20 09:49:39 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 20 Sep 2019 09:49:39 GMT Subject: [Approved] RFR: Handle binary patches in webrev In-Reply-To: References: Message-ID: <2DWIr4pXsVSU8Wl5D-Jv_ZsTDbphJree1y786pfV-4E=.4098e677-41f4-4c83-a277-cc2176c58d83@github.com> On Fri, 20 Sep 2019 09:46:18 GMT, Erik Helin wrote: > Hi all, > > this patch makes `git webrev` generate `.patch` files for binary files. Thanks @rwestberg for the initial reproducer! > > ## Testing > - [x] Added three new unit tests > > Thanks, > Erik > > ---------------- > > Commits: > - cd9b801d: Handle binary patches in webrev > > Stats: 221 lines in 7 files changed: 185 ins; 12 del; 24 mod > Changes: https://git.openjdk.java.net/skara/pull/150/files > Webrev: https://webrevs.openjdk.java.net/skara/150/webrev.00 > Patch: https://git.openjdk.java.net/skara/pull/150.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/150/head:pull/150 Looks good, thanks for fixing! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/150 From ehelin at openjdk.org Fri Sep 20 09:54:00 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 20 Sep 2019 09:54:00 GMT Subject: [Approved] RFR: Add an issue link to RFR mails if the PR title contains one In-Reply-To: <20Hh4i56Yj2u4QLI_AfA-maYqVk0h__otP6XmBPQrI4=.933ac788-e248-4d77-b7d8-39074b238c26@github.com> References: <20Hh4i56Yj2u4QLI_AfA-maYqVk0h__otP6XmBPQrI4=.933ac788-e248-4d77-b7d8-39074b238c26@github.com> Message-ID: On Fri, 20 Sep 2019 07:45:20 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that adds an issue link to RFR emails if the PR title contains one. It also allows projects to specify their issue key in case it is different from the project name. > > Best regards, > Robin > > ---------------- > > Commits: > - af1d7158: Add an issue link to RFR mails if the PR title contains one > > Stats: 84 lines in 11 files changed: 57 ins; 0 del; 27 mod > Changes: https://git.openjdk.java.net/skara/pull/149/files > Webrev: https://webrevs.openjdk.java.net/skara/149/webrev.00 > Patch: https://git.openjdk.java.net/skara/pull/149.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/149/head:pull/149 Looks good, nice work Robin! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/149 From rwestberg at openjdk.org Fri Sep 20 11:33:10 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 20 Sep 2019 11:33:10 GMT Subject: RFR: A generated webrev should always include index.html Message-ID: Hi all, Please review this small change that ensures that the file size filter used when generating webrevs is not applied to the index.html file. Best regards, Robin ---------------- Commits: - 36fba5e9: Never filter out index.html Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Changes: https://git.openjdk.java.net/skara/pull/151/files Webrev: https://webrevs.openjdk.java.net/skara/151/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/151.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/151/head:pull/151 PR: https://git.openjdk.java.net/skara/pull/151 From rwestberg at openjdk.org Fri Sep 20 12:26:11 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 20 Sep 2019 12:26:11 GMT Subject: RFR: Fix problem with finding a collapsed parent Message-ID: Hi all, Please review this change that fixes a problem with finding the correct parent for a review comment, if the parent was combined with another comment before it was sent. Best regards, Robin ---------------- Commits: - b5f94dc6: Fix problem with finding a collapsed parent Stats: 12 lines in 2 files changed: 10 ins; 0 del; 2 mod Changes: https://git.openjdk.java.net/skara/pull/152/files Webrev: https://webrevs.openjdk.java.net/skara/152/webrev.00 Patch: https://git.openjdk.java.net/skara/pull/152.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/152/head:pull/152 PR: https://git.openjdk.java.net/skara/pull/152 From duke at openjdk.java.net Fri Sep 20 12:46:52 2019 From: duke at openjdk.java.net (duke) Date: Fri, 20 Sep 2019 12:46:52 GMT Subject: [Integrated] RFR: Handle binary patches in webrev In-Reply-To: References: Message-ID: Changeset: 1721a19a Author: Erik Helin Date: 2019-09-20 12:46:34 +0000 URL: https://git.openjdk.java.net/skara/commit/1721a19a Handle binary patches in webrev Reviewed-by: rwestberg ! webrev/src/main/java/org/openjdk/skara/webrev/AddedFileView.java ! webrev/src/main/java/org/openjdk/skara/webrev/AddedPatchView.java ! webrev/src/main/java/org/openjdk/skara/webrev/ModifiedFileView.java ! webrev/src/main/java/org/openjdk/skara/webrev/PatchView.java ! webrev/src/main/java/org/openjdk/skara/webrev/RemovedFileView.java ! webrev/src/main/java/org/openjdk/skara/webrev/RemovedPatchView.java ! webrev/src/test/java/org/openjdk/skara/webrev/WebrevTests.java From ehelin at openjdk.org Fri Sep 20 12:47:00 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 20 Sep 2019 12:47:00 GMT Subject: [Approved] RFR: A generated webrev should always include index.html In-Reply-To: References: Message-ID: <_CvjdvHEZ5kYFOjPk_UoiVseh3rrwVJKnraqSSxQ4k4=.62db5a3c-ac25-40f5-b12b-5359b49aea4e@github.com> On Fri, 20 Sep 2019 11:33:10 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that ensures that the file size filter used when generating webrevs is not applied to the index.html file. > > Best regards, > Robin > > ---------------- > > Commits: > - 36fba5e9: Never filter out index.html > > Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod > Changes: https://git.openjdk.java.net/skara/pull/151/files > Webrev: https://webrevs.openjdk.java.net/skara/151/webrev.00 > Patch: https://git.openjdk.java.net/skara/pull/151.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/151/head:pull/151 Thanks for fixing, looks good :+1: ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/151 From ehelin at openjdk.org Fri Sep 20 12:48:30 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 20 Sep 2019 12:48:30 GMT Subject: [Approved] RFR: Fix problem with finding a collapsed parent In-Reply-To: References: Message-ID: On Fri, 20 Sep 2019 12:26:11 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that fixes a problem with finding the correct parent for a review comment, if the parent was combined with another comment before it was sent. > > Best regards, > Robin > > ---------------- > > Commits: > - b5f94dc6: Fix problem with finding a collapsed parent > > Stats: 12 lines in 2 files changed: 10 ins; 0 del; 2 mod > Changes: https://git.openjdk.java.net/skara/pull/152/files > Webrev: https://webrevs.openjdk.java.net/skara/152/webrev.00 > Patch: https://git.openjdk.java.net/skara/pull/152.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/152/head:pull/152 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/152 From duke at openjdk.java.net Fri Sep 20 13:03:02 2019 From: duke at openjdk.java.net (duke) Date: Fri, 20 Sep 2019 13:03:02 GMT Subject: [Integrated] RFR: Fix problem with finding a collapsed parent In-Reply-To: References: Message-ID: Changeset: 9e02b45e Author: Robin Westberg Date: 2019-09-20 13:02:54 +0000 URL: https://git.openjdk.java.net/skara/commit/9e02b45e Fix problem with finding a collapsed parent Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From duke at openjdk.java.net Fri Sep 20 13:03:32 2019 From: duke at openjdk.java.net (duke) Date: Fri, 20 Sep 2019 13:03:32 GMT Subject: [Integrated] RFR: A generated webrev should always include index.html In-Reply-To: References: Message-ID: <0937d0cf-9eb4-425d-a44b-24ed094215d0@openjdk.java.net> Changeset: 915f2092 Author: Robin Westberg Date: 2019-09-20 13:03:21 +0000 URL: https://git.openjdk.java.net/skara/commit/915f2092 A generated webrev should always include index.html Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevStorage.java From kcr at openjdk.org Fri Sep 20 13:08:50 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Fri, 20 Sep 2019 13:08:50 GMT Subject: RFR: Add an issue link to RFR mails if the PR title contains one In-Reply-To: <20Hh4i56Yj2u4QLI_AfA-maYqVk0h__otP6XmBPQrI4=.933ac788-e248-4d77-b7d8-39074b238c26@github.com> References: <20Hh4i56Yj2u4QLI_AfA-maYqVk0h__otP6XmBPQrI4=.933ac788-e248-4d77-b7d8-39074b238c26@github.com> Message-ID: <3C9eA8fx45MuREN2O9jTwJ9Ub6DBLFhRXYMGlDvnvj8=.ac32be44-fc01-4aa2-889e-2171efc1e1c5@github.com> On Fri, 20 Sep 2019 07:45:20 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that adds an issue link to RFR emails if the PR title contains one. It also allows projects to specify their issue key in case it is different from the project name. > > Best regards, > Robin > > ---------------- > > Commits: > - af1d7158: Add an issue link to RFR mails if the PR title contains one > > Stats: 84 lines in 11 files changed: 57 ins; 0 del; 27 mod > Changes: https://git.openjdk.java.net/skara/pull/149/files > Webrev: https://webrevs.openjdk.java.net/skara/149/webrev.00 > Patch: https://git.openjdk.java.net/skara/pull/149.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/149/head:pull/149 This looks great. As a follow-on to this, what about having the bot add the JBS URL as a comment in the PR (maybe as part of the status block along with Progress and Approvers)? PR: https://git.openjdk.java.net/skara/pull/149 From rwestberg at openjdk.org Fri Sep 20 13:13:59 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 20 Sep 2019 13:13:59 GMT Subject: RFR: Add support for adding an issue when formatting the commit message In-Reply-To: References: <82F1G_ctj6AilyABXoDCH1KgkoBStsLmgzOQErGBQjw=.2ab17030-4759-456f-8af0-7a66635bf67f@github.com> Message-ID: On Thu, 19 Sep 2019 14:59:52 GMT, Erik Helin wrote: > On Thu, 19 Sep 2019 12:11:49 GMT, Robin Westberg wrote: > >> Hi all, >> >> Please review this change that allows setting the issue of a commit through the PR title. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - 6222eb97: Add support for adding an issue when formatting the commit message >> >> Stats: 97 lines in 8 files changed: 78 ins; 4 del; 15 mod >> Changes: https://git.openjdk.java.net/skara/pull/148/files >> Webrev: https://webrevs.openjdk.java.net/skara/148/webrev.00 >> Patch: https://git.openjdk.java.net/skara/pull/148.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/148/head:pull/148 > > host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java line 217: > >> 216: public void setTitle(String title) { >> 217: throw new RuntimeException("not implemented yet"); >> 218: } > > Won't this be an issue if we run the unit tests as integration tests against real hosts? > > host/src/main/java/org/openjdk/skara/host/gitlab/GitLabMergeRequest.java line 259: > >> 258: public void setTitle(String title) { >> 259: throw new RuntimeException("not implemented yet"); >> 260: } > > Same issue here? You are quite right, I was planning to save it for another task, as there are already existing issues with the real host tests.. PR: https://git.openjdk.java.net/skara/pull/148 From ehelin at openjdk.org Fri Sep 20 13:14:00 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 20 Sep 2019 13:14:00 GMT Subject: RFR: Add support for adding an issue when formatting the commit message In-Reply-To: References: <82F1G_ctj6AilyABXoDCH1KgkoBStsLmgzOQErGBQjw=.2ab17030-4759-456f-8af0-7a66635bf67f@github.com> Message-ID: On Thu, 19 Sep 2019 14:59:52 GMT, Erik Helin wrote: > On Thu, 19 Sep 2019 12:11:49 GMT, Robin Westberg wrote: > >> Hi all, >> >> Please review this change that allows setting the issue of a commit through the PR title. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - 6222eb97: Add support for adding an issue when formatting the commit message >> >> Stats: 97 lines in 8 files changed: 78 ins; 4 del; 15 mod >> Changes: https://git.openjdk.java.net/skara/pull/148/files >> Webrev: https://webrevs.openjdk.java.net/skara/148/webrev.00 >> Patch: https://git.openjdk.java.net/skara/pull/148.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/148/head:pull/148 > > host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java line 217: > >> 216: public void setTitle(String title) { >> 217: throw new RuntimeException("not implemented yet"); >> 218: } > > Won't this be an issue if we run the unit tests as integration tests against real hosts? > > host/src/main/java/org/openjdk/skara/host/gitlab/GitLabMergeRequest.java line 259: > >> 258: public void setTitle(String title) { >> 259: throw new RuntimeException("not implemented yet"); >> 260: } > > Same issue here? Ah ok, lets tackle it later then ???? PR: https://git.openjdk.java.net/skara/pull/148 From ehelin at openjdk.org Fri Sep 20 13:13:58 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 20 Sep 2019 13:13:58 GMT Subject: [Approved] RFR: Add support for adding an issue when formatting the commit message In-Reply-To: <82F1G_ctj6AilyABXoDCH1KgkoBStsLmgzOQErGBQjw=.2ab17030-4759-456f-8af0-7a66635bf67f@github.com> References: <82F1G_ctj6AilyABXoDCH1KgkoBStsLmgzOQErGBQjw=.2ab17030-4759-456f-8af0-7a66635bf67f@github.com> Message-ID: On Thu, 19 Sep 2019 12:11:49 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows setting the issue of a commit through the PR title. > > Best regards, > Robin > > ---------------- > > Commits: > - 6222eb97: Add support for adding an issue when formatting the commit message > > Stats: 97 lines in 8 files changed: 78 ins; 4 del; 15 mod > Changes: https://git.openjdk.java.net/skara/pull/148/files > Webrev: https://webrevs.openjdk.java.net/skara/148/webrev.00 > Patch: https://git.openjdk.java.net/skara/pull/148.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/148/head:pull/148 Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/148 From ehelin at openjdk.org Fri Sep 20 15:19:57 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 20 Sep 2019 15:19:57 GMT Subject: RFR: Add an issue link to RFR mails if the PR title contains one In-Reply-To: <3C9eA8fx45MuREN2O9jTwJ9Ub6DBLFhRXYMGlDvnvj8=.ac32be44-fc01-4aa2-889e-2171efc1e1c5@github.com> References: <20Hh4i56Yj2u4QLI_AfA-maYqVk0h__otP6XmBPQrI4=.933ac788-e248-4d77-b7d8-39074b238c26@github.com> <3C9eA8fx45MuREN2O9jTwJ9Ub6DBLFhRXYMGlDvnvj8=.ac32be44-fc01-4aa2-889e-2171efc1e1c5@github.com> Message-ID: On Fri, 20 Sep 2019 13:08:50 GMT, Kevin Rushforth wrote: > On Fri, 20 Sep 2019 07:45:20 GMT, Robin Westberg wrote: > >> Hi all, >> >> Please review this change that adds an issue link to RFR emails if the PR title contains one. It also allows projects to specify their issue key in case it is different from the project name. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - af1d7158: Add an issue link to RFR mails if the PR title contains one >> >> Stats: 84 lines in 11 files changed: 57 ins; 0 del; 27 mod >> Changes: https://git.openjdk.java.net/skara/pull/149/files >> Webrev: https://webrevs.openjdk.java.net/skara/149/webrev.00 >> Patch: https://git.openjdk.java.net/skara/pull/149.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/149/head:pull/149 > > This looks great. As a follow-on to this, what about having the bot add the JBS URL as a comment in the PR (maybe as part of the status block along with Progress and Approvers)? @kevinrushforth it is coming, we are just starting out small ???? PR: https://git.openjdk.java.net/skara/pull/149 From ehelin at openjdk.org Fri Sep 20 15:22:32 2019 From: ehelin at openjdk.org (Erik Helin) Date: Fri, 20 Sep 2019 15:22:32 GMT Subject: RFR: webrev: fix indentation of removed binary file view Message-ID: Hi all, this small patch fixes an indentation issue with removed binary files in webrev's `index.html`. Thanks, Erik ---------------- Commits: - eb501992: webrev: fix indentation of removed binary file view Changes: https://git.openjdk.java.net/skara/pull/154/files Webrev: https://webrevs.openjdk.java.net/skara/154/webrev.00 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/154.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/154/head:pull/154 PR: https://git.openjdk.java.net/skara/pull/154 From kcr at openjdk.org Fri Sep 20 15:35:57 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Fri, 20 Sep 2019 15:35:57 GMT Subject: RFR: Add an issue link to RFR mails if the PR title contains one In-Reply-To: References: <20Hh4i56Yj2u4QLI_AfA-maYqVk0h__otP6XmBPQrI4=.933ac788-e248-4d77-b7d8-39074b238c26@github.com> <3C9eA8fx45MuREN2O9jTwJ9Ub6DBLFhRXYMGlDvnvj8=.ac32be44-fc01-4aa2-889e-2171efc1e1c5@github.com> Message-ID: On Fri, 20 Sep 2019 15:19:57 GMT, Erik Helin wrote: > On Fri, 20 Sep 2019 13:08:50 GMT, Kevin Rushforth wrote: > >> On Fri, 20 Sep 2019 07:45:20 GMT, Robin Westberg wrote: >> >>> Hi all, >>> >>> Please review this change that adds an issue link to RFR emails if the PR title contains one. It also allows projects to specify their issue key in case it is different from the project name. >>> >>> Best regards, >>> Robin >>> >>> ---------------- >>> >>> Commits: >>> - af1d7158: Add an issue link to RFR mails if the PR title contains one >>> >>> Stats: 84 lines in 11 files changed: 57 ins; 0 del; 27 mod >>> Changes: https://git.openjdk.java.net/skara/pull/149/files >>> Webrev: https://webrevs.openjdk.java.net/skara/149/webrev.00 >>> Patch: https://git.openjdk.java.net/skara/pull/149.diff >>> Fetch: git fetch https://git.openjdk.java.net/skara pull/149/head:pull/149 >> >> This looks great. As a follow-on to this, what about having the bot add the JBS URL as a comment in the PR (maybe as part of the status block along with Progress and Approvers)? > > @kevinrushforth it is coming, we are just starting out small ???? I'm looking forward to testing this for openjfx, which does have a different JBS prefix than the project name, so I'll be using the `jbs` field in `.jcheck/conf`. PR: https://git.openjdk.java.net/skara/pull/149 From kcr at openjdk.org Fri Sep 20 15:44:28 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Fri, 20 Sep 2019 15:44:28 GMT Subject: RFR: Add an issue link to RFR mails if the PR title contains one In-Reply-To: <20Hh4i56Yj2u4QLI_AfA-maYqVk0h__otP6XmBPQrI4=.933ac788-e248-4d77-b7d8-39074b238c26@github.com> References: <20Hh4i56Yj2u4QLI_AfA-maYqVk0h__otP6XmBPQrI4=.933ac788-e248-4d77-b7d8-39074b238c26@github.com> Message-ID: On Fri, 20 Sep 2019 07:45:20 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that adds an issue link to RFR emails if the PR title contains one. It also allows projects to specify their issue key in case it is different from the project name. > > Best regards, > Robin > > ---------------- > > Commits: > - af1d7158: Add an issue link to RFR mails if the PR title contains one > > Stats: 84 lines in 11 files changed: 57 ins; 0 del; 27 mod > Changes: https://git.openjdk.java.net/skara/pull/149/files > Webrev: https://webrevs.openjdk.java.net/skara/149/webrev.00 > Patch: https://git.openjdk.java.net/skara/pull/149.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/149/head:pull/149 Looks good to me. ---------------- Approved by kcr (none). PR: https://git.openjdk.java.net/skara/pull/149 From rwestberg at openjdk.org Mon Sep 23 06:26:42 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 23 Sep 2019 06:26:42 GMT Subject: RFR: Improve stripping of code blocks Message-ID: Hi all, Please review this small fix that makes the stripping of code block formatting more robust. Best regards, Robin ---------------- Commits: - d17fe52e: Improve stripping of code blocks Changes: https://git.openjdk.java.net/skara/pull/155/files Webrev: https://webrevs.openjdk.java.net/skara/155/webrev.00 Stats: 10 lines in 2 files changed: 7 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/155.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/155/head:pull/155 PR: https://git.openjdk.java.net/skara/pull/155 From rwestberg at openjdk.org Mon Sep 23 06:27:00 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 23 Sep 2019 06:27:00 GMT Subject: [Approved] RFR: webrev: fix indentation of removed binary file view In-Reply-To: References: Message-ID: On Fri, 20 Sep 2019 15:22:32 GMT, Erik Helin wrote: > Hi all, > > this small patch fixes an indentation issue with removed binary files in webrev's `index.html`. > > Thanks, > Erik > > ---------------- > > Commits: > - eb501992: webrev: fix indentation of removed binary file view > > Changes: https://git.openjdk.java.net/skara/pull/154/files > Webrev: https://webrevs.openjdk.java.net/skara/154/webrev.00 > Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/154.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/154/head:pull/154 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/154 From rwestberg at openjdk.org Mon Sep 23 08:45:33 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 23 Sep 2019 08:45:33 GMT Subject: RFR: Future-proof mbox test Message-ID: Hi all, Please review this minor test case fix that fixes a time related failure. Best regards, Robin ---------------- Commits: - 193caa0a: Future-proof mbox test Changes: https://git.openjdk.java.net/skara/pull/156/files Webrev: https://webrevs.openjdk.java.net/skara/156/webrev.00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/156.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/156/head:pull/156 PR: https://git.openjdk.java.net/skara/pull/156 From rwestberg at openjdk.org Mon Sep 23 08:46:43 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 23 Sep 2019 08:46:43 GMT Subject: RFR: 102: Setting summary does not update the preview message Message-ID: Hi all, Please review this change that ensures that the commit preview message is updated when a summary is added or updated. Best regards, Robin ---------------- Commits: - 58758066: Editing a summary should update the preview message Changes: https://git.openjdk.java.net/skara/pull/157/files Webrev: https://webrevs.openjdk.java.net/skara/157/webrev.00 Stats: 14 lines in 2 files changed: 7 ins; 6 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/157.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/157/head:pull/157 PR: https://git.openjdk.java.net/skara/pull/157 From rwestberg at openjdk.org Mon Sep 23 08:47:35 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 23 Sep 2019 08:47:35 GMT Subject: RFR: Add support for adding extra headers to mails sent to mailing lists Message-ID: Hi all, Please review this change that allows adding extra headers to mails that are sent to mailing lists. This can be used to add authentication headers. Best regards, Robin ---------------- Commits: - 7fcd00bc: Add support for adding extra headers to mails sent to mailing lists Changes: https://git.openjdk.java.net/skara/pull/158/files Webrev: https://webrevs.openjdk.java.net/skara/158/webrev.00 Stats: 32 lines in 5 files changed: 16 ins; 0 del; 16 mod Patch: https://git.openjdk.java.net/skara/pull/158.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/158/head:pull/158 PR: https://git.openjdk.java.net/skara/pull/158 From duke at openjdk.java.net Mon Sep 23 12:57:11 2019 From: duke at openjdk.java.net (duke) Date: Mon, 23 Sep 2019 12:57:11 GMT Subject: [Integrated] RFR: Add support for adding an issue when formatting the commit message In-Reply-To: <82F1G_ctj6AilyABXoDCH1KgkoBStsLmgzOQErGBQjw=.2ab17030-4759-456f-8af0-7a66635bf67f@github.com> References: <82F1G_ctj6AilyABXoDCH1KgkoBStsLmgzOQErGBQjw=.2ab17030-4759-456f-8af0-7a66635bf67f@github.com> Message-ID: <7a63bbf2-68e8-4963-a96e-493e374708a1@openjdk.java.net> Changeset: 0132f0e3 Author: Robin Westberg Date: 2019-09-23 12:57:02 +0000 URL: https://git.openjdk.java.net/skara/commit/0132f0e3 Add support for adding an issue when formatting the commit message Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java ! host/src/main/java/org/openjdk/skara/host/PullRequest.java ! host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java ! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabMergeRequest.java ! test/src/main/java/org/openjdk/skara/test/CheckableRepository.java ! test/src/main/java/org/openjdk/skara/test/TestPullRequest.java From duke at openjdk.java.net Mon Sep 23 12:58:01 2019 From: duke at openjdk.java.net (duke) Date: Mon, 23 Sep 2019 12:58:01 GMT Subject: [Integrated] RFR: Add an issue link to RFR mails if the PR title contains one In-Reply-To: <20Hh4i56Yj2u4QLI_AfA-maYqVk0h__otP6XmBPQrI4=.933ac788-e248-4d77-b7d8-39074b238c26@github.com> References: <20Hh4i56Yj2u4QLI_AfA-maYqVk0h__otP6XmBPQrI4=.933ac788-e248-4d77-b7d8-39074b238c26@github.com> Message-ID: <02ffe2bb-c770-4a87-adb9-847d2a87c0bd@openjdk.java.net> Changeset: cc79727a Author: Robin Westberg Date: 2019-09-23 12:57:43 +0000 URL: https://git.openjdk.java.net/skara/commit/cc79727a Add an issue link to RFR mails if the PR title contains one Reviewed-by: ehelin, kcr ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/PullRequestInstance.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBotTests.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/WebrevStorageTests.java ! jcheck/src/main/java/org/openjdk/skara/jcheck/GeneralConfiguration.java ! jcheck/src/main/java/org/openjdk/skara/jcheck/JCheckConfiguration.java ! test/src/main/java/org/openjdk/skara/test/CheckableRepository.java From kcr at openjdk.org Mon Sep 23 13:08:28 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Mon, 23 Sep 2019 13:08:28 GMT Subject: RFR: 102: Setting summary does not update the preview message In-Reply-To: References: Message-ID: On Mon, 23 Sep 2019 08:46:43 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that the commit preview message is updated when a summary is added or updated. > > Best regards, > Robin > > ---------------- > > Commits: > - 58758066: Editing a summary should update the preview message > > Changes: https://git.openjdk.java.net/skara/pull/157/files > Webrev: https://webrevs.openjdk.java.net/skara/157/webrev.00 > Stats: 14 lines in 2 files changed: 7 ins; 6 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/157.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/157/head:pull/157 Looks good to me. ---------------- Approved by kcr (none). PR: https://git.openjdk.java.net/skara/pull/157 From ehelin at openjdk.org Tue Sep 24 09:07:37 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 24 Sep 2019 09:07:37 GMT Subject: [Approved] RFR: Improve stripping of code blocks In-Reply-To: References: Message-ID: On Mon, 23 Sep 2019 06:26:42 GMT, Robin Westberg wrote: > Hi all, > > Please review this small fix that makes the stripping of code block formatting more robust. > > Best regards, > Robin > > ---------------- > > Commits: > - d17fe52e: Improve stripping of code blocks > > Changes: https://git.openjdk.java.net/skara/pull/155/files > Webrev: https://webrevs.openjdk.java.net/skara/155/webrev.00 > Stats: 10 lines in 2 files changed: 7 ins; 0 del; 3 mod > Patch: https://git.openjdk.java.net/skara/pull/155.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/155/head:pull/155 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/155 From ehelin at openjdk.org Tue Sep 24 09:09:08 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 24 Sep 2019 09:09:08 GMT Subject: [Approved] RFR: Future-proof mbox test In-Reply-To: References: Message-ID: On Mon, 23 Sep 2019 08:45:33 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor test case fix that fixes a time related failure. > > Best regards, > Robin > > ---------------- > > Commits: > - 193caa0a: Future-proof mbox test > > Changes: https://git.openjdk.java.net/skara/pull/156/files > Webrev: https://webrevs.openjdk.java.net/skara/156/webrev.00 > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/156.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/156/head:pull/156 That seems like a long enough timespan, hopefully the next generations will appreciate this code! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/156 From ehelin at openjdk.org Tue Sep 24 09:10:57 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 24 Sep 2019 09:10:57 GMT Subject: [Approved] RFR: 102: Setting summary does not update the preview message In-Reply-To: References: Message-ID: On Mon, 23 Sep 2019 08:46:43 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that the commit preview message is updated when a summary is added or updated. > > Best regards, > Robin > > ---------------- > > Commits: > - 58758066: Editing a summary should update the preview message > > Changes: https://git.openjdk.java.net/skara/pull/157/files > Webrev: https://webrevs.openjdk.java.net/skara/157/webrev.00 > Stats: 14 lines in 2 files changed: 7 ins; 6 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/157.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/157/head:pull/157 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/157 From duke at openjdk.java.net Tue Sep 24 09:15:41 2019 From: duke at openjdk.java.net (duke) Date: Tue, 24 Sep 2019 09:15:41 GMT Subject: [Integrated] RFR: Improve stripping of code blocks In-Reply-To: References: Message-ID: <99bfa725-29ab-40ba-90f3-b25e0d783df7@openjdk.java.net> Changeset: 5d474ee4 Author: Robin Westberg Date: 2019-09-24 09:15:31 +0000 URL: https://git.openjdk.java.net/skara/commit/5d474ee4 Improve stripping of code blocks Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MarkdownToText.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MarkdownToTextTests.java From ehelin at openjdk.org Tue Sep 24 09:16:59 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 24 Sep 2019 09:16:59 GMT Subject: [Approved] RFR: Add support for adding extra headers to mails sent to mailing lists In-Reply-To: References: Message-ID: <312R8KvhtPLo1u4iz8SjNyCQ9mtU8DmDquS7x-a0imE=.b1023e44-9271-4251-b8ab-3ccf188c548c@github.com> On Mon, 23 Sep 2019 08:47:35 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows adding extra headers to mails that are sent to mailing lists. This can be used to add authentication headers. > > Best regards, > Robin > > ---------------- > > Commits: > - 7fcd00bc: Add support for adding extra headers to mails sent to mailing lists > > Changes: https://git.openjdk.java.net/skara/pull/158/files > Webrev: https://webrevs.openjdk.java.net/skara/158/webrev.00 > Stats: 32 lines in 5 files changed: 16 ins; 0 del; 16 mod > Patch: https://git.openjdk.java.net/skara/pull/158.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/158/head:pull/158 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/158 From jvernee at openjdk.org Tue Sep 24 09:38:49 2019 From: jvernee at openjdk.org (Jorn Vernee) Date: Tue, 24 Sep 2019 09:38:49 GMT Subject: RFR: Add git-sync command In-Reply-To: References: Message-ID: <66izKN7XdKYxrasmhVmJshF_h48hh2zCSh5_v-OkXMU=.a7e4eae2-4864-4c55-aebc-5f66b6d42346@github.com> On Tue, 24 Sep 2019 09:38:45 GMT, Erik Helin wrote: > Hi all, > > this commits adds the new `git sync` command which is useful for syncing a personal fork with its upstream repository. `git sync` supports both a remote and URL as a argument, for example: > > $ git sync upstream > Syncing upstream/master with origin/master... done > > $ git sync https://github.com/openjdk/skara > Syncing https://github.com/openjdk/skara/master with origin/master... done > > The remote can also be configured in `.git/config` (or `~/.gitconfig`) as in: > > [sync] > remote = upstream > > I also added two options, `--pull` and `--fetch`, that will pull and/or fetch the current branch. This is a shorthand for `git sync && git pull`. Since `git fork` sets the `sync.remote` in `.git/config` (local for the repository) a user now only has to write to fork an upstream repository, sync the branches and update their local copy: > > $ git fork https://github.com/openjdk/skara > $ cd skara > $ git sync --pull > > The syncing leaves no trace in the local repository, I'm only using `FETCH_HEAD` in the refspec when pushing to the personal fork. > > ## Testing > - [x] `sh gradlew test` passes on Linux x86_64 > - [x] `sh gradlew reproduce` passes on Linux x86_64 > - [x] Added two new unit tests > - [x] Manual testing of `git sync` > > Thanks, > Erik > > ---------------- > > Commits: > - 62268c27: Set sync configuration with git-fork > - b4add8cc: Add --fetch and --pull options, also allow remote to be configured > - c3692ab8: Add sync to GitSkara as well > - 6d751a06: Add alias for git-sync in skara.gitconfig > - 9a77ebc5: Add git-sync command > > Changes: https://git.openjdk.java.net/skara/pull/153/files > Webrev: https://webrevs.openjdk.java.net/skara/153/webrev.00 > Stats: 508 lines in 14 files changed: 465 ins; 40 del; 3 mod > Patch: https://git.openjdk.java.net/skara/pull/153.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/153/head:pull/153 cli/src/main/java/org/openjdk/skara/cli/GitSync.java line 127: > 126: Remote.toURI(repo.pullPath(upstream)) : URI.create(upstream); > 127: var origin = "origin"; > 128: var originPushPath = Remote.toURI(repo.pushPath(origin)); I think the fork remote name should be a CLI option as well, maybe in the gitconfig as well (e.g. I have named it `fork` for some of my local repos) PR: https://git.openjdk.java.net/skara/pull/153 From ehelin at openjdk.org Tue Sep 24 09:38:45 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 24 Sep 2019 09:38:45 GMT Subject: RFR: Add git-sync command Message-ID: Hi all, this commits adds the new `git sync` command which is useful for syncing a personal fork with its upstream repository. `git sync` supports both a remote and URL as a argument, for example: $ git sync upstream Syncing upstream/master with origin/master... done $ git sync https://github.com/openjdk/skara Syncing https://github.com/openjdk/skara/master with origin/master... done The remote can also be configured in `.git/config` (or `~/.gitconfig`) as in: [sync] remote = upstream I also added two options, `--pull` and `--fetch`, that will pull and/or fetch the current branch. This is a shorthand for `git sync && git pull`. Since `git fork` sets the `sync.remote` in `.git/config` (local for the repository) a user now only has to write to fork an upstream repository, sync the branches and update their local copy: $ git fork https://github.com/openjdk/skara $ cd skara $ git sync --pull The syncing leaves no trace in the local repository, I'm only using `FETCH_HEAD` in the refspec when pushing to the personal fork. ## Testing - [x] `sh gradlew test` passes on Linux x86_64 - [x] `sh gradlew reproduce` passes on Linux x86_64 - [x] Added two new unit tests - [x] Manual testing of `git sync` Thanks, Erik ---------------- Commits: - 62268c27: Set sync configuration with git-fork - b4add8cc: Add --fetch and --pull options, also allow remote to be configured - c3692ab8: Add sync to GitSkara as well - 6d751a06: Add alias for git-sync in skara.gitconfig - 9a77ebc5: Add git-sync command Changes: https://git.openjdk.java.net/skara/pull/153/files Webrev: https://webrevs.openjdk.java.net/skara/153/webrev.00 Stats: 508 lines in 14 files changed: 465 ins; 40 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/153.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/153/head:pull/153 PR: https://git.openjdk.java.net/skara/pull/153 From duke at openjdk.java.net Tue Sep 24 09:43:18 2019 From: duke at openjdk.java.net (duke) Date: Tue, 24 Sep 2019 09:43:18 GMT Subject: [Integrated] RFR: webrev: fix indentation of removed binary file view In-Reply-To: References: Message-ID: <8846d52a-2bfe-4d05-a7b7-37a60c0cd30a@openjdk.java.net> Changeset: 016828d5 Author: Erik Helin Date: 2019-09-24 09:43:07 +0000 URL: https://git.openjdk.java.net/skara/commit/016828d5 webrev: fix indentation of removed binary file view Reviewed-by: rwestberg ! webrev/src/main/java/org/openjdk/skara/webrev/RemovedFileView.java From ehelin at openjdk.org Tue Sep 24 09:46:16 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 24 Sep 2019 09:46:16 GMT Subject: RFR: Add git-sync command In-Reply-To: <66izKN7XdKYxrasmhVmJshF_h48hh2zCSh5_v-OkXMU=.a7e4eae2-4864-4c55-aebc-5f66b6d42346@github.com> References: <66izKN7XdKYxrasmhVmJshF_h48hh2zCSh5_v-OkXMU=.a7e4eae2-4864-4c55-aebc-5f66b6d42346@github.com> Message-ID: <7Q5DRsyr3zLTyTX5zh3oMtYpsarhKKob9gmX4590V2o=.7a0457ce-8dc4-44ba-aa50-cdbb48d5028b@github.com> On Tue, 24 Sep 2019 09:38:49 GMT, Jorn Vernee wrote: > On Tue, 24 Sep 2019 09:38:45 GMT, Erik Helin wrote: > >> Hi all, >> >> this commits adds the new `git sync` command which is useful for syncing a personal fork with its upstream repository. `git sync` supports both a remote and URL as a argument, for example: >> >> $ git sync upstream >> Syncing upstream/master with origin/master... done >> >> $ git sync https://github.com/openjdk/skara >> Syncing https://github.com/openjdk/skara/master with origin/master... done >> >> The remote can also be configured in `.git/config` (or `~/.gitconfig`) as in: >> >> [sync] >> remote = upstream >> >> I also added two options, `--pull` and `--fetch`, that will pull and/or fetch the current branch. This is a shorthand for `git sync && git pull`. Since `git fork` sets the `sync.remote` in `.git/config` (local for the repository) a user now only has to write to fork an upstream repository, sync the branches and update their local copy: >> >> $ git fork https://github.com/openjdk/skara >> $ cd skara >> $ git sync --pull >> >> The syncing leaves no trace in the local repository, I'm only using `FETCH_HEAD` in the refspec when pushing to the personal fork. >> >> ## Testing >> - [x] `sh gradlew test` passes on Linux x86_64 >> - [x] `sh gradlew reproduce` passes on Linux x86_64 >> - [x] Added two new unit tests >> - [x] Manual testing of `git sync` >> >> Thanks, >> Erik >> >> ---------------- >> >> Commits: >> - 62268c27: Set sync configuration with git-fork >> - b4add8cc: Add --fetch and --pull options, also allow remote to be configured >> - c3692ab8: Add sync to GitSkara as well >> - 6d751a06: Add alias for git-sync in skara.gitconfig >> - 9a77ebc5: Add git-sync command >> >> Changes: https://git.openjdk.java.net/skara/pull/153/files >> Webrev: https://webrevs.openjdk.java.net/skara/153/webrev.00 >> Stats: 508 lines in 14 files changed: 465 ins; 40 del; 3 mod >> Patch: https://git.openjdk.java.net/skara/pull/153.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/153/head:pull/153 > > cli/src/main/java/org/openjdk/skara/cli/GitSync.java line 127: > >> 126: Remote.toURI(repo.pullPath(upstream)) : URI.create(upstream); >> 127: var origin = "origin"; >> 128: var originPushPath = Remote.toURI(repo.pushPath(origin)); > > I think the fork remote name should be a CLI option as well, maybe in the gitconfig as well (e.g. I have named it `fork` for some of my local repos) I thought about that, the hard part is what to call the option. I guess my preference would be `--to`, so that a user wishing to sync to another remote types `git sync --to fork upstream`. But then we should probably make the input at position 0 a flag instead, so the command reads `git sync --from upstream --to fork` instead. Without a `--to` flag the command reads `git sync --from upstream` which seems ok to me. Both `sync.form` and `sync.to` should be configurable in gitconfig of course. What do you think? PR: https://git.openjdk.java.net/skara/pull/153 From rwestberg at openjdk.org Tue Sep 24 09:52:06 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 24 Sep 2019 09:52:06 GMT Subject: RFR: Add git-sync command In-Reply-To: References: Message-ID: On Tue, 24 Sep 2019 09:38:45 GMT, Erik Helin wrote: > Hi all, > > this commits adds the new `git sync` command which is useful for syncing a personal fork with its upstream repository. `git sync` supports both a remote and URL as a argument, for example: > > $ git sync upstream > Syncing upstream/master with origin/master... done > > $ git sync https://github.com/openjdk/skara > Syncing https://github.com/openjdk/skara/master with origin/master... done > > The remote can also be configured in `.git/config` (or `~/.gitconfig`) as in: > > [sync] > remote = upstream > > I also added two options, `--pull` and `--fetch`, that will pull and/or fetch the current branch. This is a shorthand for `git sync && git pull`. Since `git fork` sets the `sync.remote` in `.git/config` (local for the repository) a user now only has to write to fork an upstream repository, sync the branches and update their local copy: > > $ git fork https://github.com/openjdk/skara > $ cd skara > $ git sync --pull > > The syncing leaves no trace in the local repository, I'm only using `FETCH_HEAD` in the refspec when pushing to the personal fork. > > ## Testing > - [x] `sh gradlew test` passes on Linux x86_64 > - [x] `sh gradlew reproduce` passes on Linux x86_64 > - [x] Added two new unit tests > - [x] Manual testing of `git sync` > > Thanks, > Erik > > ---------------- > > Commits: > - 62268c27: Set sync configuration with git-fork > - b4add8cc: Add --fetch and --pull options, also allow remote to be configured > - c3692ab8: Add sync to GitSkara as well > - 6d751a06: Add alias for git-sync in skara.gitconfig > - 9a77ebc5: Add git-sync command > > Changes: https://git.openjdk.java.net/skara/pull/153/files > Webrev: https://webrevs.openjdk.java.net/skara/153/webrev.00 > Stats: 508 lines in 14 files changed: 465 ins; 40 del; 3 mod > Patch: https://git.openjdk.java.net/skara/pull/153.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/153/head:pull/153 cli/src/main/java/org/openjdk/skara/cli/GitSync.java line 144: > 143: } > 144: System.out.print("Syncing " + upstream + "/" + name + " to " + origin + "/" + name + "... "); > 145: var fetchHead = repo.fetch(upstreamPullPath, branch.hash().hex()); Do you need to flush the PrintStream here? PR: https://git.openjdk.java.net/skara/pull/153 From rwestberg at openjdk.org Tue Sep 24 09:52:04 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 24 Sep 2019 09:52:04 GMT Subject: [Approved] RFR: Add git-sync command In-Reply-To: References: Message-ID: <9PRBApZfC_Vw7dluuZ7XiiKvWm8szSfHj937koBQVgY=.1bccd2c4-64ac-43a3-9992-6d9c918a5d7c@github.com> On Tue, 24 Sep 2019 09:38:45 GMT, Erik Helin wrote: > Hi all, > > this commits adds the new `git sync` command which is useful for syncing a personal fork with its upstream repository. `git sync` supports both a remote and URL as a argument, for example: > > $ git sync upstream > Syncing upstream/master with origin/master... done > > $ git sync https://github.com/openjdk/skara > Syncing https://github.com/openjdk/skara/master with origin/master... done > > The remote can also be configured in `.git/config` (or `~/.gitconfig`) as in: > > [sync] > remote = upstream > > I also added two options, `--pull` and `--fetch`, that will pull and/or fetch the current branch. This is a shorthand for `git sync && git pull`. Since `git fork` sets the `sync.remote` in `.git/config` (local for the repository) a user now only has to write to fork an upstream repository, sync the branches and update their local copy: > > $ git fork https://github.com/openjdk/skara > $ cd skara > $ git sync --pull > > The syncing leaves no trace in the local repository, I'm only using `FETCH_HEAD` in the refspec when pushing to the personal fork. > > ## Testing > - [x] `sh gradlew test` passes on Linux x86_64 > - [x] `sh gradlew reproduce` passes on Linux x86_64 > - [x] Added two new unit tests > - [x] Manual testing of `git sync` > > Thanks, > Erik > > ---------------- > > Commits: > - 62268c27: Set sync configuration with git-fork > - b4add8cc: Add --fetch and --pull options, also allow remote to be configured > - c3692ab8: Add sync to GitSkara as well > - 6d751a06: Add alias for git-sync in skara.gitconfig > - 9a77ebc5: Add git-sync command > > Changes: https://git.openjdk.java.net/skara/pull/153/files > Webrev: https://webrevs.openjdk.java.net/skara/153/webrev.00 > Stats: 508 lines in 14 files changed: 465 ins; 40 del; 3 mod > Patch: https://git.openjdk.java.net/skara/pull/153.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/153/head:pull/153 Looks good to me! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/153 From duke at openjdk.java.net Tue Sep 24 10:00:17 2019 From: duke at openjdk.java.net (duke) Date: Tue, 24 Sep 2019 10:00:17 GMT Subject: [Integrated] RFR: Future-proof mbox test In-Reply-To: References: Message-ID: <313fda79-c35b-494e-b921-37abbaeaf40b@openjdk.java.net> Changeset: 2ab7e261 Author: Robin Westberg Date: 2019-09-24 10:00:05 +0000 URL: https://git.openjdk.java.net/skara/commit/2ab7e261 Future-proof mbox test Reviewed-by: ehelin ! mailinglist/src/test/java/org/openjdk/skara/mailinglist/MboxTests.java From ehelin at openjdk.org Tue Sep 24 10:07:32 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 24 Sep 2019 10:07:32 GMT Subject: RFR: Add "binary" jcheck check Message-ID: Hi all, this patch adds a new jcheck check called "binary" that checks for binary files. ## Testing - `sh gradlew test` passes on Linux x86_64 - Added two new unit tests Thanks, Erik ---------------- Commits: - 8880a50f: Add "binary" jcheck check Changes: https://git.openjdk.java.net/skara/pull/159/files Webrev: https://webrevs.openjdk.java.net/skara/159/webrev.00 Stats: 228 lines in 7 files changed: 228 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/159.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/159/head:pull/159 PR: https://git.openjdk.java.net/skara/pull/159 From rwestberg at openjdk.org Tue Sep 24 10:15:14 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 24 Sep 2019 10:15:14 GMT Subject: [Rev 01] RFR: Add support for adding extra headers to mails sent to mailing lists In-Reply-To: References: Message-ID: The pull request has been updated with a complete new set of changes (possibly due to a rebase). ---------------- Commits: - a38ab5c9: Fix merge conflicts - 71ace6ff: Merge remote-tracking branch 'upstream/master' into extra_headers - 40851f43: Merge remote-tracking branch 'upstream/master' into extra_headers - 7fcd00bc: Add support for adding extra headers to mails sent to mailing lists Changes: https://git.openjdk.java.net/skara/pull/158/files Webrev: https://webrevs.openjdk.java.net/skara/158/webrev.01 Stats: 44 lines in 5 files changed: 28 ins; 0 del; 16 mod Patch: https://git.openjdk.java.net/skara/pull/158.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/158/head:pull/158 PR: https://git.openjdk.java.net/skara/pull/158 From ehelin at openjdk.org Tue Sep 24 10:24:14 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 24 Sep 2019 10:24:14 GMT Subject: RFR: Add git-sync command In-Reply-To: References: Message-ID: On Tue, 24 Sep 2019 09:52:06 GMT, Robin Westberg wrote: > On Tue, 24 Sep 2019 09:38:45 GMT, Erik Helin wrote: > >> Hi all, >> >> this commits adds the new `git sync` command which is useful for syncing a personal fork with its upstream repository. `git sync` supports both a remote and URL as a argument, for example: >> >> $ git sync upstream >> Syncing upstream/master with origin/master... done >> >> $ git sync https://github.com/openjdk/skara >> Syncing https://github.com/openjdk/skara/master with origin/master... done >> >> The remote can also be configured in `.git/config` (or `~/.gitconfig`) as in: >> >> [sync] >> remote = upstream >> >> I also added two options, `--pull` and `--fetch`, that will pull and/or fetch the current branch. This is a shorthand for `git sync && git pull`. Since `git fork` sets the `sync.remote` in `.git/config` (local for the repository) a user now only has to write to fork an upstream repository, sync the branches and update their local copy: >> >> $ git fork https://github.com/openjdk/skara >> $ cd skara >> $ git sync --pull >> >> The syncing leaves no trace in the local repository, I'm only using `FETCH_HEAD` in the refspec when pushing to the personal fork. >> >> ## Testing >> - [x] `sh gradlew test` passes on Linux x86_64 >> - [x] `sh gradlew reproduce` passes on Linux x86_64 >> - [x] Added two new unit tests >> - [x] Manual testing of `git sync` >> >> Thanks, >> Erik >> >> ---------------- >> >> Commits: >> - 62268c27: Set sync configuration with git-fork >> - b4add8cc: Add --fetch and --pull options, also allow remote to be configured >> - c3692ab8: Add sync to GitSkara as well >> - 6d751a06: Add alias for git-sync in skara.gitconfig >> - 9a77ebc5: Add git-sync command >> >> Changes: https://git.openjdk.java.net/skara/pull/153/files >> Webrev: https://webrevs.openjdk.java.net/skara/153/webrev.00 >> Stats: 508 lines in 14 files changed: 465 ins; 40 del; 3 mod >> Patch: https://git.openjdk.java.net/skara/pull/153.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/153/head:pull/153 > > cli/src/main/java/org/openjdk/skara/cli/GitSync.java line 144: > >> 143: } >> 144: System.out.print("Syncing " + upstream + "/" + name + " to " + origin + "/" + name + "... "); >> 145: var fetchHead = repo.fetch(upstreamPullPath, branch.hash().hex()); > > Do you need to flush the PrintStream here? Probably, good idea, let me fix! PR: https://git.openjdk.java.net/skara/pull/153 From rwestberg at openjdk.org Tue Sep 24 10:27:34 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 24 Sep 2019 10:27:34 GMT Subject: [Approved] RFR: Add "binary" jcheck check In-Reply-To: References: Message-ID: On Tue, 24 Sep 2019 10:07:32 GMT, Erik Helin wrote: > Hi all, > > this patch adds a new jcheck check called "binary" that checks for binary files. > > ## Testing > - `sh gradlew test` passes on Linux x86_64 > - Added two new unit tests > > Thanks, > Erik > > ---------------- > > Commits: > - 8880a50f: Add "binary" jcheck check > > Changes: https://git.openjdk.java.net/skara/pull/159/files > Webrev: https://webrevs.openjdk.java.net/skara/159/webrev.00 > Stats: 228 lines in 7 files changed: 228 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/159.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/159/head:pull/159 Looks good! ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/159 From rwestberg at openjdk.org Tue Sep 24 10:27:35 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 24 Sep 2019 10:27:35 GMT Subject: RFR: Add "binary" jcheck check In-Reply-To: References: Message-ID: On Tue, 24 Sep 2019 10:07:32 GMT, Erik Helin wrote: > Hi all, > > this patch adds a new jcheck check called "binary" that checks for binary files. > > ## Testing > - `sh gradlew test` passes on Linux x86_64 > - Added two new unit tests > > Thanks, > Erik > > ---------------- > > Commits: > - 8880a50f: Add "binary" jcheck check > > Changes: https://git.openjdk.java.net/skara/pull/159/files > Webrev: https://webrevs.openjdk.java.net/skara/159/webrev.00 > Stats: 228 lines in 7 files changed: 228 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/skara/pull/159.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/159/head:pull/159 bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 213: > 212: public void visit(BinaryIssue issue) { > 213: log.fine("ignored: binary file"); > 214: } Should we do something more here? Perhaps something for a follow up.. PR: https://git.openjdk.java.net/skara/pull/159 From duke at openjdk.java.net Tue Sep 24 10:28:27 2019 From: duke at openjdk.java.net (duke) Date: Tue, 24 Sep 2019 10:28:27 GMT Subject: [Integrated] RFR: Add support for adding extra headers to mails sent to mailing lists In-Reply-To: References: Message-ID: <62e97cce-7071-45d9-b1d1-cff0837ef3a1@openjdk.java.net> Changeset: 15376a9a Author: Robin Westberg Date: 2019-09-24 10:28:10 +0000 URL: https://git.openjdk.java.net/skara/commit/15376a9a Add support for adding extra headers to mails sent to mailing lists Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBotTests.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From ehelin at openjdk.org Tue Sep 24 10:30:24 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 24 Sep 2019 10:30:24 GMT Subject: RFR: Add "binary" jcheck check In-Reply-To: References: Message-ID: On Tue, 24 Sep 2019 10:27:35 GMT, Robin Westberg wrote: > On Tue, 24 Sep 2019 10:07:32 GMT, Erik Helin wrote: > >> Hi all, >> >> this patch adds a new jcheck check called "binary" that checks for binary files. >> >> ## Testing >> - `sh gradlew test` passes on Linux x86_64 >> - Added two new unit tests >> >> Thanks, >> Erik >> >> ---------------- >> >> Commits: >> - 8880a50f: Add "binary" jcheck check >> >> Changes: https://git.openjdk.java.net/skara/pull/159/files >> Webrev: https://webrevs.openjdk.java.net/skara/159/webrev.00 >> Stats: 228 lines in 7 files changed: 228 ins; 0 del; 0 mod >> Patch: https://git.openjdk.java.net/skara/pull/159.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/159/head:pull/159 > > bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 213: > >> 212: public void visit(BinaryIssue issue) { >> 213: log.fine("ignored: binary file"); >> 214: } > > Should we do something more here? Perhaps something for a follow up.. My plan was to leave that to you ???? PR: https://git.openjdk.java.net/skara/pull/159 From duke at openjdk.java.net Tue Sep 24 10:30:57 2019 From: duke at openjdk.java.net (duke) Date: Tue, 24 Sep 2019 10:30:57 GMT Subject: [Integrated] RFR: Add "binary" jcheck check In-Reply-To: References: Message-ID: <1a6caecd-850d-459a-901f-4edb24cb265b@openjdk.java.net> Changeset: 7bdfab49 Author: Erik Helin Date: 2019-09-24 10:30:47 +0000 URL: https://git.openjdk.java.net/skara/commit/7bdfab49 Add "binary" jcheck check Reviewed-by: rwestberg ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java ! cli/src/main/java/org/openjdk/skara/cli/JCheckCLIVisitor.java + jcheck/src/main/java/org/openjdk/skara/jcheck/BinaryCheck.java + jcheck/src/main/java/org/openjdk/skara/jcheck/BinaryIssue.java ! jcheck/src/main/java/org/openjdk/skara/jcheck/IssueVisitor.java + jcheck/src/test/java/org/openjdk/skara/jcheck/BinaryCheckTests.java ! jcheck/src/test/java/org/openjdk/skara/jcheck/JCheckTests.java From rwestberg at openjdk.org Tue Sep 24 10:32:34 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 24 Sep 2019 10:32:34 GMT Subject: RFR: 102: Setting summary does not update the preview message In-Reply-To: References: Message-ID: On Mon, 23 Sep 2019 13:08:28 GMT, Kevin Rushforth wrote: > On Mon, 23 Sep 2019 08:46:43 GMT, Robin Westberg wrote: > >> Hi all, >> >> Please review this change that ensures that the commit preview message is updated when a summary is added or updated. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - 58758066: Editing a summary should update the preview message >> >> Changes: https://git.openjdk.java.net/skara/pull/157/files >> Webrev: https://webrevs.openjdk.java.net/skara/157/webrev.00 >> Stats: 14 lines in 2 files changed: 7 ins; 6 del; 1 mod >> Patch: https://git.openjdk.java.net/skara/pull/157.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/157/head:pull/157 > > Looks good to me. > > ---------------- > > Approved by kcr (none). Thanks for the reviews! PR: https://git.openjdk.java.net/skara/pull/157 From duke at openjdk.java.net Tue Sep 24 10:32:56 2019 From: duke at openjdk.java.net (duke) Date: Tue, 24 Sep 2019 10:32:56 GMT Subject: [Integrated] RFR: 102: Setting summary does not update the preview message In-Reply-To: References: Message-ID: <129dca86-8404-42b2-9eba-929ed9ac4361@openjdk.java.net> Changeset: 13c43083 Author: Robin Westberg Date: 2019-09-24 10:32:48 +0000 URL: https://git.openjdk.java.net/skara/commit/13c43083 102: Setting summary does not update the preview message Reviewed-by: kcr, ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SummaryTests.java From ehelin at openjdk.org Tue Sep 24 10:37:56 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 24 Sep 2019 10:37:56 GMT Subject: [Rev 01] RFR: Add git-sync command In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - a6219094: Flush System.out after printing sync message - da8403ff: Use --from and --to flags to specify remotes Changes: - all: https://git.openjdk.java.net/skara/pull/153/files - new: https://git.openjdk.java.net/skara/pull/153/files/62268c27..a6219094 Webrevs: - full: https://webrevs.openjdk.java.net/skara/153/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/153/webrev.00-01 Stats: 40 lines in 1 file changed: 26 ins; 8 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/153.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/153/head:pull/153 PR: https://git.openjdk.java.net/skara/pull/153 From jvernee at openjdk.org Tue Sep 24 12:04:00 2019 From: jvernee at openjdk.org (Jorn Vernee) Date: Tue, 24 Sep 2019 12:04:00 GMT Subject: RFR: Add git-sync command In-Reply-To: <7Q5DRsyr3zLTyTX5zh3oMtYpsarhKKob9gmX4590V2o=.7a0457ce-8dc4-44ba-aa50-cdbb48d5028b@github.com> References: <66izKN7XdKYxrasmhVmJshF_h48hh2zCSh5_v-OkXMU=.a7e4eae2-4864-4c55-aebc-5f66b6d42346@github.com> <7Q5DRsyr3zLTyTX5zh3oMtYpsarhKKob9gmX4590V2o=.7a0457ce-8dc4-44ba-aa50-cdbb48d5028b@github.com> Message-ID: On Tue, 24 Sep 2019 09:46:16 GMT, Erik Helin wrote: > On Tue, 24 Sep 2019 09:38:49 GMT, Jorn Vernee wrote: > >> On Tue, 24 Sep 2019 09:38:45 GMT, Erik Helin wrote: >> >>> Hi all, >>> >>> this commits adds the new `git sync` command which is useful for syncing a personal fork with its upstream repository. `git sync` supports both a remote and URL as a argument, for example: >>> >>> $ git sync upstream >>> Syncing upstream/master with origin/master... done >>> >>> $ git sync https://github.com/openjdk/skara >>> Syncing https://github.com/openjdk/skara/master with origin/master... done >>> >>> The remote can also be configured in `.git/config` (or `~/.gitconfig`) as in: >>> >>> [sync] >>> remote = upstream >>> >>> I also added two options, `--pull` and `--fetch`, that will pull and/or fetch the current branch. This is a shorthand for `git sync && git pull`. Since `git fork` sets the `sync.remote` in `.git/config` (local for the repository) a user now only has to write to fork an upstream repository, sync the branches and update their local copy: >>> >>> $ git fork https://github.com/openjdk/skara >>> $ cd skara >>> $ git sync --pull >>> >>> The syncing leaves no trace in the local repository, I'm only using `FETCH_HEAD` in the refspec when pushing to the personal fork. >>> >>> ## Testing >>> - [x] `sh gradlew test` passes on Linux x86_64 >>> - [x] `sh gradlew reproduce` passes on Linux x86_64 >>> - [x] Added two new unit tests >>> - [x] Manual testing of `git sync` >>> >>> Thanks, >>> Erik >>> >>> ---------------- >>> >>> Commits: >>> - 62268c27: Set sync configuration with git-fork >>> - b4add8cc: Add --fetch and --pull options, also allow remote to be configured >>> - c3692ab8: Add sync to GitSkara as well >>> - 6d751a06: Add alias for git-sync in skara.gitconfig >>> - 9a77ebc5: Add git-sync command >>> >>> Changes: https://git.openjdk.java.net/skara/pull/153/files >>> Webrev: https://webrevs.openjdk.java.net/skara/153/webrev.00 >>> Stats: 508 lines in 14 files changed: 465 ins; 40 del; 3 mod >>> Patch: https://git.openjdk.java.net/skara/pull/153.diff >>> Fetch: git fetch https://git.openjdk.java.net/skara pull/153/head:pull/153 >> >> cli/src/main/java/org/openjdk/skara/cli/GitSync.java line 127: >> >>> 126: Remote.toURI(repo.pullPath(upstream)) : URI.create(upstream); >>> 127: var origin = "origin"; >>> 128: var originPushPath = Remote.toURI(repo.pushPath(origin)); >> >> I think the fork remote name should be a CLI option as well, maybe in the gitconfig as well (e.g. I have named it `fork` for some of my local repos) > > I thought about that, the hard part is what to call the option. I guess my preference would be `--to`, so that a user wishing to sync to another remote types `git sync --to fork upstream`. But then we should probably make the input at position 0 a flag instead, so the command reads `git sync --from upstream --to fork` instead. Without a `--to` flag the command reads `git sync --from upstream` which seems ok to me. Both `sync.form` and `sync.to` should be configurable in gitconfig of course. What do you think? Sounds good! PR: https://git.openjdk.java.net/skara/pull/153 From jvernee at openjdk.org Tue Sep 24 12:04:10 2019 From: jvernee at openjdk.org (Jorn Vernee) Date: Tue, 24 Sep 2019 12:04:10 GMT Subject: [Rev 01] RFR: Add git-sync command In-Reply-To: References: Message-ID: On Tue, 24 Sep 2019 10:37:56 GMT, Erik Helin wrote: > The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - a6219094: Flush System.out after printing sync message > - da8403ff: Use --from and --to flags to specify remotes > > Changes: > - all: https://git.openjdk.java.net/skara/pull/153/files > - new: https://git.openjdk.java.net/skara/pull/153/files/62268c27..a6219094 > > Webrevs: > - full: https://webrevs.openjdk.java.net/skara/153/webrev.01 > - incr: https://webrevs.openjdk.java.net/skara/153/webrev.00-01 > > Stats: 40 lines in 1 file changed: 26 ins; 8 del; 6 mod > Patch: https://git.openjdk.java.net/skara/pull/153.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/153/head:pull/153 Approved by jvernee (Committer). PR: https://git.openjdk.java.net/skara/pull/153 From duke at openjdk.java.net Tue Sep 24 12:13:31 2019 From: duke at openjdk.java.net (duke) Date: Tue, 24 Sep 2019 12:13:31 GMT Subject: [Integrated] RFR: Add git-sync command In-Reply-To: References: Message-ID: Changeset: 6ba889e2 Author: Erik Helin Date: 2019-09-24 12:13:22 +0000 URL: https://git.openjdk.java.net/skara/commit/6ba889e2 Add git-sync command Reviewed-by: rwestberg, jvernee ! cli/build.gradle ! cli/src/main/java/org/openjdk/skara/cli/GitFork.java ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java ! cli/src/main/java/org/openjdk/skara/cli/GitSkara.java + cli/src/main/java/org/openjdk/skara/cli/GitSync.java + cli/src/main/java/org/openjdk/skara/cli/Remote.java ! jcheck/src/test/java/org/openjdk/skara/jcheck/TestRepository.java ! skara.gitconfig ! vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java + vcs/src/main/java/org/openjdk/skara/vcs/Reference.java ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java ! vcs/src/main/resources/ext.py ! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java From ehelin at openjdk.org Tue Sep 24 12:43:49 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 24 Sep 2019 12:43:49 GMT Subject: RFR: Make build incremental Message-ID: <5xh-fngCTcwRNiJxmcaqBVV1vCv9lY7qF8A-EgAX8Fk=.b67eb298-5825-4972-8c0e-f3f46937409d@github.com> Hi all, this larger patch adds proper `@Input` and `@OutputDirectory` annotations to our Gradle plugins. The result is that the build is fully incremental ????. ## Testing - `sh gradlew images` works - `sh gradlew test` passes on Linux x86_64 - Manual testing of CLI binaries Thanks, Erik ---------------- Commits: - e34a72cc: Make build incremental Changes: https://git.openjdk.java.net/skara/pull/160/files Webrev: https://webrevs.openjdk.java.net/skara/160/webrev.00 Stats: 209 lines in 6 files changed: 68 ins; 18 del; 123 mod Patch: https://git.openjdk.java.net/skara/pull/160.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/160/head:pull/160 PR: https://git.openjdk.java.net/skara/pull/160 From rwestberg at openjdk.org Tue Sep 24 13:19:37 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Tue, 24 Sep 2019 13:19:37 GMT Subject: [Approved] RFR: Make build incremental In-Reply-To: <5xh-fngCTcwRNiJxmcaqBVV1vCv9lY7qF8A-EgAX8Fk=.b67eb298-5825-4972-8c0e-f3f46937409d@github.com> References: <5xh-fngCTcwRNiJxmcaqBVV1vCv9lY7qF8A-EgAX8Fk=.b67eb298-5825-4972-8c0e-f3f46937409d@github.com> Message-ID: <0gkkbkVhW_QmqARRvYbOyT6V_fBVaK-P7mUCiY4XvK8=.91d80a83-1092-4d5e-8217-d8420ddedd7b@github.com> On Tue, 24 Sep 2019 12:43:49 GMT, Erik Helin wrote: > Hi all, > > this larger patch adds proper `@Input` and `@OutputDirectory` annotations to our Gradle plugins. The result is that the build is fully incremental ????. > > ## Testing > - `sh gradlew images` works > - `sh gradlew test` passes on Linux x86_64 > - Manual testing of CLI binaries > > Thanks, > Erik > > ---------------- > > Commits: > - e34a72cc: Make build incremental > > Changes: https://git.openjdk.java.net/skara/pull/160/files > Webrev: https://webrevs.openjdk.java.net/skara/160/webrev.00 > Stats: 209 lines in 6 files changed: 68 ins; 18 del; 123 mod > Patch: https://git.openjdk.java.net/skara/pull/160.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/160/head:pull/160 Looks good! Note: IntelliJ users may need to ensure that they are using gradle 5.6.x, since ImagesPlugin.java uses a new API. ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/160 From duke at openjdk.java.net Tue Sep 24 14:08:41 2019 From: duke at openjdk.java.net (duke) Date: Tue, 24 Sep 2019 14:08:41 GMT Subject: [Integrated] RFR: Make build incremental In-Reply-To: <5xh-fngCTcwRNiJxmcaqBVV1vCv9lY7qF8A-EgAX8Fk=.b67eb298-5825-4972-8c0e-f3f46937409d@github.com> References: <5xh-fngCTcwRNiJxmcaqBVV1vCv9lY7qF8A-EgAX8Fk=.b67eb298-5825-4972-8c0e-f3f46937409d@github.com> Message-ID: <00b84305-4469-4993-ac28-e63e6ad4b37c@openjdk.java.net> Changeset: 65f57288 Author: Erik Helin Date: 2019-09-24 14:08:32 +0000 URL: https://git.openjdk.java.net/skara/commit/65f57288 Make build incremental Reviewed-by: rwestberg ! build.gradle ! buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/DownloadJDKTask.java ! buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/ImagesPlugin.java ! buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/LaunchersTask.java ! buildSrc/images/src/main/java/org/openjdk/skara/gradle/images/LinkTask.java ! buildSrc/module/src/main/java/org/openjdk/skara/gradle/module/ModulePlugin.java From ehelin at openjdk.org Tue Sep 24 14:08:27 2019 From: ehelin at openjdk.org (Erik Helin) Date: Tue, 24 Sep 2019 14:08:27 GMT Subject: RFR: Make build incremental In-Reply-To: <5xh-fngCTcwRNiJxmcaqBVV1vCv9lY7qF8A-EgAX8Fk=.b67eb298-5825-4972-8c0e-f3f46937409d@github.com> References: <5xh-fngCTcwRNiJxmcaqBVV1vCv9lY7qF8A-EgAX8Fk=.b67eb298-5825-4972-8c0e-f3f46937409d@github.com> Message-ID: On Tue, 24 Sep 2019 12:43:49 GMT, Erik Helin wrote: > Hi all, > > this larger patch adds proper `@Input` and `@OutputDirectory` annotations to our Gradle plugins. The result is that the build is fully incremental ????. > > ## Testing > - `sh gradlew images` works > - `sh gradlew test` passes on Linux x86_64 > - Manual testing of CLI binaries > > Thanks, > Erik > > ---------------- > > Commits: > - e34a72cc: Make build incremental > > Changes: https://git.openjdk.java.net/skara/pull/160/files > Webrev: https://webrevs.openjdk.java.net/skara/160/webrev.00 > Stats: 209 lines in 6 files changed: 68 ins; 18 del; 123 mod > Patch: https://git.openjdk.java.net/skara/pull/160.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/160/head:pull/160 @JornVernee confirmed that this PR builds on Windows PR: https://git.openjdk.java.net/skara/pull/160 From rwestberg at openjdk.org Wed Sep 25 06:41:29 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 25 Sep 2019 06:41:29 GMT Subject: RFR: Proper mime encoding of high ascii strings Message-ID: Hi all, Please review this change that ensures that all high ascii strings that are sent in emails are properly mime encoded. Before, this was only done when writing mbox archives. Best regards, Robin ---------------- Commits: - 4b22dda4: Proper mime encoding of high ascii strings Changes: https://git.openjdk.java.net/skara/pull/161/files Webrev: https://webrevs.openjdk.java.net/skara/161/webrev.00 Stats: 185 lines in 8 files changed: 153 ins; 14 del; 18 mod Patch: https://git.openjdk.java.net/skara/pull/161.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/161/head:pull/161 PR: https://git.openjdk.java.net/skara/pull/161 From ehelin at openjdk.org Wed Sep 25 08:13:21 2019 From: ehelin at openjdk.org (Erik Helin) Date: Wed, 25 Sep 2019 08:13:21 GMT Subject: [Approved] RFR: Proper mime encoding of high ascii strings In-Reply-To: References: Message-ID: On Wed, 25 Sep 2019 06:41:29 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that all high ascii strings that are sent in emails are properly mime encoded. Before, this was only done when writing mbox archives. > > Best regards, > Robin > > ---------------- > > Commits: > - 4b22dda4: Proper mime encoding of high ascii strings > > Changes: https://git.openjdk.java.net/skara/pull/161/files > Webrev: https://webrevs.openjdk.java.net/skara/161/webrev.00 > Stats: 185 lines in 8 files changed: 153 ins; 14 del; 18 mod > Patch: https://git.openjdk.java.net/skara/pull/161.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/161/head:pull/161 Wow, nice work! Looks good, thanks for fixing! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/161 From duke at openjdk.java.net Wed Sep 25 08:15:41 2019 From: duke at openjdk.java.net (duke) Date: Wed, 25 Sep 2019 08:15:41 GMT Subject: [Integrated] RFR: Proper mime encoding of high ascii strings In-Reply-To: References: Message-ID: <8eda1fd0-ea47-4569-96cb-204b78dd859d@openjdk.java.net> Changeset: 76d0158a Author: Robin Westberg Date: 2019-09-25 08:15:32 +0000 URL: https://git.openjdk.java.net/skara/commit/76d0158a Proper mime encoding of high ascii strings Reviewed-by: ehelin ! email/src/main/java/org/openjdk/skara/email/Email.java + email/src/main/java/org/openjdk/skara/email/MimeText.java ! email/src/main/java/org/openjdk/skara/email/SMTP.java ! email/src/test/java/org/openjdk/skara/email/EmailTests.java + email/src/test/java/org/openjdk/skara/email/MimeTextTests.java ! email/src/test/java/org/openjdk/skara/email/SMTPTests.java ! mailinglist/src/main/java/org/openjdk/skara/mailinglist/Mbox.java ! test/src/main/java/org/openjdk/skara/test/SMTPServer.java From rwestberg at openjdk.org Wed Sep 25 13:14:38 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Wed, 25 Sep 2019 13:14:38 GMT Subject: RFR: Issue tracker support Message-ID: Hi all, Please review this change that introduces issue support. An Issue contains a subset of PullRequest functionality, similar to how this is modeled in GitHub and GitLab. It also allows creating support for other issue trackers that do not have repository support, such as Jira. Best regards, Robin ---------------- Commits: - 7b0e6107: Implement test version of Issue and IssueProject - b603a667: GitHub and GitLab does not yet implement Issues - d1886dcc: Extract IssueProject and Issue from HostedRepository and PullRequest Changes: https://git.openjdk.java.net/skara/pull/162/files Webrev: https://webrevs.openjdk.java.net/skara/162/webrev.00 Stats: 854 lines in 20 files changed: 608 ins; 240 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/162.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/162/head:pull/162 PR: https://git.openjdk.java.net/skara/pull/162 From kcr at openjdk.org Wed Sep 25 13:50:50 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Wed, 25 Sep 2019 13:50:50 GMT Subject: RFR: 80: Allow valid bug ID format to be configurable Message-ID: JBS issue: https://bugs.openjdk.java.net/browse/SKARA-80 This provides a configuration option to define the pattern for a valid issue ID as follows. This starts with the idea @edvbld mentioned in PR #99, although I felt it was cleaner to leave the default issue format as is, and use the more restrictive pattern for the "legacy" jdk conf file. The syntax of the new pattern is: [checks "issues"] pattern= The default pattern is: [checks "issues"] pattern=^(([A-Z][A-Z0-9]+-)?[0-9]+): (\\S.*)$ For legacy JDK `.jcheck/conf` files, the pattern is as follows to match the issue ID rules in `jcheck.py`: [checks "issues"] pattern=^([124-8][0-9]{6}): (\\S.*)$ ---------------- Commits: - a12ec8ee: 80: Allow valid bug ID format to be configurable Changes: https://git.openjdk.java.net/skara/pull/163/files Webrev: https://webrevs.openjdk.java.net/skara/163/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-80 Stats: 321 lines in 5 files changed: 315 ins; 1 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/163.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/163/head:pull/163 PR: https://git.openjdk.java.net/skara/pull/163 From rwestberg at openjdk.org Thu Sep 26 11:54:09 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 26 Sep 2019 11:54:09 GMT Subject: RFR: 80: Allow valid bug ID format to be configurable In-Reply-To: References: Message-ID: On Wed, 25 Sep 2019 13:50:50 GMT, Kevin Rushforth wrote: > JBS issue: https://bugs.openjdk.java.net/browse/SKARA-80 > > This provides a configuration option to define the pattern for a valid issue ID as follows. This starts with the idea @edvbld mentioned in PR #99, although I felt it was cleaner to leave the default issue format as is, and use the more restrictive pattern for the "legacy" jdk conf file. > > The syntax of the new pattern is: > > [checks "issues"] > pattern= > > The default pattern is: > > [checks "issues"] > pattern=^(([A-Z][A-Z0-9]+-)?[0-9]+): (\\S.*)$ > > For legacy JDK `.jcheck/conf` files, the pattern is as follows to match the issue ID rules in `jcheck.py`: > > [checks "issues"] > pattern=^([124-8][0-9]{6}): (\\S.*)$ > > ---------------- > > Commits: > - a12ec8ee: 80: Allow valid bug ID format to be configurable > > Changes: https://git.openjdk.java.net/skara/pull/163/files > Webrev: https://webrevs.openjdk.java.net/skara/163/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-80 > Stats: 321 lines in 5 files changed: 315 ins; 1 del; 5 mod > Patch: https://git.openjdk.java.net/skara/pull/163.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/163/head:pull/163 jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesCheck.java line 48: > 47: if (commit.message().isEmpty() || message.issues().isEmpty()) { > 48: log.finer("isuse: no reference to a JBS issue"); > 49: return iterator(new IssuesIssue(metadata)); Suggestion: log.finer("issue: no reference to a JBS issue"); PR: https://git.openjdk.java.net/skara/pull/163 From rwestberg at openjdk.org Thu Sep 26 11:54:07 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Thu, 26 Sep 2019 11:54:07 GMT Subject: [Approved] RFR: 80: Allow valid bug ID format to be configurable In-Reply-To: References: Message-ID: On Wed, 25 Sep 2019 13:50:50 GMT, Kevin Rushforth wrote: > JBS issue: https://bugs.openjdk.java.net/browse/SKARA-80 > > This provides a configuration option to define the pattern for a valid issue ID as follows. This starts with the idea @edvbld mentioned in PR #99, although I felt it was cleaner to leave the default issue format as is, and use the more restrictive pattern for the "legacy" jdk conf file. > > The syntax of the new pattern is: > > [checks "issues"] > pattern= > > The default pattern is: > > [checks "issues"] > pattern=^(([A-Z][A-Z0-9]+-)?[0-9]+): (\\S.*)$ > > For legacy JDK `.jcheck/conf` files, the pattern is as follows to match the issue ID rules in `jcheck.py`: > > [checks "issues"] > pattern=^([124-8][0-9]{6}): (\\S.*)$ > > ---------------- > > Commits: > - a12ec8ee: 80: Allow valid bug ID format to be configurable > > Changes: https://git.openjdk.java.net/skara/pull/163/files > Webrev: https://webrevs.openjdk.java.net/skara/163/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-80 > Stats: 321 lines in 5 files changed: 315 ins; 1 del; 5 mod > Patch: https://git.openjdk.java.net/skara/pull/163.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/163/head:pull/163 Looks good, thanks for fixing this! Noticed a pre-existing typo, could perhaps fix that while we're at it.. ---------------- Approved by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/163 From kcr at openjdk.org Thu Sep 26 12:09:10 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Thu, 26 Sep 2019 12:09:10 GMT Subject: [Rev 01] RFR: 80: Allow valid bug ID format to be configurable In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 6c2edecc: Fix typo found during review Changes: - all: https://git.openjdk.java.net/skara/pull/163/files - new: https://git.openjdk.java.net/skara/pull/163/files/a12ec8ee..6c2edecc Webrevs: - full: https://webrevs.openjdk.java.net/skara/163/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/163/webrev.00-01 Issue: https://bugs.openjdk.java.net/browse/SKARA-80 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/163.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/163/head:pull/163 PR: https://git.openjdk.java.net/skara/pull/163 From kcr at openjdk.org Thu Sep 26 12:11:07 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Thu, 26 Sep 2019 12:11:07 GMT Subject: RFR: 80: Allow valid bug ID format to be configurable In-Reply-To: References: Message-ID: On Thu, 26 Sep 2019 11:54:09 GMT, Robin Westberg wrote: > On Wed, 25 Sep 2019 13:50:50 GMT, Kevin Rushforth wrote: > >> JBS issue: https://bugs.openjdk.java.net/browse/SKARA-80 >> >> This provides a configuration option to define the pattern for a valid issue ID as follows. This starts with the idea @edvbld mentioned in PR #99, although I felt it was cleaner to leave the default issue format as is, and use the more restrictive pattern for the "legacy" jdk conf file. >> >> The syntax of the new pattern is: >> >> [checks "issues"] >> pattern= >> >> The default pattern is: >> >> [checks "issues"] >> pattern=^(([A-Z][A-Z0-9]+-)?[0-9]+): (\\S.*)$ >> >> For legacy JDK `.jcheck/conf` files, the pattern is as follows to match the issue ID rules in `jcheck.py`: >> >> [checks "issues"] >> pattern=^([124-8][0-9]{6}): (\\S.*)$ >> >> ---------------- >> >> Commits: >> - a12ec8ee: 80: Allow valid bug ID format to be configurable >> >> Changes: https://git.openjdk.java.net/skara/pull/163/files >> Webrev: https://webrevs.openjdk.java.net/skara/163/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/SKARA-80 >> Stats: 321 lines in 5 files changed: 315 ins; 1 del; 5 mod >> Patch: https://git.openjdk.java.net/skara/pull/163.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/163/head:pull/163 > > jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesCheck.java line 48: > >> 47: if (commit.message().isEmpty() || message.issues().isEmpty()) { >> 48: log.finer("isuse: no reference to a JBS issue"); >> 49: return iterator(new IssuesIssue(metadata)); > > Suggestion: > > log.finer("issue: no reference to a JBS issue"); @rwestberg I fixed the typo you pointed out. PR: https://git.openjdk.java.net/skara/pull/163 From duke at openjdk.java.net Thu Sep 26 12:13:11 2019 From: duke at openjdk.java.net (duke) Date: Thu, 26 Sep 2019 12:13:11 GMT Subject: [Integrated] RFR: 80: Allow valid bug ID format to be configurable In-Reply-To: References: Message-ID: <5893bc50-01ff-433e-8661-e360288da3a9@openjdk.java.net> Changeset: 527967e0 Author: Kevin Rushforth Committer: Robin Westberg Date: 2019-09-26 12:13:01 +0000 URL: https://git.openjdk.java.net/skara/commit/527967e0 80: Allow valid bug ID format to be configurable Reviewed-by: rwestberg ! jcheck/src/main/java/org/openjdk/skara/jcheck/ChecksConfiguration.java ! jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesCheck.java + jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesConfiguration.java ! jcheck/src/main/java/org/openjdk/skara/jcheck/JCheckConfiguration.java ! jcheck/src/test/java/org/openjdk/skara/jcheck/IssuesCheckTests.java From rwestberg at openjdk.org Fri Sep 27 11:54:04 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 27 Sep 2019 11:54:04 GMT Subject: RFR: Log errors when WorkItems execute for longer than a specified time Message-ID: <0Peg88htuj62ynbGbiMTVyeRB9-6Q6DDGdVLl-b21Ew=.54bbe30c-36e3-449a-9608-c0e22b89a802@github.com> Hi all, Please review the following change that adds logging when work items execute for longer than a configured time. This can help detect issues such as https://bugs.openjdk.java.net/browse/SKARA-52 . Best regards, Robin ---------------- Commits: - 5fc40af1: Log errors when WorkItems execute for longer than a specified time Changes: https://git.openjdk.java.net/skara/pull/164/files Webrev: https://webrevs.openjdk.java.net/skara/164/webrev.00 Stats: 122 lines in 3 files changed: 94 ins; 6 del; 22 mod Patch: https://git.openjdk.java.net/skara/pull/164.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/164/head:pull/164 PR: https://git.openjdk.java.net/skara/pull/164 From rwestberg at openjdk.org Fri Sep 27 12:41:52 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Fri, 27 Sep 2019 12:41:52 GMT Subject: RFR: 52: The HgToGitConverter waits for child processes indefinitely Message-ID: Hi all, Please review this small change that adds a timeout to the HgToGitConverter, as it seems that intermittent network problems can cause the child processes to hang. Best regards, Robin ---------------- Commits: - 95304484: Kill processes if they execute more than 12 hours Changes: https://git.openjdk.java.net/skara/pull/165/files Webrev: https://webrevs.openjdk.java.net/skara/165/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-52 Stats: 11 lines in 1 file changed: 10 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/165.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/165/head:pull/165 PR: https://git.openjdk.java.net/skara/pull/165 From rwestberg at openjdk.org Mon Sep 30 07:17:35 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 30 Sep 2019 07:17:35 GMT Subject: RFR: Handle non contiguous tag ranges in the notifier Message-ID: Hi all, Please review the following change that handles the case where the notifier encounters gaps in tag ranges. Best regards, Robin ---------------- Commits: - d0d8fe42: Handle non contiguous tag ranges Changes: https://git.openjdk.java.net/skara/pull/166/files Webrev: https://webrevs.openjdk.java.net/skara/166/webrev.00 Stats: 72 lines in 3 files changed: 61 ins; 4 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/166.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/166/head:pull/166 PR: https://git.openjdk.java.net/skara/pull/166 From ehelin at openjdk.org Mon Sep 30 07:42:33 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 30 Sep 2019 07:42:33 GMT Subject: [Approved] RFR: Log errors when WorkItems execute for longer than a specified time In-Reply-To: <0Peg88htuj62ynbGbiMTVyeRB9-6Q6DDGdVLl-b21Ew=.54bbe30c-36e3-449a-9608-c0e22b89a802@github.com> References: <0Peg88htuj62ynbGbiMTVyeRB9-6Q6DDGdVLl-b21Ew=.54bbe30c-36e3-449a-9608-c0e22b89a802@github.com> Message-ID: On Fri, 27 Sep 2019 11:54:04 GMT, Robin Westberg wrote: > Hi all, > > Please review the following change that adds logging when work items execute for longer than a configured time. This can help detect issues such as https://bugs.openjdk.java.net/browse/SKARA-52 . > > Best regards, > Robin > > ---------------- > > Commits: > - 5fc40af1: Log errors when WorkItems execute for longer than a specified time > > Changes: https://git.openjdk.java.net/skara/pull/164/files > Webrev: https://webrevs.openjdk.java.net/skara/164/webrev.00 > Stats: 122 lines in 3 files changed: 94 ins; 6 del; 22 mod > Patch: https://git.openjdk.java.net/skara/pull/164.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/164/head:pull/164 Very nice functionality, great patch @rwestberg! =?utf-8?b?8J+Rjw==?= ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/164 From ehelin at openjdk.org Mon Sep 30 07:44:25 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 30 Sep 2019 07:44:25 GMT Subject: [Approved] RFR: 52: The HgToGitConverter waits for child processes indefinitely In-Reply-To: References: Message-ID: <62bn_ZayMT2wKyyYRokQQviJsxF-Bax8prOKEwjlRU0=.323016bd-9bde-4f33-b530-3d60a14ce64d@github.com> On Fri, 27 Sep 2019 12:41:52 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that adds a timeout to the HgToGitConverter, as it seems that intermittent network problems can cause the child processes to hang. > > Best regards, > Robin > > ---------------- > > Commits: > - 95304484: Kill processes if they execute more than 12 hours > > Changes: https://git.openjdk.java.net/skara/pull/165/files > Webrev: https://webrevs.openjdk.java.net/skara/165/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/SKARA-52 > Stats: 11 lines in 1 file changed: 10 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/skara/pull/165.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/165/head:pull/165 Looks good, thanks for fixing this! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/165 From ehelin at openjdk.org Mon Sep 30 07:46:13 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 30 Sep 2019 07:46:13 GMT Subject: [Approved] RFR: Handle non contiguous tag ranges in the notifier In-Reply-To: References: Message-ID: On Mon, 30 Sep 2019 07:17:35 GMT, Robin Westberg wrote: > Hi all, > > Please review the following change that handles the case where the notifier encounters gaps in tag ranges. > > Best regards, > Robin > > ---------------- > > Commits: > - d0d8fe42: Handle non contiguous tag ranges > > Changes: https://git.openjdk.java.net/skara/pull/166/files > Webrev: https://webrevs.openjdk.java.net/skara/166/webrev.00 > Stats: 72 lines in 3 files changed: 61 ins; 4 del; 7 mod > Patch: https://git.openjdk.java.net/skara/pull/166.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/166/head:pull/166 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/166 From ehelin at openjdk.org Mon Sep 30 08:12:43 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 30 Sep 2019 08:12:43 GMT Subject: RFR: Issue tracker support In-Reply-To: References: Message-ID: On Wed, 25 Sep 2019 13:14:38 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that introduces issue support. An Issue contains a subset of PullRequest functionality, similar to how this is modeled in GitHub and GitLab. It also allows creating support for other issue trackers that do not have repository support, such as Jira. > > Best regards, > Robin > > ---------------- > > Commits: > - 7b0e6107: Implement test version of Issue and IssueProject > - b603a667: GitHub and GitLab does not yet implement Issues > - d1886dcc: Extract IssueProject and Issue from HostedRepository and PullRequest > > Changes: https://git.openjdk.java.net/skara/pull/162/files > Webrev: https://webrevs.openjdk.java.net/skara/162/webrev.00 > Stats: 854 lines in 20 files changed: 608 ins; 240 del; 6 mod > Patch: https://git.openjdk.java.net/skara/pull/162.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/162/head:pull/162 _Very_ nice work Robin to have `PullRequest implements Issue` and `HostedRepository implements IssueTracker`. I see that you basically copied parts of the `PullRequest` and `HostedRepository` interfaces, I would prefer to take this opportunity to update some of the naming conventions for methods (in particular dropping the "get" prefix). I also think that that the `Issue` and `IssueTracker` interfaces should be moved to a separate module: `issuetracker`. Now sure how much of this you want to do in this PR or if you want to integrate this first and the adapt the code? host/src/main/java/org/openjdk/skara/host/Issue.java line 40: > 39: */ > 40: String getId(); > 41: Please drop the "get" and just use `id` host/src/main/java/org/openjdk/skara/host/Issue.java line 46: > 45: */ > 46: HostUserDetails getAuthor(); > 47: Again, drop the "get" host/src/main/java/org/openjdk/skara/host/Issue.java line 52: > 51: */ > 52: String getTitle(); > 53: ..and drop the "get" =?utf-8?b?8J+YuA==?= host/src/main/java/org/openjdk/skara/host/Issue.java line 64: > 63: */ > 64: String getBody(); > 65: Drop "get" here as well host/src/main/java/org/openjdk/skara/host/Issue.java line 76: > 75: */ > 76: List getComments(); > 77: and drop "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 95: > 94: */ > 95: ZonedDateTime getCreated(); > 96: I would suggest renaming `getCreated()` to `createdAt()` host/src/main/java/org/openjdk/skara/host/Issue.java line 101: > 100: */ > 101: ZonedDateTime getUpdated(); > 102: I would suggest renaming `getUpdated` to `updatedAt` host/src/main/java/org/openjdk/skara/host/Issue.java line 130: > 129: */ > 130: List getLabels(); > 131: Drop the "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 135: > 134: */ > 135: URI getWebUrl(); > 136: Drop "get" here as well host/src/main/java/org/openjdk/skara/host/Issue.java line 140: > 139: */ > 140: List getAssignees(); > 141: Drop "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 146: > 145: */ > 146: void setAssignees(List assignees); > 147: } Rename this from `setAssignees` to `assignTo`? host/src/main/java/org/openjdk/skara/host/IssueProject.java line 28: > 27: > 28: public interface IssueProject { > 29: Host host(); I would rename `IssueProject` to `IssueTracker` host/src/main/java/org/openjdk/skara/host/IssueProject.java line 30: > 29: Host host(); > 30: URI getWebUrl(); > 31: Issue createIssue(String title, List body); Drop the "get" here host/src/main/java/org/openjdk/skara/host/IssueProject.java line 32: > 31: Issue createIssue(String title, List body); > 32: Issue getIssue(String id); > 33: List getIssues(); Drop the "get" here as well host/src/main/java/org/openjdk/skara/host/IssueProject.java line 33: > 32: Issue getIssue(String id); > 33: List getIssues(); > 34: } Drop "get" here too PR: https://git.openjdk.java.net/skara/pull/162 From rwestberg at openjdk.org Mon Sep 30 08:50:44 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 30 Sep 2019 08:50:44 GMT Subject: RFR: Email body should not be mime encoded Message-ID: Hi all, Please review this change that reverts the previously introduced mime encoding of email bodies. This encoding should only be applied to email headers. For the body, a content-type header should be used. Best regards, Robin ---------------- Commits: - 642a41a5: Email body should not be mime encoded, it should use a content-type header Changes: https://git.openjdk.java.net/skara/pull/167/files Webrev: https://webrevs.openjdk.java.net/skara/167/webrev.00 Stats: 28 lines in 3 files changed: 20 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/skara/pull/167.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/167/head:pull/167 PR: https://git.openjdk.java.net/skara/pull/167 From ehelin at openjdk.org Mon Sep 30 08:58:25 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 30 Sep 2019 08:58:25 GMT Subject: [Approved] RFR: Email body should not be mime encoded In-Reply-To: References: Message-ID: On Mon, 30 Sep 2019 08:50:44 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that reverts the previously introduced mime encoding of email bodies. This encoding should only be applied to email headers. For the body, a content-type header should be used. > > Best regards, > Robin > > ---------------- > > Commits: > - 642a41a5: Email body should not be mime encoded, it should use a content-type header > > Changes: https://git.openjdk.java.net/skara/pull/167/files > Webrev: https://webrevs.openjdk.java.net/skara/167/webrev.00 > Stats: 28 lines in 3 files changed: 20 ins; 0 del; 8 mod > Patch: https://git.openjdk.java.net/skara/pull/167.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/167/head:pull/167 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/167 From rwestberg at openjdk.org Mon Sep 30 08:59:02 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 30 Sep 2019 08:59:02 GMT Subject: [Rev 01] RFR: Email body should not be mime encoded In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 59ee3379: Fix remaining use of mime body encoding Changes: - all: https://git.openjdk.java.net/skara/pull/167/files - new: https://git.openjdk.java.net/skara/pull/167/files/642a41a5..59ee3379 Webrevs: - full: https://webrevs.openjdk.java.net/skara/167/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/167/webrev.00-01 Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/167.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/167/head:pull/167 PR: https://git.openjdk.java.net/skara/pull/167 From duke at openjdk.java.net Mon Sep 30 11:56:46 2019 From: duke at openjdk.java.net (duke) Date: Mon, 30 Sep 2019 11:56:46 GMT Subject: [Integrated] RFR: Email body should not be mime encoded In-Reply-To: References: Message-ID: <0403b9b7-c8ef-4edb-a351-b4487605bc94@openjdk.java.net> Changeset: ffc5e6ca Author: Robin Westberg Date: 2019-09-30 11:56:28 +0000 URL: https://git.openjdk.java.net/skara/commit/ffc5e6ca Email body should not be mime encoded Reviewed-by: ehelin ! email/src/main/java/org/openjdk/skara/email/Email.java ! email/src/main/java/org/openjdk/skara/email/SMTP.java ! mailinglist/src/main/java/org/openjdk/skara/mailinglist/Mbox.java ! mailinglist/src/main/java/org/openjdk/skara/mailinglist/mboxfile/MboxFileList.java ! test/src/main/java/org/openjdk/skara/test/SMTPServer.java From rwestberg at openjdk.org Mon Sep 30 12:22:19 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 30 Sep 2019 12:22:19 GMT Subject: RFR: The test mailman server should handle utf-8 encoded content Message-ID: Hi all, Please review this small change that fixes a failing test case introduced by no longer mime encoding email bodies. Best regards, Robin ---------------- Commits: - 1984e4ac: The test mailman server should handle utf-8 encoded content Changes: https://git.openjdk.java.net/skara/pull/168/files Webrev: https://webrevs.openjdk.java.net/skara/168/webrev.00 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/168.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/168/head:pull/168 PR: https://git.openjdk.java.net/skara/pull/168 From ehelin at openjdk.org Mon Sep 30 12:34:36 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 30 Sep 2019 12:34:36 GMT Subject: [Approved] RFR: The test mailman server should handle utf-8 encoded content In-Reply-To: References: Message-ID: On Mon, 30 Sep 2019 12:22:19 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that fixes a failing test case introduced by no longer mime encoding email bodies. > > Best regards, > Robin > > ---------------- > > Commits: > - 1984e4ac: The test mailman server should handle utf-8 encoded content > > Changes: https://git.openjdk.java.net/skara/pull/168/files > Webrev: https://webrevs.openjdk.java.net/skara/168/webrev.00 > Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/skara/pull/168.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/168/head:pull/168 Looks good! ---------------- Approved by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/168 From duke at openjdk.java.net Mon Sep 30 12:36:46 2019 From: duke at openjdk.java.net (duke) Date: Mon, 30 Sep 2019 12:36:46 GMT Subject: [Integrated] RFR: The test mailman server should handle utf-8 encoded content In-Reply-To: References: Message-ID: <2ca75545-da4e-4786-bc36-4ca08b5de82c@openjdk.java.net> Changeset: 8b659d3f Author: Robin Westberg Date: 2019-09-30 12:36:37 +0000 URL: https://git.openjdk.java.net/skara/commit/8b659d3f The test mailman server should handle utf-8 encoded content Reviewed-by: ehelin ! test/src/main/java/org/openjdk/skara/test/TestMailmanServer.java From duke at openjdk.java.net Mon Sep 30 12:38:56 2019 From: duke at openjdk.java.net (duke) Date: Mon, 30 Sep 2019 12:38:56 GMT Subject: [Integrated] RFR: Log errors when WorkItems execute for longer than a specified time In-Reply-To: <0Peg88htuj62ynbGbiMTVyeRB9-6Q6DDGdVLl-b21Ew=.54bbe30c-36e3-449a-9608-c0e22b89a802@github.com> References: <0Peg88htuj62ynbGbiMTVyeRB9-6Q6DDGdVLl-b21Ew=.54bbe30c-36e3-449a-9608-c0e22b89a802@github.com> Message-ID: <53c3ac86-3f2b-4c03-be9e-6a06e523d3bd@openjdk.java.net> Changeset: 689b17e4 Author: Robin Westberg Date: 2019-09-30 12:38:44 +0000 URL: https://git.openjdk.java.net/skara/commit/689b17e4 Log errors when WorkItems execute for longer than a specified time Reviewed-by: ehelin ! bot/src/main/java/org/openjdk/skara/bot/BotRunner.java ! bot/src/main/java/org/openjdk/skara/bot/BotRunnerConfiguration.java ! bot/src/test/java/org/openjdk/skara/bot/BotRunnerTests.java From duke at openjdk.java.net Mon Sep 30 12:39:06 2019 From: duke at openjdk.java.net (duke) Date: Mon, 30 Sep 2019 12:39:06 GMT Subject: [Integrated] RFR: 52: The HgToGitConverter waits for child processes indefinitely In-Reply-To: References: Message-ID: Changeset: a8f991e7 Author: Robin Westberg Date: 2019-09-30 12:38:57 +0000 URL: https://git.openjdk.java.net/skara/commit/a8f991e7 52: The HgToGitConverter waits for child processes indefinitely Reviewed-by: ehelin ! vcs/src/main/java/org/openjdk/skara/vcs/openjdk/convert/HgToGitConverter.java From duke at openjdk.java.net Mon Sep 30 12:39:45 2019 From: duke at openjdk.java.net (duke) Date: Mon, 30 Sep 2019 12:39:45 GMT Subject: [Integrated] RFR: Handle non contiguous tag ranges in the notifier In-Reply-To: References: Message-ID: Changeset: a6075bb5 Author: Robin Westberg Date: 2019-09-30 12:39:38 +0000 URL: https://git.openjdk.java.net/skara/commit/a6075bb5 Handle non contiguous tag ranges in the notifier Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JNotifyBot.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java ! vcs/src/main/java/org/openjdk/skara/vcs/openjdk/OpenJDKTag.java From ehelin at openjdk.org Mon Sep 30 12:50:04 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 30 Sep 2019 12:50:04 GMT Subject: RFR: Issue tracker support In-Reply-To: References: Message-ID: On Wed, 25 Sep 2019 13:14:38 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that introduces issue support. An Issue contains a subset of PullRequest functionality, similar to how this is modeled in GitHub and GitLab. It also allows creating support for other issue trackers that do not have repository support, such as Jira. > > Best regards, > Robin > > ---------------- > > Commits: > - 7b0e6107: Implement test version of Issue and IssueProject > - b603a667: GitHub and GitLab does not yet implement Issues > - d1886dcc: Extract IssueProject and Issue from HostedRepository and PullRequest > > Changes: https://git.openjdk.java.net/skara/pull/162/files > Webrev: https://webrevs.openjdk.java.net/skara/162/webrev.00 > Stats: 854 lines in 20 files changed: 608 ins; 240 del; 6 mod > Patch: https://git.openjdk.java.net/skara/pull/162.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/162/head:pull/162 _Very_ nice work Robin to have `PullRequest implements Issue` and `HostedRepository implements IssueTracker`. I see that you basically copied parts of the `PullRequest` and `HostedRepository` interfaces, I would prefer to take this opportunity to update some of the naming conventions for methods (in particular dropping the "get" prefix). I also think that that the `Issue` and `IssueTracker` interfaces should be moved to a separate module: `issuetracker`. Now sure how much of this you want to do in this PR or if you want to integrate this first and the adapt the code? host/src/main/java/org/openjdk/skara/host/Issue.java line 40: > 39: */ > 40: String getId(); > 41: Please drop the "get" and just use `id` host/src/main/java/org/openjdk/skara/host/Issue.java line 46: > 45: */ > 46: HostUserDetails getAuthor(); > 47: Again, drop the "get" host/src/main/java/org/openjdk/skara/host/Issue.java line 52: > 51: */ > 52: String getTitle(); > 53: ..and drop the "get" ?? host/src/main/java/org/openjdk/skara/host/Issue.java line 64: > 63: */ > 64: String getBody(); > 65: Drop "get" here as well host/src/main/java/org/openjdk/skara/host/Issue.java line 76: > 75: */ > 76: List getComments(); > 77: and drop "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 95: > 94: */ > 95: ZonedDateTime getCreated(); > 96: I would suggest renaming `getCreated()` to `createdAt()` host/src/main/java/org/openjdk/skara/host/Issue.java line 101: > 100: */ > 101: ZonedDateTime getUpdated(); > 102: I would suggest renaming `getUpdated` to `updatedAt` host/src/main/java/org/openjdk/skara/host/Issue.java line 130: > 129: */ > 130: List getLabels(); > 131: Drop the "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 135: > 134: */ > 135: URI getWebUrl(); > 136: Drop "get" here as well host/src/main/java/org/openjdk/skara/host/Issue.java line 140: > 139: */ > 140: List getAssignees(); > 141: Drop "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 146: > 145: */ > 146: void setAssignees(List assignees); > 147: } Rename this from `setAssignees` to `assignTo`? host/src/main/java/org/openjdk/skara/host/IssueProject.java line 28: > 27: > 28: public interface IssueProject { > 29: Host host(); I would rename `IssueProject` to `IssueTracker` host/src/main/java/org/openjdk/skara/host/IssueProject.java line 30: > 29: Host host(); > 30: URI getWebUrl(); > 31: Issue createIssue(String title, List body); Drop the "get" here PR: https://git.openjdk.java.net/skara/pull/162 From ehelin at openjdk.org Mon Sep 30 12:49:44 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 30 Sep 2019 12:49:44 GMT Subject: RFR: Issue tracker support In-Reply-To: References: Message-ID: On Wed, 25 Sep 2019 13:14:38 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that introduces issue support. An Issue contains a subset of PullRequest functionality, similar to how this is modeled in GitHub and GitLab. It also allows creating support for other issue trackers that do not have repository support, such as Jira. > > Best regards, > Robin > > ---------------- > > Commits: > - 7b0e6107: Implement test version of Issue and IssueProject > - b603a667: GitHub and GitLab does not yet implement Issues > - d1886dcc: Extract IssueProject and Issue from HostedRepository and PullRequest > > Changes: https://git.openjdk.java.net/skara/pull/162/files > Webrev: https://webrevs.openjdk.java.net/skara/162/webrev.00 > Stats: 854 lines in 20 files changed: 608 ins; 240 del; 6 mod > Patch: https://git.openjdk.java.net/skara/pull/162.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/162/head:pull/162 _Very_ nice work Robin to have `PullRequest implements Issue` and `HostedRepository implements IssueTracker`. I see that you basically copied parts of the `PullRequest` and `HostedRepository` interfaces, I would prefer to take this opportunity to update some of the naming conventions for methods (in particular dropping the "get" prefix). I also think that that the `Issue` and `IssueTracker` interfaces should be moved to a separate module: `issuetracker`. Now sure how much of this you want to do in this PR or if you want to integrate this first and the adapt the code? host/src/main/java/org/openjdk/skara/host/Issue.java line 40: > 39: */ > 40: String getId(); > 41: Please drop the "get" and just use `id` host/src/main/java/org/openjdk/skara/host/Issue.java line 46: > 45: */ > 46: HostUserDetails getAuthor(); > 47: Again, drop the "get" host/src/main/java/org/openjdk/skara/host/Issue.java line 52: > 51: */ > 52: String getTitle(); > 53: ..and drop the "get" ?? host/src/main/java/org/openjdk/skara/host/Issue.java line 64: > 63: */ > 64: String getBody(); > 65: Drop "get" here as well host/src/main/java/org/openjdk/skara/host/Issue.java line 76: > 75: */ > 76: List getComments(); > 77: and drop "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 95: > 94: */ > 95: ZonedDateTime getCreated(); > 96: I would suggest renaming `getCreated()` to `createdAt()` host/src/main/java/org/openjdk/skara/host/Issue.java line 101: > 100: */ > 101: ZonedDateTime getUpdated(); > 102: I would suggest renaming `getUpdated` to `updatedAt` host/src/main/java/org/openjdk/skara/host/Issue.java line 130: > 129: */ > 130: List getLabels(); > 131: Drop the "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 135: > 134: */ > 135: URI getWebUrl(); > 136: Drop "get" here as well host/src/main/java/org/openjdk/skara/host/Issue.java line 140: > 139: */ > 140: List getAssignees(); > 141: Drop "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 146: > 145: */ > 146: void setAssignees(List assignees); > 147: } Rename this from `setAssignees` to `assignTo`? host/src/main/java/org/openjdk/skara/host/IssueProject.java line 28: > 27: > 28: public interface IssueProject { > 29: Host host(); I would rename `IssueProject` to `IssueTracker` host/src/main/java/org/openjdk/skara/host/IssueProject.java line 30: > 29: Host host(); > 30: URI getWebUrl(); > 31: Issue createIssue(String title, List body); Drop the "get" here host/src/main/java/org/openjdk/skara/host/IssueProject.java line 32: > 31: Issue createIssue(String title, List body); > 32: Issue getIssue(String id); > 33: List getIssues(); Drop the "get" here as well PR: https://git.openjdk.java.net/skara/pull/162 From ehelin at openjdk.org Mon Sep 30 13:33:52 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 30 Sep 2019 13:33:52 GMT Subject: RFR: Issue tracker support In-Reply-To: References: Message-ID: On Wed, 25 Sep 2019 13:14:38 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that introduces issue support. An Issue contains a subset of PullRequest functionality, similar to how this is modeled in GitHub and GitLab. It also allows creating support for other issue trackers that do not have repository support, such as Jira. > > Best regards, > Robin > > ---------------- > > Commits: > - 7b0e6107: Implement test version of Issue and IssueProject > - b603a667: GitHub and GitLab does not yet implement Issues > - d1886dcc: Extract IssueProject and Issue from HostedRepository and PullRequest > > Changes: https://git.openjdk.java.net/skara/pull/162/files > Webrev: https://webrevs.openjdk.java.net/skara/162/webrev.00 > Stats: 854 lines in 20 files changed: 608 ins; 240 del; 6 mod > Patch: https://git.openjdk.java.net/skara/pull/162.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/162/head:pull/162 _Very_ nice work Robin to have `PullRequest implements Issue` and `HostedRepository implements IssueTracker`. I see that you basically copied parts of the `PullRequest` and `HostedRepository` interfaces, I would prefer to take this opportunity to update some of the naming conventions for methods (in particular dropping the "get" prefix). I also think that that the `Issue` and `IssueTracker` interfaces should be moved to a separate module: `issuetracker`. Now sure how much of this you want to do in this PR or if you want to integrate this first and the adapt the code? host/src/main/java/org/openjdk/skara/host/Issue.java line 40: > 39: */ > 40: String getId(); > 41: Please drop the "get" and just use `id` host/src/main/java/org/openjdk/skara/host/Issue.java line 46: > 45: */ > 46: HostUserDetails getAuthor(); > 47: Again, drop the "get" host/src/main/java/org/openjdk/skara/host/Issue.java line 52: > 51: */ > 52: String getTitle(); > 53: ..and drop the "get" ?? host/src/main/java/org/openjdk/skara/host/Issue.java line 64: > 63: */ > 64: String getBody(); > 65: Drop "get" here as well host/src/main/java/org/openjdk/skara/host/Issue.java line 76: > 75: */ > 76: List getComments(); > 77: and drop "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 95: > 94: */ > 95: ZonedDateTime getCreated(); > 96: I would suggest renaming `getCreated()` to `createdAt()` host/src/main/java/org/openjdk/skara/host/Issue.java line 101: > 100: */ > 101: ZonedDateTime getUpdated(); > 102: I would suggest renaming `getUpdated` to `updatedAt` host/src/main/java/org/openjdk/skara/host/Issue.java line 130: > 129: */ > 130: List getLabels(); > 131: Drop the "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 135: > 134: */ > 135: URI getWebUrl(); > 136: Drop "get" here as well host/src/main/java/org/openjdk/skara/host/Issue.java line 140: > 139: */ > 140: List getAssignees(); > 141: Drop "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 146: > 145: */ > 146: void setAssignees(List assignees); > 147: } Rename this from `setAssignees` to `assignTo`? host/src/main/java/org/openjdk/skara/host/IssueProject.java line 28: > 27: > 28: public interface IssueProject { > 29: Host host(); I would rename `IssueProject` to `IssueTracker` PR: https://git.openjdk.java.net/skara/pull/162 From duke at openjdk.java.net Mon Sep 30 13:35:42 2019 From: duke at openjdk.java.net (duke) Date: Mon, 30 Sep 2019 13:35:42 GMT Subject: git: openjdk/skara: Proper separating of collapsed reply ids Message-ID: Changeset: fc91df24 Author: Robin Westberg Date: 2019-09-30 13:35:33 +0000 URL: https://git.openjdk.java.net/skara/commit/fc91df24 Proper separating of collapsed reply ids Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From ehelin at openjdk.org Mon Sep 30 13:40:41 2019 From: ehelin at openjdk.org (Erik Helin) Date: Mon, 30 Sep 2019 13:40:41 GMT Subject: RFR: Issue tracker support In-Reply-To: References: Message-ID: On Wed, 25 Sep 2019 13:14:38 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that introduces issue support. An Issue contains a subset of PullRequest functionality, similar to how this is modeled in GitHub and GitLab. It also allows creating support for other issue trackers that do not have repository support, such as Jira. > > Best regards, > Robin > > ---------------- > > Commits: > - 7b0e6107: Implement test version of Issue and IssueProject > - b603a667: GitHub and GitLab does not yet implement Issues > - d1886dcc: Extract IssueProject and Issue from HostedRepository and PullRequest > > Changes: https://git.openjdk.java.net/skara/pull/162/files > Webrev: https://webrevs.openjdk.java.net/skara/162/webrev.00 > Stats: 854 lines in 20 files changed: 608 ins; 240 del; 6 mod > Patch: https://git.openjdk.java.net/skara/pull/162.diff > Fetch: git fetch https://git.openjdk.java.net/skara pull/162/head:pull/162 _Very_ nice work Robin to have `PullRequest implements Issue` and `HostedRepository implements IssueTracker`. I see that you basically copied parts of the `PullRequest` and `HostedRepository` interfaces, I would prefer to take this opportunity to update some of the naming conventions for methods (in particular dropping the "get" prefix). I also think that that the `Issue` and `IssueTracker` interfaces should be moved to a separate module: `issuetracker`. Now sure how much of this you want to do in this PR or if you want to integrate this first and the adapt the code? host/src/main/java/org/openjdk/skara/host/Issue.java line 40: > 39: */ > 40: String getId(); > 41: Please drop the "get" and just use `id` host/src/main/java/org/openjdk/skara/host/Issue.java line 46: > 45: */ > 46: HostUserDetails getAuthor(); > 47: Again, drop the "get" host/src/main/java/org/openjdk/skara/host/Issue.java line 52: > 51: */ > 52: String getTitle(); > 53: ..and drop the "get" ?? host/src/main/java/org/openjdk/skara/host/Issue.java line 64: > 63: */ > 64: String getBody(); > 65: Drop "get" here as well host/src/main/java/org/openjdk/skara/host/Issue.java line 76: > 75: */ > 76: List getComments(); > 77: and drop "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 95: > 94: */ > 95: ZonedDateTime getCreated(); > 96: I would suggest renaming `getCreated()` to `createdAt()` host/src/main/java/org/openjdk/skara/host/Issue.java line 101: > 100: */ > 101: ZonedDateTime getUpdated(); > 102: I would suggest renaming `getUpdated` to `updatedAt` host/src/main/java/org/openjdk/skara/host/Issue.java line 130: > 129: */ > 130: List getLabels(); > 131: Drop the "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 135: > 134: */ > 135: URI getWebUrl(); > 136: Drop "get" here as well host/src/main/java/org/openjdk/skara/host/Issue.java line 140: > 139: */ > 140: List getAssignees(); > 141: Drop "get" here too host/src/main/java/org/openjdk/skara/host/Issue.java line 146: > 145: */ > 146: void setAssignees(List assignees); > 147: } Rename this from `setAssignees` to `assignTo`? PR: https://git.openjdk.java.net/skara/pull/162 From rwestberg at openjdk.org Mon Sep 30 14:46:30 2019 From: rwestberg at openjdk.org (Robin Westberg) Date: Mon, 30 Sep 2019 14:46:30 GMT Subject: RFR: Issue tracker support In-Reply-To: References: Message-ID: <2T39tCb7B8lb0X3_Lqj3nER3v3lwP1fxwJo6MhuwB5Y=.467e64be-bbe1-426e-98ed-3a2bf0e42943@github.com> On Mon, 30 Sep 2019 13:40:41 GMT, Erik Helin wrote: > On Wed, 25 Sep 2019 13:14:38 GMT, Robin Westberg wrote: > >> Hi all, >> >> Please review this change that introduces issue support. An Issue contains a subset of PullRequest functionality, similar to how this is modeled in GitHub and GitLab. It also allows creating support for other issue trackers that do not have repository support, such as Jira. >> >> Best regards, >> Robin >> >> ---------------- >> >> Commits: >> - 7b0e6107: Implement test version of Issue and IssueProject >> - b603a667: GitHub and GitLab does not yet implement Issues >> - d1886dcc: Extract IssueProject and Issue from HostedRepository and PullRequest >> >> Changes: https://git.openjdk.java.net/skara/pull/162/files >> Webrev: https://webrevs.openjdk.java.net/skara/162/webrev.00 >> Stats: 854 lines in 20 files changed: 608 ins; 240 del; 6 mod >> Patch: https://git.openjdk.java.net/skara/pull/162.diff >> Fetch: git fetch https://git.openjdk.java.net/skara pull/162/head:pull/162 > > _Very_ nice work Robin to have `PullRequest implements Issue` and `HostedRepository implements IssueTracker`. I see that you basically copied parts of the `PullRequest` and `HostedRepository` interfaces, I would prefer to take this opportunity to update some of the naming conventions for methods (in particular dropping the "get" prefix). I also think that that the `Issue` and `IssueTracker` interfaces should be moved to a separate module: `issuetracker`. Now sure how much of this you want to do in this PR or if you want to integrate this first and the adapt the code? > > host/src/main/java/org/openjdk/skara/host/Issue.java line 40: > >> 39: */ >> 40: String getId(); >> 41: > > Please drop the "get" and just use `id` > > host/src/main/java/org/openjdk/skara/host/Issue.java line 46: > >> 45: */ >> 46: HostUserDetails getAuthor(); >> 47: > > Again, drop the "get" > > host/src/main/java/org/openjdk/skara/host/Issue.java line 52: > >> 51: */ >> 52: String getTitle(); >> 53: > > ...and drop the "get" ?? > > host/src/main/java/org/openjdk/skara/host/Issue.java line 64: > >> 63: */ >> 64: String getBody(); >> 65: > > Drop "get" here as well > > host/src/main/java/org/openjdk/skara/host/Issue.java line 76: > >> 75: */ >> 76: List getComments(); >> 77: > > and drop "get" here too > > host/src/main/java/org/openjdk/skara/host/Issue.java line 95: > >> 94: */ >> 95: ZonedDateTime getCreated(); >> 96: > > I would suggest renaming `getCreated()` to `createdAt()` > > host/src/main/java/org/openjdk/skara/host/Issue.java line 101: > >> 100: */ >> 101: ZonedDateTime getUpdated(); >> 102: > > I would suggest renaming `getUpdated` to `updatedAt` > > host/src/main/java/org/openjdk/skara/host/Issue.java line 130: > >> 129: */ >> 130: List getLabels(); >> 131: > > Drop the "get" here too > > host/src/main/java/org/openjdk/skara/host/Issue.java line 135: > >> 134: */ >> 135: URI getWebUrl(); >> 136: > > Drop "get" here as well > > host/src/main/java/org/openjdk/skara/host/Issue.java line 140: > >> 139: */ >> 140: List getAssignees(); >> 141: > > Drop "get" here too > > host/src/main/java/org/openjdk/skara/host/Issue.java line 146: > >> 145: */ >> 146: void setAssignees(List assignees); >> 147: } > > Rename this from `setAssignees` to `assignTo`? Right, as the PullRequest interface now extends the Issue interface, renaming these methods would touch pretty much every file in the bots directory I guess.. ?? But yes, would be nice to clean up. (While I'm at it, I'll have to check if the mailing list archive correctly displays these: ??? and ?) :) PR: https://git.openjdk.java.net/skara/pull/162 From kcr at openjdk.org Mon Sep 30 21:28:59 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Mon, 30 Sep 2019 21:28:59 GMT Subject: RFR: WIP: 108: Command line tools fon't run with Cygwin git Message-ID: This is a very preliminary "proof of concept" patch that allows `git jcheck` to work with git from Cygwin. It is incomplete, and is missing the necessary checks to allow it to continue working with native Windows git. @edvbld @rwestberg - I submitted it this early to get your high-level feedback on whether this support is something that you have already thought about already; if not, I'd like your feedback on the approach. The idea would be to check whether we are are using a Cygwin version of git (this should be trivial), and if so, do the conversion between the `Path` strings and the input/output to the `git` command in all of the necessary places in `GitRepository` (that should be the only class that needs to be modified). ---------------- Commits: - 11270d33: WIP: 108: Command line tools fon't run with Cygwin git Changes: https://git.openjdk.java.net/skara/pull/170/files Webrev: https://webrevs.openjdk.java.net/skara/170/webrev.00 Stats: 30 lines in 2 files changed: 23 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/170.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/170/head:pull/170 PR: https://git.openjdk.java.net/skara/pull/170 From kcr at openjdk.org Mon Sep 30 21:47:33 2019 From: kcr at openjdk.org (Kevin Rushforth) Date: Mon, 30 Sep 2019 21:47:33 GMT Subject: [Rev 01] RFR: WIP: 108: Command line tools fon't run with Cygwin git In-Reply-To: References: Message-ID: The pull request has been updated with additional changes. ---------------- Added commits: - 2a580b8e: Add missing comment Changes: - all: https://git.openjdk.java.net/skara/pull/170/files - new: https://git.openjdk.java.net/skara/pull/170/files/11270d33..2a580b8e Webrevs: - full: https://webrevs.openjdk.java.net/skara/170/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/170/webrev.00-01 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/170.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/170/head:pull/170 PR: https://git.openjdk.java.net/skara/pull/170