RFR: Extend the repository configuration syntax

Erik Duveblad via github.com duke at openjdk.java.net
Tue Sep 3 08:46:32 UTC 2019


On Tue, 3 Sep 2019 08:34:31 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:

> Hi all,
> 
> Please review this change that extends the BotRunner configuration parsing of repository names. Previously, every repository had to be described one time for each host/credential set it was to be used with. Now it is allowed to specify this directly as a string of the form `<host definition name>/<actual repository name>`. Additionally, a ref name can optionally be appended of the form `:<ref name>` at the end of the string.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 78bc64f4:	Extend the repository configuration syntax, allow fetching an embedded ref name
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/116
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/116/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/116.diff
> 
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/116/head:pull/116

This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment:

Obviously correct :smile: Thanks for the tests!

PR: https://git.openjdk.java.net/skara/pull/116


More information about the skara-dev mailing list