RFR: Add support for Mercurial

Robin Westberg via github.com duke at openjdk.java.net
Mon Sep 9 13:58:14 UTC 2019


On Mon, 9 Sep 2019 13:54:43 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:

> Hi all,
> 
> this patch adds skara.py which makes it quite a bit more convenient to use the Skara tools from Mercurial (hg). I also added `--mercurial` to `git-pr` and `git-fork` so they can be used with [hg-git](https://bitbucket.org/durin42/hg-git). There are still a few minor things to work out, for example `hg pr create` does not work yet and I need to do add some help texts, but it is a start.
> 
> ## Testing
> - [x] Manual testing with git token
> 
> Thanks,
> Erik
> 
> ----------------
> 
> Commits:
>  - fadd0cd8:	Add support for Mercurial
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/122
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/122/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/122.diff
> 
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/122/head:pull/122

This PR has been reviewed by Robin Westberg via github.com - changes are approved. Review comment:

Looks good! Only had some minor comments / suggestions.

PR: https://git.openjdk.java.net/skara/pull/122

cli/src/main/java/org/openjdk/skara/cli/GitFork.java line 156:

> 155: 
> 156:         System.out.println("path: " + path);
> 157:         var fork = host.getRepository(path).fork();

Debugging printout?

PR: https://git.openjdk.java.net/skara/pull/122

skara.py line 27:

> 26: import shutil
> 27: 
> 28: cmdtable = {}

Add a testedwith line?

PR: https://git.openjdk.java.net/skara/pull/122


More information about the skara-dev mailing list