Approved and Reviewed by ehelin

Erik Helin ehelin at openjdk.org
Thu Sep 12 11:55:45 UTC 2019


On Thu, 12 Sep 2019 07:09:26 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that improves the collapse handling of multiple emails generated in a single archival run. It should only combine multiple review comments, and avoid merging top-level comments.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 06329dfe:	Improve approval mail handling
>  - 045b1ab1:	Avoid extending comments made when the PR is updated with new content
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/128
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/128/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/128.diff
> 
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/128/head:pull/128

Looks great, thanks @rwestberg for hanging in there!

----------------

Review status set to Approved by ehelin (project role: Reviewer).

This PR has been marked as Reviewed by ehelin.

PR: https://git.openjdk.java.net/skara/pull/128


More information about the skara-dev mailing list