RFR: Upgrade JUnit 5 to 5.5.1

[Erik Helin]

On Mon, 16 Sep 2019 13:41:05 GMT, Christian Stein <cstein at openjdk.org> wrote:

> On Mon, 2 Sep 2019 11:16:39 GMT, Marc Philipp via github.com <duke at openjdk.java.net> wrote:
> 
>> On Thu, 22 Aug 2019 14:10:58 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:
>> 
>>> On Thu, 22 Aug 2019 11:58:43 GMT, Christian Stein via github.com <duke at openjdk.java.net> wrote:
>>> 
>>>> Upgrade JUnit 5 to Jupiter 5.5.1 and Platform 1.5.1
>>>> 
>>>> - Set Jupiter version number 5.5.1
>>>> - Introduce Platform Launcher 1.5.1 test runtime dependency
>>>>   in order to force Gradle to load the module from the module-path
>>>> - Add missing "requires 'org.junit.jupiter.params'" directives
>>>>   in modules: jcheck, storage, vcs, and webrev
>>>> 
>>>> Solves https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69
>>>> 
>>>> ----------------
>>>> 
>>>> Commits:
>>>>  - 5e253f99:	Upgrade JUnit 5 to Jupiter 5.5.1 and Platform 1.5.1
>>>> 			- Set Jupiter version number 5.5.1
>>>> 			- Introduce Platform Launcher 1.5.1 test runtime dependency
>>>> 			in order to force Gradle to load the module from the module-path
>>>> 			- Add missing "requires 'org.junit.jupiter.params'" directives
>>>> 			in modules: jcheck, storage, vcs, and webrev
>>>> 			Solves https://bugs.openjdk.java.net/projects/SKARA/issues/SKARA-69
>>>> 
>>>> Pull request:
>>>> https://git.openjdk.java.net/skara/pull/66
>>>> 
>>>> Webrev:
>>>> https://webrevs.openjdk.java.net/skara/66/webrev.00
>>>> 
>>>> Patch:
>>>> https://git.openjdk.java.net/skara/pull/66.diff
>>>> 
>>>> Fetch command:
>>>> git fetch https://git.openjdk.java.net/skara pull/66/head:pull/66
>>> 
>>> build.gradle line 54:
>>> 
>>>> 53: 
>>>> 54:     test {
>>>> 55:         useJUnitPlatform()
>>> 
>>> Hmm, I don't really follow here - how does adding a test runtime dependency on org.junit.platform:junit-platform-launcher:1.5.1 force Gradle to load the JUnit Platform launcher from the module path? Did you forgot to `git add` a change made to `buildSrc/.../ModulePlugin.java`?
>>> 
>>> PR: https://git.openjdk.java.net/skara/pull/66
>> 
>> Gradle always puts the version of the junit-platform-launcher it ships with on the classpath. Adding `org.junit.platform:junit-platform-launcher:1.5.1` to the module path seems to hide that version from the classloader which now loads the version on the module path instead. This version is a proper module and may access the `org.junit.platform.commons.util` package of the junit-platform-commons module.
>> 
>> PR: https://git.openjdk.java.net/skara/pull/66
> 
> Before making this PR integration-ready, shall I update to JUnit 5.5.2 right away? We fixed two minor bugs: https://junit.org/junit5/docs/5.5.2/release-notes/
> 
> PR: https://git.openjdk.java.net/skara/pull/66

Lets do that as a separate PR, I will have to test that one as well. Now that I've finally finished testing and reviewing this one lets integrate it :+1:

PR: https://git.openjdk.java.net/skara/pull/66