[Approved]: RFR: Add thumbs up emoji alias

Erik Helin ehelin at openjdk.org
Tue Sep 17 11:56:47 UTC 2019


On Tue, 17 Sep 2019 11:05:55 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this minor change that adds an entry for the 👍 emoji, which we've recently encountered in the wild.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - c4bb48a4:	Add thumbs up emoji alias
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/135
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/135/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/135.diff
> 
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/135/head:pull/135

Haha, yes, I like the "thumbs up" emoji. Nice patch, looks good :+1:

----------------

Review status set to Approved by ehelin (project role: Reviewer).

PR: https://git.openjdk.java.net/skara/pull/135


More information about the skara-dev mailing list