[Approved]: RFR: 9: JDK dependencies should only be in one file

Robin Westberg rwestberg at openjdk.org
Wed Sep 18 07:23:16 UTC 2019


On Wed, 18 Sep 2019 07:18:25 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> this patch refactors the initial step of the build a bit. The JDK an Gradle dependencies are now specified in `deps.env` that both `gradlew` and `gradlew.bat` consumes. I also removed the dependency on `unzip` by writing a small Java implementation of unzip 😸 
> 
> ## Testing
> - [x] `sh gradlew test` passes on Linux x86_64
> 
> Thanks,
> Erik
> 
> ----------------
> 
> Commits:
>  - d6e823c5:	9: JDK dependencies should only be in one file
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/139
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/139/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/139.diff
> 
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/139/head:pull/139

Looks good, I hope you have tested it. :)

----------------

Review status set to Approved by rwestberg (project role: Reviewer).

PR: https://git.openjdk.java.net/skara/pull/139


More information about the skara-dev mailing list