RFR: Add support for adding an issue when formatting the commit message

Erik Helin ehelin at openjdk.org
Thu Sep 19 14:59:52 UTC 2019


On Thu, 19 Sep 2019 12:11:49 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that allows setting the issue of a commit through the PR title.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 6222eb97: Add support for adding an issue when formatting the commit message
> 
>   Stats: 97 lines in 8 files changed: 78 ins; 4 del; 15 mod
> Changes: https://git.openjdk.java.net/skara/pull/148/files
>  Webrev: https://webrevs.openjdk.java.net/skara/148/webrev.00
>   Patch: https://git.openjdk.java.net/skara/pull/148.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/148/head:pull/148

host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java line 217:

> 216:     public void setTitle(String title) {
> 217:         throw new RuntimeException("not implemented yet");
> 218:     }

Won't this be an issue if we run the unit tests as integration tests against real hosts?

host/src/main/java/org/openjdk/skara/host/gitlab/GitLabMergeRequest.java line 259:

> 258:     public void setTitle(String title) {
> 259:         throw new RuntimeException("not implemented yet");
> 260:     }

Same issue here?

PR: https://git.openjdk.java.net/skara/pull/148


More information about the skara-dev mailing list