[Approved] RFR: A generated webrev should always include index.html

Erik Helin ehelin at openjdk.org
Fri Sep 20 12:47:00 UTC 2019


On Fri, 20 Sep 2019 11:33:10 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this small change that ensures that the file size filter used when generating webrevs is not applied to the index.html file.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 36fba5e9: Never filter out index.html
> 
>   Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod
> Changes: https://git.openjdk.java.net/skara/pull/151/files
>  Webrev: https://webrevs.openjdk.java.net/skara/151/webrev.00
>   Patch: https://git.openjdk.java.net/skara/pull/151.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/151/head:pull/151

Thanks for fixing, looks good :+1:

----------------

Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/151


More information about the skara-dev mailing list