RFR: Add "binary" jcheck check

Erik Helin ehelin at openjdk.org
Tue Sep 24 10:30:24 UTC 2019


On Tue, 24 Sep 2019 10:27:35 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> On Tue, 24 Sep 2019 10:07:32 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> 
>> Hi all,
>> 
>> this patch adds a new jcheck check called "binary" that checks for binary files.
>> 
>> ## Testing
>> - `sh gradlew test` passes on Linux x86_64
>> - Added two new unit tests
>> 
>> Thanks,
>> Erik
>> 
>> ----------------
>> 
>> Commits:
>>  - 8880a50f: Add "binary" jcheck check
>> 
>> Changes: https://git.openjdk.java.net/skara/pull/159/files
>>  Webrev: https://webrevs.openjdk.java.net/skara/159/webrev.00
>>   Stats: 228 lines in 7 files changed: 228 ins; 0 del; 0 mod
>>   Patch: https://git.openjdk.java.net/skara/pull/159.diff
>>   Fetch: git fetch https://git.openjdk.java.net/skara pull/159/head:pull/159
> 
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 213:
> 
>> 212:     public void visit(BinaryIssue issue) {
>> 213:         log.fine("ignored: binary file");
>> 214:     }
> 
> Should we do something more here? Perhaps something for a follow up..

My plan was to leave that to you 😉

PR: https://git.openjdk.java.net/skara/pull/159


More information about the skara-dev mailing list