RFR: 102: Setting summary does not update the preview message

Robin Westberg rwestberg at openjdk.org
Tue Sep 24 10:32:34 UTC 2019


On Mon, 23 Sep 2019 13:08:28 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> On Mon, 23 Sep 2019 08:46:43 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
> 
>> Hi all,
>> 
>> Please review this change that ensures that the commit preview message is updated when a summary is added or updated.
>> 
>> Best regards,
>> Robin
>> 
>> ----------------
>> 
>> Commits:
>>  - 58758066: Editing a summary should update the preview message
>> 
>> Changes: https://git.openjdk.java.net/skara/pull/157/files
>>  Webrev: https://webrevs.openjdk.java.net/skara/157/webrev.00
>>   Stats: 14 lines in 2 files changed: 7 ins; 6 del; 1 mod
>>   Patch: https://git.openjdk.java.net/skara/pull/157.diff
>>   Fetch: git fetch https://git.openjdk.java.net/skara pull/157/head:pull/157
> 
> Looks good to me.
> 
> ----------------
> 
> Approved by kcr (none).

Thanks for the reviews!

PR: https://git.openjdk.java.net/skara/pull/157


More information about the skara-dev mailing list