[Approved] RFR: 52: The HgToGitConverter waits for child processes indefinitely

Erik Helin ehelin at openjdk.org
Mon Sep 30 07:44:25 UTC 2019


On Fri, 27 Sep 2019 12:41:52 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this small change that adds a timeout to the HgToGitConverter, as it seems that intermittent network problems can cause the child processes to hang.
> 
> Best regards,
> Robin
> 
> ----------------
> 
> Commits:
>  - 95304484: Kill processes if they execute more than 12 hours
> 
> Changes: https://git.openjdk.java.net/skara/pull/165/files
>  Webrev: https://webrevs.openjdk.java.net/skara/165/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/SKARA-52
>   Stats: 11 lines in 1 file changed: 10 ins; 0 del; 1 mod
>   Patch: https://git.openjdk.java.net/skara/pull/165.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/165/head:pull/165

Looks good, thanks for fixing this!

----------------

Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/165


More information about the skara-dev mailing list