RFR: webrev: do not fetch remote branches

[Robin Westberg]

On Thu, 2 Apr 2020 15:01:14 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes webrev use the branches under `remote/`
> (e.g. `origin/`) to when calculating the closest remote branch. There is no need
> to fetch the remote branches.
> 
> Testing:
> - Manual testing of `git webrev`
> 
> Thanks,
> Erik

Looks good!

cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java line 270:

> 269:                             var branchHead = repo.resolve(branch).orElseThrow();
> 270:                             var mergeBase = repo.mergeBase(branchHead, head);
> 271:                             var distance = repo.commitMetadata(mergeBase, head).size();

Now that the fetch is gone, could repo become a ReadOnlyRepository again?

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/560