RFR: webrev: do not fetch remote branches

Erik Helin ehelin at openjdk.java.net
Fri Apr 3 12:42:51 UTC 2020


On Fri, 3 Apr 2020 07:02:46 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that makes webrev use the branches under `remote/`
>> (e.g. `origin/`) to when calculating the closest remote branch. There is no need
>> to fetch the remote branches.
>> 
>> Testing:
>> - Manual testing of `git webrev`
>> 
>> Thanks,
>> Erik
>
> cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java line 270:
> 
>> 269:                             var branchHead = repo.resolve(branch).orElseThrow();
>> 270:                             var mergeBase = repo.mergeBase(branchHead, head);
>> 271:                             var distance = repo.commitMetadata(mergeBase, head).size();
> 
> Now that the fetch is gone, could repo become a ReadOnlyRepository again?

Ah right, yes! Will fix ��

-------------

PR: https://git.openjdk.java.net/skara/pull/560


More information about the skara-dev mailing list