[Rev 01] RFR: 351: /contributor command should allow GitHub and OpenJDK usernames

Robin Westberg rwestberg at openjdk.java.net
Wed Apr 8 11:59:37 UTC 2020


On Wed, 8 Apr 2020 11:42:44 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/ContributorCommand.java
>>   
>>   Co-Authored-By: Erik Duveblad <erik.helin at oracle.com>
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/ContributorCommand.java line 41:
> 
>> 40:         reply.println();
>> 41:         reply.println(" * `/contributor add @" + pr.repository().forge().name() + "-User`");
>> 42:         reply.println(" * `/contributor add duke`");
> 
> Suggestion:
> 
>         reply.println(" * `/contributor add @openjdk-bot`");

Sure, is probably safer to use a username that we control.

-------------

PR: https://git.openjdk.java.net/skara/pull/571


More information about the skara-dev mailing list