RFR: merge-bot: use commitMetadata when listing commits

Robin Westberg rwestberg at openjdk.java.net
Wed Apr 15 09:11:35 UTC 2020


On Wed, 15 Apr 2020 09:01:21 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes the automatic merge bot use `commitMetadata`
> instead of `commits` to speed up listing of large commit ranges.
> 
> Testing:
> - `make test` passes on Linux x64
> 
> Thanks,
> Erik

Looks good, just one minor comment!

bots/merge/src/main/java/org/openjdk/skara/bots/merge/MergeBot.java line 466:

> 465:
> 466:                     var commits = repo.commitMetadata(mergeBase.hex() + ".." + fetchHead.hex(), true);
> 467:                     var numCommits = commits.size();

Use the overloaded range syntax instead of manual ".."?

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/578


More information about the skara-dev mailing list