RFR: cli: add git-proxy tool

Erik Helin ehelin at openjdk.java.net
Fri Apr 17 08:52:50 UTC 2020


On Thu, 16 Apr 2020 18:22:38 GMT, Per Lidén <pliden at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that adds a small new tool: `git-proxy`. `git-proxy`
>> can be used to set up the `HTTPS_PROXY` and `HTTP_PROXY` environment
>> variables based on either the `http.proxy` configuration setting or the `-c
>> http.proxy=` argument. Finally `git-proxy` will also set up the
>> `GIT_SSH_COMMAND` environment variable to use the `CONNECT` method for tunneling
>> SSH over an HTTP proxy.
>> 
>> Testing:
>> - manual testing of `git-proxy`
>> - `make test` passes on Linux x64
>> 
>> Thanks,
>> Erik
>
> cli/src/main/java/org/openjdk/skara/cli/GitProxy.java line 58:
> 
>> 57:     }
>> 58:
>> 59:     public static void main(String[] args) throws IOException, InterruptedException {
> 
> It looks like both these methods are unused?

Oops, yes �� They are remnants from a prototype, before I realized I could just utilize the `HttpProxy` class.

-------------

PR: https://git.openjdk.java.net/skara/pull/585


More information about the skara-dev mailing list