RFR: 382: List commits that have been pushed in integration message

[Erik Helin]

On Mon, 27 Apr 2020 08:57:05 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that lists the commits that have been pushed since the PR was created (up to 10).
> 
> Best regards,
> Robin

Looks good in general, just one minor question and one minor comment ��

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 447:

> 446:             divergingCommits.stream()
> 447:                             .limit(10)
> 448:                             .forEach(c -> message.append(" * ").append(c.hash().hex()).append(":
> ").append(c.message().get(0)).append("\n"));

Will this be the most recent or the oldest 10 diverging commits?

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 450:

> 449:             if (divergingCommits.size() > 10) {
> 450:                 message.append(" * ... full list: ").append(pr.repository().webUrl(baseHash.hex(),
> pr.targetRef())).append("\n"); 451:             }

Can we say something like `* ... and 5 more: `?

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/602