RFR: 382: List commits that have been pushed in integration message

[Erik Helin]

On Mon, 27 Apr 2020 09:18:26 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 447:
>> 
>>> 446:             divergingCommits.stream()
>>> 447:                             .limit(10)
>>> 448:                             .forEach(c -> message.append(" * ").append(c.hash().hex()).append(":
>>> ").append(c.message().get(0)).append("\n"));
>> 
>> Will this be the most recent or the oldest 10 diverging commits?
>
> This should give the 10 most recent.

Sounds good ��

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 450:
>> 
>>> 449:             if (divergingCommits.size() > 10) {
>>> 450:                 message.append(" * ... full list: ").append(pr.repository().webUrl(baseHash.hex(),
>>> pr.targetRef())).append("\n"); 451:             }
>> 
>> Can we say something like `* ... and 5 more: `?
>
> Sure, but the link itself should show a full list, right?

Yeah, I think that is the best

-------------

PR: https://git.openjdk.java.net/skara/pull/602