RFR: bridgekeeper: support multiple close messages
Robin Westberg
rwestberg at openjdk.java.net
Tue Aug 18 12:28:22 UTC 2020
On Tue, 18 Aug 2020 10:03:16 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
>
> please review this small patch that allows the bridgekeeper bot to close pull requests with different messages
> depending on the type of repository.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added an additional unit test
>
> Thanks,
> Erik
Looks good, just one question!
bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/PullRequestCloserBot.java line 71:
> 70: } else {
> 71: message = "Welcome to the OpenJDK organization on GitHub!\n\n" +
> 72: "This repository does not currently accept pull requests." +
Guess this can't be reached?
-------------
Marked as reviewed by rwestberg (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/720
More information about the skara-dev
mailing list