RFR: git: commitMetadata should return commits in topo order

Robin Westberg rwestberg at openjdk.java.net
Fri Aug 21 14:58:21 UTC 2020

On Fri, 21 Aug 2020 13:39:01 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this small patch that makes `GitRepository.commitMetadata` return commits topological order (i.e. all
> parents first, then the parent). This is already done by `GitRepository.commits`.
> Testing:
> - [x] `make test` passes on Linux x64
> - [ ] Did not add a new unit test since it is hard to force commits to be returned in non-topological order
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/727

More information about the skara-dev mailing list