RFR: hg: allow tags without email

Robin Westberg rwestberg at openjdk.java.net
Sat Aug 22 08:58:07 UTC 2020

On Fri, 21 Aug 2020 15:13:01 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch which allows `HgRepository.tag` to allow a `null` argument for `authorEmail`. Mercurial does
> not require e-mails for authors, so neither should `HgRepository`.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/729

More information about the skara-dev mailing list