RFR: Mailing list filter rule generator / verifier [v3]

Erik Helin ehelin at openjdk.java.net
Mon Aug 24 12:53:49 UTC 2020

On Mon, 24 Aug 2020 12:40:10 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Hi all,
>> Please review this change that introduces the "mlrules" command, which can be used to generate and verify mailing list
>> filter rules for the jdk/jdk family of development mailing lists. These filter rules can be used by the Skara bots when
>> figuring out on which list(s) a jdk pull request should be reviewed.  The idea is that this command can be used by
>> knowledgeable OpenJDK developers to help improve the quality of the filter rules that will eventually end up being used
>> when the jdk repository starts using pull requests. Examples of usage, together with an initial version of these filter
>> rules, will be posted separately.  Best regards, Robin
> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:
>   Fix test running problem

Looks good in general! I would suggest renaming `GitDebug.java` to `SkaraDebug.java` (and `GitDebugHelp` to
`SkaraDebugHelp`). I also added a few minor inline comments.

cli/src/main/java/org/openjdk/skara/cli/GitDebug.java line 38:

> 37:                 Command.name("import-hg")
> 38:                        .helptext("convert hg to git")
> 39:                        .main(GitOpenJDKImport::main),


                       .helptext("import a hg repository")

cli/src/main/java/org/openjdk/skara/cli/GitDebug.java line 41:

> 40:                 Command.name("import-git")
> 41:                        .helptext("convert git to hg")
> 42:                        .main(GitOpenJDKImport::main),


                       .helptext("import git repository")

cli/src/main/java/org/openjdk/skara/cli/GitDebug.java line 44:

> 43:                 Command.name("verify-import")
> 44:                        .helptext("verify hg to git")
> 45:                        .main(GitVerifyImport::main),


                       .helptext("verify imported repository")

cli/src/main/java/org/openjdk/skara/cli/GitDebug.java line 53:

> 52:
> 53:         var parser = new MultiCommandParser("git debug", commands);
> 54:         var command = parser.parse(args);


        var parser = new MultiCommandParser("skara debug", commands);


Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/733

More information about the skara-dev mailing list