RFR: vcs: improve git->hg converter [v2]

Erik Helin ehelin at openjdk.java.net
Mon Aug 24 16:02:39 UTC 2020


On Mon, 24 Aug 2020 15:38:44 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove debug println
>
> vcs/src/test/java/org/openjdk/skara/vcs/openjdk/converter/GitToHgConverterTests.java line 46:
> 
>> 45:     void assertCommitEquals(ReadOnlyRepository gitRepo, Commit gitCommit, ReadOnlyRepository hgRepo, Commit
>> hgCommit) throws IOException { 46:         System.out.println("git commit: " + gitCommit.hash() + ", hg commit: " +
>> hgCommit.hash()); 47:         assertEquals(gitCommit.authored(), hgCommit.authored());
> 
> Debugging leftover?

Thanks, removed

> vcs/src/test/java/org/openjdk/skara/vcs/openjdk/converter/GitToHgConverterTests.java line 473:
> 
>> 472:
>> 473:     @Disabled("Depends on internet connection")
>> 474:     @Test
> 
> There are similar tests for the bridge bot that are skipped if there is no connection:
> 
> https://github.com/openjdk/skara/blob/269027247e5c5778560d3031476dfd0ece4e57d3/bots/hgbridge/src/test/java/org/openjdk/skara/bots/hgbridge/BridgeBotTests.java#L131
> 
> but not sure if something similar would be appropriate here as well?

Good idea, but these takes also takes a bit too long to run in addition to requiring an internet connection, so I would
prefer to leave them out for now. I might look into conditionally enable them depending on an environment variable so
that we can have them running in CI.

-------------

PR: https://git.openjdk.java.net/skara/pull/736


More information about the skara-dev mailing list