RFR: Allow '+' to be in branch names in merge PR titles [v2]

Jorn Vernee jvernee at openjdk.java.net
Wed Dec 9 16:34:50 UTC 2020


On Wed, 9 Dec 2020 16:10:41 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix test failure
>>  - Fix existing typo
>
> forge/src/main/java/org/openjdk/skara/forge/PullRequestUtils.java line 65:
> 
>> 63:         var sourceMatcher = mergeSourcePattern.matcher(pr.title());
>> 64:         if (!sourceMatcher.matches()) {
>> 65:             throw new CommitFailure("Could not determine the source for this merge. A Merge PR title must be specified of the format: `" +
> 
> Perhaps "specified *in* the format:" would sound better, but I'm not a native speaker. :)

Yeah, that sounds nicer (though I think technically both are correct).

-------------

PR: https://git.openjdk.java.net/skara/pull/970


More information about the skara-dev mailing list