From ehelin at openjdk.java.net Mon Feb 3 10:31:18 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 3 Feb 2020 10:31:18 GMT Subject: RFR: 253: Add note about git-publish to README Message-ID: <49jTuWduvX73_PTKEsqvC2WkfiF5Xu3YiMtHd1nIIPI=.95a52cd8-772a-4003-ad3a-35b0aec37701@github.com> Hi all, please review this small patch that updates the README with some info about `git-publish`. Thanks, Erik ------------- Commits: - 2dce21e2: Update the README Changes: https://git.openjdk.java.net/skara/pull/390/files Webrev: https://webrevs.openjdk.java.net/skara/390/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-253 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/390.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/390/head:pull/390 PR: https://git.openjdk.java.net/skara/pull/390 From rwestberg at openjdk.java.net Mon Feb 3 10:31:28 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 3 Feb 2020 10:31:28 GMT Subject: RFR: 253: Add note about git-publish to README In-Reply-To: <49jTuWduvX73_PTKEsqvC2WkfiF5Xu3YiMtHd1nIIPI=.95a52cd8-772a-4003-ad3a-35b0aec37701@github.com> References: <49jTuWduvX73_PTKEsqvC2WkfiF5Xu3YiMtHd1nIIPI=.95a52cd8-772a-4003-ad3a-35b0aec37701@github.com> Message-ID: On Mon, 3 Feb 2020 10:22:56 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that updates the README with some info about > `git-publish`. > > Thanks, > Erik Looks good, thanks for fixing! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/390 From ehelin at openjdk.java.net Mon Feb 3 10:40:47 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 3 Feb 2020 10:40:47 GMT Subject: [Integrated] RFR: 253: Add note about git-publish to README In-Reply-To: <49jTuWduvX73_PTKEsqvC2WkfiF5Xu3YiMtHd1nIIPI=.95a52cd8-772a-4003-ad3a-35b0aec37701@github.com> References: <49jTuWduvX73_PTKEsqvC2WkfiF5Xu3YiMtHd1nIIPI=.95a52cd8-772a-4003-ad3a-35b0aec37701@github.com> Message-ID: <1b178b75-4426-4b9d-9d0e-b3a5ee499817@openjdk.org> Changeset: ca9b2d4f Author: Erik Helin Date: 2020-02-03 10:40:30 +0000 URL: https://git.openjdk.java.net/skara/commit/ca9b2d4f 253: Add note about git-publish to README Reviewed-by: rwestberg ! README.md From ehelin at openjdk.java.net Tue Feb 4 09:15:32 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 4 Feb 2020 09:15:32 GMT Subject: RFR: Fix problem with ignoring links in Jira In-Reply-To: <2xxLf4FfTzDBCUHj-Cyfr8MCDhy8sJf7_L1ME0mMp-0=.8d573e05-25a1-49b7-af1c-002f98b987a0@github.com> References: <2xxLf4FfTzDBCUHj-Cyfr8MCDhy8sJf7_L1ME0mMp-0=.8d573e05-25a1-49b7-af1c-002f98b987a0@github.com> Message-ID: On Fri, 31 Jan 2020 15:55:09 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that avoids a potential NPE in the Jira issue handler, which can happen for external links added from another source than the Skara code. > > Best regards, > Robin Looks good, thanks for fixing! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/389 From rwestberg at openjdk.java.net Tue Feb 4 09:19:52 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 4 Feb 2020 09:19:52 GMT Subject: RFR: 251: Bypass PR update cache when the cooldown period expires for a bridge candidate In-Reply-To: References: Message-ID: On Fri, 31 Jan 2020 13:28:29 GMT, Erik Helin wrote: >> Hi all, >> >> Please review this change that ensures that the mailing list bridge bot retries the bridge operation if it was initially delayed due to the configured cooldown period. >> >> Best regards, >> Robin > > bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CooldownQuarantine.java line 46: > >> 45: public synchronized boolean inQuarantine(PullRequest pr) { >> 46: var uniqueId = getUniqueId(pr); >> 47: > > Suggestion: > > var uniqueId = pr.webUrl(); Sounds reasonable! ------------- PR: https://git.openjdk.java.net/skara/pull/388 From rwestberg at openjdk.java.net Tue Feb 4 09:25:28 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 4 Feb 2020 09:25:28 GMT Subject: RFR: 256: Multiple [Integrated] messages can still be sent Message-ID: Hi all, Please review this follow-up fix for SKARA-248. Best regards, Robin ------------- Commits: - c4c2509e: Make TestMailmanServer behave more like pipermail Changes: https://git.openjdk.java.net/skara/pull/391/files Webrev: https://webrevs.openjdk.java.net/skara/391/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-256 Stats: 31 lines in 4 files changed: 8 ins; 8 del; 15 mod Patch: https://git.openjdk.java.net/skara/pull/391.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/391/head:pull/391 PR: https://git.openjdk.java.net/skara/pull/391 From ehelin at openjdk.java.net Tue Feb 4 09:25:28 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 4 Feb 2020 09:25:28 GMT Subject: RFR: 256: Multiple [Integrated] messages can still be sent In-Reply-To: References: Message-ID: On Tue, 4 Feb 2020 09:15:31 GMT, Robin Westberg wrote: > Hi all, > > Please review this follow-up fix for SKARA-248. > > Best regards, > Robin Looks good, thanks for fixing! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/391 From rwestberg at openjdk.java.net Tue Feb 4 09:28:14 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 4 Feb 2020 09:28:14 GMT Subject: [Integrated] RFR: Fix problem with ignoring links in Jira In-Reply-To: <2xxLf4FfTzDBCUHj-Cyfr8MCDhy8sJf7_L1ME0mMp-0=.8d573e05-25a1-49b7-af1c-002f98b987a0@github.com> References: <2xxLf4FfTzDBCUHj-Cyfr8MCDhy8sJf7_L1ME0mMp-0=.8d573e05-25a1-49b7-af1c-002f98b987a0@github.com> Message-ID: Changeset: 833d8ed6 Author: Robin Westberg Date: 2020-02-04 09:27:59 +0000 URL: https://git.openjdk.java.net/skara/commit/833d8ed6 Fix problem with ignoring links in Jira Reviewed-by: ehelin ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java From rwestberg at openjdk.java.net Tue Feb 4 09:28:49 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 4 Feb 2020 09:28:49 GMT Subject: [Integrated] RFR: 256: Multiple [Integrated] messages can still be sent In-Reply-To: References: Message-ID: Changeset: 39831e68 Author: Robin Westberg Date: 2020-02-04 09:28:25 +0000 URL: https://git.openjdk.java.net/skara/commit/39831e68 256: Multiple [Integrated] messages can still be sent Reviewed-by: ehelin ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java ! test/src/main/java/org/openjdk/skara/test/TestMailmanServer.java From rwestberg at openjdk.java.net Tue Feb 4 09:40:22 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 4 Feb 2020 09:40:22 GMT Subject: [Rev 01] RFR: 251: Bypass PR update cache when the cooldown period expires for a bridge candidate In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that ensures that the mailing list bridge bot retries the bridge operation if it was initially delayed due to the configured cooldown period. > > Best regards, > Robin The pull request has been updated with 1 additional commit. ------------- Added commits: - 50386921: Remove usage of getUniqueId Changes: - all: https://git.openjdk.java.net/skara/pull/388/files - new: https://git.openjdk.java.net/skara/pull/388/files/3f5657b5..50386921 Webrevs: - full: https://webrevs.openjdk.java.net/skara/388/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/388/webrev.00-01 Stats: 24 lines in 2 files changed: 0 ins; 20 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/388.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/388/head:pull/388 PR: https://git.openjdk.java.net/skara/pull/388 From rwestberg at openjdk.java.net Tue Feb 4 12:10:09 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 4 Feb 2020 12:10:09 GMT Subject: RFR: 257: Proper setting of custom fields in Jira issues Message-ID: <0Q9qAGB3IN5j9OBnuCSK-uvC8Yyr2DxKXR3QUGkefIg=.dcb33442-a42c-4d19-8b72-d9c649253c42@github.com> Hi all, Please review this change that properly sets custom fields when creating Jira issues. Best regards, Robin ------------- Commits: - 3a6aa0bf: Properly set custom properties when creating Jira issues Changes: https://git.openjdk.java.net/skara/pull/392/files Webrev: https://webrevs.openjdk.java.net/skara/392/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-257 Stats: 34 lines in 2 files changed: 32 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/392.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/392/head:pull/392 PR: https://git.openjdk.java.net/skara/pull/392 From rwestberg at openjdk.java.net Tue Feb 4 13:15:49 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 4 Feb 2020 13:15:49 GMT Subject: RFR: 255: Improve git repository health check Message-ID: <1VHhcA1ttnETo8rfSSfnWaD4AGzXO9UXjtTVDIdYOJA=.e74ec18b-7aa6-49d9-9897-2eb3ae914727@github.com> Hi all, Please review this change that improves the accuracy of the git repository health check. Best regards, Robin ------------- Commits: - 00270149: Use git fsck for the health check Changes: https://git.openjdk.java.net/skara/pull/393/files Webrev: https://webrevs.openjdk.java.net/skara/393/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-255 Stats: 13 lines in 1 file changed: 0 ins; 11 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/393.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/393/head:pull/393 PR: https://git.openjdk.java.net/skara/pull/393 From ehelin at openjdk.java.net Tue Feb 4 16:36:23 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 4 Feb 2020 16:36:23 GMT Subject: RFR: 258: jcheck reviewers check has wrong default values Message-ID: Hi all, please review this patch that fixes the default value for the "new" style configuration of the "reviewers" check in jcheck. Testing: - added a new unit test - all unit tests pass on Linux x64 Thanks, Erik ------------- Commits: - 243f9371: skara-258 Changes: https://git.openjdk.java.net/skara/pull/394/files Webrev: https://webrevs.openjdk.java.net/skara/394/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-258 Stats: 36 lines in 2 files changed: 31 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/394.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/394/head:pull/394 PR: https://git.openjdk.java.net/skara/pull/394 From rwestberg at openjdk.java.net Tue Feb 4 16:41:13 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 4 Feb 2020 16:41:13 GMT Subject: RFR: 258: jcheck reviewers check has wrong default values In-Reply-To: References: Message-ID: On Tue, 4 Feb 2020 16:22:51 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes the default value for the "new" style > configuration of the "reviewers" check in jcheck. > > Testing: > - added a new unit test > - all unit tests pass on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/394 From ehelin at openjdk.java.net Tue Feb 4 16:42:35 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 4 Feb 2020 16:42:35 GMT Subject: [Integrated] RFR: 258: jcheck reviewers check has wrong default values In-Reply-To: References: Message-ID: <0523250d-93b4-43ec-9682-cf2124b16eeb@openjdk.org> Changeset: 1d0c6a5f Author: Erik Helin Date: 2020-02-04 16:42:19 +0000 URL: https://git.openjdk.java.net/skara/commit/1d0c6a5f 258: jcheck reviewers check has wrong default values Reviewed-by: rwestberg ! jcheck/src/main/java/org/openjdk/skara/jcheck/ReviewersConfiguration.java ! jcheck/src/test/java/org/openjdk/skara/jcheck/ReviewersCheckTests.java From ehelin at openjdk.java.net Wed Feb 5 08:23:53 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 08:23:53 GMT Subject: git: openjdk/skara: Typo in conversion from legacy jcheck conf Message-ID: Changeset: ce4ae7b9 Author: Erik Helin Date: 2020-02-05 08:23:38 +0000 URL: https://git.openjdk.java.net/skara/commit/ce4ae7b9 Typo in conversion from legacy jcheck conf Reviewed-by: rwestberg ! jcheck/src/main/java/org/openjdk/skara/jcheck/JCheckConfiguration.java ! jcheck/src/test/java/org/openjdk/skara/jcheck/ReviewersCheckTests.java From ehelin at openjdk.java.net Wed Feb 5 08:24:11 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 08:24:11 GMT Subject: RFR: Typo in conversion from legacy jcheck conf Message-ID: <-eczDBIKv1XxxltHmCFUV9fPKzLF8vCsza5GTUyj3Hg=.9c885945-b3e7-4d92-9490-ff3b3ab0b48e@github.com> Hi all, please review this patch that fixes a typo in the conversion of the old jcheck configuration format (to the more recent one introduced by Skara). Testing: - `make test` passes on Linux x64 - Added a new unit test Thanks, Erik ------------- Commits: - b0a110a3: Typo in conversion from legacy jcheck conf Changes: https://git.openjdk.java.net/skara/pull/395/files Webrev: https://webrevs.openjdk.java.net/skara/395/webrev.00 Stats: 64 lines in 2 files changed: 62 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/395.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/395/head:pull/395 PR: https://git.openjdk.java.net/skara/pull/395 From rwestberg at openjdk.java.net Wed Feb 5 08:24:23 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 5 Feb 2020 08:24:23 GMT Subject: RFR: Typo in conversion from legacy jcheck conf In-Reply-To: <-eczDBIKv1XxxltHmCFUV9fPKzLF8vCsza5GTUyj3Hg=.9c885945-b3e7-4d92-9490-ff3b3ab0b48e@github.com> References: <-eczDBIKv1XxxltHmCFUV9fPKzLF8vCsza5GTUyj3Hg=.9c885945-b3e7-4d92-9490-ff3b3ab0b48e@github.com> Message-ID: On Wed, 5 Feb 2020 08:19:48 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes a typo in the conversion of the old > jcheck configuration format (to the more recent one introduced by Skara). > > Testing: > - `make test` passes on Linux x64 > - Added a new unit test > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/395 From ehelin at openjdk.java.net Wed Feb 5 09:31:27 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 09:31:27 GMT Subject: git: openjdk/skara: 260: CSR command should handle null resolution Message-ID: Changeset: 5632c913 Author: Erik Helin Date: 2020-02-05 09:31:10 +0000 URL: https://git.openjdk.java.net/skara/commit/5632c913 260: CSR command should handle null resolution Reviewed-by: rwestberg ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CSRCommand.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CSRTests.java ! json/src/main/java/org/openjdk/skara/json/JSONArray.java ! json/src/main/java/org/openjdk/skara/json/JSONBoolean.java ! json/src/main/java/org/openjdk/skara/json/JSONDecimal.java ! json/src/main/java/org/openjdk/skara/json/JSONNumber.java ! json/src/main/java/org/openjdk/skara/json/JSONObject.java ! json/src/main/java/org/openjdk/skara/json/JSONString.java ! json/src/main/java/org/openjdk/skara/json/JSONValue.java ! json/src/test/java/org/openjdk/skara/json/JSONParserTests.java From ehelin at openjdk.java.net Wed Feb 5 09:34:44 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 09:34:44 GMT Subject: RFR: 260: CSR command should handle null resolution Message-ID: Hi all, please review this patch that fixes an issue with the `/csr` command. Issues in JBS of "CSR" type can have `null` as the value for the `"resolution"` field, something that the `CSRCommand` did not anticipate. This patch makes the `CSRCommand` much more defensive when interpreting JSON. I also added a number of methods to `JSONValue` for querying the type of a `JSONValue` to allow code to safely use the `as*` methods. Testing: - `make test` passes on Linux x64 - added a unit test that showcase the issue - added unit tests for new `JSONValue` methods Thanks, Erik ------------- Commits: - 520471ee: Ensure CSR command can handle null resolution Changes: https://git.openjdk.java.net/skara/pull/396/files Webrev: https://webrevs.openjdk.java.net/skara/396/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-260 Stats: 228 lines in 10 files changed: 226 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/396.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/396/head:pull/396 PR: https://git.openjdk.java.net/skara/pull/396 From rwestberg at openjdk.java.net Wed Feb 5 09:34:55 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 5 Feb 2020 09:34:55 GMT Subject: RFR: 260: CSR command should handle null resolution In-Reply-To: References: Message-ID: <4lJ2qZbMN6BarlaqWMD6shxEsS1BrUwSA8brS1P2YWU=.030ba1d5-4016-407b-ae79-9a94cb22b587@github.com> On Wed, 5 Feb 2020 09:28:05 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes an issue with the `/csr` command. Issues in > JBS of "CSR" type can have `null` as the value for the `"resolution"` field, > something that the `CSRCommand` did not anticipate. This patch makes the > `CSRCommand` much more defensive when interpreting JSON. > > I also added a number of methods to `JSONValue` for querying the type of a > `JSONValue` to allow code to safely use the `as*` methods. > > Testing: > - `make test` passes on Linux x64 > - added a unit test that showcase the issue > - added unit tests for new `JSONValue` methods > > Thanks, > Erik Looks good, thanks for fixing! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/396 From ehelin at openjdk.java.net Wed Feb 5 10:02:56 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 10:02:56 GMT Subject: git: openjdk/skara: Use very defensive programming in CSRCommand Message-ID: Changeset: 189ade65 Author: Erik Helin Date: 2020-02-05 10:02:39 +0000 URL: https://git.openjdk.java.net/skara/commit/189ade65 Use very defensive programming in CSRCommand Reviewed-by: rwestberg ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CSRCommand.java ! json/src/test/java/org/openjdk/skara/json/JSONParserTests.java From ehelin at openjdk.java.net Wed Feb 5 10:07:10 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 10:07:10 GMT Subject: RFR: Use very defensive programming in CSRCommand Message-ID: Hi all, please review this follow-up patch to 5632c91342c703d2197aad402492c3679762638e that uses even more defensive programming to avoid `null` pointers. Thanks, Erik ------------- Commits: - 1ff39df0: Use very defensive programming in CSRCommand Changes: https://git.openjdk.java.net/skara/pull/397/files Webrev: https://webrevs.openjdk.java.net/skara/397/webrev.00 Stats: 12 lines in 2 files changed: 10 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/397.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/397/head:pull/397 PR: https://git.openjdk.java.net/skara/pull/397 From rwestberg at openjdk.java.net Wed Feb 5 10:07:20 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 5 Feb 2020 10:07:20 GMT Subject: RFR: Use very defensive programming in CSRCommand In-Reply-To: References: Message-ID: <72a1FRXdnU3OzJngxf5znuV6sXRwhxcAtitbOFs6Y78=.fc0e6c8a-371c-4223-ae20-728ab023178e@github.com> On Wed, 5 Feb 2020 10:00:04 GMT, Erik Helin wrote: > Hi all, > > please review this follow-up patch to 5632c91342c703d2197aad402492c3679762638e > that uses even more defensive programming to avoid `null` pointers. > > Thanks, > Erik This should do it! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/397 From ehelin at openjdk.java.net Wed Feb 5 10:07:20 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 10:07:20 GMT Subject: RFR: Use very defensive programming in CSRCommand In-Reply-To: <72a1FRXdnU3OzJngxf5znuV6sXRwhxcAtitbOFs6Y78=.fc0e6c8a-371c-4223-ae20-728ab023178e@github.com> References: <72a1FRXdnU3OzJngxf5znuV6sXRwhxcAtitbOFs6Y78=.fc0e6c8a-371c-4223-ae20-728ab023178e@github.com> Message-ID: On Wed, 5 Feb 2020 10:01:30 GMT, Robin Westberg wrote: >> Hi all, >> >> please review this follow-up patch to 5632c91342c703d2197aad402492c3679762638e >> that uses even more defensive programming to avoid `null` pointers. >> >> Thanks, >> Erik > > This should do it! > This should do it! :crossed_fingers: ------------- PR: https://git.openjdk.java.net/skara/pull/397 From ehelin at openjdk.java.net Wed Feb 5 10:32:04 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 10:32:04 GMT Subject: git: openjdk/skara: Fix markdown formatting in /csr command Message-ID: Changeset: 6cc53a0c Author: Erik Helin Date: 2020-02-05 10:31:40 +0000 URL: https://git.openjdk.java.net/skara/commit/6cc53a0c Fix markdown formatting in /csr command Reviewed-by: rwestberg ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CSRCommand.java From ehelin at openjdk.java.net Wed Feb 5 10:32:52 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 10:32:52 GMT Subject: RFR: Fix markdown formatting in /csr command Message-ID: Hi all, please review this small patch that fixes some markdown formatting in the bot reply to the `/csr` command. Thanks, Erik ------------- Commits: - 20fa0e61: Fix markdown formatting in /csr command Changes: https://git.openjdk.java.net/skara/pull/398/files Webrev: https://webrevs.openjdk.java.net/skara/398/webrev.00 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/398.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/398/head:pull/398 PR: https://git.openjdk.java.net/skara/pull/398 From rwestberg at openjdk.java.net Wed Feb 5 10:33:24 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 5 Feb 2020 10:33:24 GMT Subject: RFR: Fix markdown formatting in /csr command In-Reply-To: References: Message-ID: On Wed, 5 Feb 2020 10:27:49 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that fixes some markdown formatting in the bot > reply to the `/csr` command. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/398 From ehelin at openjdk.java.net Wed Feb 5 11:01:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 11:01:19 GMT Subject: RFR: Fix git issues with merge bot Message-ID: <2zc9szyYTiyol-lsyk886bhrvifp2SvgnvuZsoia4WU=.ac526bf5-a87e-42ba-a16f-9b9f915d1a13@github.com> Hi all, please review this small patch that fixes a few issues with how the merge bot interacts with git. Thanks, Erik ------------- Commits: - 8eec5424: Fix git issues with merge bot Changes: https://git.openjdk.java.net/skara/pull/399/files Webrev: https://webrevs.openjdk.java.net/skara/399/webrev.00 Stats: 14 lines in 1 file changed: 11 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/399.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/399/head:pull/399 PR: https://git.openjdk.java.net/skara/pull/399 From rwestberg at openjdk.java.net Wed Feb 5 11:01:33 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 5 Feb 2020 11:01:33 GMT Subject: RFR: Fix git issues with merge bot In-Reply-To: <2zc9szyYTiyol-lsyk886bhrvifp2SvgnvuZsoia4WU=.ac526bf5-a87e-42ba-a16f-9b9f915d1a13@github.com> References: <2zc9szyYTiyol-lsyk886bhrvifp2SvgnvuZsoia4WU=.ac526bf5-a87e-42ba-a16f-9b9f915d1a13@github.com> Message-ID: <37W2EbzhaYMA5XVahv0KxZZvUtikPqErvBR53mmIlAs=.47d7247b-f74c-4785-8b8a-f1fa5f00a54a@github.com> On Wed, 5 Feb 2020 10:56:25 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that fixes a few issues with how the merge bot > interacts with git. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/399 From ehelin at openjdk.java.net Wed Feb 5 11:07:32 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 11:07:32 GMT Subject: [Integrated] RFR: Fix git issues with merge bot In-Reply-To: <2zc9szyYTiyol-lsyk886bhrvifp2SvgnvuZsoia4WU=.ac526bf5-a87e-42ba-a16f-9b9f915d1a13@github.com> References: <2zc9szyYTiyol-lsyk886bhrvifp2SvgnvuZsoia4WU=.ac526bf5-a87e-42ba-a16f-9b9f915d1a13@github.com> Message-ID: <10800af0-a739-465f-908d-62e3becc886d@openjdk.org> Changeset: 28d695ba Author: Erik Helin Date: 2020-02-05 11:07:19 +0000 URL: https://git.openjdk.java.net/skara/commit/28d695ba Fix git issues with merge bot Reviewed-by: rwestberg ! bots/merge/src/main/java/org/openjdk/skara/bots/merge/MergeBot.java From jvernee at openjdk.java.net Wed Feb 5 11:39:21 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Wed, 5 Feb 2020 11:39:21 GMT Subject: RFR: Improve merge bot commit message Message-ID: The current commit message the merge bot uses just says > Merge I'd like it if the message contained the branches involved as well, to be a little more informative. ------------- Commits: - 610082af: Improve merge bot commit message Changes: https://git.openjdk.java.net/skara/pull/400/files Webrev: https://webrevs.openjdk.java.net/skara/400/webrev.00 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/400.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/400/head:pull/400 PR: https://git.openjdk.java.net/skara/pull/400 From jvernee at openjdk.java.net Wed Feb 5 12:04:25 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Wed, 5 Feb 2020 12:04:25 GMT Subject: [Rev 01] RFR: Improve merge bot commit message In-Reply-To: References: Message-ID: <01RkbQh81m9tQ8Gnrt1x2UGAbai_rjypDtPHDRw1NOI=.b006f42c-90bc-40e7-b957-0c2cb25c7a2f@github.com> > The current commit message the merge bot uses just says > >> Merge > > I'd like it if the message contained the branches involved as well, to be a little more informative. The pull request has been updated with 1 additional commit. ------------- Added commits: - 17e49484: Update tests as well Changes: - all: https://git.openjdk.java.net/skara/pull/400/files - new: https://git.openjdk.java.net/skara/pull/400/files/610082af..17e49484 Webrevs: - full: https://webrevs.openjdk.java.net/skara/400/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/400/webrev.00-01 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/400.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/400/head:pull/400 PR: https://git.openjdk.java.net/skara/pull/400 From joe.darcy at oracle.com Wed Feb 5 12:12:38 2020 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 5 Feb 2020 04:12:38 -0800 Subject: FYI, slides about Skara from OCW Feb 2020, Brussels Message-ID: <16955769-d1ac-31df-ab16-135b565ad3cd@oracle.com> FYI, http://cr.openjdk.java.net/~darcy/Presentations/OCW/owc-2020-02-skara-update.pdf Cheers, -Joe From ehelin at openjdk.java.net Wed Feb 5 13:51:33 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 13:51:33 GMT Subject: RFR: Improve merge bot commit message In-Reply-To: References: Message-ID: On Wed, 5 Feb 2020 11:34:23 GMT, Jorn Vernee wrote: > The current commit message the merge bot uses just says > >> Merge > > I'd like it if the message contained the branches involved as well, to be a little more informative. This patch changes the message to for instance: > >> Merge branch: 'branchA' into: 'branchB' How about "Automatic merge of into "? Just to make it clear that the merge was done automatically. ------------- PR: https://git.openjdk.java.net/skara/pull/400 From jvernee at openjdk.java.net Wed Feb 5 13:52:05 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Wed, 5 Feb 2020 13:52:05 GMT Subject: RFR: Improve merge bot commit message In-Reply-To: References: Message-ID: On Wed, 5 Feb 2020 13:51:17 GMT, Erik Helin wrote: >> The current commit message the merge bot uses just says >> >>> Merge >> >> I'd like it if the message contained the branches involved as well, to be a little more informative. This patch changes the message to for instance: >> >>> Merge branch: 'branchA' into: 'branchB' > > How about "Automatic merge of branchA into branchB"? Just to make it clear that the merge was done automatically. > > > How about "Automatic merge of into "? Just to make it clear that the merge was done automatically. Yes, good idea! ------------- PR: https://git.openjdk.java.net/skara/pull/400 From jvernee at openjdk.java.net Wed Feb 5 14:05:43 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Wed, 5 Feb 2020 14:05:43 GMT Subject: [Rev 02] RFR: Improve merge bot commit message In-Reply-To: References: Message-ID: > The current commit message the merge bot uses just says > >> Merge > > I'd like it if the message contained the branches involved as well, to be a little more informative. This patch changes the message to for instance: > >> Merge branch: 'branchA' into: 'branchB' The pull request has been updated with 1 additional commit. ------------- Added commits: - 1764e3bd: Add information to commit message saying that it's automatic Changes: - all: https://git.openjdk.java.net/skara/pull/400/files - new: https://git.openjdk.java.net/skara/pull/400/files/17e49484..1764e3bd Webrevs: - full: https://webrevs.openjdk.java.net/skara/400/webrev.02 - incr: https://webrevs.openjdk.java.net/skara/400/webrev.01-02 Stats: 7 lines in 2 files changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/400.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/400/head:pull/400 PR: https://git.openjdk.java.net/skara/pull/400 From jvernee at openjdk.java.net Wed Feb 5 14:17:26 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Wed, 5 Feb 2020 14:17:26 GMT Subject: [Rev 03] RFR: Improve merge bot commit message In-Reply-To: References: Message-ID: > The current commit message the merge bot uses just says > >> Merge > > I'd like it if the message contained the branches involved as well, to be a little more informative. This patch changes the message to for instance: > >> Merge branch: 'branchA' into: 'branchB' Previous commits in this pull request have been removed, probably due to a force push. The incremental views will show differences compared to the previous content of the PR. ------------- Added commits: - 8ebfcdab: Add information to commit message saying that it's automatic Changes: - all: https://git.openjdk.java.net/skara/pull/400/files - new: https://git.openjdk.java.net/skara/pull/400/files/1764e3bd..8ebfcdab Webrevs: - full: https://webrevs.openjdk.java.net/skara/400/webrev.03 - incr: https://webrevs.openjdk.java.net/skara/400/webrev.02-03 Stats: 7 lines in 2 files changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/400.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/400/head:pull/400 PR: https://git.openjdk.java.net/skara/pull/400 From ehelin at openjdk.java.net Wed Feb 5 14:44:23 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 14:44:23 GMT Subject: [Rev 03] RFR: Improve merge bot commit message In-Reply-To: References: Message-ID: On Wed, 5 Feb 2020 14:44:23 GMT, Jorn Vernee wrote: >> The current commit message the merge bot uses just says >> >>> Merge >> >> I'd like it if the message contained the branches involved as well, to be a little more informative. This patch changes the message to for instance: >> >>> Merge branch: 'branchA' into: 'branchB' > > Previous commits in this pull request have been removed, probably due to a force push. The incremental views will show differences compared to the previous content of the PR. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/400 From jvernee at openjdk.java.net Wed Feb 5 14:47:13 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Wed, 5 Feb 2020 14:47:13 GMT Subject: [Integrated] RFR: Improve merge bot commit message In-Reply-To: References: Message-ID: <95c69682-c8d2-4050-b65e-9d56c739fe2c@openjdk.org> Changeset: 5c96b1cc Author: Jorn Vernee Date: 2020-02-05 14:46:59 +0000 URL: https://git.openjdk.java.net/skara/commit/5c96b1cc Improve merge bot commit message Reviewed-by: ehelin ! bots/merge/src/main/java/org/openjdk/skara/bots/merge/MergeBot.java ! bots/merge/src/test/java/org/openjdk/skara/bots/merge/MergeBotTests.java From ehelin at openjdk.java.net Wed Feb 5 15:11:02 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 15:11:02 GMT Subject: git: openjdk/skara: Do not use pull in merge bot Message-ID: <84e52f6d-b223-4c8a-9c0b-15e007a6c59e@openjdk.org> Changeset: c80ca805 Author: Erik Helin Date: 2020-02-05 15:10:49 +0000 URL: https://git.openjdk.java.net/skara/commit/c80ca805 Do not use pull in merge bot Reviewed-by: rwestberg ! bots/merge/src/main/java/org/openjdk/skara/bots/merge/MergeBot.java ! vcs/src/main/java/org/openjdk/skara/vcs/Repository.java ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java From ehelin at openjdk.java.net Wed Feb 5 15:13:22 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 5 Feb 2020 15:13:22 GMT Subject: RFR: Do not use pull in merge bot Message-ID: Hi all, please review this patch that ensures that merge bot do not use pull (it should only use merge operations). Thanks, Erik ------------- Commits: - c32e82de: Do not use pull in merge bot Changes: https://git.openjdk.java.net/skara/pull/401/files Webrev: https://webrevs.openjdk.java.net/skara/401/webrev.00 Stats: 38 lines in 4 files changed: 23 ins; 7 del; 8 mod Patch: https://git.openjdk.java.net/skara/pull/401.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/401/head:pull/401 PR: https://git.openjdk.java.net/skara/pull/401 From rwestberg at openjdk.java.net Wed Feb 5 15:13:33 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 5 Feb 2020 15:13:33 GMT Subject: RFR: Do not use pull in merge bot In-Reply-To: References: Message-ID: On Wed, 5 Feb 2020 15:06:45 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that merge bot do not use pull (it should > only use merge operations). > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/401 From ehelin at openjdk.java.net Thu Feb 6 09:21:25 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 6 Feb 2020 09:21:25 GMT Subject: RFR: 255: Improve git repository health check In-Reply-To: <1VHhcA1ttnETo8rfSSfnWaD4AGzXO9UXjtTVDIdYOJA=.e74ec18b-7aa6-49d9-9897-2eb3ae914727@github.com> References: <1VHhcA1ttnETo8rfSSfnWaD4AGzXO9UXjtTVDIdYOJA=.e74ec18b-7aa6-49d9-9897-2eb3ae914727@github.com> Message-ID: On Tue, 4 Feb 2020 13:09:02 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that improves the accuracy of the git repository health check. > > Best regards, > Robin Looks good, thanks for fixing! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/393 From erik.helin at oracle.com Thu Feb 6 09:46:39 2020 From: erik.helin at oracle.com (Erik Helin) Date: Thu, 6 Feb 2020 10:46:39 +0100 Subject: CFV: New Skara Reviewer: Jorn Vernee Message-ID: <227f202d-0002-4441-d6a1-c1a69a1b8527@oracle.com> I hereby nominate Jorn Vernee to Skara Reviewer. Jorn has so far made 17 commits to the Skara project, reviewed numerous patches and also contributed a larger body of work in the form of the topological merge bot. Jorn has showed excellent understanding of the Skara source code and has provided relevant and on-the-point feedback in his reviews. Votes are due by February 20 11:00 CET. Only current Skara Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [2]. Thanks, Erik [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#reviewer-vote From erik.helin at oracle.com Thu Feb 6 09:47:27 2020 From: erik.helin at oracle.com (Erik Helin) Date: Thu, 6 Feb 2020 10:47:27 +0100 Subject: CFV: New Skara Reviewer: Jorn Vernee In-Reply-To: <227f202d-0002-4441-d6a1-c1a69a1b8527@oracle.com> References: <227f202d-0002-4441-d6a1-c1a69a1b8527@oracle.com> Message-ID: <597b7b94-bb1e-d333-60e4-cf10f425e021@oracle.com> Vote: yes Thanks, Erik On 2/6/20 10:46 AM, Erik Helin wrote: > I hereby nominate Jorn Vernee to Skara Reviewer. > > Jorn has so far made 17 commits to the Skara project, reviewed numerous > patches and also contributed a larger body of work in the form of the > topological merge bot. Jorn has showed excellent understanding of the > Skara source code and has provided relevant and on-the-point feedback in > his reviews. > > Votes are due by February 20 11:00 CET. > > Only current Skara Reviewers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying > to this mailing list. > > For Three-Vote Consensus voting instructions, see [2]. > > Thanks, > Erik > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote From ehelin at openjdk.java.net Thu Feb 6 09:53:32 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 6 Feb 2020 09:53:32 GMT Subject: RFR: 257: Proper setting of custom fields in Jira issues In-Reply-To: <0Q9qAGB3IN5j9OBnuCSK-uvC8Yyr2DxKXR3QUGkefIg=.dcb33442-a42c-4d19-8b72-d9c649253c42@github.com> References: <0Q9qAGB3IN5j9OBnuCSK-uvC8Yyr2DxKXR3QUGkefIg=.dcb33442-a42c-4d19-8b72-d9c649253c42@github.com> Message-ID: On Tue, 4 Feb 2020 12:05:33 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that properly sets custom fields when creating Jira issues. > > Best regards, > Robin Looks good! Just a minor nit: since this patch was created the `JSON` API has gotten the possibility to query `JSONValue` objects for their type using `is*` methods (e.g. `isObject()`). If you merge master into this PR then you will be able to use these new methods ?? issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java line 204: > 203: } > 204: if (unfiltered instanceof JSONObject) { > 205: if (unfiltered.asObject().contains("id")) { Suggestion: if (unfiltered.isObject()) { ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/392 From ehelin at openjdk.java.net Thu Feb 6 09:54:33 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 6 Feb 2020 09:54:33 GMT Subject: [Rev 01] RFR: 251: Bypass PR update cache when the cooldown period expires for a bridge candidate In-Reply-To: References: Message-ID: <1npkafkzi0Ui7cJUT0fuUY6i7Sy7jBl28rn3V-QWf6A=.52d738df-12a4-46d5-a15d-f9733ad82cfa@github.com> On Thu, 6 Feb 2020 09:54:33 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this change that ensures that the mailing list bridge bot retries the bridge operation if it was initially delayed due to the configured cooldown period. >> >> Best regards, >> Robin > > The pull request has been updated with 1 additional commit. Looks good, thanks for the update! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/388 From rwestberg at openjdk.java.net Thu Feb 6 09:56:19 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 6 Feb 2020 09:56:19 GMT Subject: RFR: 266: Allow getting commit metadata for a range Message-ID: Hi all, Please review this change that implements getting commit metadata for a range (for git repositories). This is in turn used in a few places in the bots where the full commit information isn't needed, such as counting them. Best regards, Robin ------------- Commits: - 7af18a94: Allow getting commit metadata for a range Changes: https://git.openjdk.java.net/skara/pull/402/files Webrev: https://webrevs.openjdk.java.net/skara/402/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-266 Stats: 49 lines in 6 files changed: 33 ins; 1 del; 15 mod Patch: https://git.openjdk.java.net/skara/pull/402.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/402/head:pull/402 PR: https://git.openjdk.java.net/skara/pull/402 From ehelin at openjdk.java.net Thu Feb 6 09:56:29 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 6 Feb 2020 09:56:29 GMT Subject: RFR: 266: Allow getting commit metadata for a range In-Reply-To: References: Message-ID: On Thu, 6 Feb 2020 09:44:45 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that implements getting commit metadata for a range (for git repositories). This is in turn used in a few places in the bots where the full commit information isn't needed, such as counting them. > > Best regards, > Robin Looks good, I can take care of the Mercurial implementation. ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/402 From robin.westberg at oracle.com Thu Feb 6 09:59:02 2020 From: robin.westberg at oracle.com (Robin Westberg) Date: Thu, 6 Feb 2020 10:59:02 +0100 Subject: CFV: New Skara Reviewer: Jorn Vernee In-Reply-To: <227f202d-0002-4441-d6a1-c1a69a1b8527@oracle.com> References: <227f202d-0002-4441-d6a1-c1a69a1b8527@oracle.com> Message-ID: <38942B19-7015-4C02-A3D8-AD74FACA31E0@oracle.com> Vote: yes Best regards, Robin > On 6 Feb 2020, at 10:46, Erik Helin wrote: > > I hereby nominate Jorn Vernee to Skara Reviewer. > > Jorn has so far made 17 commits to the Skara project, reviewed numerous patches and also contributed a larger body of work in the form of the topological merge bot. Jorn has showed excellent understanding of the Skara source code and has provided relevant and on-the-point feedback in his reviews. > > Votes are due by February 20 11:00 CET. > > Only current Skara Reviewers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Three-Vote Consensus voting instructions, see [2]. > > Thanks, > Erik > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote From rwestberg at openjdk.java.net Thu Feb 6 10:03:39 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 6 Feb 2020 10:03:39 GMT Subject: [Integrated] RFR: 266: Allow getting commit metadata for a range In-Reply-To: References: Message-ID: Changeset: c08e9a6d Author: Robin Westberg Date: 2020-02-06 10:03:19 +0000 URL: https://git.openjdk.java.net/skara/commit/c08e9a6d 266: Allow getting commit metadata for a range Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryWorkItem.java ! jcheck/src/test/java/org/openjdk/skara/jcheck/TestRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java From rwestberg at openjdk.java.net Thu Feb 6 10:04:05 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 6 Feb 2020 10:04:05 GMT Subject: [Integrated] RFR: 255: Improve git repository health check In-Reply-To: <1VHhcA1ttnETo8rfSSfnWaD4AGzXO9UXjtTVDIdYOJA=.e74ec18b-7aa6-49d9-9897-2eb3ae914727@github.com> References: <1VHhcA1ttnETo8rfSSfnWaD4AGzXO9UXjtTVDIdYOJA=.e74ec18b-7aa6-49d9-9897-2eb3ae914727@github.com> Message-ID: <2c1083af-da30-44b2-ad98-182ee7786234@openjdk.org> Changeset: ca0bc833 Author: Robin Westberg Date: 2020-02-06 10:03:47 +0000 URL: https://git.openjdk.java.net/skara/commit/ca0bc833 255: Improve git repository health check Reviewed-by: ehelin ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java From rwestberg at openjdk.java.net Thu Feb 6 10:13:21 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 6 Feb 2020 10:13:21 GMT Subject: [Rev 01] RFR: 266: Allow getting commit metadata for a range In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that implements getting commit metadata for a range (for git repositories). This is in turn used in a few places in the bots where the full commit information isn't needed, such as counting them. > > Best regards, > Robin The pull request has been updated with 1 additional commit. ------------- Added commits: - 69c43d7b: Remove too verbose toString method Changes: - all: https://git.openjdk.java.net/skara/pull/402/files - new: https://git.openjdk.java.net/skara/pull/402/files/7af18a94..69c43d7b Webrevs: - full: https://webrevs.openjdk.java.net/skara/402/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/402/webrev.00-01 Stats: 12 lines in 1 file changed: 0 ins; 12 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/402.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/402/head:pull/402 PR: https://git.openjdk.java.net/skara/pull/402 From joe.darcy at oracle.com Thu Feb 6 10:17:41 2020 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 6 Feb 2020 02:17:41 -0800 Subject: CFV: New Skara Reviewer: Jorn Vernee In-Reply-To: <227f202d-0002-4441-d6a1-c1a69a1b8527@oracle.com> References: <227f202d-0002-4441-d6a1-c1a69a1b8527@oracle.com> Message-ID: <755db6c3-ee10-e1ad-8e0f-1a70fe9a6774@oracle.com> Vote: yes -Joe On 2/6/2020 1:46 AM, Erik Helin wrote: > I hereby nominate Jorn Vernee to Skara Reviewer. > > Jorn has so far made 17 commits to the Skara project, reviewed > numerous patches and also contributed a larger body of work in the > form of the topological merge bot. Jorn has showed excellent > understanding of the Skara source code and has provided relevant and > on-the-point feedback in his reviews. > > Votes are due by February 20 11:00 CET. > > Only current Skara Reviewers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying > to this mailing list. > > For Three-Vote Consensus voting instructions, see [2]. > > Thanks, > Erik > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote From rwestberg at openjdk.java.net Thu Feb 6 10:31:39 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 6 Feb 2020 10:31:39 GMT Subject: [Integrated] RFR: 257: Proper setting of custom fields in Jira issues In-Reply-To: <0Q9qAGB3IN5j9OBnuCSK-uvC8Yyr2DxKXR3QUGkefIg=.dcb33442-a42c-4d19-8b72-d9c649253c42@github.com> References: <0Q9qAGB3IN5j9OBnuCSK-uvC8Yyr2DxKXR3QUGkefIg=.dcb33442-a42c-4d19-8b72-d9c649253c42@github.com> Message-ID: Changeset: 72c721a2 Author: Robin Westberg Date: 2020-02-06 10:31:19 +0000 URL: https://git.openjdk.java.net/skara/commit/72c721a2 257: Proper setting of custom fields in Jira issues Reviewed-by: ehelin ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java From rwestberg at openjdk.java.net Thu Feb 6 10:32:05 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 6 Feb 2020 10:32:05 GMT Subject: [Integrated] RFR: 251: Bypass PR update cache when the cooldown period expires for a bridge candidate In-Reply-To: References: Message-ID: <08f5ca1c-8898-4a65-b583-ca6fafb3c741@openjdk.org> Changeset: 3cbdfd40 Author: Robin Westberg Date: 2020-02-06 10:31:47 +0000 URL: https://git.openjdk.java.net/skara/commit/3cbdfd40 251: Bypass PR update cache when the cooldown period expires for a bridge candidate Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java + bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CooldownQuarantine.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java ! forge/src/main/java/org/openjdk/skara/forge/PullRequestUpdateCache.java From rwestberg at openjdk.java.net Thu Feb 6 10:39:28 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 6 Feb 2020 10:39:28 GMT Subject: [Rev 01] RFR: 257: Proper setting of custom fields in Jira issues In-Reply-To: <0Q9qAGB3IN5j9OBnuCSK-uvC8Yyr2DxKXR3QUGkefIg=.dcb33442-a42c-4d19-8b72-d9c649253c42@github.com> References: <0Q9qAGB3IN5j9OBnuCSK-uvC8Yyr2DxKXR3QUGkefIg=.dcb33442-a42c-4d19-8b72-d9c649253c42@github.com> Message-ID: > Hi all, > > Please review this change that properly sets custom fields when creating Jira issues. > > Best regards, > Robin The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Added commits: - 53c9e887: Updated after review - 901e0ea1: Merge remote-tracking branch 'upstream/master' into issue_properties - ca0bc833: 255: Improve git repository health check - c08e9a6d: 266: Allow getting commit metadata for a range - c80ca805: Do not use pull in merge bot - 5c96b1cc: Improve merge bot commit message - 28d695ba: Fix git issues with merge bot - 6cc53a0c: Fix markdown formatting in /csr command - 189ade65: Use very defensive programming in CSRCommand - 5632c913: 260: CSR command should handle null resolution - ce4ae7b9: Typo in conversion from legacy jcheck conf - 1d0c6a5f: 258: jcheck reviewers check has wrong default values - 39831e68: 256: Multiple [Integrated] messages can still be sent - 833d8ed6: Fix problem with ignoring links in Jira Changes: - all: https://git.openjdk.java.net/skara/pull/392/files - new: https://git.openjdk.java.net/skara/pull/392/files/3a6aa0bf..53c9e887 Webrevs: - full: https://webrevs.openjdk.java.net/skara/392/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/392/webrev.00-01 Stats: 472 lines in 28 files changed: 387 ins; 21 del; 64 mod Patch: https://git.openjdk.java.net/skara/pull/392.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/392/head:pull/392 PR: https://git.openjdk.java.net/skara/pull/392 From ehelin at openjdk.java.net Thu Feb 6 10:52:41 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 6 Feb 2020 10:52:41 GMT Subject: RFR: Add toString methods to all WorkItems Message-ID: <2jcOjNdd_e_CX8HbRytPZ-LKrM2CunXz9hqGNJeZgeY=.f20b894a-da1d-4dfc-8d26-d3a04253e95f@github.com> Hi all, please review this small patch that adds proper `toString` implementations to all classes implementing `WorkItem` (to get better logging). Thanks, Erik ------------- Commits: - 1f8ffb73: Add toString methods to all WorkItems Changes: https://git.openjdk.java.net/skara/pull/403/files Webrev: https://webrevs.openjdk.java.net/skara/403/webrev.00 Stats: 24 lines in 8 files changed: 20 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/403.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/403/head:pull/403 PR: https://git.openjdk.java.net/skara/pull/403 From rwestberg at openjdk.java.net Thu Feb 6 10:52:56 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 6 Feb 2020 10:52:56 GMT Subject: RFR: Add toString methods to all WorkItems In-Reply-To: <2jcOjNdd_e_CX8HbRytPZ-LKrM2CunXz9hqGNJeZgeY=.f20b894a-da1d-4dfc-8d26-d3a04253e95f@github.com> References: <2jcOjNdd_e_CX8HbRytPZ-LKrM2CunXz9hqGNJeZgeY=.f20b894a-da1d-4dfc-8d26-d3a04253e95f@github.com> Message-ID: <9Oiq-nncfo0x4JTK-YjAr_oCEcCSHGgSQ8Evjd0uP-M=.e61bb068-45d6-45e2-a843-a4d16e63da25@github.com> On Thu, 6 Feb 2020 10:47:09 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that adds proper `toString` implementations to > all classes implementing `WorkItem` (to get better logging). > > Thanks, > Erik Looks good, just one pre-existing inconsistent spacing issue. bots/mirror/src/main/java/org/openjdk/skara/bots/mirror/MirrorBot.java line 88: > 87: public String toString() { > 88: return "MirrorBot@" + from.name() + "-> " + to.name(); > 89: } Suggestion: return "MirrorBot@" + from.name() + " -> " + to.name(); ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/403 From rwestberg at openjdk.java.net Thu Feb 6 10:52:57 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 6 Feb 2020 10:52:57 GMT Subject: RFR: Add toString methods to all WorkItems In-Reply-To: <9Oiq-nncfo0x4JTK-YjAr_oCEcCSHGgSQ8Evjd0uP-M=.e61bb068-45d6-45e2-a843-a4d16e63da25@github.com> References: <2jcOjNdd_e_CX8HbRytPZ-LKrM2CunXz9hqGNJeZgeY=.f20b894a-da1d-4dfc-8d26-d3a04253e95f@github.com> <9Oiq-nncfo0x4JTK-YjAr_oCEcCSHGgSQ8Evjd0uP-M=.e61bb068-45d6-45e2-a843-a4d16e63da25@github.com> Message-ID: On Thu, 6 Feb 2020 10:49:56 GMT, Robin Westberg wrote: >> Hi all, >> >> please review this small patch that adds proper `toString` implementations to >> all classes implementing `WorkItem` (to get better logging). >> >> Thanks, >> Erik > > bots/mirror/src/main/java/org/openjdk/skara/bots/mirror/MirrorBot.java line 88: > >> 87: public String toString() { >> 88: return "MirrorBot@" + from.name() + "-> " + to.name(); >> 89: } > > Suggestion: > > return "MirrorBot@" + from.name() + " -> " + to.name(); Or the other way around ?? ------------- PR: https://git.openjdk.java.net/skara/pull/403 From rwestberg at openjdk.java.net Thu Feb 6 10:59:54 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 6 Feb 2020 10:59:54 GMT Subject: RFR: 267: Be more tolerant when parsing mbox files Message-ID: Hi all, Please review this change that allows parsing of mail id's encountered in the wild. Best regards, Robin ------------- Commits: - 53967ac3: Allow parsing email addresses without any domain Changes: https://git.openjdk.java.net/skara/pull/404/files Webrev: https://webrevs.openjdk.java.net/skara/404/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-267 Stats: 18 lines in 2 files changed: 12 ins; 1 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/404.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/404/head:pull/404 PR: https://git.openjdk.java.net/skara/pull/404 From ehelin at openjdk.java.net Thu Feb 6 11:05:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 6 Feb 2020 11:05:17 GMT Subject: [Integrated] RFR: Add toString methods to all WorkItems In-Reply-To: <2jcOjNdd_e_CX8HbRytPZ-LKrM2CunXz9hqGNJeZgeY=.f20b894a-da1d-4dfc-8d26-d3a04253e95f@github.com> References: <2jcOjNdd_e_CX8HbRytPZ-LKrM2CunXz9hqGNJeZgeY=.f20b894a-da1d-4dfc-8d26-d3a04253e95f@github.com> Message-ID: <4bdf5904-952b-44a4-88e8-86570209ae0b@openjdk.org> Changeset: feb2fcc0 Author: Erik Helin Date: 2020-02-06 11:05:01 +0000 URL: https://git.openjdk.java.net/skara/commit/feb2fcc0 Add toString methods to all WorkItems Reviewed-by: rwestberg ! bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/PullRequestCloserBot.java ! bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/PullRequestPrunerBot.java ! bots/csr/src/main/java/org/openjdk/skara/bots/csr/CSRBot.java ! bots/mirror/src/main/java/org/openjdk/skara/bots/mirror/MirrorBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CommentPosterWorkItem.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandWorkItem.java ! bots/topological/src/main/java/org/openjdk/skara/bots/topological/TopologicalBot.java From ehelin at openjdk.java.net Thu Feb 6 11:05:30 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 6 Feb 2020 11:05:30 GMT Subject: [Rev 01] RFR: Add toString methods to all WorkItems In-Reply-To: <2jcOjNdd_e_CX8HbRytPZ-LKrM2CunXz9hqGNJeZgeY=.f20b894a-da1d-4dfc-8d26-d3a04253e95f@github.com> References: <2jcOjNdd_e_CX8HbRytPZ-LKrM2CunXz9hqGNJeZgeY=.f20b894a-da1d-4dfc-8d26-d3a04253e95f@github.com> Message-ID: > Hi all, > > please review this small patch that adds proper `toString` implementations to > all classes implementing `WorkItem` (to get better logging). > > Thanks, > Erik The pull request has been updated with 1 additional commit. ------------- Added commits: - c03d9287: Update bots/mirror/src/main/java/org/openjdk/skara/bots/mirror/MirrorBot.java Changes: - all: https://git.openjdk.java.net/skara/pull/403/files - new: https://git.openjdk.java.net/skara/pull/403/files/1f8ffb73..c03d9287 Webrevs: - full: https://webrevs.openjdk.java.net/skara/403/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/403/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/403.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/403/head:pull/403 PR: https://git.openjdk.java.net/skara/pull/403 From ehelin at openjdk.java.net Thu Feb 6 11:06:01 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 6 Feb 2020 11:06:01 GMT Subject: RFR: 267: Be more tolerant when parsing mbox files In-Reply-To: References: Message-ID: On Thu, 6 Feb 2020 10:48:56 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows parsing of mail id's encountered in the wild. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/404 From rwestberg at openjdk.java.net Thu Feb 6 11:09:27 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 6 Feb 2020 11:09:27 GMT Subject: [Integrated] RFR: 267: Be more tolerant when parsing mbox files In-Reply-To: References: Message-ID: Changeset: 6e9e58b7 Author: Robin Westberg Date: 2020-02-06 11:09:10 +0000 URL: https://git.openjdk.java.net/skara/commit/6e9e58b7 267: Be more tolerant when parsing mbox files Reviewed-by: ehelin ! email/src/main/java/org/openjdk/skara/email/EmailAddress.java ! email/src/test/java/org/openjdk/skara/email/EmailAddressTests.java From ehelin at openjdk.java.net Thu Feb 6 11:10:42 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 6 Feb 2020 11:10:42 GMT Subject: RFR: git-pr: friendly help message when missing action Message-ID: Hi all, please review this small patch that makes `git pr` print a more friendly help message when no action is specified. Testing: - Manual testing of `git pr` Thanks, Erik ------------- Commits: - 29e950c6: git-pr: friendly help message when missing action Changes: https://git.openjdk.java.net/skara/pull/405/files Webrev: https://webrevs.openjdk.java.net/skara/405/webrev.00 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/405.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/405/head:pull/405 PR: https://git.openjdk.java.net/skara/pull/405 From rwestberg at openjdk.java.net Thu Feb 6 11:10:42 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 6 Feb 2020 11:10:42 GMT Subject: RFR: git-pr: friendly help message when missing action In-Reply-To: References: Message-ID: <01e1U2pla7ph4Xoo7YjgDeM-ojXatbfiSR7LVGjhtEU=.895281dc-1613-4e70-bd96-c494ecc20339@github.com> On Thu, 6 Feb 2020 11:03:05 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes `git pr` print a more friendly help > message when no action is specified. > > Testing: > - Manual testing of `git pr` > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/405 From ehelin at openjdk.java.net Thu Feb 6 11:12:45 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 6 Feb 2020 11:12:45 GMT Subject: [Integrated] RFR: git-pr: friendly help message when missing action In-Reply-To: References: Message-ID: Changeset: a57c1319 Author: Erik Helin Date: 2020-02-06 11:12:29 +0000 URL: https://git.openjdk.java.net/skara/commit/a57c1319 git-pr: friendly help message when missing action Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java From rwestberg at openjdk.java.net Fri Feb 7 06:48:08 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 7 Feb 2020 06:48:08 GMT Subject: git: openjdk/skara: Avoid running the mailing list bridge too often Message-ID: Changeset: b5f92284 Author: Robin Westberg Date: 2020-02-07 06:47:51 +0000 URL: https://git.openjdk.java.net/skara/commit/b5f92284 Avoid running the mailing list bridge too often Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CooldownQuarantine.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java From ehelin at openjdk.java.net Fri Feb 7 07:15:09 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 7 Feb 2020 07:15:09 GMT Subject: RFR: merge-bot: clearer merge messages when merging between repos Message-ID: Hi all, please review this small patch that makes the commit message a bit clearer when the merge bot merges branches in _different_ repositories. For example, if the bot merges openjdk/jdk:master to openjdk/panama-foreign:master, the message will now be: > Automatic merge of jdk:master into master Testing: - `make test` passes on Linux x64 - Updated unit tests to test for new message style Thanks, Erik ------------- Commits: - e6c53da6: merge-bot: clearer merge messages when merging between repos Changes: https://git.openjdk.java.net/skara/pull/407/files Webrev: https://webrevs.openjdk.java.net/skara/407/webrev.00 Stats: 10 lines in 2 files changed: 3 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/407.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/407/head:pull/407 PR: https://git.openjdk.java.net/skara/pull/407 From rwestberg at openjdk.java.net Fri Feb 7 07:15:19 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 7 Feb 2020 07:15:19 GMT Subject: RFR: merge-bot: clearer merge messages when merging between repos In-Reply-To: References: Message-ID: On Fri, 7 Feb 2020 07:06:56 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes the commit message a bit clearer when > the merge bot merges branches in _different_ repositories. For example, if the > bot merges openjdk/jdk:master to openjdk/panama-foreign:master, the message will > now be: > >> Automatic merge of jdk:master into master > > Testing: > - `make test` passes on Linux x64 > - Updated unit tests to test for new message style > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/407 From ehelin at openjdk.java.net Fri Feb 7 07:31:24 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 7 Feb 2020 07:31:24 GMT Subject: RFR: git-sync: use ref names instead of hashes Message-ID: Hi all, please review this small patch that makes `git sync` avoid using SHA-1 hashes when executing `git fetch`. There was nothing wrong with this approach, but older `git` clients have problems when the ref to fetch is a SHA-1 hash. There is no drawback in using the ref name instead, it only increases compatibility with older `git` clients. Thanks, Erik ------------- Commits: - ad941e54: git-sync: use ref names instead of hashes Changes: https://git.openjdk.java.net/skara/pull/408/files Webrev: https://webrevs.openjdk.java.net/skara/408/webrev.00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/408.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/408/head:pull/408 PR: https://git.openjdk.java.net/skara/pull/408 From rwestberg at openjdk.java.net Fri Feb 7 07:31:25 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 7 Feb 2020 07:31:25 GMT Subject: RFR: git-sync: use ref names instead of hashes In-Reply-To: References: Message-ID: <5uTeE-VUiEtP2XA7YzfzTTmZ54p_I_wupLo2OWuTapo=.307d51c0-072d-4751-97c6-2777ad15a3b7@github.com> On Fri, 7 Feb 2020 07:19:37 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes `git sync` avoid using SHA-1 hashes > when executing `git fetch`. There was nothing wrong with this approach, but > older `git` clients have problems when the ref to fetch is a SHA-1 hash. There > is no drawback in using the ref name instead, it only increases compatibility > with older `git` clients. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/408 From ehelin at openjdk.java.net Fri Feb 7 07:43:23 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 7 Feb 2020 07:43:23 GMT Subject: [Integrated] RFR: merge-bot: clearer merge messages when merging between repos In-Reply-To: References: Message-ID: <76193590-55f9-44b3-9db2-2bcbd83dd637@openjdk.org> Changeset: 19f5473d Author: Erik Helin Date: 2020-02-07 07:43:09 +0000 URL: https://git.openjdk.java.net/skara/commit/19f5473d merge-bot: clearer merge messages when merging between repos Reviewed-by: rwestberg ! bots/merge/src/main/java/org/openjdk/skara/bots/merge/MergeBot.java ! bots/merge/src/test/java/org/openjdk/skara/bots/merge/MergeBotTests.java From ehelin at openjdk.java.net Fri Feb 7 07:43:52 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 7 Feb 2020 07:43:52 GMT Subject: [Integrated] RFR: git-sync: use ref names instead of hashes In-Reply-To: References: Message-ID: Changeset: 9958c7e4 Author: Erik Helin Date: 2020-02-07 07:43:35 +0000 URL: https://git.openjdk.java.net/skara/commit/9958c7e4 git-sync: use ref names instead of hashes Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitSync.java From ehelin at openjdk.java.net Fri Feb 7 11:38:52 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 7 Feb 2020 11:38:52 GMT Subject: git: openjdk/skara: merge-bot: use correct credentials when creating PR Message-ID: <721e0ac0-c487-49a9-b013-91fba8ea5bd2@openjdk.org> Changeset: c3359eff Author: Erik Helin Date: 2020-02-07 11:38:39 +0000 URL: https://git.openjdk.java.net/skara/commit/c3359eff merge-bot: use correct credentials when creating PR Reviewed-by: rwestberg ! bots/merge/src/main/java/org/openjdk/skara/bots/merge/MergeBot.java From ehelin at openjdk.java.net Fri Feb 7 13:05:11 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 7 Feb 2020 13:05:11 GMT Subject: git: openjdk/skara: merge-bot: use correct credentials for listing PRs Message-ID: <35c8a4ff-c56e-406b-87cc-f26782418223@openjdk.org> Changeset: 099d7153 Author: Erik Helin Date: 2020-02-07 13:04:59 +0000 URL: https://git.openjdk.java.net/skara/commit/099d7153 merge-bot: use correct credentials for listing PRs Reviewed-by: rwestberg ! bots/merge/src/main/java/org/openjdk/skara/bots/merge/MergeBot.java From ehelin at openjdk.java.net Fri Feb 7 13:07:39 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 7 Feb 2020 13:07:39 GMT Subject: RFR: merge-bot: use correct credentials for listing PRs Message-ID: Hi all, please review this small patch that fixes some additional credential confusion in the merge bot. The bot did not use correct credentials for listing the pull requests for the target repository. Thanks, Erik ------------- Commits: - 509933a7: merge-bot: use correct credentials for listing PRs Changes: https://git.openjdk.java.net/skara/pull/410/files Webrev: https://webrevs.openjdk.java.net/skara/410/webrev.00 Stats: 8 lines in 1 file changed: 3 ins; 3 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/410.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/410/head:pull/410 PR: https://git.openjdk.java.net/skara/pull/410 From rwestberg at openjdk.java.net Fri Feb 7 13:07:39 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 7 Feb 2020 13:07:39 GMT Subject: RFR: merge-bot: use correct credentials for listing PRs In-Reply-To: References: Message-ID: On Fri, 7 Feb 2020 12:58:21 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that fixes some additional credential confusion > in the merge bot. The bot did not use correct credentials for listing the pull > requests for the target repository. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/410 From rwestberg at openjdk.java.net Fri Feb 7 13:18:42 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 7 Feb 2020 13:18:42 GMT Subject: RFR: Improve materialization speed Message-ID: Hi all, Please review this change that allows materializing a HostedRepository using a common shared "seed", and make use of it in the PR bot. Best regards, Robin ------------- Commits: - bdd86cbd: Use in pr bot - 1673d312: Initial implementation Changes: https://git.openjdk.java.net/skara/pull/411/files Webrev: https://webrevs.openjdk.java.net/skara/411/webrev.00 Stats: 206 lines in 12 files changed: 186 ins; 2 del; 18 mod Patch: https://git.openjdk.java.net/skara/pull/411.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/411/head:pull/411 PR: https://git.openjdk.java.net/skara/pull/411 From rwestberg at openjdk.java.net Fri Feb 7 14:19:32 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 7 Feb 2020 14:19:32 GMT Subject: git: openjdk/skara: Only check the head commit Message-ID: <3661ff04-3116-40a1-bc66-0d0fd64f1f83@openjdk.org> Changeset: b0cc35dd Author: Robin Westberg Date: 2020-02-07 14:19:18 +0000 URL: https://git.openjdk.java.net/skara/commit/b0cc35dd Only check the head commit Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java From ehelin at openjdk.java.net Fri Feb 7 15:04:22 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 7 Feb 2020 15:04:22 GMT Subject: RFR: git-pr: git diff can exit with code 141 Message-ID: <3Cwi2ji5Ot5I0rWPYKSkVVaeeFAWZ7M6VCaFIP-A3gY=.d8138c51-3bd3-4085-a3b5-d325bf39f847@github.com> Hi all, please review this small patch that allows `git diff` to exit with code 141 during the `git pr show` command. `git diff` might exit with code 141 if it is using a pager (e.g. `less`) that works with signals (e.g. `SIGPIPE`). For example, if a user is viewing a large(r) patch using `git diff` using `less` and presses "q", then `SIGPIPE` is sent to `git diff` which therefore will exit with code 128 + 13 = 141 (`SIGPIPE` is signal 13). The fix is simple, just make `git pr show` allow `git diff` to exit with code 141. Testing: - Manual testing of `git pr show` Thanks, Erik ------------- Commits: - d9f6fea1: Remove trailing whitespace - 6820b2ac: git-pr: git diff can exit with code 141 Changes: https://git.openjdk.java.net/skara/pull/413/files Webrev: https://webrevs.openjdk.java.net/skara/413/webrev.00 Stats: 10 lines in 1 file changed: 7 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/413.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/413/head:pull/413 PR: https://git.openjdk.java.net/skara/pull/413 From rwestberg at openjdk.java.net Fri Feb 7 15:06:32 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 7 Feb 2020 15:06:32 GMT Subject: RFR: git-pr: git diff can exit with code 141 In-Reply-To: <3Cwi2ji5Ot5I0rWPYKSkVVaeeFAWZ7M6VCaFIP-A3gY=.d8138c51-3bd3-4085-a3b5-d325bf39f847@github.com> References: <3Cwi2ji5Ot5I0rWPYKSkVVaeeFAWZ7M6VCaFIP-A3gY=.d8138c51-3bd3-4085-a3b5-d325bf39f847@github.com> Message-ID: On Fri, 7 Feb 2020 14:55:03 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that allows `git diff` to exit with code 141 > during the `git pr show` command. `git diff` might exit with code 141 if it is > using a pager (e.g. `less`) that works with signals (e.g. `SIGPIPE`). For > example, if a user is viewing a large(r) patch using `git diff` using `less` and > presses "q", then `SIGPIPE` is sent to `git diff` which therefore will exit with > code 128 + 13 = 141 (`SIGPIPE` is signal 13). > > The fix is simple, just make `git pr show` allow `git diff` to exit with code > 141. > > Testing: > - Manual testing of `git pr show` > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/413 From ehelin at openjdk.java.net Fri Feb 7 15:08:13 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 7 Feb 2020 15:08:13 GMT Subject: [Integrated] RFR: git-pr: git diff can exit with code 141 In-Reply-To: <3Cwi2ji5Ot5I0rWPYKSkVVaeeFAWZ7M6VCaFIP-A3gY=.d8138c51-3bd3-4085-a3b5-d325bf39f847@github.com> References: <3Cwi2ji5Ot5I0rWPYKSkVVaeeFAWZ7M6VCaFIP-A3gY=.d8138c51-3bd3-4085-a3b5-d325bf39f847@github.com> Message-ID: <78f621c5-24ac-4858-a66c-4d6a6489bc35@openjdk.org> Changeset: c73064e6 Author: Erik Helin Date: 2020-02-07 15:07:59 +0000 URL: https://git.openjdk.java.net/skara/commit/c73064e6 git-pr: git diff can exit with code 141 Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java From rwestberg at openjdk.java.net Fri Feb 7 15:24:56 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 7 Feb 2020 15:24:56 GMT Subject: RFR: Remove unnecessary merge test Message-ID: Hi all, Please review this small change that removes a failing test. The test checked that all merged commits also passed jcheck, but this is not actually something that is required. (For example, when merging between projects the reviewer rules / roles are most likely different). Best regards, Robin ------------- Commits: - 571ccf9d: Remove unnecessary test Changes: https://git.openjdk.java.net/skara/pull/414/files Webrev: https://webrevs.openjdk.java.net/skara/414/webrev.00 Stats: 55 lines in 1 file changed: 0 ins; 55 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/414.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/414/head:pull/414 PR: https://git.openjdk.java.net/skara/pull/414 From ehelin at openjdk.java.net Fri Feb 7 15:25:09 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 7 Feb 2020 15:25:09 GMT Subject: RFR: Remove unnecessary merge test In-Reply-To: References: Message-ID: On Fri, 7 Feb 2020 15:17:39 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that removes a failing test. The test checked that all merged commits also passed jcheck, but this is not actually something that is required. (For example, when merging between projects the reviewer rules / roles are most likely different). > > Best regards, > Robin Looks good, thanks for fixing! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/414 From rwestberg at openjdk.java.net Fri Feb 7 15:26:53 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 7 Feb 2020 15:26:53 GMT Subject: [Integrated] RFR: Remove unnecessary merge test In-Reply-To: References: Message-ID: Changeset: 27af764d Author: Robin Westberg Date: 2020-02-07 15:26:39 +0000 URL: https://git.openjdk.java.net/skara/commit/27af764d Remove unnecessary merge test Reviewed-by: ehelin ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/MergeTests.java From ehelin at openjdk.java.net Fri Feb 7 16:03:40 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 7 Feb 2020 16:03:40 GMT Subject: RFR: git-pr: do not assume a master branch Message-ID: <8dHqMMLHyc6YYQnPK5p5uveRw1lxVmMmXdUDivbCabs=.99a6b5cb-5e72-4879-9c7d-da4b7f7f342f@github.com> Hi all, please review this patch that makes `git pr` work even though no `master` branch is present (which is the case if you clone a repository that uses a different default branch). The fix consists of two parts: - Use a better algorithm for detecting the target branch. `git pr create` will now pick the "closest" branch that exists in the upstream (parent) repository as the target branch by default. - Read the .jcheck/conf file from the target branch Testing: - Manually tested `git pr create` on different repositories on Linux x64 Thanks, Erik ------------- Commits: - 1fa953ef: Merge branch 'master' - 447e865b: Read .jcheck/conf from target branch - 63a2a088: Fix a few bugs - 0d424208: git-pr: better algorithm for detecting target branch Changes: https://git.openjdk.java.net/skara/pull/415/files Webrev: https://webrevs.openjdk.java.net/skara/415/webrev.00 Stats: 78 lines in 4 files changed: 64 ins; 9 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/415.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/415/head:pull/415 PR: https://git.openjdk.java.net/skara/pull/415 From rwestberg at openjdk.java.net Mon Feb 10 07:16:53 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 10 Feb 2020 07:16:53 GMT Subject: RFR: git-pr: do not assume a master branch In-Reply-To: <8dHqMMLHyc6YYQnPK5p5uveRw1lxVmMmXdUDivbCabs=.99a6b5cb-5e72-4879-9c7d-da4b7f7f342f@github.com> References: <8dHqMMLHyc6YYQnPK5p5uveRw1lxVmMmXdUDivbCabs=.99a6b5cb-5e72-4879-9c7d-da4b7f7f342f@github.com> Message-ID: On Fri, 7 Feb 2020 15:21:25 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `git pr` work even though no `master` branch > is present (which is the case if you clone a repository that uses a different > default branch). The fix consists of two parts: > > - Use a better algorithm for detecting the target branch. `git pr create` will > now pick the "closest" branch that exists in the upstream (parent) repository > as the target branch by default. > - Read the .jcheck/conf file from the target branch > > Testing: > - Manually tested `git pr create` on different repositories on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/415 From ehelin at openjdk.java.net Mon Feb 10 09:42:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 10 Feb 2020 09:42:17 GMT Subject: [Integrated] RFR: git-pr: do not assume a master branch In-Reply-To: <8dHqMMLHyc6YYQnPK5p5uveRw1lxVmMmXdUDivbCabs=.99a6b5cb-5e72-4879-9c7d-da4b7f7f342f@github.com> References: <8dHqMMLHyc6YYQnPK5p5uveRw1lxVmMmXdUDivbCabs=.99a6b5cb-5e72-4879-9c7d-da4b7f7f342f@github.com> Message-ID: Changeset: 4637c1b5 Author: Erik Helin Date: 2020-02-10 09:42:02 +0000 URL: https://git.openjdk.java.net/skara/commit/4637c1b5 git-pr: do not assume a master branch Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java ! vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java From ehelin at openjdk.java.net Mon Feb 10 10:36:24 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 10 Feb 2020 10:36:24 GMT Subject: RFR: merge-bot: update message for failed merges Message-ID: <6vx3JtCH1WZ-ROKaqmpsqxhswKdG7XV5dmBJc93r3OQ=.61deacf7-e2cc-404e-8440-6ced86f32745@github.com> Hi all, please review this patch that updates the merge bot to produce a nicer message (and clearer instructions) in the failed merge pull requests. The message will now include the files that contains merge conflicts. I also updated the message to limit the number of files and commits it lists (currently capped to ten each). Finally I also fixed the instructions for fixing a merge conflict to be correct ?? Testing: - added unit test for `ReadOnlyRepository::status` - `make test` passes on Linux x64 Thanks, Erik ------------- Commits: - 176d03a4: merge-bot: update message for failed merges Changes: https://git.openjdk.java.net/skara/pull/416/files Webrev: https://webrevs.openjdk.java.net/skara/416/webrev.00 Stats: 134 lines in 8 files changed: 120 ins; 4 del; 10 mod Patch: https://git.openjdk.java.net/skara/pull/416.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/416/head:pull/416 PR: https://git.openjdk.java.net/skara/pull/416 From rwestberg at openjdk.java.net Mon Feb 10 10:59:46 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 10 Feb 2020 10:59:46 GMT Subject: RFR: merge-bot: update message for failed merges In-Reply-To: <6vx3JtCH1WZ-ROKaqmpsqxhswKdG7XV5dmBJc93r3OQ=.61deacf7-e2cc-404e-8440-6ced86f32745@github.com> References: <6vx3JtCH1WZ-ROKaqmpsqxhswKdG7XV5dmBJc93r3OQ=.61deacf7-e2cc-404e-8440-6ced86f32745@github.com> Message-ID: On Mon, 10 Feb 2020 10:27:05 GMT, Erik Helin wrote: > Hi all, > > please review this patch that updates the merge bot to produce a nicer message > (and clearer instructions) in the failed merge pull requests. The message will > now include the files that contains merge conflicts. I also updated the message > to limit the number of files and commits it lists (currently capped to ten > each). Finally I also fixed the instructions for fixing a merge conflict to be > correct ?? > > Testing: > - added unit test for `ReadOnlyRepository::status` > - `make test` passes on Linux x64 > > Thanks, > Erik Looks good, only a spelling comment! bots/merge/src/main/java/org/openjdk/skara/bots/merge/MergeBot.java line 471: > 470: message.add(""); > 471: message.add("Now processed to create a pull request towards this repository."); > 472: message.add("If you are using the [Skara](https://wiki.openjdk.java.net/display/skara#Skara-Skara)" + Suggestion: message.add("Now proceed to create a pull request towards this repository."); ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/416 From rwestberg at openjdk.java.net Mon Feb 10 13:08:35 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 10 Feb 2020 13:08:35 GMT Subject: [Integrated] RFR: Improve materialization speed In-Reply-To: References: Message-ID: <09000e99-3ed8-427f-9954-bd02d09733f4@openjdk.org> Changeset: a67c3c1a Author: Robin Westberg Date: 2020-02-10 13:08:20 +0000 URL: https://git.openjdk.java.net/skara/commit/a67c3c1a Improve materialization speed Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/LabelerWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotBuilder.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SponsorCommand.java + forge/src/main/java/org/openjdk/skara/forge/HostedRepositoryPool.java ! jcheck/src/test/java/org/openjdk/skara/jcheck/TestRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/Repository.java ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java From ehelin at openjdk.java.net Mon Feb 10 13:08:53 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 10 Feb 2020 13:08:53 GMT Subject: [Integrated] RFR: merge-bot: update message for failed merges In-Reply-To: <6vx3JtCH1WZ-ROKaqmpsqxhswKdG7XV5dmBJc93r3OQ=.61deacf7-e2cc-404e-8440-6ced86f32745@github.com> References: <6vx3JtCH1WZ-ROKaqmpsqxhswKdG7XV5dmBJc93r3OQ=.61deacf7-e2cc-404e-8440-6ced86f32745@github.com> Message-ID: Changeset: 8a48b2cb Author: Erik Helin Date: 2020-02-10 13:08:36 +0000 URL: https://git.openjdk.java.net/skara/commit/8a48b2cb merge-bot: update message for failed merges Reviewed-by: rwestberg ! bots/merge/src/main/java/org/openjdk/skara/bots/merge/MergeBot.java ! jcheck/src/test/java/org/openjdk/skara/jcheck/TestRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/Status.java ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/tools/PatchHeader.java ! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java From rwestberg at openjdk.java.net Mon Feb 10 13:17:14 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 10 Feb 2020 13:17:14 GMT Subject: [Rev 01] RFR: Improve materialization speed In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that allows materializing a HostedRepository using a common shared "seed", and make use of it in the PR bot. > > Best regards, > Robin The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Added commits: - 77890bec: Ensure that both source and target refs are present locally - f4bc6a89: Fix build error after merge - 612d83ce: Merge remote-tracking branch 'upstream/master' into faster_materialize - 4637c1b5: git-pr: do not assume a master branch - aac97324: Merge remote-tracking branch 'upstream/master' into faster_materialize - 27af764d: Remove unnecessary merge test - c73064e6: git-pr: git diff can exit with code 141 - b0cc35dd: Only check the head commit - 099d7153: merge-bot: use correct credentials for listing PRs - c3359eff: merge-bot: use correct credentials when creating PR - 9958c7e4: git-sync: use ref names instead of hashes - 19f5473d: merge-bot: clearer merge messages when merging between repos - b5f92284: Avoid running the mailing list bridge too often - a57c1319: git-pr: friendly help message when missing action - 6e9e58b7: 267: Be more tolerant when parsing mbox files - feb2fcc0: Add toString methods to all WorkItems - 3cbdfd40: 251: Bypass PR update cache when the cooldown period expires for a bridge candidate - 72c721a2: 257: Proper setting of custom fields in Jira issues - ca0bc833: 255: Improve git repository health check - c08e9a6d: 266: Allow getting commit metadata for a range - c80ca805: Do not use pull in merge bot - 5c96b1cc: Improve merge bot commit message - 28d695ba: Fix git issues with merge bot - 6cc53a0c: Fix markdown formatting in /csr command - 189ade65: Use very defensive programming in CSRCommand - 5632c913: 260: CSR command should handle null resolution - ce4ae7b9: Typo in conversion from legacy jcheck conf - e31fdac1: Updated after offline review Changes: - all: https://git.openjdk.java.net/skara/pull/411/files - new: https://git.openjdk.java.net/skara/pull/411/files/bdd86cbd..77890bec Webrevs: - full: https://webrevs.openjdk.java.net/skara/411/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/411/webrev.00-01 Stats: 1162 lines in 48 files changed: 833 ins; 236 del; 93 mod Patch: https://git.openjdk.java.net/skara/pull/411.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/411/head:pull/411 PR: https://git.openjdk.java.net/skara/pull/411 From ehelin at openjdk.java.net Mon Feb 10 13:17:15 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 10 Feb 2020 13:17:15 GMT Subject: [Rev 01] RFR: Improve materialization speed In-Reply-To: References: Message-ID: On Mon, 10 Feb 2020 13:10:58 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this change that allows materializing a HostedRepository using a common shared "seed", and make use of it in the PR bot. >> >> Best regards, >> Robin > > The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/411 From ehelin at openjdk.java.net Mon Feb 10 13:17:52 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 10 Feb 2020 13:17:52 GMT Subject: [Rev 01] RFR: merge-bot: update message for failed merges In-Reply-To: <6vx3JtCH1WZ-ROKaqmpsqxhswKdG7XV5dmBJc93r3OQ=.61deacf7-e2cc-404e-8440-6ced86f32745@github.com> References: <6vx3JtCH1WZ-ROKaqmpsqxhswKdG7XV5dmBJc93r3OQ=.61deacf7-e2cc-404e-8440-6ced86f32745@github.com> Message-ID: > Hi all, > > please review this patch that updates the merge bot to produce a nicer message > (and clearer instructions) in the failed merge pull requests. The message will > now include the files that contains merge conflicts. I also updated the message > to limit the number of files and commits it lists (currently capped to ten > each). Finally I also fixed the instructions for fixing a merge conflict to be > correct ?? > > Testing: > - added unit test for `ReadOnlyRepository::status` > - `make test` passes on Linux x64 > > Thanks, > Erik The pull request has been updated with 1 additional commit. ------------- Added commits: - be773280: Fix spelling Changes: - all: https://git.openjdk.java.net/skara/pull/416/files - new: https://git.openjdk.java.net/skara/pull/416/files/176d03a4..be773280 Webrevs: - full: https://webrevs.openjdk.java.net/skara/416/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/416/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/416.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/416/head:pull/416 PR: https://git.openjdk.java.net/skara/pull/416 From ehelin at openjdk.java.net Mon Feb 10 13:17:53 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 10 Feb 2020 13:17:53 GMT Subject: [Rev 01] RFR: merge-bot: update message for failed merges In-Reply-To: References: <6vx3JtCH1WZ-ROKaqmpsqxhswKdG7XV5dmBJc93r3OQ=.61deacf7-e2cc-404e-8440-6ced86f32745@github.com> Message-ID: On Mon, 10 Feb 2020 10:56:51 GMT, Robin Westberg wrote: >> The pull request has been updated with 1 additional commit. > > bots/merge/src/main/java/org/openjdk/skara/bots/merge/MergeBot.java line 471: > >> 470: message.add(""); >> 471: message.add("Now processed to create a pull request towards this repository."); >> 472: message.add("If you are using the [Skara](https://wiki.openjdk.java.net/display/skara#Skara-Skara)" + > > Suggestion: > > message.add("Now proceed to create a pull request towards this repository."); Thanks! ------------- PR: https://git.openjdk.java.net/skara/pull/416 From rwestberg at openjdk.java.net Mon Feb 10 14:45:29 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 10 Feb 2020 14:45:29 GMT Subject: RFR: Fetch PRs using the head hash Message-ID: Hi all, Please review this follow-up fix for faster remote repository materialization that fetches PRs by their head hash instead of a named source ref, as the ref may not be present in the remote repo. Best regards, Robin ------------- Commits: - 3fbb06e8: Fetch PRs using the head hash, as the source ref may not be present. Speed up move on failure. Changes: https://git.openjdk.java.net/skara/pull/417/files Webrev: https://webrevs.openjdk.java.net/skara/417/webrev.00 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/417.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/417/head:pull/417 PR: https://git.openjdk.java.net/skara/pull/417 From ehelin at openjdk.java.net Mon Feb 10 14:45:29 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 10 Feb 2020 14:45:29 GMT Subject: RFR: Fetch PRs using the head hash In-Reply-To: References: Message-ID: On Mon, 10 Feb 2020 14:05:20 GMT, Robin Westberg wrote: > Hi all, > > Please review this follow-up fix for faster remote repository materialization that fetches PRs by their head hash instead of a named source ref, as the ref may not be present in the remote repo. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/417 From ehelin at openjdk.java.net Mon Feb 10 14:53:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 10 Feb 2020 14:53:17 GMT Subject: RFR: Always set commit_id and comments when adding review Message-ID: <8aQskZDhpVEDPgyEYhvLBJLavJGqFlekygZd0QgyPWU=.5e302f51-f544-44fc-8f3d-3c60cc997067@github.com> Hi all, please review this small patch that ensures that we always set the fields `commit_id` and `comments` when adding a review to a GitHub pull request. Testing: - Manual testing using `git pr approve` Thanks, Erik ------------- Commits: - cc6c6ba8: Always set commit_id and comments when adding review Changes: https://git.openjdk.java.net/skara/pull/418/files Webrev: https://webrevs.openjdk.java.net/skara/418/webrev.00 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/418.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/418/head:pull/418 PR: https://git.openjdk.java.net/skara/pull/418 From ehelin at openjdk.java.net Mon Feb 10 15:46:04 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 10 Feb 2020 15:46:04 GMT Subject: RFR: git-pr: status cannot handle rfr label correctly Message-ID: Hi all, please review this small pull request that updates how the status for a pull request is calculated. We changed a while back to keep the "rfr" label on pull requests that are ready (a PR is still "ready for review" even if it already has been reviewed). `git pr status` wasn't updated however, so it printed the wrong status for pull requests. This patch fixes this issue, so `git pr status` once again works correctly. Testing: - Manual testing of `git pr status` and `git pr list` Thanks, Erik ------------- Commits: - ecf961e1: git-pr: status cannot handle rfr label correctly Changes: https://git.openjdk.java.net/skara/pull/419/files Webrev: https://webrevs.openjdk.java.net/skara/419/webrev.00 Stats: 6 lines in 1 file changed: 2 ins; 2 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/419.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/419/head:pull/419 PR: https://git.openjdk.java.net/skara/pull/419 From clanger at openjdk.java.net Mon Feb 10 17:43:15 2020 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 10 Feb 2020 17:43:15 GMT Subject: [Rev 02] RFR: Fix parsing of editor commandline in git-pr In-Reply-To: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: > For git editor configurations that aren't a simple call to an editor but have more parameters, the starting of the editor in git pr does not work. > At least, I observed this in my windows environment, where I have the following git config entry: > core.editor="C:\\Program Files\\Notepad++\\notepad++.exe" -multiInst -notabbar -nosession -noPlugin The pull request has been updated with a new target base due to a merge or a rebase. ------------- Commits: - 67cdd0cc: Fix parsing of editor commandline in git-pr. Changes: https://git.openjdk.java.net/skara/pull/259/files Webrev: https://webrevs.openjdk.java.net/skara/259/webrev.02 Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/259.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/259/head:pull/259 PR: https://git.openjdk.java.net/skara/pull/259 From clanger at openjdk.java.net Mon Feb 10 22:38:07 2020 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 10 Feb 2020 22:38:07 GMT Subject: RFR: Fix parsing of editor commandline in git-pr In-Reply-To: References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: On Mon, 25 Nov 2019 11:09:49 GMT, Erik Helin wrote: >> Christopher, as Robin says, we unfortunately only have a man page at the moment (which won't help you very much since you are on Windows). You can get more abbreviated help information by running `git pr -h`. Robin is also right in how you add a longer multiline description to the pull request. >> >> As for the regular expression, could you please add a comments above with a few examples. Also, do you really need the quotation marks around the path to `notepad.exe` for `core.editor`? Won't the following suffice: >> >> core.editor = C:\Program Files\Notepad++\notepad++.exe -multiInst -notabbar -nosession -noPlugin >> >> Thanks, >> Erik > > @RealCLanger did you see mine and Robin's comments? Hi, finally I got back to this. > As for the regular expression, could you please add a comments above with a few examples. I've done that. > Also, do you really need the quotation marks around the path to `notepad.exe` for `core.editor`? Won't the following suffice: > > ``` > core.editor = C:\Program Files\Notepad++\notepad++.exe -multiInst -notabbar -nosession -noPlugin Probably yes, but that's how I found my git configuration without manual changes that I'm aware of. So it should work. And I think, even if I remove the quotation marks, it still wouldn't work. Please review :) ------------- PR: https://git.openjdk.java.net/skara/pull/259 From clanger at openjdk.java.net Mon Feb 10 22:38:07 2020 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 10 Feb 2020 22:38:07 GMT Subject: [Rev 03] RFR: Fix parsing of editor commandline in git-pr In-Reply-To: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: > For git editor configurations that aren't a simple call to an editor but have more parameters, the starting of the editor in git pr does not work. > At least, I observed this in my windows environment, where I have the following git config entry: > core.editor="C:\\Program Files\\Notepad++\\notepad++.exe" -multiInst -notabbar -nosession -noPlugin Previous commits in this pull request have been removed, probably due to a force push. The incremental views will show differences compared to the previous content of the PR. ------------- Added commits: - 40e03b44: Fix parsing of editor commandline in git-pr. Changes: - all: https://git.openjdk.java.net/skara/pull/259/files - new: https://git.openjdk.java.net/skara/pull/259/files/67cdd0cc..40e03b44 Webrevs: - full: https://webrevs.openjdk.java.net/skara/259/webrev.03 - incr: https://webrevs.openjdk.java.net/skara/259/webrev.02-03 Stats: 15 lines in 1 file changed: 4 ins; 10 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/259.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/259/head:pull/259 PR: https://git.openjdk.java.net/skara/pull/259 From rwestberg at openjdk.java.net Tue Feb 11 06:38:23 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 06:38:23 GMT Subject: RFR: git-pr: status cannot handle rfr label correctly In-Reply-To: References: Message-ID: On Mon, 10 Feb 2020 15:35:17 GMT, Erik Helin wrote: > Hi all, > > please review this small pull request that updates how the status for a pull > request is calculated. We changed a while back to keep the "rfr" label on pull > requests that are ready (a PR is still "ready for review" even if it already has > been reviewed). `git pr status` wasn't updated however, so it printed the wrong > status for pull requests. This patch fixes this issue, so `git pr status` once > again works correctly. > > Testing: > - Manual testing of `git pr status` and `git pr list` > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/419 From rwestberg at openjdk.java.net Tue Feb 11 06:38:44 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 06:38:44 GMT Subject: RFR: Always set commit_id and comments when adding review In-Reply-To: <8aQskZDhpVEDPgyEYhvLBJLavJGqFlekygZd0QgyPWU=.5e302f51-f544-44fc-8f3d-3c60cc997067@github.com> References: <8aQskZDhpVEDPgyEYhvLBJLavJGqFlekygZd0QgyPWU=.5e302f51-f544-44fc-8f3d-3c60cc997067@github.com> Message-ID: On Mon, 10 Feb 2020 14:42:14 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that ensures that we always set the fields > `commit_id` and `comments` when adding a review to a GitHub pull request. > > Testing: > - Manual testing using `git pr approve` > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/418 From ehelin at openjdk.java.net Tue Feb 11 06:41:06 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 06:41:06 GMT Subject: [Integrated] RFR: git-pr: status cannot handle rfr label correctly In-Reply-To: References: Message-ID: <53d7d8c0-52c6-4a81-aa82-09b15aa1e2c6@openjdk.org> Changeset: 0cb32dda Author: Erik Helin Date: 2020-02-11 06:40:50 +0000 URL: https://git.openjdk.java.net/skara/commit/0cb32dda git-pr: status cannot handle rfr label correctly Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java From ehelin at openjdk.java.net Tue Feb 11 06:41:25 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 06:41:25 GMT Subject: [Integrated] RFR: Always set commit_id and comments when adding review In-Reply-To: <8aQskZDhpVEDPgyEYhvLBJLavJGqFlekygZd0QgyPWU=.5e302f51-f544-44fc-8f3d-3c60cc997067@github.com> References: <8aQskZDhpVEDPgyEYhvLBJLavJGqFlekygZd0QgyPWU=.5e302f51-f544-44fc-8f3d-3c60cc997067@github.com> Message-ID: Changeset: a865b97a Author: Erik Helin Date: 2020-02-11 06:41:07 +0000 URL: https://git.openjdk.java.net/skara/commit/a865b97a Always set commit_id and comments when adding review Reviewed-by: rwestberg ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java From rwestberg at openjdk.java.net Tue Feb 11 06:51:05 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 06:51:05 GMT Subject: [Integrated] RFR: Fetch PRs using the head hash In-Reply-To: References: Message-ID: Changeset: 21d6acf9 Author: Robin Westberg Date: 2020-02-11 06:50:45 +0000 URL: https://git.openjdk.java.net/skara/commit/21d6acf9 Fetch PRs using the head hash Reviewed-by: ehelin ! forge/src/main/java/org/openjdk/skara/forge/HostedRepositoryPool.java From ehelin at openjdk.java.net Tue Feb 11 07:37:36 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 07:37:36 GMT Subject: RFR: Fix parsing of editor commandline in git-pr In-Reply-To: References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: On Mon, 10 Feb 2020 22:30:18 GMT, Christoph Langer wrote: >> @RealCLanger did you see mine and Robin's comments? > > Hi, > > finally I got back to this. > >> As for the regular expression, could you please add a comments above with a few examples. > > I've done that. > >> Also, do you really need the quotation marks around the path to `notepad.exe` for `core.editor`? Won't the following suffice: >> >> ``` >> core.editor = C:\Program Files\Notepad++\notepad++.exe -multiInst -notabbar -nosession -noPlugin > > Probably yes, but that's how I found my git configuration without manual changes that I'm aware of. So it should work. And I think, even if I remove the quotation marks, it still wouldn't work. > > Please review :) Thanks Christopher! I agree, if it is possible to have quotation marks around the binary in `core.editor`, then we should support that. Looking at your patch, what do you think about doing something perhaps a bit simpler than a regular expression: var parts = editor.split(" "); if (parts.length > 0) { var binary = parts[0]; // Binary might be wrapped in quotes on Windows if (binary.startsWith(""") && binary.endsWith(""")) { parts[0] = binary.substring(1, binary.length() - 1); } } var pb = new ProcessBuilder(parts); ------------- PR: https://git.openjdk.java.net/skara/pull/259 From clanger at openjdk.java.net Tue Feb 11 07:44:13 2020 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 11 Feb 2020 07:44:13 GMT Subject: RFR: Fix parsing of editor commandline in git-pr In-Reply-To: References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: On Tue, 11 Feb 2020 07:37:21 GMT, Erik Helin wrote: >> Hi, >> >> finally I got back to this. >> >>> As for the regular expression, could you please add a comments above with a few examples. >> >> I've done that. >> >>> Also, do you really need the quotation marks around the path to `notepad.exe` for `core.editor`? Won't the following suffice: >>> >>> ``` >>> core.editor = C:\Program Files\Notepad++\notepad++.exe -multiInst -notabbar -nosession -noPlugin >> >> Probably yes, but that's how I found my git configuration without manual changes that I'm aware of. So it should work. And I think, even if I remove the quotation marks, it still wouldn't work. >> >> Please review :) > > Thanks Christopher! I agree, if it is possible to have quotation marks around the binary in `core.editor`, then we should support that. Looking at your patch, what do you think about doing something perhaps a bit simpler than a regular expression: > > var parts = editor.split(" "); > if (parts.length > 0) { > var binary = parts[0]; > // Binary might be wrapped in quotes on Windows > if (binary.startsWith(""") && binary.endsWith(""")) { > parts[0] = binary.substring(1, binary.length() - 1); > } > } > var pb = new ProcessBuilder(parts); > Thanks Christopher! I agree, if it is possible to have quotation marks around the binary in `core.editor`, then we should support that. Looking at your patch, what do you think about doing something perhaps a bit simpler than a regular expression: > > ```java > var parts = editor.split(" "); > if (parts.length > 0) { > var binary = parts[0]; > // Binary might be wrapped in quotes on Windows > if (binary.startsWith(""") && binary.endsWith(""")) { > parts[0] = binary.substring(1, binary.length() - 1); > } > } > var pb = new ProcessBuilder(parts); > ``` Hm, I agree that something simpler and more explicit than such a regexp would be desirable. But, as for your suggestion, what if the binary path contains blanks? Then it would be distributed along parts[0...n]. Furthermore, the options for the editor could also be quoted items with blanks in it. So, I guess the regexp would handle all that. ------------- PR: https://git.openjdk.java.net/skara/pull/259 From rwestberg at openjdk.java.net Tue Feb 11 07:47:04 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 07:47:04 GMT Subject: RFR: Improve robustness of removing invalid clones Message-ID: <0m5aoWLEZjEaoA9Zkud_UaV5ZQL2FDTOKnqDzE5yHIc=.1faa77a6-71a0-4f0f-bfac-01dc8dcb4027@github.com> Hi all, Please review this change that improves the removal of invalid clones. The preservation is only meant to aid debugging, so any problems in that area should not throw any exception. Best regards, Robin ------------- Commits: - 6e03e513: Improve robustness of removing invalid clones Changes: https://git.openjdk.java.net/skara/pull/420/files Webrev: https://webrevs.openjdk.java.net/skara/420/webrev.00 Stats: 29 lines in 1 file changed: 23 ins; 4 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/420.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/420/head:pull/420 PR: https://git.openjdk.java.net/skara/pull/420 From ehelin at openjdk.java.net Tue Feb 11 07:47:22 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 07:47:22 GMT Subject: RFR: Improve robustness of removing invalid clones In-Reply-To: <0m5aoWLEZjEaoA9Zkud_UaV5ZQL2FDTOKnqDzE5yHIc=.1faa77a6-71a0-4f0f-bfac-01dc8dcb4027@github.com> References: <0m5aoWLEZjEaoA9Zkud_UaV5ZQL2FDTOKnqDzE5yHIc=.1faa77a6-71a0-4f0f-bfac-01dc8dcb4027@github.com> Message-ID: On Tue, 11 Feb 2020 07:37:49 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that improves the removal of invalid clones. The preservation is only meant to aid debugging, so any problems in that area should not throw any exception. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/420 From rwestberg at openjdk.java.net Tue Feb 11 07:53:16 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 07:53:16 GMT Subject: [Integrated] RFR: Improve robustness of removing invalid clones In-Reply-To: <0m5aoWLEZjEaoA9Zkud_UaV5ZQL2FDTOKnqDzE5yHIc=.1faa77a6-71a0-4f0f-bfac-01dc8dcb4027@github.com> References: <0m5aoWLEZjEaoA9Zkud_UaV5ZQL2FDTOKnqDzE5yHIc=.1faa77a6-71a0-4f0f-bfac-01dc8dcb4027@github.com> Message-ID: <55bebc19-75bc-4adf-8260-85cda6a299d1@openjdk.org> Changeset: 1d560423 Author: Robin Westberg Date: 2020-02-11 07:52:59 +0000 URL: https://git.openjdk.java.net/skara/commit/1d560423 Improve robustness of removing invalid clones Reviewed-by: ehelin ! forge/src/main/java/org/openjdk/skara/forge/HostedRepositoryPool.java From ehelin at openjdk.java.net Tue Feb 11 09:13:10 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 09:13:10 GMT Subject: RFR: contributor command: better validation of input Message-ID: Hi all, please review this patch that adds a bit more strict validation of the input to the `/contributor add` command. This is done to ensure that the resulting `Co-authored-by` trailer in the final commit message will be approved by jcheck. Testing: - Added two additional unit tests for validation - `make test` passes on Linux x64 Thanks, Erik ------------- Commits: - df27f322: contributor command: better validation of input Changes: https://git.openjdk.java.net/skara/pull/421/files Webrev: https://webrevs.openjdk.java.net/skara/421/webrev.00 Stats: 84 lines in 3 files changed: 80 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/421.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/421/head:pull/421 PR: https://git.openjdk.java.net/skara/pull/421 From rwestberg at openjdk.java.net Tue Feb 11 09:13:21 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 09:13:21 GMT Subject: RFR: contributor command: better validation of input In-Reply-To: References: Message-ID: On Tue, 11 Feb 2020 09:03:36 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds a bit more strict validation of the input to > the `/contributor add` command. This is done to ensure that the resulting > `Co-authored-by` trailer in the final commit message will be approved by jcheck. > > Testing: > - Added two additional unit tests for validation > - `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/421 From ehelin at openjdk.java.net Tue Feb 11 09:18:02 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 09:18:02 GMT Subject: [Integrated] RFR: contributor command: better validation of input In-Reply-To: References: Message-ID: <12a64016-12ba-48d0-99f6-4b73f3c932fb@openjdk.org> Changeset: 132bd38b Author: Erik Helin Date: 2020-02-11 09:17:42 +0000 URL: https://git.openjdk.java.net/skara/commit/132bd38b contributor command: better validation of input Reviewed-by: rwestberg ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/ContributorCommand.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java ! vcs/src/main/java/org/openjdk/skara/vcs/openjdk/CommitMessageSyntax.java From rwestberg at openjdk.java.net Tue Feb 11 09:52:20 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 09:52:20 GMT Subject: RFR: Use a stable creation date for new revisions Message-ID: Hi all, Please review this change that ensures that a stable creation date is used when creating emails for new content in a PR. Otherwise they may get stuck in cooldown forever. Best regards, Robin ------------- Commits: - ba1a0516: Use a stable creation date for new revisions Changes: https://git.openjdk.java.net/skara/pull/422/files Webrev: https://webrevs.openjdk.java.net/skara/422/webrev.00 Stats: 159 lines in 3 files changed: 151 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/skara/pull/422.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/422/head:pull/422 PR: https://git.openjdk.java.net/skara/pull/422 From ehelin at openjdk.java.net Tue Feb 11 09:52:20 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 09:52:20 GMT Subject: RFR: Use a stable creation date for new revisions In-Reply-To: References: Message-ID: On Tue, 11 Feb 2020 09:45:18 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that a stable creation date is used when creating emails for new content in a PR. Otherwise they may get stuck in cooldown forever. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/422 From ehelin at openjdk.java.net Tue Feb 11 09:56:57 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 09:56:57 GMT Subject: RFR: Fix parsing of editor commandline in git-pr In-Reply-To: References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: On Tue, 11 Feb 2020 07:44:06 GMT, Christoph Langer wrote: >> Thanks Christopher! I agree, if it is possible to have quotation marks around the binary in `core.editor`, then we should support that. Looking at your patch, what do you think about doing something perhaps a bit simpler than a regular expression: >> >> var parts = editor.split(" "); >> if (parts.length > 0) { >> var binary = parts[0]; >> // Binary might be wrapped in quotes on Windows >> if (binary.startsWith(""") && binary.endsWith(""")) { >> parts[0] = binary.substring(1, binary.length() - 1); >> } >> } >> var pb = new ProcessBuilder(parts); > >> Thanks Christopher! I agree, if it is possible to have quotation marks around the binary in `core.editor`, then we should support that. Looking at your patch, what do you think about doing something perhaps a bit simpler than a regular expression: >> >> ```java >> var parts = editor.split(" "); >> if (parts.length > 0) { >> var binary = parts[0]; >> // Binary might be wrapped in quotes on Windows >> if (binary.startsWith(""") && binary.endsWith(""")) { >> parts[0] = binary.substring(1, binary.length() - 1); >> } >> } >> var pb = new ProcessBuilder(parts); >> ``` > > Hm, I agree that something simpler and more explicit than such a regexp would be desirable. But, as for your suggestion, what if the binary path contains blanks? Then it would be distributed along parts[0...n]. Furthermore, the options for the editor could also be quoted items with blanks in it. So, I guess the regexp would handle all that. Ah right, my UNIX brain forgot about paths with spaces in them ?? Yes, seems like we need the regular expression here. Just a quick question on the last part of the regex, `\\s*`, will that turn into groups? I wanted to make sure that we execute the editor _with_ all the arguments the user might have added. ------------- PR: https://git.openjdk.java.net/skara/pull/259 From ehelin at openjdk.java.net Tue Feb 11 09:59:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 09:59:19 GMT Subject: RFR: pr-bot: throw on unexpected jcheck issues Message-ID: Hi all, please _carefully_ review this patch that throws `IllegalStateException` for some jcheck issues that shouldn't happen for commits that the PR bot has created. I think I have gone through all cases, but would appreciate careful reviewing here ?? Testing: - `make test` passes on Linux x64 Thanks, Erik ------------- Commits: - b3e60e05: pr-bot: throw on unexpected jcheck issues Changes: https://git.openjdk.java.net/skara/pull/423/files Webrev: https://webrevs.openjdk.java.net/skara/423/webrev.00 Stats: 9 lines in 1 file changed: 2 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/423.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/423/head:pull/423 PR: https://git.openjdk.java.net/skara/pull/423 From rwestberg at openjdk.java.net Tue Feb 11 10:00:39 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 10:00:39 GMT Subject: RFR: pr-bot: throw on unexpected jcheck issues In-Reply-To: References: Message-ID: On Tue, 11 Feb 2020 09:50:46 GMT, Erik Helin wrote: > Hi all, > > please _carefully_ review this patch that throws `IllegalStateException` for > some jcheck issues that shouldn't happen for commits that the PR bot has > created. I think I have gone through all cases, but would appreciate careful > reviewing here ?? > > Testing: > - `make test` passes on Linux x64 > > Thanks, > Erik After careful consideration, I declare this to be looking good. ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/423 From rwestberg at openjdk.java.net Tue Feb 11 10:02:29 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 10:02:29 GMT Subject: [Integrated] RFR: Use a stable creation date for new revisions In-Reply-To: References: Message-ID: Changeset: 67e9843f Author: Robin Westberg Date: 2020-02-11 10:02:14 +0000 URL: https://git.openjdk.java.net/skara/commit/67e9843f Use a stable creation date for new revisions Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From rwestberg at openjdk.java.net Tue Feb 11 10:24:06 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 10:24:06 GMT Subject: RFR: Standardize pr bot scratch folder names and detect invalid directories Message-ID: Hi all, Please review this small change that ensures that the PR bot uses unique folders for scratch repositories, and removes invalid destination directories before attempting a fresh clone. Best regards, Robin ------------- Commits: - 8b5e1d1e: Standardize pr bot scratch folder names and detect invalid directories as clone targets Changes: https://git.openjdk.java.net/skara/pull/424/files Webrev: https://webrevs.openjdk.java.net/skara/424/webrev.00 Stats: 18 lines in 6 files changed: 3 ins; 0 del; 15 mod Patch: https://git.openjdk.java.net/skara/pull/424.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/424/head:pull/424 PR: https://git.openjdk.java.net/skara/pull/424 From ehelin at openjdk.java.net Tue Feb 11 10:24:16 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 10:24:16 GMT Subject: RFR: Standardize pr bot scratch folder names and detect invalid directories In-Reply-To: References: Message-ID: On Tue, 11 Feb 2020 10:18:51 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that ensures that the PR bot uses unique folders for scratch repositories, and removes invalid destination directories before attempting a fresh clone. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/424 From rwestberg at openjdk.java.net Tue Feb 11 10:26:19 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 10:26:19 GMT Subject: [Integrated] RFR: Standardize pr bot scratch folder names and detect invalid directories In-Reply-To: References: Message-ID: <6ab8f2c5-ddfe-41aa-8fa0-788a18b3dda8@openjdk.org> Changeset: 77105e66 Author: Robin Westberg Date: 2020-02-11 10:26:03 +0000 URL: https://git.openjdk.java.net/skara/commit/77105e66 Standardize pr bot scratch folder names and detect invalid directories Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/LabelerWorkItem.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SponsorCommand.java ! forge/src/main/java/org/openjdk/skara/forge/HostedRepositoryPool.java From ehelin at openjdk.java.net Tue Feb 11 10:50:03 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 10:50:03 GMT Subject: RFR: contributor command: friendlier message when removing contributor Message-ID: Hi all, please review this patch that prints a bit friendlier message when removing a contributors. The message will now include the contributors associated with the pull request _if_ the given contributor is not one of them. Testing: - added a new unit test for the feature - `make test` passes on Linux x64 Thanks, Erik ------------- Commits: - 89621068: contributor command: friendlier message when removing contributor Changes: https://git.openjdk.java.net/skara/pull/425/files Webrev: https://webrevs.openjdk.java.net/skara/425/webrev.00 Stats: 58 lines in 2 files changed: 56 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/425.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/425/head:pull/425 PR: https://git.openjdk.java.net/skara/pull/425 From ehelin at openjdk.java.net Tue Feb 11 11:05:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 11:05:19 GMT Subject: [Rev 01] RFR: contributor command: friendlier message when removing contributor In-Reply-To: References: Message-ID: <4qebxFCnfcm1Q8gfnEyTSilVvJS7EV4RkY-3e3Oo6hQ=.f7f637fc-77ad-4c4b-90d0-c85ddbbb69d5@github.com> > Hi all, > > please review this patch that prints a bit friendlier message when removing a > contributors. The message will now include the contributors associated with the > pull request _if_ the given contributor is not one of them. > > Testing: > - added a new unit test for the feature > - `make test` passes on Linux x64 > > Thanks, > Erik The pull request has been updated with 1 additional commit. ------------- Added commits: - df39617b: Format regular expressions better Changes: - all: https://git.openjdk.java.net/skara/pull/425/files - new: https://git.openjdk.java.net/skara/pull/425/files/89621068..df39617b Webrevs: - full: https://webrevs.openjdk.java.net/skara/425/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/425/webrev.00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/425.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/425/head:pull/425 PR: https://git.openjdk.java.net/skara/pull/425 From rwestberg at openjdk.java.net Tue Feb 11 11:05:19 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 11:05:19 GMT Subject: [Rev 01] RFR: contributor command: friendlier message when removing contributor In-Reply-To: <4qebxFCnfcm1Q8gfnEyTSilVvJS7EV4RkY-3e3Oo6hQ=.f7f637fc-77ad-4c4b-90d0-c85ddbbb69d5@github.com> References: <4qebxFCnfcm1Q8gfnEyTSilVvJS7EV4RkY-3e3Oo6hQ=.f7f637fc-77ad-4c4b-90d0-c85ddbbb69d5@github.com> Message-ID: On Tue, 11 Feb 2020 10:56:22 GMT, Erik Helin wrote: >> Hi all, >> >> please review this patch that prints a bit friendlier message when removing a >> contributors. The message will now include the contributors associated with the >> pull request _if_ the given contributor is not one of them. >> >> Testing: >> - added a new unit test for the feature >> - `make test` passes on Linux x64 >> >> Thanks, >> Erik > > The pull request has been updated with 1 additional commit. Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/425 From ehelin at openjdk.java.net Tue Feb 11 11:08:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 11:08:37 GMT Subject: [Integrated] RFR: contributor command: friendlier message when removing contributor In-Reply-To: References: Message-ID: Changeset: b7fd5b63 Author: Erik Helin Date: 2020-02-11 11:08:21 +0000 URL: https://git.openjdk.java.net/skara/commit/b7fd5b63 contributor command: friendlier message when removing contributor Reviewed-by: rwestberg ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/ContributorCommand.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java From rwestberg at openjdk.java.net Tue Feb 11 11:34:45 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 11:34:45 GMT Subject: RFR: Improve cooldown test stability Message-ID: Hi all, Please review this small change that avoids spurious failures in the cooldown retry tests. Best regards, Robin ------------- Commits: - 2e842424: Improve cooldown test stability Changes: https://git.openjdk.java.net/skara/pull/426/files Webrev: https://webrevs.openjdk.java.net/skara/426/webrev.00 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/426.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/426/head:pull/426 PR: https://git.openjdk.java.net/skara/pull/426 From duke at openjdk.java.net Tue Feb 11 11:40:55 2020 From: duke at openjdk.java.net (J.Duke) Date: Tue, 11 Feb 2020 11:40:55 GMT Subject: RFR: Improve cooldown test stability In-Reply-To: References: Message-ID: <-l8fHVw9qSnrswD9xl4rUy5hD8Ze5DNu7nssvxSzP2I=.b049bff6-4885-47e8-a053-025b12147d6a@github.com> On Tue, 11 Feb 2020 11:22:34 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that avoids spurious failures in the cooldown retry tests. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by duke (no project role). PR: https://git.openjdk.java.net/skara/pull/426 From ehelin at openjdk.java.net Tue Feb 11 13:15:24 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 13:15:24 GMT Subject: [Integrated] RFR: pr-bot: throw on unexpected jcheck issues In-Reply-To: References: Message-ID: <1b116a51-0286-472d-b302-254b8f83187a@openjdk.org> Changeset: 8a386afc Author: Erik Helin Date: 2020-02-11 13:15:10 +0000 URL: https://git.openjdk.java.net/skara/commit/8a386afc pr-bot: throw on unexpected jcheck issues Reviewed-by: rwestberg ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java From ehelin at openjdk.java.net Tue Feb 11 13:16:44 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 11 Feb 2020 13:16:44 GMT Subject: RFR: Improve cooldown test stability In-Reply-To: References: Message-ID: On Tue, 11 Feb 2020 11:22:34 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that avoids spurious failures in the cooldown retry tests. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/426 From clanger at openjdk.java.net Tue Feb 11 13:22:23 2020 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 11 Feb 2020 13:22:23 GMT Subject: [Rev 04] RFR: Fix parsing of editor commandline in git-pr In-Reply-To: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: > For git editor configurations that aren't a simple call to an editor but have more parameters, the starting of the editor in git pr does not work. > At least, I observed this in my windows environment, where I have the following git config entry: > core.editor="C:\\Program Files\\Notepad++\\notepad++.exe" -multiInst -notabbar -nosession -noPlugin The pull request has been updated with a new target base due to a merge or a rebase. ------------- Commits: - fcfba396: Fix parsing of editor commandline in git-pr. Changes: https://git.openjdk.java.net/skara/pull/259/files Webrev: https://webrevs.openjdk.java.net/skara/259/webrev.04 Stats: 22 lines in 1 file changed: 11 ins; 9 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/259.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/259/head:pull/259 PR: https://git.openjdk.java.net/skara/pull/259 From clanger at openjdk.java.net Tue Feb 11 13:22:23 2020 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 11 Feb 2020 13:22:23 GMT Subject: RFR: Fix parsing of editor commandline in git-pr In-Reply-To: References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: On Tue, 11 Feb 2020 09:56:40 GMT, Erik Helin wrote: >>> Thanks Christopher! I agree, if it is possible to have quotation marks around the binary in `core.editor`, then we should support that. Looking at your patch, what do you think about doing something perhaps a bit simpler than a regular expression: >>> >>> ```java >>> var parts = editor.split(" "); >>> if (parts.length > 0) { >>> var binary = parts[0]; >>> // Binary might be wrapped in quotes on Windows >>> if (binary.startsWith(""") && binary.endsWith(""")) { >>> parts[0] = binary.substring(1, binary.length() - 1); >>> } >>> } >>> var pb = new ProcessBuilder(parts); >>> ``` >> >> Hm, I agree that something simpler and more explicit than such a regexp would be desirable. But, as for your suggestion, what if the binary path contains blanks? Then it would be distributed along parts[0...n]. Furthermore, the options for the editor could also be quoted items with blanks in it. So, I guess the regexp would handle all that. > > Ah right, my UNIX brain forgot about paths with spaces in them ?? Yes, seems like we need the regular expression here. Just a quick question on the last part of the regex, `\\s*`, will that turn into groups? I wanted to make sure that we execute the editor _with_ all the arguments the user might have added. > Ah right, my UNIX brain forgot about paths with spaces in them ?? Yes, seems like we need the regular expression here. Just a quick question on the last part of the regex, `\\s*`, will that turn into groups? I wanted to make sure that we execute the editor _with_ all the arguments the user might have added. The \\s* in the end will not turn into a group. It'll just lead to accepting trailing whitespace. I've tested the regex again in a small testprogram with several variations in input. One thing I've added is a \\s* in the beginning to accept leading whitespace - just in case. So the regex basically is: -optional leading whitespace(non-quoted token|quoted token)optional trailing whitespace- The group is just formed out of the token. PR is updated, hopefully the final version :) ------------- PR: https://git.openjdk.java.net/skara/pull/259 From rwestberg at openjdk.java.net Tue Feb 11 14:30:33 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 14:30:33 GMT Subject: RFR: Use different scratch folders for different repos Message-ID: Hi all, Please review this small change that ensures that different repositories get different scratch folders when inspected by the pullrequest bot, which should increase performance. Best regards, Robin ------------- Commits: - 9e02092c: Use different scratch folders for different repos Changes: https://git.openjdk.java.net/skara/pull/427/files Webrev: https://webrevs.openjdk.java.net/skara/427/webrev.00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/427.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/427/head:pull/427 PR: https://git.openjdk.java.net/skara/pull/427 From rwestberg at openjdk.java.net Tue Feb 11 14:30:38 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 14:30:38 GMT Subject: git: openjdk/skara: Use different scratch folders for different repos Message-ID: <290c42e1-b93d-46cd-81eb-0ca2fb1f1f5e@openjdk.org> Changeset: 9e9559ad Author: Robin Westberg Date: 2020-02-11 14:30:20 +0000 URL: https://git.openjdk.java.net/skara/commit/9e9559ad Use different scratch folders for different repos Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java From rwestberg at openjdk.java.net Tue Feb 11 14:38:42 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 11 Feb 2020 14:38:42 GMT Subject: [Integrated] RFR: Improve cooldown test stability In-Reply-To: References: Message-ID: <8e2583ba-d8a2-4d44-a0b2-1b51e7c3ef6f@openjdk.org> Changeset: 4248ba2d Author: Robin Westberg Date: 2020-02-11 14:38:26 +0000 URL: https://git.openjdk.java.net/skara/commit/4248ba2d Improve cooldown test stability Reviewed-by: duke, ehelin ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From rwestberg at openjdk.java.net Wed Feb 12 08:35:10 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 12 Feb 2020 08:35:10 GMT Subject: [Rev 04] RFR: Fix parsing of editor commandline in git-pr In-Reply-To: References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: On Tue, 11 Feb 2020 13:22:23 GMT, Christoph Langer wrote: >> For git editor configurations that aren't a simple call to an editor but have more parameters, the starting of the editor in git pr does not work. >> At least, I observed this in my windows environment, where I have the following git config entry: >> core.editor="C:\\Program Files\\Notepad++\\notepad++.exe" -multiInst -notabbar -nosession -noPlugin > > The pull request has been updated with a new target base due to a merge or a rebase. Looks good to me! Hopefully we won't need more complex shell lexing than this :) My only concern is that the quotes will remain around the arguments, but I guess that's fine for at least the binary name. ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/259 From rwestberg at openjdk.java.net Wed Feb 12 10:59:27 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 12 Feb 2020 10:59:27 GMT Subject: RFR: Use seeded materialization when generating mails Message-ID: Hi all, Please review this change that uses seeded materialization when generating emails, to improve performance. Best regards, Robin ------------- Commits: - 430b8cda: Use seeded materialization when generating mails Changes: https://git.openjdk.java.net/skara/pull/428/files Webrev: https://webrevs.openjdk.java.net/skara/428/webrev.00 Stats: 24 lines in 3 files changed: 19 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/428.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/428/head:pull/428 PR: https://git.openjdk.java.net/skara/pull/428 From ehelin at openjdk.java.net Wed Feb 12 11:09:25 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 12 Feb 2020 11:09:25 GMT Subject: RFR: pr-bot: add contributors to summary Message-ID: Hi all, please review this patch that adds information about contributors to the PR body. Please note that we now have to run an extra pass with the `CheckWorkItem` to make it possible to update the PR body based on the results from the `CommandWorkItem`. Testing: - added a new unit test - `make test` passes on Linux x64 Thanks, Erik ------------- Commits: - 419e99e3: pr-bot: add contributors to summary Changes: https://git.openjdk.java.net/skara/pull/429/files Webrev: https://webrevs.openjdk.java.net/skara/429/webrev.00 Stats: 84 lines in 3 files changed: 84 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/429.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/429/head:pull/429 PR: https://git.openjdk.java.net/skara/pull/429 From rwestberg at openjdk.java.net Wed Feb 12 11:09:26 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 12 Feb 2020 11:09:26 GMT Subject: RFR: pr-bot: add contributors to summary In-Reply-To: References: Message-ID: On Wed, 12 Feb 2020 10:55:23 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds information about contributors to the PR > body. Please note that we now have to run an extra pass with the `CheckWorkItem` > to make it possible to update the PR body based on the results from the > `CommandWorkItem`. > > Testing: > - added a new unit test > - `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/429 From ehelin at openjdk.java.net Wed Feb 12 11:27:02 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 12 Feb 2020 11:27:02 GMT Subject: RFR: test-bot: better logging for IOException Message-ID: Hi all, please review this small patch that updates the logging for the test bot when it receives an `IOException`. Testing: - `make test` passes on Linux x64 Thanks, Erik ------------- Commits: - c90268cd: test-bot: better logging for IOException Changes: https://git.openjdk.java.net/skara/pull/430/files Webrev: https://webrevs.openjdk.java.net/skara/430/webrev.00 Stats: 42 lines in 1 file changed: 16 ins; 9 del; 17 mod Patch: https://git.openjdk.java.net/skara/pull/430.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/430/head:pull/430 PR: https://git.openjdk.java.net/skara/pull/430 From rwestberg at openjdk.java.net Wed Feb 12 11:27:02 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 12 Feb 2020 11:27:02 GMT Subject: RFR: test-bot: better logging for IOException In-Reply-To: References: Message-ID: On Wed, 12 Feb 2020 11:15:36 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that updates the logging for the test bot when it > receives an `IOException`. > > Testing: > - `make test` passes on Linux x64 > > Thanks, > Erik Looks good, just a minor comment. bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestBot.java line 100: > 99: log.info("Could not retrieve test jobs for PR: " + desc); > 100: log.info(e.getMessage()); > 101: } Perhaps use log.throwing here? ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/430 From ehelin at openjdk.java.net Wed Feb 12 12:52:51 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 12 Feb 2020 12:52:51 GMT Subject: RFR: Use seeded materialization when generating mails In-Reply-To: References: Message-ID: On Wed, 12 Feb 2020 10:49:26 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that uses seeded materialization when generating emails, to improve performance. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/428 From rwestberg at openjdk.java.net Wed Feb 12 14:52:44 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 12 Feb 2020 14:52:44 GMT Subject: [Integrated] RFR: Fix parsing of editor commandline in git-pr. In-Reply-To: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> References: <_LS_R7zJeioUPnMLoFfgIeN2PvfFIDx0s8v9qDKCKWw=.de806251-ec68-414f-8e45-f36f3a8a2522@github.com> Message-ID: <2c122fd2-62a1-47bd-ad4c-c1dba212644b@openjdk.org> Changeset: 9b9160be Author: Christoph Langer Committer: Robin Westberg Date: 2020-02-12 14:52:27 +0000 URL: https://git.openjdk.java.net/skara/commit/9b9160be Fix parsing of editor commandline in git-pr Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java From rwestberg at openjdk.java.net Wed Feb 12 14:56:51 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 12 Feb 2020 14:56:51 GMT Subject: [Integrated] RFR: Use seeded materialization when generating mails In-Reply-To: References: Message-ID: Changeset: 4b961c8a Author: Robin Westberg Date: 2020-02-12 14:56:34 +0000 URL: https://git.openjdk.java.net/skara/commit/4b961c8a Use seeded materialization when generating mails Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotBuilder.java From rwestberg at openjdk.java.net Wed Feb 12 15:27:29 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 12 Feb 2020 15:27:29 GMT Subject: RFR: 263: Add target repo and branch to subject of RFR email Message-ID: Hi all, Please review this change that optionally adds the name of the target repo and/or branch to the subject line of an RFR email. Best regards, Robin ------------- Commits: - 6bef52f4: Merge remote-tracking branch 'upstream/master' into branch_prefix - 2456ad1f: Add support for optional repo and branch prefix on generated RFR emails Changes: https://git.openjdk.java.net/skara/pull/431/files Webrev: https://webrevs.openjdk.java.net/skara/431/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-263 Stats: 265 lines in 7 files changed: 228 ins; 0 del; 37 mod Patch: https://git.openjdk.java.net/skara/pull/431.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/431/head:pull/431 PR: https://git.openjdk.java.net/skara/pull/431 From rwestberg at openjdk.java.net Wed Feb 12 15:35:59 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 12 Feb 2020 15:35:59 GMT Subject: RFR: Configure the mlbridge seed folder properly Message-ID: Hi all, Please review this small follow-up to #428 which properly configures the seed folder. Best regards, Robin ------------- Commits: - 64bc07ca: Actually configure the seed folder properly Changes: https://git.openjdk.java.net/skara/pull/432/files Webrev: https://webrevs.openjdk.java.net/skara/432/webrev.00 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/432.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/432/head:pull/432 PR: https://git.openjdk.java.net/skara/pull/432 From ehelin at openjdk.java.net Wed Feb 12 15:58:25 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 12 Feb 2020 15:58:25 GMT Subject: RFR: test-bot: better logging for IOException In-Reply-To: References: Message-ID: <80-on6aLy1_SIJf9dPCt8-dcp1yn8ORymu3oBfiCjh0=.718b12d1-b491-4c0a-847a-c49902c36ba4@github.com> On Wed, 12 Feb 2020 11:18:58 GMT, Robin Westberg wrote: >> Hi all, >> >> please review this small patch that updates the logging for the test bot when it >> receives an `IOException`. >> >> Testing: >> - `make test` passes on Linux x64 >> >> Thanks, >> Erik > > bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestBot.java line 100: > >> 99: log.info("Could not retrieve test jobs for PR: " + desc); >> 100: log.info(e.getMessage()); >> 101: } > > Perhaps use log.throwing here? Ah, good point, wasn't aware of that one ?? ------------- PR: https://git.openjdk.java.net/skara/pull/430 From ehelin at openjdk.java.net Wed Feb 12 15:59:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 12 Feb 2020 15:59:17 GMT Subject: RFR: Configure the mlbridge seed folder properly In-Reply-To: References: Message-ID: On Wed, 12 Feb 2020 15:14:21 GMT, Robin Westberg wrote: > Hi all, > > Please review this small follow-up to #428 which properly configures the seed folder. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/432 From ehelin at openjdk.java.net Wed Feb 12 16:07:18 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 12 Feb 2020 16:07:18 GMT Subject: RFR: 263: Add target repo and branch to subject of RFR email In-Reply-To: References: Message-ID: On Wed, 12 Feb 2020 14:54:55 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that optionally adds the name of the target repo and/or branch to the subject line of an RFR email. > > Best regards, > Robin Looks good, nice feature! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/431 From kcr at openjdk.java.net Wed Feb 12 16:13:49 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Wed, 12 Feb 2020 16:13:49 GMT Subject: RFR: 263: Add target repo and branch to subject of RFR email In-Reply-To: References: Message-ID: On Wed, 12 Feb 2020 16:05:09 GMT, Erik Helin wrote: >> Hi all, >> >> Please review this change that optionally adds the name of the target repo and/or branch to the subject line of an RFR email. >> >> Best regards, >> Robin > > Looks good, nice feature! Will this exclude the master branch? What I want is the branch name to be displayed only if it is other than master. ------------- PR: https://git.openjdk.java.net/skara/pull/431 From rwestberg at openjdk.java.net Wed Feb 12 16:22:18 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 12 Feb 2020 16:22:18 GMT Subject: RFR: 263: Add target repo and branch to subject of RFR email In-Reply-To: References: Message-ID: On Wed, 12 Feb 2020 16:11:39 GMT, Kevin Rushforth wrote: >> Looks good, nice feature! > > Will this exclude the master branch? What I want is the branch name to be displayed only if it is other than master. Yes, it is configured with a regular expression regarding which branch names to show. In your case, we can set it to something like `jfx.*` or even `^(?!.*master).*$`. ------------- PR: https://git.openjdk.java.net/skara/pull/431 From ehelin at openjdk.java.net Wed Feb 12 17:23:42 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 12 Feb 2020 17:23:42 GMT Subject: [Rev 01] RFR: test-bot: better logging for IOException In-Reply-To: References: Message-ID: > Hi all, > > please review this small patch that updates the logging for the test bot when it > receives an `IOException`. > > Testing: > - `make test` passes on Linux x64 > > Thanks, > Erik The pull request has been updated with 1 additional commit. ------------- Added commits: - 972370c4: Use log.throwing for reporting exceptions Changes: - all: https://git.openjdk.java.net/skara/pull/430/files - new: https://git.openjdk.java.net/skara/pull/430/files/c90268cd..972370c4 Webrevs: - full: https://webrevs.openjdk.java.net/skara/430/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/430/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/430.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/430/head:pull/430 PR: https://git.openjdk.java.net/skara/pull/430 From rwestberg at openjdk.java.net Thu Feb 13 06:58:12 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 13 Feb 2020 06:58:12 GMT Subject: [Integrated] RFR: Configure the mlbridge seed folder properly In-Reply-To: References: Message-ID: <7312da64-fb4f-4db0-9ec1-317da08bb5c1@openjdk.org> Changeset: f06967e7 Author: Robin Westberg Date: 2020-02-13 06:57:55 +0000 URL: https://git.openjdk.java.net/skara/commit/f06967e7 Configure the mlbridge seed folder properly Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java From rwestberg at openjdk.java.net Thu Feb 13 08:05:06 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 13 Feb 2020 08:05:06 GMT Subject: [Rev 01] RFR: 263: Add target repo and branch to subject of RFR email In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that optionally adds the name of the target repo and/or branch to the subject line of an RFR email. > > Best regards, > Robin The pull request has been updated with a new target base due to a merge or a rebase. ------------- Commits: - 8ca3abb0: Merge remote-tracking branch 'upstream/master' into branch_prefix - 6bef52f4: Merge remote-tracking branch 'upstream/master' into branch_prefix - 2456ad1f: Add support for optional repo and branch prefix on generated RFR emails Changes: https://git.openjdk.java.net/skara/pull/431/files Webrev: https://webrevs.openjdk.java.net/skara/431/webrev.01 Stats: 266 lines in 7 files changed: 228 ins; 0 del; 38 mod Patch: https://git.openjdk.java.net/skara/pull/431.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/431/head:pull/431 PR: https://git.openjdk.java.net/skara/pull/431 From rwestberg at openjdk.java.net Thu Feb 13 10:34:40 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 13 Feb 2020 10:34:40 GMT Subject: RFR: Check updated PRs for mailing list archive bridging Message-ID: Hi all, Please review this change that introduces support for fetching pull requests updated after a certain time/date. This allows catching comments made to closed PRs, without having to check every closed PR (which would be too expensive). Since certain forges (e.g. GitLab) do not update the updatedAt on every type of update, perform the regular check on all open issues periodically as well to catch any such updates. Best regards, Robin ------------- Commits: - 0e715511: Check updated PRs for mailing list archive bridging to catch comments on closed PRs Changes: https://git.openjdk.java.net/skara/pull/433/files Webrev: https://webrevs.openjdk.java.net/skara/433/webrev.00 Stats: 100 lines in 7 files changed: 90 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/skara/pull/433.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/433/head:pull/433 PR: https://git.openjdk.java.net/skara/pull/433 From rwestberg at openjdk.java.net Thu Feb 13 10:38:25 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 13 Feb 2020 10:38:25 GMT Subject: [Integrated] RFR: 263: Add target repo and branch to subject of RFR email In-Reply-To: References: Message-ID: <68fe4d4b-7ed1-4a1c-8d03-bbd50f618af9@openjdk.org> Changeset: e04fed3a Author: Robin Westberg Date: 2020-02-13 10:37:48 +0000 URL: https://git.openjdk.java.net/skara/commit/e04fed3a 263: Add target repo and branch to subject of RFR email Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotBuilder.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From rwestberg at openjdk.java.net Thu Feb 13 10:47:02 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 13 Feb 2020 10:47:02 GMT Subject: [Integrated] RFR: Check updated PRs for mailing list archive bridging In-Reply-To: References: Message-ID: Changeset: e18cfc58 Author: Robin Westberg Date: 2020-02-13 10:46:47 +0000 URL: https://git.openjdk.java.net/skara/commit/e18cfc58 Check updated PRs for mailing list archive bridging Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java ! bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryHostedRepository.java ! forge/src/main/java/org/openjdk/skara/forge/HostedRepository.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java ! test/src/main/java/org/openjdk/skara/test/TestHostedRepository.java From ehelin at openjdk.java.net Thu Feb 13 11:57:08 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 13 Feb 2020 11:57:08 GMT Subject: RFR: Check updated PRs for mailing list archive bridging In-Reply-To: References: Message-ID: On Thu, 13 Feb 2020 10:27:26 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that introduces support for fetching pull requests updated after a certain time/date. This allows catching comments made to closed PRs, without having to check every closed PR (which would be too expensive). > > Since certain forges (e.g. GitLab) do not update the updatedAt on every type of update, perform the regular check on all open issues periodically as well to catch any such updates. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/433 From rwestberg at openjdk.java.net Thu Feb 13 11:57:09 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 13 Feb 2020 11:57:09 GMT Subject: RFR: Check updated PRs for mailing list archive bridging In-Reply-To: References: Message-ID: On Thu, 13 Feb 2020 10:45:09 GMT, Erik Helin wrote: >> Hi all, >> >> Please review this change that introduces support for fetching pull requests updated after a certain time/date. This allows catching comments made to closed PRs, without having to check every closed PR (which would be too expensive). >> >> Since certain forges (e.g. GitLab) do not update the updatedAt on every type of update, perform the regular check on all open issues periodically as well to catch any such updates. >> >> Best regards, >> Robin > > Looks good! Looks like it is working! ------------- PR: https://git.openjdk.java.net/skara/pull/433 From ehelin at openjdk.java.net Thu Feb 13 12:59:33 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 13 Feb 2020 12:59:33 GMT Subject: [Integrated] RFR: test-bot: better logging for IOException In-Reply-To: References: Message-ID: <0f4f4eb5-3855-4d24-ac88-ac6d89007bd7@openjdk.org> Changeset: f8a0b667 Author: Erik Helin Date: 2020-02-13 12:59:17 +0000 URL: https://git.openjdk.java.net/skara/commit/f8a0b667 test-bot: better logging for IOException Reviewed-by: rwestberg ! bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestBot.java From ehelin at openjdk.java.net Thu Feb 13 12:59:59 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 13 Feb 2020 12:59:59 GMT Subject: [Integrated] RFR: pr-bot: add contributors to summary In-Reply-To: References: Message-ID: Changeset: 3857844a Author: Erik Helin Date: 2020-02-13 12:59:44 +0000 URL: https://git.openjdk.java.net/skara/commit/3857844a pr-bot: add contributors to summary Reviewed-by: rwestberg ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java From jvernee at openjdk.java.net Thu Feb 13 13:45:25 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Thu, 13 Feb 2020 13:45:25 GMT Subject: RFR: Add checkout instructions to PR body Message-ID: Hi, I'd like let the pr bot add the fetch comamnd found in the automatic emails to the PR body, so that people using only GitHub can see the instructions as well. This adds a new "Instructions" section to the body of the PR message: > ## Instructions > To checkout these changes locally: > ```bash > $ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16 > $ git checkout pull/16 > ``` Testing: - Running `.\gradlew test` Any other recommendations for testing this? Thanks, Jorn ------------- Commits: - 7de15f5c: Use instance method instead of passing PR as argument - 6f34266c: Add checkout instructions to PR body Changes: https://git.openjdk.java.net/skara/pull/434/files Webrev: https://webrevs.openjdk.java.net/skara/434/webrev.00 Stats: 16 lines in 1 file changed: 16 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/434.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/434/head:pull/434 PR: https://git.openjdk.java.net/skara/pull/434 From ehelin at openjdk.java.net Thu Feb 13 14:28:40 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 13 Feb 2020 14:28:40 GMT Subject: RFR: Add checkout instructions to PR body In-Reply-To: References: Message-ID: <9OTU_tWxTzxCZhTAu6Bdl9p-I2Gi06xvViX54NtHNaQ=.1465a335-7d79-4cc7-bcd9-f1e5dc5bdbf1@github.com> On Thu, 13 Feb 2020 13:29:44 GMT, Jorn Vernee wrote: > Hi, > > I'd like let the pr bot add the fetch comamnd found in the automatic emails to the PR body, so that people using only GitHub can see the instructions as well. > > This adds a new "Instructions" section to the body of the PR message: > >> ## Instructions >> To checkout these changes locally: >> ```bash >> $ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16 >> $ git checkout pull/16 >> ``` > > Testing: > - Running `.\gradlew test` > > Any other recommendations for testing this? > > Thanks, > Jorn Thanks Jorn, good idea ?? I think we might want to overhaul the design a little bit to accommodate for this new section. I added in some more section that might appear in a pull request - what do you think about the following? > ----------------------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [ ] Change must be properly reviewed (1/2) > > ### Reviewers > * Erik Duveblad ([ehelin](localhost) - **Reviewer**) > * Joe Darcy ([darcy](locahost) - **Reviewer**) ?? Re-review required (review applies to 7de15f5c44a6f4f5a18afda090d52b7b69c7d09c) > > ### Issue > * [JDK-8712393](localhost): Add download instructions to pull request > > > ### Contributors > * Robin Westberg ([rwestberg](localhost)) > > ### Download > `$ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16` > `$ git checkout pull/16` ------------- PR: https://git.openjdk.java.net/skara/pull/434 From ehelin at openjdk.java.net Thu Feb 13 15:49:22 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 13 Feb 2020 15:49:22 GMT Subject: RFR: Make Host::user return Optional Message-ID: Hi all, please review this refactoring that makes `Host::user` return an `Optional` to support cases when a username does not map to a user. Testing: - `make test` passes on Linux x64 Thanks, Erik ------------- Commits: - 61f86b04: Make Host::user return Optional Changes: https://git.openjdk.java.net/skara/pull/435/files Webrev: https://webrevs.openjdk.java.net/skara/435/webrev.00 Stats: 60 lines in 11 files changed: 32 ins; 0 del; 28 mod Patch: https://git.openjdk.java.net/skara/pull/435.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/435/head:pull/435 PR: https://git.openjdk.java.net/skara/pull/435 From ehelin at openjdk.java.net Thu Feb 13 16:06:14 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 13 Feb 2020 16:06:14 GMT Subject: RFR: Add HostUserDetails::email Message-ID: Hi all, please review this patch that adds the method `HostUserDetails::email`. It is rare for user to have public emails, but the bots can now take advantage of those rare cases. Testing: - `make test` on Linux x64 passes Thanks, Erik ------------- Commits: - c77e1d95: Add HostUserDetails::email Changes: https://git.openjdk.java.net/skara/pull/436/files Webrev: https://webrevs.openjdk.java.net/skara/436/webrev.00 Stats: 28 lines in 3 files changed: 25 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/436.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/436/head:pull/436 PR: https://git.openjdk.java.net/skara/pull/436 From rwestberg at openjdk.java.net Fri Feb 14 07:57:29 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 14 Feb 2020 07:57:29 GMT Subject: RFR: Make Host::user return Optional In-Reply-To: References: Message-ID: On Thu, 13 Feb 2020 15:34:32 GMT, Erik Helin wrote: > Hi all, > > please review this refactoring that makes `Host::user` return an > `Optional` to support cases when a username does not map to a user. > > Testing: > - `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/435 From rwestberg at openjdk.java.net Fri Feb 14 07:59:10 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 14 Feb 2020 07:59:10 GMT Subject: RFR: Add HostUserDetails::email In-Reply-To: References: Message-ID: On Thu, 13 Feb 2020 15:44:19 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the method `HostUserDetails::email`. It is > rare for user to have public emails, but the bots can now take advantage of > those rare cases. > > Testing: > - `make test` on Linux x64 passes > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/436 From rwestberg at openjdk.java.net Fri Feb 14 08:01:36 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 14 Feb 2020 08:01:36 GMT Subject: RFR: 270: Remove ignored reviews from the summary Message-ID: <8qdW7Wnq_Fxr0woXWEXxvXmGSpjstirqnx3BzUE34Gg=.e47afc06-4cfa-49f5-9ca3-7feea93b4daf@github.com> Hi all, Please review this change that when a project is configured to ignore stale reviews, the PR body is updated to reflect the status of reviews that are no longer applicable. Best regards, Robin ------------- Commits: - 779a9e65: Indicate if a review is no longer counted Changes: https://git.openjdk.java.net/skara/pull/437/files Webrev: https://webrevs.openjdk.java.net/skara/437/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-270 Stats: 23 lines in 3 files changed: 9 ins; 0 del; 14 mod Patch: https://git.openjdk.java.net/skara/pull/437.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/437/head:pull/437 PR: https://git.openjdk.java.net/skara/pull/437 From ehelin at openjdk.java.net Fri Feb 14 08:37:32 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 14 Feb 2020 08:37:32 GMT Subject: RFR: vcs: add support for Mercurial 5.3 Message-ID: Hi all, please review this patch that adds support for Mercurial 5.3 ------------- Commits: - c60e44aa: vcs: add support for Mercurial 5.3 Changes: https://git.openjdk.java.net/skara/pull/438/files Webrev: https://webrevs.openjdk.java.net/skara/438/webrev.00 Stats: 13 lines in 1 file changed: 6 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/438.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/438/head:pull/438 PR: https://git.openjdk.java.net/skara/pull/438 From rwestberg at openjdk.java.net Fri Feb 14 08:37:50 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 14 Feb 2020 08:37:50 GMT Subject: RFR: vcs: add support for Mercurial 5.3 In-Reply-To: References: Message-ID: <_DzhHbkAef5dQTKum2_qe6FY9dOm9_sFY-1iSpS4Jns=.87baeeb1-d65d-411b-966e-5e7aad980da9@github.com> On Fri, 14 Feb 2020 08:29:32 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds support for Mercurial 5.3. Mercurial changed its internal API slightly for 5.3, see [here](https://phab.mercurial-scm.org/D7406) for the relevant commit. The fix is simple, just make a `tuple` for the returned value `repo.status`. > > Testing: > - `make test` with _both_ hg 4.9 and 5.3 > > Thanks, > Erik Great, let's see if the mac build is happy now. ------------- PR: https://git.openjdk.java.net/skara/pull/438 From rwestberg at openjdk.java.net Fri Feb 14 09:27:03 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 14 Feb 2020 09:27:03 GMT Subject: RFR: vcs: add support for Mercurial 5.3 In-Reply-To: References: Message-ID: On Fri, 14 Feb 2020 08:29:32 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds support for Mercurial 5.3. Mercurial changed its internal API slightly for 5.3, see [here](https://phab.mercurial-scm.org/D7406) for the relevant commit. The fix is simple, just make a `tuple` for the returned value `repo.status`. > > Testing: > - `make test` with _both_ hg 4.9 and 5.3 > > Thanks, > Erik All builds passed, looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/438 From ehelin at openjdk.java.net Fri Feb 14 10:51:16 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 14 Feb 2020 10:51:16 GMT Subject: [Integrated] RFR: vcs: add support for Mercurial 5.3 In-Reply-To: References: Message-ID: Changeset: c23c574f Author: Erik Helin Date: 2020-02-14 10:50:51 +0000 URL: https://git.openjdk.java.net/skara/commit/c23c574f vcs: add support for Mercurial 5.3 Reviewed-by: rwestberg ! vcs/src/main/resources/ext.py From ehelin at openjdk.java.net Fri Feb 14 10:52:29 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 14 Feb 2020 10:52:29 GMT Subject: [Integrated] RFR: Make Host::user return Optional In-Reply-To: References: Message-ID: <99df24b0-01ed-48e7-a7a1-3b0aed212e5f@openjdk.org> Changeset: 57f1d634 Author: Erik Helin Date: 2020-02-14 10:52:05 +0000 URL: https://git.openjdk.java.net/skara/commit/57f1d634 Make Host::user return Optional Reviewed-by: rwestberg ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java ! bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryContinuousIntegration.java ! bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryHost.java ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabHost.java ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java ! host/src/main/java/org/openjdk/skara/host/Host.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraHost.java ! issuetracker/src/test/java/org/openjdk/skara/issuetracker/IssueTrackerTests.java ! test/src/main/java/org/openjdk/skara/test/TestHost.java From ehelin at openjdk.java.net Fri Feb 14 10:52:51 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 14 Feb 2020 10:52:51 GMT Subject: [Integrated] RFR: Add HostUserDetails::email In-Reply-To: References: Message-ID: Changeset: 4c469bf0 Author: Erik Helin Date: 2020-02-14 10:52:30 +0000 URL: https://git.openjdk.java.net/skara/commit/4c469bf0 Add HostUserDetails::email Reviewed-by: rwestberg ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabHost.java ! host/src/main/java/org/openjdk/skara/host/HostUser.java From ehelin at openjdk.java.net Fri Feb 14 10:53:44 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 14 Feb 2020 10:53:44 GMT Subject: RFR: 270: Remove ignored reviews from the summary In-Reply-To: <8qdW7Wnq_Fxr0woXWEXxvXmGSpjstirqnx3BzUE34Gg=.e47afc06-4cfa-49f5-9ca3-7feea93b4daf@github.com> References: <8qdW7Wnq_Fxr0woXWEXxvXmGSpjstirqnx3BzUE34Gg=.e47afc06-4cfa-49f5-9ca3-7feea93b4daf@github.com> Message-ID: On Fri, 14 Feb 2020 07:51:19 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that when a project is configured to ignore stale reviews, the PR body is updated to reflect the status of reviews that are no longer applicable. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/437 From rwestberg at openjdk.java.net Fri Feb 14 11:46:27 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 14 Feb 2020 11:46:27 GMT Subject: RFR: 279: Optionally only update project-specific issues Message-ID: Hi all, Please review this change that allows the issue notifier to only update issues when the commit originates from a matching PR. This can be used for projects that merge commits from/to different branches, but only want to be notified about the original commit resulting from a PR integration. Best regards, Robin ------------- Commits: - b3626fe9: Merge remote-tracking branch 'upstream/master' into notify_pronly - d32a0c02: Implement pr-only issue notification Changes: https://git.openjdk.java.net/skara/pull/439/files Webrev: https://webrevs.openjdk.java.net/skara/439/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-279 Stats: 118 lines in 3 files changed: 92 ins; 4 del; 22 mod Patch: https://git.openjdk.java.net/skara/pull/439.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/439/head:pull/439 PR: https://git.openjdk.java.net/skara/pull/439 From rwestberg at openjdk.java.net Fri Feb 14 13:31:37 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 14 Feb 2020 13:31:37 GMT Subject: [Integrated] RFR: 270: Remove ignored reviews from the summary In-Reply-To: <8qdW7Wnq_Fxr0woXWEXxvXmGSpjstirqnx3BzUE34Gg=.e47afc06-4cfa-49f5-9ca3-7feea93b4daf@github.com> References: <8qdW7Wnq_Fxr0woXWEXxvXmGSpjstirqnx3BzUE34Gg=.e47afc06-4cfa-49f5-9ca3-7feea93b4daf@github.com> Message-ID: <54b91039-1a64-4bf5-9181-18bcd9be7c14@openjdk.org> Changeset: 7f3f4b2e Author: Robin Westberg Date: 2020-02-14 13:31:18 +0000 URL: https://git.openjdk.java.net/skara/commit/7f3f4b2e 270: Remove ignored reviews from the summary Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java From ehelin at openjdk.java.net Fri Feb 14 14:58:52 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 14 Feb 2020 14:58:52 GMT Subject: RFR: 279: Optionally only update project-specific issues In-Reply-To: References: Message-ID: <3z93T2Bb-OHEuSEehEeIrr2YNTJ1u6W42sHgJ7zDsZE=.66d49cb6-6083-4e60-be50-a4494fee49fd@github.com> On Fri, 14 Feb 2020 11:37:44 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows the issue notifier to only update issues when the commit originates from a matching PR. This can be used for projects that merge commits from/to different branches, but only want to be notified about the original commit resulting from a PR integration. > > Best regards, > Robin bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java line 266: > 265: .filter(pr -> pr.targetRef().equals(branch.name())) > 266: .collect(Collectors.toList()); > 267: if (pullRequests.size() == 0) { Use [Stream.count](https://docs.oracle.com/en/java/javase/13/docs/api/java.base/java/util/stream/Stream.html#count()) here instead of materializing the list? You would have to change the following `if` to `if (count == 0L) {`. ------------- PR: https://git.openjdk.java.net/skara/pull/439 From aph at redhat.com Fri Feb 14 16:36:53 2020 From: aph at redhat.com (Andrew Haley) Date: Fri, 14 Feb 2020 16:36:53 +0000 Subject: Does this error matter? Message-ID: <70743b5d-28a3-07fe-b4ae-b3bf4c1d4555@redhat.com> Removing java_mirror ... done. mc space: 8608 [ 0.1% of total] out of 12288 bytes [ 70.1% used] at 0x0000000800000000 rw space: 4007528 [ 33.6% of total] out of 4009984 bytes [ 99.9% used] at 0x0000000800003000 ro space: 7227800 [ 60.7% of total] out of 7229440 bytes [100.0% used] at 0x00000008003d6000 md space: 2320 [ 0.0% of total] out of 4096 bytes [ 56.6% used] at 0x0000000800abb000 ca0 space: 413696 [ 3.5% of total] out of 413696 bytes [100.0% used] at 0x00000007ffc00000 oa0 space: 241664 [ 2.0% of total] out of 241664 bytes [100.0% used] at 0x00000007ff800000 total : 11901616 [100.0% of total] out of 11911168 bytes [ 99.9% used] BUILD SUCCESSFUL in 39s 44 actionable tasks: 44 executed ** (process:69472): CRITICAL **: 16:24:17.542: could not connect to Secret Service: Error calling StartServiceByName for org.freedesktop.secrets: Timeout was reached Username for 'https://github.com': theRealAph Password for 'https://theRealAph at github.com': ** (process:69617): CRITICAL **: 16:25:39.630: store failed: Error calling StartServiceByName for org.freedesktop.secrets: Timeout was reached -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From aph at redhat.com Sat Feb 15 09:05:25 2020 From: aph at redhat.com (Andrew Haley) Date: Sat, 15 Feb 2020 09:05:25 +0000 Subject: Does this error matter? Message-ID: <5bc25c0a-5b42-3207-bcc9-9b558523ae38@redhat.com> Removing java_mirror ... done. mc space: 8608 [ 0.1% of total] out of 12288 bytes [ 70.1% used] at 0x0000000800000000 rw space: 4007528 [ 33.6% of total] out of 4009984 bytes [ 99.9% used] at 0x0000000800003000 ro space: 7227800 [ 60.7% of total] out of 7229440 bytes [100.0% used] at 0x00000008003d6000 md space: 2320 [ 0.0% of total] out of 4096 bytes [ 56.6% used] at 0x0000000800abb000 ca0 space: 413696 [ 3.5% of total] out of 413696 bytes [100.0% used] at 0x00000007ffc00000 oa0 space: 241664 [ 2.0% of total] out of 241664 bytes [100.0% used] at 0x00000007ff800000 total : 11901616 [100.0% of total] out of 11911168 bytes [ 99.9% used] BUILD SUCCESSFUL in 39s 44 actionable tasks: 44 executed ** (process:69472): CRITICAL **: 16:24:17.542: could not connect to Secret Service: Error calling StartServiceByName for org.freedesktop.secrets: Timeout was reached Username for 'https://github.com': theRealAph Password for 'https://theRealAph at github.com': ** (process:69617): CRITICAL **: 16:25:39.630: store failed: Error calling StartServiceByName for org.freedesktop.secrets: Timeout was reached -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From rwestberg at openjdk.java.net Mon Feb 17 08:15:05 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 17 Feb 2020 08:15:05 GMT Subject: [Rev 01] RFR: 279: Optionally only update project-specific issues In-Reply-To: References: Message-ID: <8AyrUHHv0WNpT-baFGxcpHCiH_FlX7XjqqjAtUZOvow=.d5bd23f7-04be-46de-be1c-6e9f17133b80@github.com> > Hi all, > > Please review this change that allows the issue notifier to only update issues when the commit originates from a matching PR. This can be used for projects that merge commits from/to different branches, but only want to be notified about the original commit resulting from a PR integration. > > Best regards, > Robin The pull request has been updated with 1 additional commit. ------------- Added commits: - a0b93de0: Updated after review Changes: - all: https://git.openjdk.java.net/skara/pull/439/files - new: https://git.openjdk.java.net/skara/pull/439/files/b3626fe9..a0b93de0 Webrevs: - full: https://webrevs.openjdk.java.net/skara/439/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/439/webrev.00-01 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/439.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/439/head:pull/439 PR: https://git.openjdk.java.net/skara/pull/439 From rwestberg at openjdk.java.net Mon Feb 17 08:15:06 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 17 Feb 2020 08:15:06 GMT Subject: [Rev 01] RFR: 279: Optionally only update project-specific issues In-Reply-To: <3z93T2Bb-OHEuSEehEeIrr2YNTJ1u6W42sHgJ7zDsZE=.66d49cb6-6083-4e60-be50-a4494fee49fd@github.com> References: <3z93T2Bb-OHEuSEehEeIrr2YNTJ1u6W42sHgJ7zDsZE=.66d49cb6-6083-4e60-be50-a4494fee49fd@github.com> Message-ID: On Fri, 14 Feb 2020 14:56:36 GMT, Erik Helin wrote: >> The pull request has been updated with 1 additional commit. > > bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java line 266: > >> 265: .filter(pr -> pr.targetRef().equals(branch.name())) >> 266: .collect(Collectors.toList()); >> 267: if (pullRequests.size() == 0) { > > Use [Stream.count](https://docs.oracle.com/en/java/javase/13/docs/api/java.base/java/util/stream/Stream.html#count()) here instead of materializing the list? You would have to change the following `if` to `if (count == 0L) {`. Good point, will fix! ------------- PR: https://git.openjdk.java.net/skara/pull/439 From rwestberg at openjdk.java.net Mon Feb 17 08:49:47 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 17 Feb 2020 08:49:47 GMT Subject: [Integrated] RFR: 279: Optionally only update project-specific issues In-Reply-To: References: Message-ID: <13c00644-8764-4c4a-9ba2-f70c03d584b6@openjdk.org> Changeset: a0b9185b Author: Robin Westberg Date: 2020-02-17 08:49:18 +0000 URL: https://git.openjdk.java.net/skara/commit/a0b9185b 279: Optionally only update project-specific issues Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/NotifyBotFactory.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From ehelin at openjdk.java.net Mon Feb 17 08:50:25 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 17 Feb 2020 08:50:25 GMT Subject: [Rev 01] RFR: 279: Optionally only update project-specific issues In-Reply-To: <8AyrUHHv0WNpT-baFGxcpHCiH_FlX7XjqqjAtUZOvow=.d5bd23f7-04be-46de-be1c-6e9f17133b80@github.com> References: <8AyrUHHv0WNpT-baFGxcpHCiH_FlX7XjqqjAtUZOvow=.d5bd23f7-04be-46de-be1c-6e9f17133b80@github.com> Message-ID: <8Lg9lmdQp00jFFR7pS7FXLixKMAu9YPDVrEy56gvcxg=.223a6670-5f82-42e5-a487-b9d6d827f28f@github.com> On Mon, 17 Feb 2020 08:15:05 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this change that allows the issue notifier to only update issues when the commit originates from a matching PR. This can be used for projects that merge commits from/to different branches, but only want to be notified about the original commit resulting from a PR integration. >> >> Best regards, >> Robin > > The pull request has been updated with 1 additional commit. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/439 From erik.helin at oracle.com Mon Feb 17 09:08:34 2020 From: erik.helin at oracle.com (Erik Helin) Date: Mon, 17 Feb 2020 10:08:34 +0100 Subject: Does this error matter? In-Reply-To: <70743b5d-28a3-07fe-b4ae-b3bf4c1d4555@redhat.com> References: <70743b5d-28a3-07fe-b4ae-b3bf4c1d4555@redhat.com> Message-ID: On 2/14/20 5:36 PM, Andrew Haley wrote: > Removing java_mirror ... done. > mc space: 8608 [ 0.1% of total] out of 12288 bytes [ 70.1% used] at 0x0000000800000000 > rw space: 4007528 [ 33.6% of total] out of 4009984 bytes [ 99.9% used] at 0x0000000800003000 > ro space: 7227800 [ 60.7% of total] out of 7229440 bytes [100.0% used] at 0x00000008003d6000 > md space: 2320 [ 0.0% of total] out of 4096 bytes [ 56.6% used] at 0x0000000800abb000 > ca0 space: 413696 [ 3.5% of total] out of 413696 bytes [100.0% used] at 0x00000007ffc00000 > oa0 space: 241664 [ 2.0% of total] out of 241664 bytes [100.0% used] at 0x00000007ff800000 > total : 11901616 [100.0% of total] out of 11911168 bytes [ 99.9% used] > > BUILD SUCCESSFUL in 39s > 44 actionable tasks: 44 executed What command did you run? `make`, `git skara update` or `sh gradlew`? > ** (process:69472): CRITICAL **: 16:24:17.542: could not connect to Secret Service: Error calling StartServiceByName for org.freedesktop.secrets: Timeout was reached > Username for 'https://github.com': theRealAph > Password for 'https://theRealAph at github.com': > > ** (process:69617): CRITICAL **: 16:25:39.630: store failed: Error calling StartServiceByName for org.freedesktop.secrets: Timeout was reached > The message you are seeing most likely comes from the git-credential-helper [0] you are using. I can see that you are using GNU/Linux, I'm guessing RHEL? If so, which version of RHEL? Did you follow the instructions for Fedora on the Skara wiki [1] when setting up the credential helper? If you did, then you are using the "libsecret" helper [2]. The git "libsecret" credential helper is a small wrapper around libsecret [3]. libsecret is going to communicate over dbus [4] with a implementation of the 'org.freedesktop.secrets' service (e.g. gnome-keyring [5]). From the message it seems like the libsecret library can't start the 'org.freedesktop.secrets' service, you might want to check in /var/log/syslog to see if there are any additional log messages (see for example [6]). If you believe you have found a bug in libsecret then you can file an issue in their GitLab issue tracker [7]. Unfortunately there is not much Skara can do to help fix this issue, this error occurs at lower level in your GNU/Linux desktop stack :( Did you run `git token store https://github.com` as described on the Skara wiki [8] for storing you personal access token? Did that work? Thanks, Erik [0]: https://git-scm.com/docs/gitcredentials#Documentation/gitcredentials.txt-helper [1]: https://wiki.openjdk.java.net/display/skara#Skara-GNU/Linux.1 [2]: https://github.com/git/git/blob/master/contrib/credential/libsecret/git-credential-libsecret.c [3]: https://wiki.gnome.org/Projects/Libsecret [4]: https://www.freedesktop.org/wiki/Software/dbus/ [5]: https://wiki.gnome.org/Projects/GnomeKeyring/ [6]: https://gitlab.gnome.org/GNOME/libsecret/issues/19 [7]: https://gitlab.gnome.org/GNOME/libsecret/issues/ [8]: https://wiki.openjdk.java.net/display/skara#Skara-PersonalAccessToken From aph at redhat.com Mon Feb 17 10:00:38 2020 From: aph at redhat.com (Andrew Haley) Date: Mon, 17 Feb 2020 10:00:38 +0000 Subject: Does this error matter? In-Reply-To: References: <70743b5d-28a3-07fe-b4ae-b3bf4c1d4555@redhat.com> Message-ID: <86838845-1412-9807-3e23-8e7666f09e7c@redhat.com> On 2/17/20 9:08 AM, Erik Helin wrote: > On 2/14/20 5:36 PM, Andrew Haley wrote: >> Removing java_mirror ... done. >> mc space: 8608 [ 0.1% of total] out of 12288 bytes [ 70.1% used] at 0x0000000800000000 >> rw space: 4007528 [ 33.6% of total] out of 4009984 bytes [ 99.9% used] at 0x0000000800003000 >> ro space: 7227800 [ 60.7% of total] out of 7229440 bytes [100.0% used] at 0x00000008003d6000 >> md space: 2320 [ 0.0% of total] out of 4096 bytes [ 56.6% used] at 0x0000000800abb000 >> ca0 space: 413696 [ 3.5% of total] out of 413696 bytes [100.0% used] at 0x00000007ffc00000 >> oa0 space: 241664 [ 2.0% of total] out of 241664 bytes [100.0% used] at 0x00000007ff800000 >> total : 11901616 [100.0% of total] out of 11911168 bytes [ 99.9% used] >> >> BUILD SUCCESSFUL in 39s >> 44 actionable tasks: 44 executed > > What command did you run? `make`, `git skara update` or `sh gradlew`? $ git token store https://github.com/ >> ** (process:69472): CRITICAL **: 16:24:17.542: could not connect to Secret Service: Error calling StartServiceByName for org.freedesktop.secrets: Timeout was reached >> Username for 'https://github.com': theRealAph >> Password for 'https://theRealAph at github.com': >> >> ** (process:69617): CRITICAL **: 16:25:39.630: store failed: Error calling StartServiceByName for org.freedesktop.secrets: Timeout was reached >> > > The message you are seeing most likely comes from the > git-credential-helper [0] you are using. I can see that you are using > GNU/Linux, I'm guessing RHEL? If so, which version of RHEL? RHEL 8. > Did you follow the instructions for Fedora on the Skara wiki [1] > when setting up the credential helper? If you did, then you are > using the "libsecret" helper [2]. The git "libsecret" credential > helper is a small wrapper around libsecret [3]. libsecret is going > to communicate over dbus [4] with a implementation of the > 'org.freedesktop.secrets' service (e.g. gnome-keyring [5]). Yes, I did. > From the message it seems like the libsecret library can't start the > 'org.freedesktop.secrets' service, you might want to check in > /var/log/syslog to see if there are any additional log messages (see for > example [6]). If you believe you have found a bug in libsecret then you > can file an issue in their GitLab issue tracker [7]. Unfortunately there > is not much Skara can do to help fix this issue, this error occurs at > lower level in your GNU/Linux desktop stack :( Yeah, OK. So there's some problem there. Does Skara need this stuff? Git seems to work without it. > Did you run `git token store https://github.com` as described on the > Skara wiki [8] for storing you personal access token? Did that work? No, it failed with the same error. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From rwestberg at openjdk.java.net Mon Feb 17 10:47:03 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 17 Feb 2020 10:47:03 GMT Subject: git: openjdk/skara: Refactor notifier bot constructors Message-ID: Changeset: 2ef003b5 Author: Robin Westberg Date: 2020-02-17 10:46:13 +0000 URL: https://git.openjdk.java.net/skara/commit/2ef003b5 Refactor notifier bot constructors Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotBuilder.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java + bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdaterBuilder.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java + bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdaterBuilder.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/NotifyBot.java + bots/notify/src/main/java/org/openjdk/skara/bots/notify/NotifyBotBuilder.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/NotifyBotFactory.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From ehelin at openjdk.java.net Mon Feb 17 10:59:50 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 17 Feb 2020 10:59:50 GMT Subject: RFR: git-pr: show commit messages Message-ID: Hi all, please review this patch that adds commit messages to webrevs (if applicable). The current `MetadataFormatter` is a bit bare-bones, I plan to enhance it in future patches. I had to implement a few overloads of `commitMetadata` to support this feature, hence the changes to `vcs`. Testing: - Added unit tests for `commitMetadata` - Manual testing of `git-webrev` for both Git and Mercurial repositories Thanks, Erik ------------- Commits: - 33a8ded3: git-pr: show commit messages Changes: https://git.openjdk.java.net/skara/pull/441/files Webrev: https://webrevs.openjdk.java.net/skara/441/webrev.00 Stats: 329 lines in 11 files changed: 311 ins; 2 del; 16 mod Patch: https://git.openjdk.java.net/skara/pull/441.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/441/head:pull/441 PR: https://git.openjdk.java.net/skara/pull/441 From rwestberg at openjdk.java.net Mon Feb 17 10:41:17 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 17 Feb 2020 10:41:17 GMT Subject: RFR: Refactor notifier bot constructors Message-ID: Hi all, Please review this refactoring change that changes a few multi-argument-constructors into builders instead. Best regards, Robin ------------- Commits: - 2281f3c0: Builderify IssueUpdater - 0d1c76f6: Builderify MailingListUpdater - 5697a8c4: Fix unnecessary use of pattern - 8fa3e280: Builderify notify bot Changes: https://git.openjdk.java.net/skara/pull/440/files Webrev: https://webrevs.openjdk.java.net/skara/440/webrev.00 Stats: 773 lines in 13 files changed: 618 ins; 23 del; 132 mod Patch: https://git.openjdk.java.net/skara/pull/440.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/440/head:pull/440 PR: https://git.openjdk.java.net/skara/pull/440 From ehelin at openjdk.java.net Mon Feb 17 10:41:32 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 17 Feb 2020 10:41:32 GMT Subject: RFR: Refactor notifier bot constructors In-Reply-To: References: Message-ID: On Mon, 17 Feb 2020 10:31:20 GMT, Robin Westberg wrote: > Hi all, > > Please review this refactoring change that changes a few multi-argument-constructors into builders instead. > > Best regards, > Robin Looks good ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/440 From jvernee at openjdk.java.net Mon Feb 17 11:16:21 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Mon, 17 Feb 2020 11:16:21 GMT Subject: RFR: Add checkout instructions to PR body In-Reply-To: <9OTU_tWxTzxCZhTAu6Bdl9p-I2Gi06xvViX54NtHNaQ=.1465a335-7d79-4cc7-bcd9-f1e5dc5bdbf1@github.com> References: <9OTU_tWxTzxCZhTAu6Bdl9p-I2Gi06xvViX54NtHNaQ=.1465a335-7d79-4cc7-bcd9-f1e5dc5bdbf1@github.com> Message-ID: On Thu, 13 Feb 2020 14:26:29 GMT, Erik Helin wrote: >> Hi, >> >> I'd like let the pr bot add the fetch comamnd found in the automatic emails to the PR body, so that people using only GitHub can see the instructions as well. >> >> This adds a new "Instructions" section to the body of the PR message: >> >>> ## Instructions >>> To checkout these changes locally: >>> ```bash >>> $ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16 >>> $ git checkout pull/16 >>> ``` >> >> Testing: >> - Running `.\gradlew test` >> >> Any other recommendations for testing this? >> >> Thanks, >> Jorn > > Thanks Jorn, good idea ?? I think we might want to overhaul the design a little bit to accommodate for this new section. I added in some more sections that might appear in a pull request - what do you think about the following? > >> ----------------------- >> ### Progress >> - [x] Change must not contain extraneous whitespace >> - [ ] Change must be properly reviewed (1/2) >> >> ### Issues >> * [JDK-8712393](localhost): Add download instructions to pull request >> >> ### Contributors >> * Robin Westberg ([rwestberg](localhost)) >> >> ### Reviewers >> * Erik Duveblad ([ehelin](localhost) - **Reviewer**) >> * Joe Darcy ([darcy](locahost) - **Reviewer**) ?? Re-review required (review applies to 7de15f5c44a6f4f5a18afda090d52b7b69c7d09c) >> >> ### Download >> `$ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16` >> `$ git checkout pull/16` Hey Erik, I like the new format that you suggest as well :) I've applied the suggestions. ------------- PR: https://git.openjdk.java.net/skara/pull/434 From jvernee at openjdk.java.net Mon Feb 17 11:16:20 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Mon, 17 Feb 2020 11:16:20 GMT Subject: [Rev 01] RFR: Add checkout instructions to PR body In-Reply-To: References: Message-ID: <_knqqcz0XdvYsqDzOYQbTxs9xqCADKT7PGP_RDcW-LQ=.987bd378-73b6-4b2d-a001-d677e4d042ea@github.com> > Hi, > > I'd like let the pr bot add the fetch comamnd found in the automatic emails to the PR body, so that people using only GitHub can see the instructions as well. > > This adds a new "Instructions" section to the body of the PR message: > >> ## Instructions >> To checkout these changes locally: >> ```bash >> $ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16 >> $ git checkout pull/16 >> ``` > > Testing: > - Running `.\gradlew test` > > Any other recommendations for testing this? > > Thanks, > Jorn The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Added commits: - 0774b382: Remove some unneeded lines - 6b97147e: Update message format after suggestions - 94cf7816: Use instance method instead of passing PR as argument - e8abf3ff: Add checkout instructions to PR body - 2ef003b5: Refactor notifier bot constructors - a0b9185b: 279: Optionally only update project-specific issues - 7f3f4b2e: 270: Remove ignored reviews from the summary - 4c469bf0: Add HostUserDetails::email - 57f1d634: Make Host::user return Optional - c23c574f: vcs: add support for Mercurial 5.3 Changes: - all: https://git.openjdk.java.net/skara/pull/434/files - new: https://git.openjdk.java.net/skara/pull/434/files/7de15f5c..0774b382 Webrevs: - full: https://webrevs.openjdk.java.net/skara/434/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/434/webrev.00-01 Stats: 1006 lines in 28 files changed: 779 ins; 28 del; 199 mod Patch: https://git.openjdk.java.net/skara/pull/434.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/434/head:pull/434 PR: https://git.openjdk.java.net/skara/pull/434 From rwestberg at openjdk.java.net Mon Feb 17 12:14:15 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 17 Feb 2020 12:14:15 GMT Subject: RFR: git-webrev: show commit messages In-Reply-To: References: Message-ID: <7S1h81XUwiep9xkmzBK6A3FDXWu49DYvJ82uLGA5Hew=.e02a6b86-bbc2-4dac-a5ce-ec30342624d3@github.com> On Mon, 17 Feb 2020 10:48:48 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds commit messages to webrevs (if applicable). > The current `MetadataFormatter` is a bit bare-bones, I plan to enhance it in > future patches. I had to implement a few overloads of `commitMetadata` to > support this feature, hence the changes to `vcs`. > > Testing: > - Added unit tests for `commitMetadata` > - Manual testing of `git-webrev` for both Git and Mercurial repositories > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/441 From erik.helin at oracle.com Mon Feb 17 12:56:32 2020 From: erik.helin at oracle.com (Erik Helin) Date: Mon, 17 Feb 2020 13:56:32 +0100 Subject: Does this error matter? In-Reply-To: <86838845-1412-9807-3e23-8e7666f09e7c@redhat.com> References: <70743b5d-28a3-07fe-b4ae-b3bf4c1d4555@redhat.com> <86838845-1412-9807-3e23-8e7666f09e7c@redhat.com> Message-ID: On 2/17/20 11:00 AM, Andrew Haley wrote: > On 2/17/20 9:08 AM, Erik Helin wrote: >> On 2/14/20 5:36 PM, Andrew Haley wrote: >>> Removing java_mirror ... done. >>> mc space: 8608 [ 0.1% of total] out of 12288 bytes [ 70.1% used] at 0x0000000800000000 >>> rw space: 4007528 [ 33.6% of total] out of 4009984 bytes [ 99.9% used] at 0x0000000800003000 >>> ro space: 7227800 [ 60.7% of total] out of 7229440 bytes [100.0% used] at 0x00000008003d6000 >>> md space: 2320 [ 0.0% of total] out of 4096 bytes [ 56.6% used] at 0x0000000800abb000 >>> ca0 space: 413696 [ 3.5% of total] out of 413696 bytes [100.0% used] at 0x00000007ffc00000 >>> oa0 space: 241664 [ 2.0% of total] out of 241664 bytes [100.0% used] at 0x00000007ff800000 >>> total : 11901616 [100.0% of total] out of 11911168 bytes [ 99.9% used] >>> >>> BUILD SUCCESSFUL in 39s >>> 44 actionable tasks: 44 executed >> >> What command did you run? `make`, `git skara update` or `sh gradlew`? > > $ git token store https://github.com/ Ah ok, Skara just bootstrapped itself. >>> ** (process:69472): CRITICAL **: 16:24:17.542: could not connect to Secret Service: Error calling StartServiceByName for org.freedesktop.secrets: Timeout was reached >>> Username for 'https://github.com': theRealAph >>> Password for 'https://theRealAph at github.com': >>> >>> ** (process:69617): CRITICAL **: 16:25:39.630: store failed: Error calling StartServiceByName for org.freedesktop.secrets: Timeout was reached >>> >> >> The message you are seeing most likely comes from the >> git-credential-helper [0] you are using. I can see that you are using >> GNU/Linux, I'm guessing RHEL? If so, which version of RHEL? > > RHEL 8. Ok. >> Did you follow the instructions for Fedora on the Skara wiki [1] >> when setting up the credential helper? If you did, then you are >> using the "libsecret" helper [2]. The git "libsecret" credential >> helper is a small wrapper around libsecret [3]. libsecret is going >> to communicate over dbus [4] with a implementation of the >> 'org.freedesktop.secrets' service (e.g. gnome-keyring [5]). > > Yes, I did. > >> From the message it seems like the libsecret library can't start the >> 'org.freedesktop.secrets' service, you might want to check in >> /var/log/syslog to see if there are any additional log messages (see for >> example [6]). If you believe you have found a bug in libsecret then you >> can file an issue in their GitLab issue tracker [7]. Unfortunately there >> is not much Skara can do to help fix this issue, this error occurs at >> lower level in your GNU/Linux desktop stack :( > > Yeah, OK. So there's some problem there. > > Does Skara need this stuff? Git seems to work without it. Yes, Git works fine without this. Skara does not strictly need this, but the Skara tooling will ask you for you username and personal access token (PAT) every time if you do not store them in a credential store using a credential helper. We do support supplying your token via an environment variable for users who do not wish to (or are unable to) use a token store. See the description under the "Manual" section on the Skara wiki [0] for an example using gpg. Depending on your security needs you can also use the "cache" and/or "store" credential helpers, see [1] for more details. >> Did you run `git token store https://github.com` as described on the >> Skara wiki [8] for storing you personal access token? Did that work? > > No, it failed with the same error. Ok. Thanks, Erik [0]: https://wiki.openjdk.java.net/display/skara#Skara-GNU/Linux.1 [1]: https://git-scm.com/docs/gitcredentials#_avoiding_repetition From rwestberg at openjdk.java.net Mon Feb 17 14:19:15 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 17 Feb 2020 14:19:15 GMT Subject: RFR: 280: Notifier should support repo/branch prefixes Message-ID: Hi all, Please review this change that add support for repo/branch prefixes to the mails sent by the PR notifier. Best regards, Robin ------------- Commits: - 30f68ed5: Add optional subject prefix for pr notifier Changes: https://git.openjdk.java.net/skara/pull/442/files Webrev: https://webrevs.openjdk.java.net/skara/442/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-280 Stats: 142 lines in 4 files changed: 135 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/442.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/442/head:pull/442 PR: https://git.openjdk.java.net/skara/pull/442 From ehelin at openjdk.java.net Mon Feb 17 14:47:16 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 17 Feb 2020 14:47:16 GMT Subject: RFR: 275: PR bot should allows merge-style PRs with only branch names In-Reply-To: References: Message-ID: On Mon, 17 Feb 2020 14:30:35 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows merge-style PRs to only reference the source branch name, in case the source is in the same repository. > > Best regards, > Robin Looks good, nice fix! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/443 From rwestberg at openjdk.java.net Mon Feb 17 14:43:17 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 17 Feb 2020 14:43:17 GMT Subject: RFR: 275: PR bot should allows merge-style PRs with only branch names Message-ID: Hi all, Please review this change that allows merge-style PRs to only reference the source branch name, in case the source is in the same repository. Best regards, Robin ------------- Commits: - 3467d1f2: Allow intra-repo merges with branchname only Changes: https://git.openjdk.java.net/skara/pull/443/files Webrev: https://webrevs.openjdk.java.net/skara/443/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-275 Stats: 111 lines in 2 files changed: 90 ins; 2 del; 19 mod Patch: https://git.openjdk.java.net/skara/pull/443.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/443/head:pull/443 PR: https://git.openjdk.java.net/skara/pull/443 From ehelin at openjdk.java.net Mon Feb 17 14:43:45 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 17 Feb 2020 14:43:45 GMT Subject: RFR: 280: Notifier should support repo/branch prefixes In-Reply-To: References: Message-ID: On Mon, 17 Feb 2020 14:07:11 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that add support for repo/branch prefixes to the mails sent by the PR notifier. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/442 From ehelin at openjdk.java.net Mon Feb 17 15:01:35 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 17 Feb 2020 15:01:35 GMT Subject: [Rev 01] RFR: Add checkout instructions to PR body In-Reply-To: <_knqqcz0XdvYsqDzOYQbTxs9xqCADKT7PGP_RDcW-LQ=.987bd378-73b6-4b2d-a001-d677e4d042ea@github.com> References: <_knqqcz0XdvYsqDzOYQbTxs9xqCADKT7PGP_RDcW-LQ=.987bd378-73b6-4b2d-a001-d677e4d042ea@github.com> Message-ID: On Mon, 17 Feb 2020 11:16:20 GMT, Jorn Vernee wrote: >> Hi, >> >> I'd like let the pr bot add the fetch comamnd found in the automatic emails to the PR body, so that people using only GitHub can see the instructions as well. >> >> This adds a new "Instructions" section to the body of the PR message: >> >>> ## Instructions >>> To checkout these changes locally: >>> ```bash >>> $ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16 >>> $ git checkout pull/16 >>> ``` >> >> Testing: >> - Running `.\gradlew test` >> >> Any other recommendations for testing this? >> >> Thanks, >> Jorn > > The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Nice work! Just a small nit, you can use a Markdown [thematic break](https://spec.commonmark.org/0.29/#thematic-break) instead of using the `
` HTML tag directly. bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 305: > 304: var progressBody = new StringBuilder(); > 305: progressBody.append(""); > 306: progressBody.append("### Progress\n"); Suggestion: progressBody.append("---------"); ------------- PR: https://git.openjdk.java.net/skara/pull/434 From ehelin at openjdk.java.net Mon Feb 17 15:04:36 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 17 Feb 2020 15:04:36 GMT Subject: [Integrated] RFR: git-pr: show commit messages In-Reply-To: References: Message-ID: <27562463-b8d5-4a9f-a5cb-4fa08141c27a@openjdk.org> Changeset: 38bc15ef Author: Erik Helin Date: 2020-02-17 15:04:20 +0000 URL: https://git.openjdk.java.net/skara/commit/38bc15ef git-webrev: show commit messages Reviewed-by: rwestberg ! jcheck/src/test/java/org/openjdk/skara/jcheck/TestRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java ! vcs/src/main/resources/ext.py ! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java ! webrev/src/main/java/org/openjdk/skara/webrev/AddedFileView.java + webrev/src/main/java/org/openjdk/skara/webrev/MetadataFormatter.java ! webrev/src/main/java/org/openjdk/skara/webrev/ModifiedFileView.java ! webrev/src/main/java/org/openjdk/skara/webrev/RemovedFileView.java ! webrev/src/main/java/org/openjdk/skara/webrev/Webrev.java From ehelin at openjdk.java.net Mon Feb 17 15:34:03 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 17 Feb 2020 15:34:03 GMT Subject: [Rev 01] RFR: git-webrev: show commit messages In-Reply-To: References: Message-ID: > Hi all, > > please review this patch that adds commit messages to webrevs (if applicable). > The current `MetadataFormatter` is a bit bare-bones, I plan to enhance it in > future patches. I had to implement a few overloads of `commitMetadata` to > support this feature, hence the changes to `vcs`. > > Testing: > - Added unit tests for `commitMetadata` > - Manual testing of `git-webrev` for both Git and Mercurial repositories > > Thanks, > Erik The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Added commits: - 584b709f: Support for Mercurial 5.3 - 26b47534: Merge branch 'master' into git-pr-commit-message - 2ef003b5: Refactor notifier bot constructors - a0b9185b: 279: Optionally only update project-specific issues - 7f3f4b2e: 270: Remove ignored reviews from the summary - 4c469bf0: Add HostUserDetails::email - 57f1d634: Make Host::user return Optional - c23c574f: vcs: add support for Mercurial 5.3 Changes: - all: https://git.openjdk.java.net/skara/pull/441/files - new: https://git.openjdk.java.net/skara/pull/441/files/33a8ded3..584b709f Webrevs: - full: https://webrevs.openjdk.java.net/skara/441/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/441/webrev.00-01 Stats: 992 lines in 28 files changed: 777 ins; 22 del; 193 mod Patch: https://git.openjdk.java.net/skara/pull/441.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/441/head:pull/441 PR: https://git.openjdk.java.net/skara/pull/441 From ehelin at openjdk.java.net Mon Feb 17 15:42:03 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 17 Feb 2020 15:42:03 GMT Subject: RFR: git-webrev: create links for bug ids in commit messages Message-ID: Hi all, please review this patch that creates links to [JBS](https://bugs.openjdk.java.net) for issue id:s in commit messages. This patch also creates a link to the upstream revision if possible. Finally I also updated some of the titles to match `webrev.ksh`. The reason for not using the types `IssueProject` and `PullRequest` is that `webrev.ksh` has traditionally never required a network connection. The bots however are free to do so and can therefore provide better implementations for `issueLinker` and `commitLinker`. This work will be done in a follow-up patch. Testing: - `make test` passes on Linux x64 - Manual testing of `git-webrev` Thanks, Erik ------------- Commits: - e7683755: git-webrev: create links for bug ids in commit messages Changes: https://git.openjdk.java.net/skara/pull/444/files Webrev: https://webrevs.openjdk.java.net/skara/444/webrev.00 Stats: 94 lines in 5 files changed: 76 ins; 1 del; 17 mod Patch: https://git.openjdk.java.net/skara/pull/444.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/444/head:pull/444 PR: https://git.openjdk.java.net/skara/pull/444 From rwestberg at openjdk.java.net Mon Feb 17 15:58:33 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 17 Feb 2020 15:58:33 GMT Subject: RFR: git-webrev: create links for bug ids in commit messages In-Reply-To: References: Message-ID: On Mon, 17 Feb 2020 15:29:00 GMT, Erik Helin wrote: > Hi all, > > please review this patch that creates links to > [JBS](https://bugs.openjdk.java.net) for issue id:s in commit messages. This > patch also creates a link to the upstream revision if possible. Finally I also > updated some of the titles to match `webrev.ksh`. > > The reason for not using the types `IssueProject` and `PullRequest` is that > `webrev.ksh` has traditionally never required a network connection. The bots > however are free to do so and can therefore provide better implementations for > `issueLinker` and `commitLinker`. This work will be done in a follow-up patch. > > Testing: > - `make test` passes on Linux x64 > - Manual testing of `git-webrev` > > Thanks, > Erik Looks good! Just wanted to note that webrev.ksh actually does attempt to fetch the issue title from JBS: if [[ -n $WGET ]]; then msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '' | sed 's/<title>[(.*)] (.*) - Java Bug System/\1 : \2/' | html_dequote | html_quote` fi if [[ -z $msg ]]; then msg="${id}" fi But such an implementation can certainly be left for later. ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/444 From rwestberg at openjdk.java.net Mon Feb 17 16:01:11 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 17 Feb 2020 16:01:11 GMT Subject: [Integrated] RFR: 275: PR bot should allows merge-style PRs with only branch names In-Reply-To: References: Message-ID: <34c562db-a680-4825-8cbd-5a2a121d7891@openjdk.org> Changeset: 64bc771a Author: Robin Westberg Date: 2020-02-17 16:00:49 +0000 URL: https://git.openjdk.java.net/skara/commit/64bc771a 275: PR bot should allows merge-style PRs with only branch names Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/MergeTests.java From rwestberg at openjdk.java.net Mon Feb 17 16:00:18 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 17 Feb 2020 16:00:18 GMT Subject: [Integrated] RFR: 280: Notifier should support repo/branch prefixes In-Reply-To: References: Message-ID: <7b7f4301-5940-46c7-89b4-0b01c70ff6d2@openjdk.org> Changeset: e4b8ae3d Author: Robin Westberg Date: 2020-02-17 15:59:58 +0000 URL: https://git.openjdk.java.net/skara/commit/e4b8ae3d 280: Notifier should support repo/branch prefixes Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdaterBuilder.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/NotifyBotFactory.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From rwestberg at openjdk.java.net Mon Feb 17 16:11:14 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 17 Feb 2020 16:11:14 GMT Subject: RFR: 273: PR bot should check for empty pull request body Message-ID: Hi all, Please review this change that makes empty PR bodies fail jcheck, in order to improve the mailing list bridge experience. Best regards, Robin ------------- Commits: - 3fbd064d: Disallow empty PR bodies Changes: https://git.openjdk.java.net/skara/pull/445/files Webrev: https://webrevs.openjdk.java.net/skara/445/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-273 Stats: 67 lines in 3 files changed: 63 ins; 2 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/445.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/445/head:pull/445 PR: https://git.openjdk.java.net/skara/pull/445 From jvernee at openjdk.java.net Mon Feb 17 16:30:12 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Mon, 17 Feb 2020 16:30:12 GMT Subject: [Rev 02] RFR: Add checkout instructions to PR body In-Reply-To: References: Message-ID: <4ryJO1WAXv0grCqA5xMhyUy6SyqIn3LNHSir7sw0HKA=.59452804-a515-44f7-bd23-7760dedfb91d@github.com> > Hi, > > I'd like let the pr bot add the fetch comamnd found in the automatic emails to the PR body, so that people using only GitHub can see the instructions as well. > > This adds a new "Instructions" section to the body of the PR message: > >> ## Instructions >> To checkout these changes locally: >> ```bash >> $ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16 >> $ git checkout pull/16 >> ``` > > Testing: > - Running `.\gradlew test` > > Any other recommendations for testing this? > > Thanks, > Jorn The pull request has been updated with 1 additional commit. ------------- Added commits: - 93d02e60: Use markdown thematic break Changes: - all: https://git.openjdk.java.net/skara/pull/434/files - new: https://git.openjdk.java.net/skara/pull/434/files/0774b382..93d02e60 Webrevs: - full: https://webrevs.openjdk.java.net/skara/434/webrev.02 - incr: https://webrevs.openjdk.java.net/skara/434/webrev.01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/434.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/434/head:pull/434 PR: https://git.openjdk.java.net/skara/pull/434 From ehelin at openjdk.java.net Mon Feb 17 16:18:16 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 17 Feb 2020 16:18:16 GMT Subject: [Integrated] RFR: git-webrev: create links for bug ids in commit messages In-Reply-To: References: Message-ID: Changeset: d5b6d4ca Author: Erik Helin Date: 2020-02-17 16:17:57 +0000 URL: https://git.openjdk.java.net/skara/commit/d5b6d4ca git-webrev: create links for bug ids in commit messages Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java ! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java ! webrev/src/main/java/org/openjdk/skara/webrev/IndexView.java ! webrev/src/main/java/org/openjdk/skara/webrev/MetadataFormatter.java ! webrev/src/main/java/org/openjdk/skara/webrev/Webrev.java From ehelin at openjdk.java.net Mon Feb 17 16:19:53 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 17 Feb 2020 16:19:53 GMT Subject: RFR: git-webrev: create links for bug ids in commit messages In-Reply-To: References: Message-ID: On Mon, 17 Feb 2020 15:56:26 GMT, Robin Westberg wrote: >> Hi all, >> >> please review this patch that creates links to >> [JBS](https://bugs.openjdk.java.net) for issue id:s in commit messages. This >> patch also creates a link to the upstream revision if possible. Finally I also >> updated some of the titles to match `webrev.ksh`. >> >> The reason for not using the types `IssueProject` and `PullRequest` is that >> `webrev.ksh` has traditionally never required a network connection. The bots >> however are free to do so and can therefore provide better implementations for >> `issueLinker` and `commitLinker`. This work will be done in a follow-up patch. >> >> Testing: >> - `make test` passes on Linux x64 >> - Manual testing of `git-webrev` >> >> Thanks, >> Erik > > Looks good! > > Just wanted to note that webrev.ksh actually does attempt to fetch the issue title from JBS: > if [[ -n $WGET ]]; then > msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '' | sed 's/<title>[(.*)] (.*) - Java Bug System/\1 : \2/' | html_dequote | html_quote` > fi > if [[ -z $msg ]]; then > msg="${id}" > fi > > But such an implementation can certainly be left for later. > Just wanted to note that webrev.ksh actually does attempt to fetch the issue title from JBS: Ah. right, now I remember. We may or may not want to do that, `git-webrev` is _really_ fast in offline mode ?? ------------- PR: https://git.openjdk.java.net/skara/pull/444 From rwestberg at openjdk.java.net Mon Feb 17 17:17:38 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 17 Feb 2020 17:17:38 GMT Subject: RFR: Use seeded materialization for notifier, fix potential race condition Message-ID: Hi all, Please review this change that uses seeded materialization into a bare repository for the notifier, to increase performance. Also fix a potential race condition by fetching upstream content after enumerating branches. Best regards, Robin ------------- Commits: - 5c633736: Use seeded materialization for notifier, fix potential race condition Changes: https://git.openjdk.java.net/skara/pull/446/files Webrev: https://webrevs.openjdk.java.net/skara/446/webrev.00 Stats: 74 lines in 2 files changed: 24 ins; 31 del; 19 mod Patch: https://git.openjdk.java.net/skara/pull/446.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/446/head:pull/446 PR: https://git.openjdk.java.net/skara/pull/446 From ehelin at openjdk.java.net Tue Feb 18 07:57:14 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 07:57:14 GMT Subject: [Rev 01] RFR: Add checkout instructions to PR body In-Reply-To: References: <_knqqcz0XdvYsqDzOYQbTxs9xqCADKT7PGP_RDcW-LQ=.987bd378-73b6-4b2d-a001-d677e4d042ea@github.com> Message-ID: On Mon, 17 Feb 2020 14:59:26 GMT, Erik Helin wrote: >> The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. > > Nice work! Just a small nit, you can use a Markdown [thematic break](https://spec.commonmark.org/0.29/#thematic-break) instead of using the `
` HTML tag directly. It seems like the test `org.openjdk.skara.bots.pr.ContributorTests > prBodyUpdates` is failing on both Linux and Mac. I think you have to change these two lines: - https://github.com/openjdk/skara/blob/master/bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java#L335 ` if (line.equals("## Contributors")) {` - https://github.com/openjdk/skara/blob/master/bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java#L355 ` assertNotEquals("## Contributors", line);` ------------- PR: https://git.openjdk.java.net/skara/pull/434 From ehelin at openjdk.java.net Tue Feb 18 08:02:14 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 08:02:14 GMT Subject: RFR: 273: PR bot should check for empty pull request body In-Reply-To: References: Message-ID: On Mon, 17 Feb 2020 15:59:21 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that makes empty PR bodies fail jcheck, in order to improve the mailing list bridge experience. > > Best regards, > Robin Looks good, just two minor comments on the error message! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 132: > 131: if (bodyWithoutStatus().isBlank()) { > 132: var error = "The PR body must not be empty - the content will be used for a notification email."; > 133: ret.add(error); Suggestion: var error = "The pull request body must not be empty."; bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java line 691: > 690: assertEquals(CheckStatus.FAILURE, check.status()); > 691: assertTrue(check.summary().orElseThrow().contains("PR body must not be empty")); > 692: Suggestion: assertTrue(check.summary().orElseThrow().contains("The pull request body must not be empty.")); ------------- PR: https://git.openjdk.java.net/skara/pull/445 From ehelin at openjdk.java.net Tue Feb 18 08:45:04 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 08:45:04 GMT Subject: RFR: Use seeded materialization for notifier, fix potential race condition In-Reply-To: References: Message-ID: On Mon, 17 Feb 2020 17:00:31 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that uses seeded materialization into a bare repository for the notifier, to increase performance. Also fix a potential race condition by fetching upstream content after enumerating branches. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/446 From rwestberg at openjdk.java.net Tue Feb 18 09:52:03 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 18 Feb 2020 09:52:03 GMT Subject: [Integrated] RFR: Use seeded materialization for notifier, fix potential race condition In-Reply-To: References: Message-ID: <0abb0fb9-f522-4682-b662-a0d09395320d@openjdk.org> Changeset: 16182f5c Author: Robin Westberg Date: 2020-02-18 09:51:25 +0000 URL: https://git.openjdk.java.net/skara/commit/16182f5c Use seeded materialization for notifier, fix potential race condition Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryWorkItem.java ! forge/src/main/java/org/openjdk/skara/forge/HostedRepositoryPool.java From ehelin at openjdk.java.net Tue Feb 18 10:43:34 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 10:43:34 GMT Subject: git: openjdk/skara: git-pr: support atomic integrations Message-ID: <1fcdd704-1b0f-4d20-81f9-8bdee9677879@openjdk.org> Changeset: b2770574 Author: Erik Helin Date: 2020-02-18 10:43:15 +0000 URL: https://git.openjdk.java.net/skara/commit/b2770574 git-pr: support atomic integrations Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java From jvernee at openjdk.java.net Tue Feb 18 10:44:01 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Tue, 18 Feb 2020 10:44:01 GMT Subject: [Rev 03] RFR: Add checkout instructions to PR body In-Reply-To: References: Message-ID: > Hi, > > I'd like let the pr bot add the fetch comamnd found in the automatic emails to the PR body, so that people using only GitHub can see the instructions as well. > > This adds a new "Instructions" section to the body of the PR message: > >> ## Instructions >> To checkout these changes locally: >> ```bash >> $ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16 >> $ git checkout pull/16 >> ``` > > Testing: > - Running `.\gradlew test` > > Any other recommendations for testing this? > > Thanks, > Jorn The pull request has been updated with 1 additional commit. ------------- Added commits: - 9fc0eb92: Fix tests Changes: - all: https://git.openjdk.java.net/skara/pull/434/files - new: https://git.openjdk.java.net/skara/pull/434/files/93d02e60..9fc0eb92 Webrevs: - full: https://webrevs.openjdk.java.net/skara/434/webrev.03 - incr: https://webrevs.openjdk.java.net/skara/434/webrev.02-03 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/434.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/434/head:pull/434 PR: https://git.openjdk.java.net/skara/pull/434 From jvernee at openjdk.java.net Tue Feb 18 10:44:18 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Tue, 18 Feb 2020 10:44:18 GMT Subject: [Rev 01] RFR: Add checkout instructions to PR body In-Reply-To: References: <_knqqcz0XdvYsqDzOYQbTxs9xqCADKT7PGP_RDcW-LQ=.987bd378-73b6-4b2d-a001-d677e4d042ea@github.com> Message-ID: On Tue, 18 Feb 2020 07:54:51 GMT, Erik Helin wrote: >> Nice work! Just a small nit, you can use a Markdown [thematic break](https://spec.commonmark.org/0.29/#thematic-break) instead of using the `
` HTML tag directly. > > It seems like the test `org.openjdk.skara.bots.pr.ContributorTests > prBodyUpdates` is failing on both Linux and Mac. I think you have to change these two lines: > > - https://github.com/openjdk/skara/blob/master/bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java#L335 > ` if (line.equals("## Contributors")) {` > - https://github.com/openjdk/skara/blob/master/bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java#L355 > ` assertNotEquals("## Contributors", line);` @edvbld Thanks Erik, That test is being skipped when running on Windows and I'm seeing a lot of "STANDARD_ERROR"s in the build log for the workflow, so not sure if this was a false negative. I gave the latest version a run on WSL. There are a lot of failing tests if I do that, unrelated to this PR, but at least the particular test is now passing. ------------- PR: https://git.openjdk.java.net/skara/pull/434 From ehelin at openjdk.java.net Tue Feb 18 11:12:32 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 11:12:32 GMT Subject: RFR: git-pr: recognize more forms on integration comments Message-ID: <8ctoFLRYKW5Ur4XVgnMRiuWHf7uiUaZ957PXQCM6lVI=.35b8213b-a765-46f2-adff-e406f847c049@github.com> Hi all, please review this small patch that makes `git pr integrate` recognize multiple forms of integration result comments (for example ones with rebase information). Thanks, Erik ------------- Commits: - 0ac4d122: git-pr: recognize more forms on integration comments Changes: https://git.openjdk.java.net/skara/pull/448/files Webrev: https://webrevs.openjdk.java.net/skara/448/webrev.00 Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/448.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/448/head:pull/448 PR: https://git.openjdk.java.net/skara/pull/448 From rwestberg at openjdk.java.net Tue Feb 18 11:12:44 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 18 Feb 2020 11:12:44 GMT Subject: RFR: git-pr: recognize more forms on integration comments In-Reply-To: <8ctoFLRYKW5Ur4XVgnMRiuWHf7uiUaZ957PXQCM6lVI=.35b8213b-a765-46f2-adff-e406f847c049@github.com> References: <8ctoFLRYKW5Ur4XVgnMRiuWHf7uiUaZ957PXQCM6lVI=.35b8213b-a765-46f2-adff-e406f847c049@github.com> Message-ID: On Tue, 18 Feb 2020 11:03:30 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes `git pr integrate` recognize multiple > forms of integration result comments (for example ones with rebase information). > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/448 From ehelin at openjdk.java.net Tue Feb 18 11:12:57 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 11:12:57 GMT Subject: [Integrated] RFR: git-pr: recognize more forms on integration comments In-Reply-To: <8ctoFLRYKW5Ur4XVgnMRiuWHf7uiUaZ957PXQCM6lVI=.35b8213b-a765-46f2-adff-e406f847c049@github.com> References: <8ctoFLRYKW5Ur4XVgnMRiuWHf7uiUaZ957PXQCM6lVI=.35b8213b-a765-46f2-adff-e406f847c049@github.com> Message-ID: <75b7d972-58a7-479f-9b7a-dda9f5ee88dc@openjdk.org> Changeset: 01d1519b Author: Erik Helin Date: 2020-02-18 11:12:41 +0000 URL: https://git.openjdk.java.net/skara/commit/01d1519b git-pr: recognize more forms on integration comments Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java From ehelin at openjdk.java.net Tue Feb 18 11:17:03 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 11:17:03 GMT Subject: [Rev 03] RFR: Add checkout instructions to PR body In-Reply-To: References: Message-ID: On Tue, 18 Feb 2020 10:44:01 GMT, Jorn Vernee wrote: >> Hi, >> >> I'd like let the pr bot add the fetch comamnd found in the automatic emails to the PR body, so that people using only GitHub can see the instructions as well. >> >> This adds a new "Instructions" section to the body of the PR message: >> >>> ## Instructions >>> To checkout these changes locally: >>> ```bash >>> $ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16 >>> $ git checkout pull/16 >>> ``` >> >> Testing: >> - Running `.\gradlew test` >> >> Any other recommendations for testing this? >> >> Thanks, >> Jorn > > The pull request has been updated with 1 additional commit. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/434 From ehelin at openjdk.java.net Tue Feb 18 11:17:04 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 11:17:04 GMT Subject: [Rev 01] RFR: Add checkout instructions to PR body In-Reply-To: References: <_knqqcz0XdvYsqDzOYQbTxs9xqCADKT7PGP_RDcW-LQ=.987bd378-73b6-4b2d-a001-d677e4d042ea@github.com> Message-ID: On Tue, 18 Feb 2020 10:31:08 GMT, Jorn Vernee wrote: >> It seems like the test `org.openjdk.skara.bots.pr.ContributorTests > prBodyUpdates` is failing on both Linux and Mac. I think you have to change these two lines: >> >> - https://github.com/openjdk/skara/blob/master/bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java#L335 >> ` if (line.equals("## Contributors")) {` >> - https://github.com/openjdk/skara/blob/master/bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java#L355 >> ` assertNotEquals("## Contributors", line);` > > @edvbld Thanks Erik, > > That test is being skipped when running on Windows and I'm seeing a lot of "STANDARD_ERROR"s in the build log for the workflow, so not sure if this was a false negative. > > I gave the latest version a run on WSL. There are a lot of failing tests if I do that, unrelated to this PR, but at least the particular test is now passing. @JornVernee Yeah, most of the bot tests are disabled on Windows. I would be happy to review patches to get the tests passing on WSL ?? ------------- PR: https://git.openjdk.java.net/skara/pull/434 From jvernee at openjdk.java.net Tue Feb 18 12:20:49 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Tue, 18 Feb 2020 12:20:49 GMT Subject: [Integrated] RFR: Add checkout instructions to PR body In-Reply-To: References: Message-ID: Changeset: 84a1235c Author: Jorn Vernee Date: 2020-02-18 12:20:25 +0000 URL: https://git.openjdk.java.net/skara/commit/84a1235c Add checkout instructions to PR body Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java From ehelin at openjdk.java.net Tue Feb 18 12:53:09 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 12:53:09 GMT Subject: RFR: git-pr: rename "update" to "set" Message-ID: Hi all, please review this patch that renames the `git pr` subcommand `update` to `set`. This is done for a couple of reasons: - `update` can be viewed as appending or enhancing whereas `set` better reflects that we do set some fields (i.e. all existing values for the field has to be repeated for appending). - `update` is freed up to be user for future commands - `set` is shorter than `update` ?? Examples of how the command is intended to be used are `git pr set --assignees=rwestberg`, `git pr set --reviewers=JornVernee` and `git pr set --no-draft`. Testing: - Manual testing of `git pr set` Thanks, Erik ------------- Commits: - 120a5741: git-pr: rename "update" to "set" Changes: https://git.openjdk.java.net/skara/pull/449/files Webrev: https://webrevs.openjdk.java.net/skara/449/webrev.00 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/449.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/449/head:pull/449 PR: https://git.openjdk.java.net/skara/pull/449 From rwestberg at openjdk.java.net Tue Feb 18 13:01:24 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 18 Feb 2020 13:01:24 GMT Subject: RFR: git-pr: rename "update" to "set" In-Reply-To: References: Message-ID: On Tue, 18 Feb 2020 12:43:14 GMT, Erik Helin wrote: > Hi all, > > please review this patch that renames the `git pr` subcommand `update` to `set`. > This is done for a couple of reasons: > > - `update` can be viewed as appending or enhancing whereas `set` better reflects > that we do set some fields (i.e. all existing values for the field has to be > repeated for appending). > - `update` is freed up to be user for future commands > - `set` is shorter than `update` ?? > > Examples of how the command is intended to be used are `git pr set > --assignees=rwestberg`, `git pr set --reviewers=JornVernee` and `git pr set > --no-draft`. > > Testing: > - Manual testing of `git pr set` > > Thanks, > Erik Sounds good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/449 From ehelin at openjdk.java.net Tue Feb 18 13:16:10 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 13:16:10 GMT Subject: [Integrated] RFR: git-pr: rename "update" to "set" In-Reply-To: References: Message-ID: Changeset: 5c2736f0 Author: Erik Helin Date: 2020-02-18 13:15:53 +0000 URL: https://git.openjdk.java.net/skara/commit/5c2736f0 git-pr: rename "update" to "set" Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java From rwestberg at openjdk.java.net Tue Feb 18 13:21:00 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 18 Feb 2020 13:21:00 GMT Subject: RFR: Retry the mbox push action a few times in case of concurrent updates Message-ID: <8fhsZk6Afym17DOxvN9pu315iis8hZeXGRPDi_G_2Yk=.2077a01a-b4b7-4ba5-a64f-c77b5b046997@github.com> Hi all, Please review this small change that retries the mbox push action a few times, to avoid errors when there are concurrent updates (to unrelated mboxes). Also performs a rebase action if needed to decrease the chance of an error. Best regards, Robin ------------- Commits: - 14e99ad0: Retry the mbox push action a few times in case of concurrent updates, as well as attempt to rebase Changes: https://git.openjdk.java.net/skara/pull/450/files Webrev: https://webrevs.openjdk.java.net/skara/450/webrev.00 Stats: 18 lines in 1 file changed: 12 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/450.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/450/head:pull/450 PR: https://git.openjdk.java.net/skara/pull/450 From rwestberg at openjdk.java.net Tue Feb 18 13:27:17 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 18 Feb 2020 13:27:17 GMT Subject: [Integrated] RFR: Retry the mbox push action a few times in case of concurrent updates In-Reply-To: <8fhsZk6Afym17DOxvN9pu315iis8hZeXGRPDi_G_2Yk=.2077a01a-b4b7-4ba5-a64f-c77b5b046997@github.com> References: <8fhsZk6Afym17DOxvN9pu315iis8hZeXGRPDi_G_2Yk=.2077a01a-b4b7-4ba5-a64f-c77b5b046997@github.com> Message-ID: <9caa4f23-fd33-4b2f-b257-3ec124474a8e@openjdk.org> Changeset: cdb7dd43 Author: Robin Westberg Date: 2020-02-18 13:27:00 +0000 URL: https://git.openjdk.java.net/skara/commit/cdb7dd43 Retry the mbox push action a few times in case of concurrent updates Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java From ehelin at openjdk.java.net Tue Feb 18 13:28:23 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 13:28:23 GMT Subject: RFR: Retry the mbox push action a few times in case of concurrent updates In-Reply-To: <8fhsZk6Afym17DOxvN9pu315iis8hZeXGRPDi_G_2Yk=.2077a01a-b4b7-4ba5-a64f-c77b5b046997@github.com> References: <8fhsZk6Afym17DOxvN9pu315iis8hZeXGRPDi_G_2Yk=.2077a01a-b4b7-4ba5-a64f-c77b5b046997@github.com> Message-ID: On Tue, 18 Feb 2020 13:06:36 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that retries the mbox push action a few times, to avoid errors when there are concurrent updates (to unrelated mboxes). Also performs a rebase action if needed to decrease the chance of an error. > > Best regards, > Robin Looks good, thanks for fixing! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/450 From ehelin at openjdk.java.net Tue Feb 18 13:44:41 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 13:44:41 GMT Subject: RFR: csr bot: use pull request cache Message-ID: Hi all, please review this patch that makes the CSR bot use the pull request cache. The CSR bot now has two phases, the first phase simply checks if any updated has gotten the "csr" label. The addition of a "csr" label can only happen by comments being added to the PR, so the `PullRequestCache` will return these PRs are requiring an update. The second phase then loops through all pull requests that have the CSR label and check if the CSR request has been resolved. Testing: - `make test` passes on Linux x64 Thanks, Erik ------------- Commits: - 623db4bf: csr bot: use pull request cache Changes: https://git.openjdk.java.net/skara/pull/451/files Webrev: https://webrevs.openjdk.java.net/skara/451/webrev.00 Stats: 43 lines in 1 file changed: 20 ins; 0 del; 23 mod Patch: https://git.openjdk.java.net/skara/pull/451.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/451/head:pull/451 PR: https://git.openjdk.java.net/skara/pull/451 From rwestberg at openjdk.java.net Tue Feb 18 13:44:53 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 18 Feb 2020 13:44:53 GMT Subject: RFR: csr bot: use pull request cache In-Reply-To: References: Message-ID: On Tue, 18 Feb 2020 13:32:19 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the CSR bot use the pull request cache. The > CSR bot now has two phases, the first phase simply checks if any updated has > gotten the "csr" label. The addition of a "csr" label can only happen by > comments being added to the PR, so the `PullRequestCache` will return these PRs > are requiring an update. > > The second phase then loops through all pull requests that have the CSR label > and check if the CSR request has been resolved. > > Testing: > - `make test` passes on Linux x64 > > Thanks, > Erik Looks good, just one comment about detecting external changes. bots/csr/src/main/java/org/openjdk/skara/bots/csr/CSRBot.java line 76: > 75: hasCSRLabel.add(pr.id()); > 76: } > 77: } Perhaps check if the CSR_LABEL is gone but the PR is in hasCSRLabel, in case it was manually removed? ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/451 From ehelin at openjdk.java.net Tue Feb 18 13:49:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 13:49:19 GMT Subject: git: openjdk/skara: webrev: check that issue linker is not null Message-ID: Changeset: e4673d67 Author: Erik Helin Date: 2020-02-18 13:48:55 +0000 URL: https://git.openjdk.java.net/skara/commit/e4673d67 webrev: check that issue linker is not null Reviewed-by: rwestberg ! webrev/src/main/java/org/openjdk/skara/webrev/Webrev.java From ehelin at openjdk.java.net Tue Feb 18 13:52:46 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 13:52:46 GMT Subject: [Integrated] RFR: csr bot: use pull request cache In-Reply-To: References: Message-ID: <306fb3ed-01b7-4f51-99e2-5078b507c159@openjdk.org> Changeset: 88db8fad Author: Erik Helin Date: 2020-02-18 13:52:30 +0000 URL: https://git.openjdk.java.net/skara/commit/88db8fad csr bot: use pull request cache Reviewed-by: rwestberg ! bots/csr/src/main/java/org/openjdk/skara/bots/csr/CSRBot.java From ehelin at openjdk.java.net Tue Feb 18 13:48:08 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 13:48:08 GMT Subject: RFR: csr bot: use pull request cache In-Reply-To: References: Message-ID: <4h51oEvuNbW-RWEPwv0lT83rMCok4j-QB8eRj1PZl0Q=.789a2681-8fde-40d3-bc63-f3b84c8b4786@github.com> On Tue, 18 Feb 2020 13:38:19 GMT, Robin Westberg wrote: >> Hi all, >> >> please review this patch that makes the CSR bot use the pull request cache. The >> CSR bot now has two phases, the first phase simply checks if any updated has >> gotten the "csr" label. The addition of a "csr" label can only happen by >> comments being added to the PR, so the `PullRequestCache` will return these PRs >> are requiring an update. >> >> The second phase then loops through all pull requests that have the CSR label >> and check if the CSR request has been resolved. >> >> Testing: >> - `make test` passes on Linux x64 >> >> Thanks, >> Erik > > bots/csr/src/main/java/org/openjdk/skara/bots/csr/CSRBot.java line 76: > >> 75: hasCSRLabel.add(pr.id()); >> 76: } >> 77: } > > Perhaps check if the CSR_LABEL is gone but the PR is in hasCSRLabel, in case it was manually removed? Good idea, will fix! ------------- PR: https://git.openjdk.java.net/skara/pull/451 From ehelin at openjdk.java.net Tue Feb 18 14:05:54 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 14:05:54 GMT Subject: [Rev 01] RFR: 273: PR bot should check for empty pull request body In-Reply-To: References: Message-ID: On Tue, 18 Feb 2020 13:40:13 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this change that makes empty PR bodies fail jcheck, in order to improve the mailing list bridge experience. >> >> Best regards, >> Robin > > The pull request has been updated with a new target base due to a merge or a rebase. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/445 From rwestberg at openjdk.java.net Tue Feb 18 14:05:53 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 18 Feb 2020 14:05:53 GMT Subject: [Rev 01] RFR: 273: PR bot should check for empty pull request body In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that makes empty PR bodies fail jcheck, in order to improve the mailing list bridge experience. > > Best regards, > Robin The pull request has been updated with a new target base due to a merge or a rebase. ------------- Commits: - 4bee7768: Merge remote-tracking branch 'origin/pr_empty_body' into pr_empty_body - d3cb9b42: Apply suggestions from code review - 2ed6681c: Merge remote-tracking branch 'upstream/master' into pr_empty_body - 3fbd064d: Disallow empty PR bodies Changes: https://git.openjdk.java.net/skara/pull/445/files Webrev: https://webrevs.openjdk.java.net/skara/445/webrev.01 Stats: 67 lines in 3 files changed: 63 ins; 2 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/445.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/445/head:pull/445 PR: https://git.openjdk.java.net/skara/pull/445 From rwestberg at openjdk.java.net Tue Feb 18 14:20:23 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 18 Feb 2020 14:20:23 GMT Subject: RFR: Add missing newline to PR progress body Message-ID: Hi all, Please review this minor fix that adds a missing newline to the recently updated PR summary body. Best regards, Robin ------------- Commits: - 0e5499f4: Add missing newline Changes: https://git.openjdk.java.net/skara/pull/453/files Webrev: https://webrevs.openjdk.java.net/skara/453/webrev.00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/453.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/453/head:pull/453 PR: https://git.openjdk.java.net/skara/pull/453 From rwestberg at openjdk.java.net Tue Feb 18 15:07:47 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 18 Feb 2020 15:07:47 GMT Subject: [Integrated] RFR: Add missing newline to PR progress body In-Reply-To: References: Message-ID: <3d0ed36a-9a2f-4b52-b7b3-cc00ec31da7a@openjdk.org> Changeset: 726cd95c Author: Robin Westberg Date: 2020-02-18 15:07:30 +0000 URL: https://git.openjdk.java.net/skara/commit/726cd95c Add missing newline to PR progress body Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java From ehelin at openjdk.java.net Tue Feb 18 15:08:23 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 18 Feb 2020 15:08:23 GMT Subject: RFR: Add missing newline to PR progress body In-Reply-To: References: Message-ID: <0v0-mHgnJUY03vhTM_tG_bnqvgKmPm0FBVqKFUwDM_c=.08e646cf-7b78-4441-9706-b2eb7fb35379@github.com> On Tue, 18 Feb 2020 14:08:58 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor fix that adds a missing newline to the recently updated PR summary body. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/453 From rwestberg at openjdk.java.net Tue Feb 18 15:17:17 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 18 Feb 2020 15:17:17 GMT Subject: [Integrated] RFR: 273: PR bot should check for empty pull request body In-Reply-To: References: Message-ID: Changeset: 6632a9f1 Author: Robin Westberg Date: 2020-02-18 15:16:54 +0000 URL: https://git.openjdk.java.net/skara/commit/6632a9f1 273: PR bot should check for empty pull request body Reviewed-by: ehelin ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java ! test/src/main/java/org/openjdk/skara/test/HostCredentials.java From ehelin at openjdk.java.net Wed Feb 19 08:16:42 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 19 Feb 2020 08:16:42 GMT Subject: RFR: git-pr: support git pr create --draft Message-ID: Hi all, please review this patch adds support for `--draft` switch to `git pr create`. Testing: - Manual testing of `git pr create` Thanks, Erik ------------- Commits: - c667d5a6: Support git pr create --draft Changes: https://git.openjdk.java.net/skara/pull/454/files Webrev: https://webrevs.openjdk.java.net/skara/454/webrev.00 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/454.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/454/head:pull/454 PR: https://git.openjdk.java.net/skara/pull/454 From rwestberg at openjdk.java.net Wed Feb 19 08:16:42 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 19 Feb 2020 08:16:42 GMT Subject: RFR: git-pr: support git pr create --draft In-Reply-To: References: Message-ID: On Tue, 18 Feb 2020 15:07:40 GMT, Erik Helin wrote: > Hi all, > > please review this patch adds support for `--draft` switch to `git pr create`. > > Testing: > - Manual testing of `git pr create` > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/454 From rwestberg at openjdk.java.net Wed Feb 19 08:49:14 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 19 Feb 2020 08:49:14 GMT Subject: git: openjdk/skara: Use unique folder per repo for notifier materialization Message-ID: <75b9d9f6-ac0b-4b71-baf0-e168d2f32653@openjdk.org> Changeset: 8f9bf4f1 Author: Robin Westberg Date: 2020-02-19 08:48:55 +0000 URL: https://git.openjdk.java.net/skara/commit/8f9bf4f1 Use unique folder per repo for notifier materialization Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryWorkItem.java From rwestberg at openjdk.java.net Wed Feb 19 08:49:41 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 19 Feb 2020 08:49:41 GMT Subject: RFR: Use unique folder per repo for notifier materialization Message-ID: Hi all, Please review this minor change that ensures the notifier uses a unique folder name for materialization different repositories. Otherwise there can be tag conflicts. Best regards, Robin ------------- Commits: - f062cc21: Unique folder per repo for notifier materialization Changes: https://git.openjdk.java.net/skara/pull/455/files Webrev: https://webrevs.openjdk.java.net/skara/455/webrev.00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/455.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/455/head:pull/455 PR: https://git.openjdk.java.net/skara/pull/455 From ehelin at openjdk.java.net Wed Feb 19 08:49:52 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 19 Feb 2020 08:49:52 GMT Subject: RFR: Use unique folder per repo for notifier materialization In-Reply-To: References: Message-ID: On Wed, 19 Feb 2020 08:41:17 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that ensures the notifier uses a unique folder name for materialization different repositories. Otherwise there can be tag conflicts. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/455 From rwestberg at openjdk.java.net Wed Feb 19 09:39:17 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 19 Feb 2020 09:39:17 GMT Subject: RFR: Update issue matcher after layout changes Message-ID: Hi all, Please review this change that adapts the issue block matchers after the recent layout update to the PR summary body. Best regards, Robin ------------- Commits: - b84844aa: Update issue matcher after layout changes Changes: https://git.openjdk.java.net/skara/pull/456/files Webrev: https://webrevs.openjdk.java.net/skara/456/webrev.00 Stats: 9 lines in 3 files changed: 0 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/skara/pull/456.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/456/head:pull/456 PR: https://git.openjdk.java.net/skara/pull/456 From rwestberg at openjdk.java.net Wed Feb 19 09:44:09 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 19 Feb 2020 09:44:09 GMT Subject: [Integrated] RFR: Update issue matcher after layout changes In-Reply-To: References: Message-ID: Changeset: 5e9d4ade Author: Robin Westberg Date: 2020-02-19 09:43:48 +0000 URL: https://git.openjdk.java.net/skara/commit/5e9d4ade Update issue matcher after layout changes Reviewed-by: ehelin ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/PullRequestWorkItem.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java From ehelin at openjdk.java.net Wed Feb 19 09:44:39 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 19 Feb 2020 09:44:39 GMT Subject: RFR: Update issue matcher after layout changes In-Reply-To: References: Message-ID: <0qRIP16TaKstIqsvS27PP3F7aq4OImUBx8l-sJGBH6M=.04793193-5459-4346-88b7-c59a944e969a@github.com> On Wed, 19 Feb 2020 09:30:31 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that adapts the issue block matchers after the recent layout update to the PR summary body. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/456 From ehelin at openjdk.java.net Wed Feb 19 10:14:51 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 19 Feb 2020 10:14:51 GMT Subject: [Rev 01] RFR: git-pr: support git pr create --draft In-Reply-To: References: Message-ID: > Hi all, > > please review this patch adds support for `--draft` switch to `git pr create`. > > Testing: > - Manual testing of `git pr create` > > Thanks, > Erik The pull request has been updated with 1 additional commit. ------------- Added commits: - 4d86006d: Support 'git pr set --no-draft' Changes: - all: https://git.openjdk.java.net/skara/pull/454/files - new: https://git.openjdk.java.net/skara/pull/454/files/c667d5a6..4d86006d Webrevs: - full: https://webrevs.openjdk.java.net/skara/454/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/454/webrev.00-01 Stats: 101 lines in 5 files changed: 101 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/454.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/454/head:pull/454 PR: https://git.openjdk.java.net/skara/pull/454 From ehelin at openjdk.java.net Wed Feb 19 10:15:10 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 19 Feb 2020 10:15:10 GMT Subject: [Rev 01] RFR: git-pr: support git pr create --draft In-Reply-To: References: Message-ID: On Tue, 18 Feb 2020 15:25:53 GMT, Robin Westberg wrote: >> The pull request has been updated with 1 additional commit. > > Looks good! Just pushed a new commit that also enables the command `git pr set --no-draft` in order to support moving a PR in draft state to a non-draft state. The GitHub API for doing so was only available in the GraphQL API, so I had to add a new `RestRequest` to `GitHubHost`. It makes sense for the GraphQL `RestRequest` to be a field in `GitHubHost` since all GraphQL requests use the same [endpoint](https://api.github.com/graphql). ------------- PR: https://git.openjdk.java.net/skara/pull/454 From rwestberg at openjdk.java.net Wed Feb 19 10:15:10 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 19 Feb 2020 10:15:10 GMT Subject: [Rev 01] RFR: git-pr: support git pr create --draft In-Reply-To: References: Message-ID: On Wed, 19 Feb 2020 10:14:51 GMT, Erik Helin wrote: >> Hi all, >> >> please review this patch adds support for `--draft` switch to `git pr create`. >> >> Testing: >> - Manual testing of `git pr create` >> >> Thanks, >> Erik > > The pull request has been updated with 1 additional commit. Looks good, just a naming comment, can keep as is as well! But remember to update TestPullRequest as well. forge/src/main/java/org/openjdk/skara/forge/PullRequest.java line 138: > 137: boolean isDraft(); > 138: void makeNotDraft(); > 139: } While symmetrical, perhaps `makeFinal` or `makeReady` would look nicer.. But if so `isDraft` should perhaps be `isFinal` as well. ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/454 From rwestberg at openjdk.java.net Wed Feb 19 12:11:46 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 19 Feb 2020 12:11:46 GMT Subject: RFR: 283: Pull request pruner bot should look at comments and reviews only Message-ID: Hi all, Please review this change that should make the pull request pruner bot more robust. Best regards, Robin ------------- Commits: - 62350644: Pull request pruner bot should look at comments and reviews only Changes: https://git.openjdk.java.net/skara/pull/457/files Webrev: https://webrevs.openjdk.java.net/skara/457/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-283 Stats: 61 lines in 3 files changed: 42 ins; 3 del; 16 mod Patch: https://git.openjdk.java.net/skara/pull/457.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/457/head:pull/457 PR: https://git.openjdk.java.net/skara/pull/457 From ehelin at openjdk.java.net Wed Feb 19 13:25:50 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 19 Feb 2020 13:25:50 GMT Subject: RFR: 283: Pull request pruner bot should look at comments and reviews only In-Reply-To: References: Message-ID: On Wed, 19 Feb 2020 12:01:49 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that should make the pull request pruner bot more robust. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/457 From rwestberg at openjdk.java.net Wed Feb 19 13:30:30 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 19 Feb 2020 13:30:30 GMT Subject: [Integrated] RFR: 283: Pull request pruner bot should look at comments and reviews only In-Reply-To: References: Message-ID: <48211414-96bc-44ae-abae-648db561e033@openjdk.org> Changeset: 0feb780f Author: Robin Westberg Date: 2020-02-19 13:29:50 +0000 URL: https://git.openjdk.java.net/skara/commit/0feb780f 283: Pull request pruner bot should look at comments and reviews only Reviewed-by: ehelin ! bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/BridgekeeperBotFactory.java ! bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/PullRequestPrunerBot.java ! bots/bridgekeeper/src/test/java/org/openjdk/skara/bots/bridgekeeper/PullRequestPrunerBotTests.java From ehelin at openjdk.java.net Thu Feb 20 07:58:14 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 20 Feb 2020 07:58:14 GMT Subject: [Rev 03] RFR: No need for locking when using TestHostedRepository In-Reply-To: <41Q_HVzEsl6rKyx562Mkc4npMd7_wRLir_5CfepZKUg=.e178405b-6b0c-4d20-8ba1-643dc99b471b@github.com> References: <41Q_HVzEsl6rKyx562Mkc4npMd7_wRLir_5CfepZKUg=.e178405b-6b0c-4d20-8ba1-643dc99b471b@github.com> Message-ID: On Mon, 2 Dec 2019 14:48:45 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this change that skips creating repository lock files when using the TestHostedRepository, as it uses unique temporary folders anyway. This makes the tests run a little bit faster. >> >> Best regards, >> Robin > > The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/219 From ehelin at openjdk.java.net Thu Feb 20 08:18:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 20 Feb 2020 08:18:19 GMT Subject: RFR: git-pr: use multi-command argument parser Message-ID: Hi all, please review this refactoring of `git pr` to start to use the `MultiCommandParser`. This refactoring is needed for several reasons: - not all subcommands support all options - better help messages - better reuse of utility functions - the code was essentially one gigantic `main` function I plan to split this file into multiple files, one for each command, but that is for a later refactoring. I have tried to preserve the semantics of all commands and have tested them locally. Thanks, Erik ------------- Commits: - 5a0abe42: Remove tabs - 52fe55e9: git-pr: use multi-command argument parser Changes: https://git.openjdk.java.net/skara/pull/458/files Webrev: https://webrevs.openjdk.java.net/skara/458/webrev.00 Stats: 1676 lines in 1 file changed: 790 ins; 575 del; 311 mod Patch: https://git.openjdk.java.net/skara/pull/458.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/458/head:pull/458 PR: https://git.openjdk.java.net/skara/pull/458 From rwestberg at openjdk.java.net Thu Feb 20 08:35:04 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 20 Feb 2020 08:35:04 GMT Subject: RFR: git-pr: use multi-command argument parser In-Reply-To: References: Message-ID: On Thu, 20 Feb 2020 08:07:38 GMT, Erik Helin wrote: > Hi all, > > please review this refactoring of `git pr` to start to use the > `MultiCommandParser`. This refactoring is needed for several reasons: > > - not all subcommands support all options > - better help messages > - better reuse of utility functions > - the code was essentially one gigantic `main` function > > I plan to split this file into multiple files, one for each command, but that is > for a later refactoring. I have tried to preserve the semantics of all commands > and have tested them locally. > > Thanks, > Erik Looks good to me! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/458 From erik.helin at oracle.com Thu Feb 20 10:09:53 2020 From: erik.helin at oracle.com (Erik Helin) Date: Thu, 20 Feb 2020 11:09:53 +0100 Subject: Result: New Skara Reviewer: Jorn Vernee Message-ID: <32ecf7f0-6b5a-a1d1-1913-0a71a4ad347e@oracle.com> Voting for Jorn Vernee [1] is now closed. Yes: 3 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus, this is sufficient to approve the nomination. Erik [1] https://mail.openjdk.java.net/pipermail/skara-dev/2020-February/001701.html From ehelin at openjdk.java.net Thu Feb 20 10:19:42 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 20 Feb 2020 10:19:42 GMT Subject: [Integrated] RFR: git-pr: use multi-command argument parser In-Reply-To: References: Message-ID: <2e78b652-4bb5-45c3-9f8c-f2b808222c57@openjdk.org> Changeset: 529eedf9 Author: Erik Helin Date: 2020-02-20 10:19:19 +0000 URL: https://git.openjdk.java.net/skara/commit/529eedf9 git-pr: use multi-command argument parser Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java From ehelin at openjdk.java.net Thu Feb 20 10:22:00 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 20 Feb 2020 10:22:00 GMT Subject: git: openjdk/skara: forge: add method diffUrl to PullRequest Message-ID: Changeset: 513a8e3f Author: Erik Helin Date: 2020-02-20 10:21:39 +0000 URL: https://git.openjdk.java.net/skara/commit/513a8e3f forge: add method diffUrl to PullRequest Reviewed-by: rwestberg ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java ! forge/src/main/java/org/openjdk/skara/forge/PullRequest.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java ! test/src/main/java/org/openjdk/skara/test/TestPullRequest.java From ehelin at openjdk.java.net Thu Feb 20 10:25:00 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 20 Feb 2020 10:25:00 GMT Subject: RFR: forge: add method diffUrl to PullRequest Message-ID: <97epzsjvFmNMkLTEZZIjf4pt1sFRz1S6xXSCfpwoFE0=.4e685eb1-e860-4168-9325-efc3c82a7015@github.com> Hi all, please review this small patch that adds the method `PullRequest::diffUrl`. Although the implementation is the same for both `GitHubPullRequest` and `GitLabMergeRequest` I chose to not do a `default` method to highlight that this is more of a coincidence than a rule. Thanks, Erik ------------- Commits: - 89faf8e2: forge: add method diffUrl to PullRequest Changes: https://git.openjdk.java.net/skara/pull/459/files Webrev: https://webrevs.openjdk.java.net/skara/459/webrev.00 Stats: 32 lines in 6 files changed: 25 ins; 4 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/459.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/459/head:pull/459 PR: https://git.openjdk.java.net/skara/pull/459 From rwestberg at openjdk.java.net Thu Feb 20 10:25:01 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 20 Feb 2020 10:25:01 GMT Subject: RFR: forge: add method diffUrl to PullRequest In-Reply-To: <97epzsjvFmNMkLTEZZIjf4pt1sFRz1S6xXSCfpwoFE0=.4e685eb1-e860-4168-9325-efc3c82a7015@github.com> References: <97epzsjvFmNMkLTEZZIjf4pt1sFRz1S6xXSCfpwoFE0=.4e685eb1-e860-4168-9325-efc3c82a7015@github.com> Message-ID: On Thu, 20 Feb 2020 10:14:33 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that adds the method `PullRequest::diffUrl`. > Although the implementation is the same for both `GitHubPullRequest` and > `GitLabMergeRequest` I chose to not do a `default` method to highlight that this > is more of a coincidence than a rule. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/459 From ehelin at openjdk.java.net Thu Feb 20 13:30:46 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 20 Feb 2020 13:30:46 GMT Subject: RFR: git-pr: move subcommands to separate files Message-ID: Hi all, please review this patch that splits `GitPr.java` into multiple files - one file per sub-command. This makes the code much more maintainable and allows for easy addition of new commands. Testing: - Manual testing of `git pr` Thanks, Erik ------------- Commits: - 365b1ce4: git-pr: move subcommands to separate files Changes: https://git.openjdk.java.net/skara/pull/460/files Webrev: https://webrevs.openjdk.java.net/skara/460/webrev.00 Stats: 3621 lines in 18 files changed: 2023 ins; 1569 del; 29 mod Patch: https://git.openjdk.java.net/skara/pull/460.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/460/head:pull/460 PR: https://git.openjdk.java.net/skara/pull/460 From rwestberg at openjdk.java.net Thu Feb 20 13:32:54 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 20 Feb 2020 13:32:54 GMT Subject: RFR: git-pr: move subcommands to separate files In-Reply-To: References: Message-ID: On Thu, 20 Feb 2020 13:25:05 GMT, Erik Helin wrote: > Hi all, > > please review this patch that splits `GitPr.java` into multiple files - one file > per sub-command. This makes the code much more maintainable and allows for easy > addition of new commands. > > Testing: > - Manual testing of `git pr` > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/460 From ehelin at openjdk.java.net Thu Feb 20 13:38:47 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 20 Feb 2020 13:38:47 GMT Subject: [Integrated] RFR: git-pr: move subcommands to separate files In-Reply-To: References: Message-ID: <292cf424-a5c0-4a66-9814-cbfb25c4e5f7@openjdk.org> Changeset: 708736d0 Author: Erik Helin Date: 2020-02-20 13:38:31 +0000 URL: https://git.openjdk.java.net/skara/commit/708736d0 git-pr: move subcommands to separate files Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitCredentials.java ! cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java ! cli/src/main/java/org/openjdk/skara/cli/Logging.java ! cli/src/main/java/org/openjdk/skara/cli/Remote.java + cli/src/main/java/org/openjdk/skara/cli/pr/GitPrApply.java + cli/src/main/java/org/openjdk/skara/cli/pr/GitPrApprove.java + cli/src/main/java/org/openjdk/skara/cli/pr/GitPrCheckout.java + cli/src/main/java/org/openjdk/skara/cli/pr/GitPrClose.java + cli/src/main/java/org/openjdk/skara/cli/pr/GitPrCreate.java + cli/src/main/java/org/openjdk/skara/cli/pr/GitPrFetch.java + cli/src/main/java/org/openjdk/skara/cli/pr/GitPrIntegrate.java + cli/src/main/java/org/openjdk/skara/cli/pr/GitPrList.java + cli/src/main/java/org/openjdk/skara/cli/pr/GitPrSet.java + cli/src/main/java/org/openjdk/skara/cli/pr/GitPrShow.java + cli/src/main/java/org/openjdk/skara/cli/pr/GitPrStatus.java + cli/src/main/java/org/openjdk/skara/cli/pr/GitPrTest.java + cli/src/main/java/org/openjdk/skara/cli/pr/Utils.java From ehelin at openjdk.java.net Thu Feb 20 14:52:39 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 20 Feb 2020 14:52:39 GMT Subject: [Rev 02] RFR: git-pr: support git pr create --draft In-Reply-To: References: Message-ID: > Hi all, > > please review this patch adds support for `--draft` switch to `git pr create`. > > Testing: > - Manual testing of `git pr create` > > Thanks, > Erik The pull request has been updated with a new target base due to a merge or a rebase. ------------- Commits: - 33177e22: Merge master - 4d86006d: Support 'git pr set --no-draft' - c667d5a6: Support git pr create --draft Changes: https://git.openjdk.java.net/skara/pull/454/files Webrev: https://webrevs.openjdk.java.net/skara/454/webrev.02 Stats: 115 lines in 8 files changed: 114 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/454.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/454/head:pull/454 PR: https://git.openjdk.java.net/skara/pull/454 From ehelin at openjdk.java.net Thu Feb 20 14:52:40 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 20 Feb 2020 14:52:40 GMT Subject: [Rev 01] RFR: git-pr: support git pr create --draft In-Reply-To: References: Message-ID: On Wed, 19 Feb 2020 10:01:47 GMT, Robin Westberg wrote: >> The pull request has been updated with 1 additional commit. > > forge/src/main/java/org/openjdk/skara/forge/PullRequest.java line 138: > >> 137: boolean isDraft(); >> 138: void makeNotDraft(); >> 139: } > > While symmetrical, perhaps `makeFinal` or `makeReady` would look nicer.. But if so `isDraft` should perhaps be `isFinal` as well. Yeah, I sort of agree. However both platforms (GitHub and GitLab) does not have a word for the "not draft" state. So to make it very clear I think I prefer the current verbose (and slightly weird) naming to be make the code clearer. ------------- PR: https://git.openjdk.java.net/skara/pull/454 From ehelin at openjdk.java.net Thu Feb 20 15:12:11 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 20 Feb 2020 15:12:11 GMT Subject: [Rev 03] RFR: git-pr: support git pr create --draft In-Reply-To: References: Message-ID: > Hi all, > > please review this patch adds support for `--draft` switch to `git pr create`. > > Testing: > - Manual testing of `git pr create` > > Thanks, > Erik The pull request has been updated with 1 additional commit. ------------- Added commits: - acd7a317: Better helptext for git pr set --no-draft Changes: - all: https://git.openjdk.java.net/skara/pull/454/files - new: https://git.openjdk.java.net/skara/pull/454/files/33177e22..acd7a317 Webrevs: - full: https://webrevs.openjdk.java.net/skara/454/webrev.03 - incr: https://webrevs.openjdk.java.net/skara/454/webrev.02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/454.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/454/head:pull/454 PR: https://git.openjdk.java.net/skara/pull/454 From aph at redhat.com Thu Feb 20 15:17:14 2020 From: aph at redhat.com (Andrew Haley) Date: Thu, 20 Feb 2020 15:17:14 +0000 Subject: Does this error matter? In-Reply-To: References: <70743b5d-28a3-07fe-b4ae-b3bf4c1d4555@redhat.com> <86838845-1412-9807-3e23-8e7666f09e7c@redhat.com> Message-ID: On 2/17/20 12:56 PM, Erik Helin wrote: > On 2/17/20 11:00 AM, Andrew Haley wrote: >> On 2/17/20 9:08 AM, Erik Helin wrote: >>> From the message it seems like the libsecret library can't start the >>> 'org.freedesktop.secrets' service, you might want to check in >>> /var/log/syslog to see if there are any additional log messages (see for >>> example [6]). If you believe you have found a bug in libsecret then you >>> can file an issue in their GitLab issue tracker [7]. Unfortunately there >>> is not much Skara can do to help fix this issue, this error occurs at >>> lower level in your GNU/Linux desktop stack :( >> >> Yeah, OK. So there's some problem there. >> >> Does Skara need this stuff? Git seems to work without it. > > Yes, Git works fine without this. Skara does not strictly need this, > but the Skara tooling will ask you for you username and personal > access token (PAT) every time if you do not store them in a > credential store using a credential helper. > > We do support supplying your token via an environment variable for > users who do not wish to (or are unable to) use a token store. See > the description under the "Manual" section on the Skara wiki [0] for > an example using gpg. Yes! It took a while to get it working because (I think) there is a mistake in the Wiki. It says: [credentials "https://github.com"] username = foobar I think "credentials" is wrong. It keeps asking me for my username. If I change this to "credential" it seems to work. This is much better for me than depending on a token store: all it needs is a working GPG, and I guess everyone has that. It doesn't need a GUI or anything, it works everywhere. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From kcr at openjdk.java.net Thu Feb 20 20:42:52 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Thu, 20 Feb 2020 20:42:52 GMT Subject: RFR: WIP: 108: Command line tools fon't run with Cygwin git In-Reply-To: References: Message-ID: On Tue, 8 Oct 2019 06:38:01 GMT, Robin Westberg wrote: >> Hi Kevin, >> >> thanks for looking into this and sorry for not responding earlier. I would like to understand your use case a bit more - why are you using Cygwin git over [Git for Windows](https://gitforwindows.org/)? I understand that you need to use Cygwin, but why not use the Windows native git binary in Cygwin (instead of Cygwin's version of git)? >> >> Looking at your changes I can immediately see that adding support for the Cygwin version of git will have far-reaching consequences for almost all our code, so I would really like to understand the advantages of using Cygwin git before pursuing this further. >> >> Thanks, >> Erik > > Please disregard this comment, investigating a failed email delivery. I'm withdrawing this PR. I still think having support for Cygwin git would be a good thing. I tried native Windows git a few months back and had a variety of usage issues, so I'm sticking with Cygwin git. I can live without formal support for the Skara command line tools on Cygwin git (my temporary patch is enough to allow `git jcheck` to work, so this isn't blocking me). ------------- PR: https://git.openjdk.java.net/skara/pull/170 From ehelin at openjdk.java.net Fri Feb 21 08:16:58 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 21 Feb 2020 08:16:58 GMT Subject: [Integrated] RFR: git-pr: support git pr create --draft In-Reply-To: References: Message-ID: Changeset: 30706722 Author: Erik Helin Date: 2020-02-21 08:16:40 +0000 URL: https://git.openjdk.java.net/skara/commit/30706722 git-pr: support git pr create --draft Reviewed-by: rwestberg ! bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java ! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrCreate.java ! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrSet.java ! forge/src/main/java/org/openjdk/skara/forge/PullRequest.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java ! test/src/main/java/org/openjdk/skara/test/TestPullRequest.java From ehelin at openjdk.java.net Fri Feb 21 09:11:21 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 21 Feb 2020 09:11:21 GMT Subject: RFR: git-pr: add multiple new options to "git pr set" Message-ID: Hi all, please review this patch that adds a number of options to `git pr set`: - `--open` - set the pull request's state to "open" - `--closed` - set the pull request's state to "closed" - `--title` - set the pull request's title - `--body` - set the pull request's body Already existing options to `git pr set` include: - `--assignees` - set the assignees of the pull request - `--no-draft` - set the pull request's state to "not draft" All in all, `git pr set` has now become rather useful ?? Testing: - Manual testing of `git pr set` on Linux x64 Thanks, Erik ------------- Commits: - 4732856b: git-pr: add options to "git pr set" Changes: https://git.openjdk.java.net/skara/pull/461/files Webrev: https://webrevs.openjdk.java.net/skara/461/webrev.00 Stats: 49 lines in 1 file changed: 49 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/461.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/461/head:pull/461 PR: https://git.openjdk.java.net/skara/pull/461 From rwestberg at openjdk.java.net Fri Feb 21 09:22:30 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 21 Feb 2020 09:22:30 GMT Subject: RFR: git-pr: add multiple new options to "git pr set" In-Reply-To: References: Message-ID: <73Sxzjxpdl2hZKK4VOL-kRuUgZf0ih2iKtIkw7BCkyY=.c6ce17f6-20cb-42b4-845d-26c19d8212c2@github.com> On Fri, 21 Feb 2020 09:04:47 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds a number of options to `git pr set`: > > - `--open` - set the pull request's state to "open" > - `--closed` - set the pull request's state to "closed" > - `--title` - set the pull request's title > - `--body` - set the pull request's body > > Already existing options to `git pr set` include: > > - `--assignees` - set the assignees of the pull request > - `--no-draft` - set the pull request's state to "not draft" > > All in all, `git pr set` has now become rather useful ?? > > Testing: > - Manual testing of `git pr set` on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/461 From ehelin at openjdk.java.net Fri Feb 21 09:27:02 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 21 Feb 2020 09:27:02 GMT Subject: [Integrated] RFR: git-pr: add multiple new options to "git pr set" In-Reply-To: References: Message-ID: Changeset: 9f41339a Author: Erik Helin Date: 2020-02-21 09:26:41 +0000 URL: https://git.openjdk.java.net/skara/commit/9f41339a git-pr: add multiple new options to "git pr set" Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrSet.java From ehelin at openjdk.java.net Fri Feb 21 09:39:01 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 21 Feb 2020 09:39:01 GMT Subject: RFR: git-pr: set should allow no assignees Message-ID: Hi all, please review this small patch that allows the `--assignees` option to `git pr set` to be empty. That is, `git pr set --assignees=` should make the pull request have no user assigned to it. Testing: - Manual testing of `git pr set --assignees=` on Linux x64 Thanks, Erik ------------- Commits: - 283c6fdd: git-pr: set should allow no assignees Changes: https://git.openjdk.java.net/skara/pull/462/files Webrev: https://webrevs.openjdk.java.net/skara/462/webrev.00 Stats: 5 lines in 3 files changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/462.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/462/head:pull/462 PR: https://git.openjdk.java.net/skara/pull/462 From rwestberg at openjdk.java.net Fri Feb 21 09:48:55 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 21 Feb 2020 09:48:55 GMT Subject: RFR: git-pr: set should allow no assignees In-Reply-To: References: Message-ID: On Fri, 21 Feb 2020 09:33:08 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that allows the `--assignees` option to `git pr > set` to be empty. That is, `git pr set --assignees=` should make the pull > request have no user assigned to it. > > Testing: > - Manual testing of `git pr set --assignees=` on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/462 From ehelin at openjdk.java.net Fri Feb 21 10:06:50 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 21 Feb 2020 10:06:50 GMT Subject: [Integrated] RFR: git-pr: set should allow no assignees In-Reply-To: References: Message-ID: <274d4e3f-4700-436e-963d-90ba087cfa3e@openjdk.org> Changeset: c309df62 Author: Erik Helin Date: 2020-02-21 10:06:28 +0000 URL: https://git.openjdk.java.net/skara/commit/c309df62 git-pr: set should allow no assignees Reviewed-by: rwestberg ! args/src/main/java/org/openjdk/skara/args/Argument.java ! args/src/main/java/org/openjdk/skara/args/ArgumentParser.java ! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrSet.java From erik.helin at oracle.com Fri Feb 21 10:16:21 2020 From: erik.helin at oracle.com (Erik Helin) Date: Fri, 21 Feb 2020 11:16:21 +0100 Subject: Does this error matter? In-Reply-To: References: <70743b5d-28a3-07fe-b4ae-b3bf4c1d4555@redhat.com> <86838845-1412-9807-3e23-8e7666f09e7c@redhat.com> Message-ID: <7e60c181-f50c-4f2b-4fab-24cf305c64b4@oracle.com> On 2/20/20 4:17 PM, Andrew Haley wrote: > On 2/17/20 12:56 PM, Erik Helin wrote: >> On 2/17/20 11:00 AM, Andrew Haley wrote: >>> On 2/17/20 9:08 AM, Erik Helin wrote: >>>> From the message it seems like the libsecret library can't start the >>>> 'org.freedesktop.secrets' service, you might want to check in >>>> /var/log/syslog to see if there are any additional log messages (see for >>>> example [6]). If you believe you have found a bug in libsecret then you >>>> can file an issue in their GitLab issue tracker [7]. Unfortunately there >>>> is not much Skara can do to help fix this issue, this error occurs at >>>> lower level in your GNU/Linux desktop stack :( >>> >>> Yeah, OK. So there's some problem there. >>> >>> Does Skara need this stuff? Git seems to work without it. >> >> Yes, Git works fine without this. Skara does not strictly need this, >> but the Skara tooling will ask you for you username and personal >> access token (PAT) every time if you do not store them in a >> credential store using a credential helper. >> >> We do support supplying your token via an environment variable for >> users who do not wish to (or are unable to) use a token store. See >> the description under the "Manual" section on the Skara wiki [0] for >> an example using gpg. > > Yes! It took a while to get it working because (I think) there is a > mistake in the Wiki. It says: > > [credentials "https://github.com"] > username = foobar > > I think "credentials" is wrong. It keeps asking me for my username. If > I change this to "credential" it seems to work. Yes, you are correct, sorry about the typo :( I have updated the wiki as well. > This is much better for me than depending on a token store: all it > needs is a working GPG, and I guess everyone has that. It doesn't need > a GUI or anything, it works everywhere. Great that you got it working! Thanks, Erik From ehelin at openjdk.java.net Fri Feb 21 11:30:12 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 21 Feb 2020 11:30:12 GMT Subject: RFR: git-pr: publish later and polish error messages Message-ID: Hi all, please review this patch that ensure that `git pr create` runs `git publish` as _late_ as possible. This is to avoid GitHub showing the "You just pushed a branch" notification while the user is writing the pull request message in the editor. I also polished several of the error messages to provide better info and do better checks. Testing: - manual testing of `git pr create` on Linux x64 Thanks, Erik ------------- Commits: - b999c162: git-pr: publish later and polish error messages Changes: https://git.openjdk.java.net/skara/pull/463/files Webrev: https://webrevs.openjdk.java.net/skara/463/webrev.00 Stats: 86 lines in 1 file changed: 44 ins; 30 del; 12 mod Patch: https://git.openjdk.java.net/skara/pull/463.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/463/head:pull/463 PR: https://git.openjdk.java.net/skara/pull/463 From rwestberg at openjdk.java.net Fri Feb 21 11:58:22 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 21 Feb 2020 11:58:22 GMT Subject: RFR: git-pr: publish later and polish error messages In-Reply-To: References: Message-ID: On Fri, 21 Feb 2020 11:25:22 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensure that `git pr create` runs `git publish` as > _late_ as possible. This is to avoid GitHub showing the "You just pushed a > branch" notification while the user is writing the pull request message in the > editor. > > I also polished several of the error messages to provide better info and do > better checks. > > Testing: > - manual testing of `git pr create` on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/463 From ehelin at openjdk.java.net Fri Feb 21 13:02:39 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 21 Feb 2020 13:02:39 GMT Subject: [Integrated] RFR: git-pr: publish later and polish error messages In-Reply-To: References: Message-ID: <8ccef76e-9ba0-4e98-a17e-4d4c9a07156f@openjdk.org> Changeset: 9a4e98b5 Author: Erik Helin Date: 2020-02-21 13:02:19 +0000 URL: https://git.openjdk.java.net/skara/commit/9a4e98b5 git-pr: publish later and polish error messages Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrCreate.java From ehelin at openjdk.java.net Fri Feb 21 13:17:30 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 21 Feb 2020 13:17:30 GMT Subject: RFR: git-jcheck: set exit code correctly Message-ID: Hi all, please review this small patch that ensures that `JCheckCLIVisitor` correctly sets `hasDisplayedError` for all errors. This will in turn make sure that `git-jcheck` exits with code `1` whenever an error has been shown which in turn will make `git create --jcheck` work correctly. Testing: - Manual testing of `git jcheck` and `git pr create --jcheck` on Linux x64 Thanks, Erik ------------- Commits: - 5bfae13b: git-jcheck: set exit code correctly Changes: https://git.openjdk.java.net/skara/pull/464/files Webrev: https://webrevs.openjdk.java.net/skara/464/webrev.00 Stats: 21 lines in 1 file changed: 19 ins; 2 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/464.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/464/head:pull/464 PR: https://git.openjdk.java.net/skara/pull/464 From rwestberg at openjdk.java.net Fri Feb 21 13:17:31 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 21 Feb 2020 13:17:31 GMT Subject: RFR: git-jcheck: set exit code correctly In-Reply-To: References: Message-ID: On Fri, 21 Feb 2020 13:08:56 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that ensures that `JCheckCLIVisitor` correctly > sets `hasDisplayedError` for all errors. This will in turn make sure that > `git-jcheck` exits with code `1` whenever an error has been shown which in > turn will make `git create --jcheck` work correctly. > > Testing: > - Manual testing of `git jcheck` and `git pr create --jcheck` on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/464 From ehelin at openjdk.java.net Fri Feb 21 13:28:24 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 21 Feb 2020 13:28:24 GMT Subject: [Integrated] RFR: git-jcheck: set exit code correctly In-Reply-To: References: Message-ID: <6de12a6e-eb6a-4cba-907f-f046d2aa7df0@openjdk.org> Changeset: 3bffa0b9 Author: Erik Helin Date: 2020-02-21 13:28:11 +0000 URL: https://git.openjdk.java.net/skara/commit/3bffa0b9 git-jcheck: set exit code correctly Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/JCheckCLIVisitor.java From ehelin at openjdk.java.net Fri Feb 21 14:14:08 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 21 Feb 2020 14:14:08 GMT Subject: RFR: git-jcheck: remove --local, add --ignore Message-ID: <-SeK_AaJt19T3WAQxrURx1S5BUtXWvJw7ulLcWzHFF0=.02b9a9b8-492e-4c53-a4b3-1fb0d44d1a90@github.com> Hi all, please review this patch that removes the flags `--local` and `--pull-request` from `git-jcheck` and instead adds the more general `--ignore` flag. For example, `git jcheck --local` now becomes `git jcheck --ignore=branches,committer,reviewers,issues`. Since all errors from `git-jcheck` includes the name of the check that cause the error, it is pretty easy to iteratively come up with a custom `--ignore` value. Testing: - Manual testing of `git-jcheck` and `git-pr create --jcheck` on Linux x64 Thanks, Erik ------------- Commits: - b9a07ee8: git-jcheck: remove --local, add --ignore Changes: https://git.openjdk.java.net/skara/pull/465/files Webrev: https://webrevs.openjdk.java.net/skara/465/webrev.00 Stats: 204 lines in 3 files changed: 80 ins; 38 del; 86 mod Patch: https://git.openjdk.java.net/skara/pull/465.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/465/head:pull/465 PR: https://git.openjdk.java.net/skara/pull/465 From rwestberg at openjdk.java.net Fri Feb 21 14:15:54 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 21 Feb 2020 14:15:54 GMT Subject: RFR: git-jcheck: remove --local, add --ignore In-Reply-To: <-SeK_AaJt19T3WAQxrURx1S5BUtXWvJw7ulLcWzHFF0=.02b9a9b8-492e-4c53-a4b3-1fb0d44d1a90@github.com> References: <-SeK_AaJt19T3WAQxrURx1S5BUtXWvJw7ulLcWzHFF0=.02b9a9b8-492e-4c53-a4b3-1fb0d44d1a90@github.com> Message-ID: On Fri, 21 Feb 2020 14:08:43 GMT, Erik Helin wrote: > Hi all, > > please review this patch that removes the flags `--local` and `--pull-request` > from `git-jcheck` and instead adds the more general `--ignore` flag. For > example, `git jcheck --local` now becomes `git jcheck > --ignore=branches,committer,reviewers,issues`. Since all errors from > `git-jcheck` includes the name of the check that cause the error, it is pretty > easy to iteratively come up with a custom `--ignore` value. > > Testing: > - Manual testing of `git-jcheck` and `git-pr create --jcheck` on Linux x64 > > Thanks, > Erik Looks good to me! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/465 From rwestberg at openjdk.java.net Fri Feb 21 15:25:51 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 21 Feb 2020 15:25:51 GMT Subject: RFR: Include commit messages in mail body for new revision emails Message-ID: Hi all, Please review this change that includes the commit messages in the mail body when a new revision email is sent out, which should improve quoting. Best regards, Robin ------------- Commits: - dbd4dc67: Initial version Changes: https://git.openjdk.java.net/skara/pull/466/files Webrev: https://webrevs.openjdk.java.net/skara/466/webrev.00 Stats: 190 lines in 3 files changed: 110 ins; 39 del; 41 mod Patch: https://git.openjdk.java.net/skara/pull/466.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/466/head:pull/466 PR: https://git.openjdk.java.net/skara/pull/466 From ehelin at openjdk.java.net Mon Feb 24 05:57:48 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 24 Feb 2020 05:57:48 GMT Subject: [Integrated] RFR: git-jcheck: remove --local, add --ignore In-Reply-To: <-SeK_AaJt19T3WAQxrURx1S5BUtXWvJw7ulLcWzHFF0=.02b9a9b8-492e-4c53-a4b3-1fb0d44d1a90@github.com> References: <-SeK_AaJt19T3WAQxrURx1S5BUtXWvJw7ulLcWzHFF0=.02b9a9b8-492e-4c53-a4b3-1fb0d44d1a90@github.com> Message-ID: <1017528a-cef1-45ba-b0ce-a36d71db493d@openjdk.org> Changeset: 73581b1a Author: Erik Helin Date: 2020-02-24 05:57:29 +0000 URL: https://git.openjdk.java.net/skara/commit/73581b1a git-jcheck: remove --local, add --ignore Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java ! cli/src/main/java/org/openjdk/skara/cli/JCheckCLIVisitor.java ! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrCreate.java From rwestberg at openjdk.java.net Mon Feb 24 08:03:16 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 24 Feb 2020 08:03:16 GMT Subject: RFR: Handle links already deleted Message-ID: Hi all, Please review this small change that gracefully handles removing Jira links that have already been deleted. Best regards, Robin ------------- Commits: - 2d237d75: Handle links already deleted Changes: https://git.openjdk.java.net/skara/pull/467/files Webrev: https://webrevs.openjdk.java.net/skara/467/webrev.00 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/467.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/467/head:pull/467 PR: https://git.openjdk.java.net/skara/pull/467 From rwestberg at openjdk.java.net Mon Feb 24 08:35:39 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 24 Feb 2020 08:35:39 GMT Subject: RFR: Make the rest request error transform optional Message-ID: Hi all, Please review this change that allows the rest request error transform functional to only transform certain errors, and let the rest be handled as untransformed. Best regards, Robin ------------- Commits: - 018d326c: Make the error transform optional Changes: https://git.openjdk.java.net/skara/pull/468/files Webrev: https://webrevs.openjdk.java.net/skara/468/webrev.00 Stats: 31 lines in 8 files changed: 3 ins; 7 del; 21 mod Patch: https://git.openjdk.java.net/skara/pull/468.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/468/head:pull/468 PR: https://git.openjdk.java.net/skara/pull/468 From ehelin at openjdk.java.net Mon Feb 24 08:42:33 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 24 Feb 2020 08:42:33 GMT Subject: RFR: Handle links already deleted In-Reply-To: References: Message-ID: On Mon, 24 Feb 2020 07:57:18 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that gracefully handles removing Jira links that have already been deleted. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/467 From ehelin at openjdk.java.net Mon Feb 24 08:43:25 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 24 Feb 2020 08:43:25 GMT Subject: RFR: Make the rest request error transform optional In-Reply-To: References: Message-ID: On Mon, 24 Feb 2020 08:30:32 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows the rest request error transform functional to only transform certain errors, and let the rest be handled as untransformed. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/468 From ehelin at openjdk.java.net Mon Feb 24 13:04:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 24 Feb 2020 13:04:37 GMT Subject: RFR: vcs: add Hash::zero Message-ID: Hi all, please review this small refactoring that adds the method `Hash::zero` representing an empty hash. The zero hash was already used throughout the code base but in a less clear way. Testing: - `make test` passes on Linux x64 Thanks, Erik ------------- Commits: - 2c2c69c7: vcs: add Hash::zero Changes: https://git.openjdk.java.net/skara/pull/469/files Webrev: https://webrevs.openjdk.java.net/skara/469/webrev.00 Stats: 50 lines in 13 files changed: 5 ins; 9 del; 36 mod Patch: https://git.openjdk.java.net/skara/pull/469.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/469/head:pull/469 PR: https://git.openjdk.java.net/skara/pull/469 From rwestberg at openjdk.java.net Mon Feb 24 13:32:19 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 24 Feb 2020 13:32:19 GMT Subject: [Integrated] RFR: Make the rest request error transform optional In-Reply-To: References: Message-ID: Changeset: 0e9e8412 Author: Robin Westberg Date: 2020-02-24 13:32:02 +0000 URL: https://git.openjdk.java.net/skara/commit/0e9e8412 Make the rest request error transform optional Reviewed-by: ehelin ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabHost.java ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraHost.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java ! network/src/main/java/org/openjdk/skara/network/RestRequest.java ! network/src/test/java/org/openjdk/skara/network/RestRequestTests.java From rwestberg at openjdk.java.net Mon Feb 24 13:33:32 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 24 Feb 2020 13:33:32 GMT Subject: RFR: vcs: add Hash::zero In-Reply-To: References: Message-ID: On Mon, 24 Feb 2020 12:56:33 GMT, Erik Helin wrote: > Hi all, > > please review this small refactoring that adds the method `Hash::zero` > representing an empty hash. The zero hash was already used throughout the code > base but in a less clear way. > > Testing: > - `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/469 From ehelin at openjdk.java.net Mon Feb 24 14:14:46 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 24 Feb 2020 14:14:46 GMT Subject: [Integrated] RFR: vcs: add Hash::zero In-Reply-To: References: Message-ID: <4a3c5a57-3004-408d-99c2-240e1bf86b01@openjdk.org> Changeset: b090b57c Author: Erik Helin Date: 2020-02-24 14:14:32 +0000 URL: https://git.openjdk.java.net/skara/commit/b090b57c vcs: add Hash::zero Reviewed-by: rwestberg ! forge/src/test/java/org/openjdk/skara/forge/CheckBuilderTests.java ! jcheck/src/test/java/org/openjdk/skara/jcheck/BinaryCheckTests.java ! jcheck/src/test/java/org/openjdk/skara/jcheck/ExecutableCheckTests.java ! jcheck/src/test/java/org/openjdk/skara/jcheck/HgTagCommitCheckTests.java ! jcheck/src/test/java/org/openjdk/skara/jcheck/WhitespaceCheckTests.java ! vcs/src/main/java/org/openjdk/skara/vcs/CommitMetadata.java ! vcs/src/main/java/org/openjdk/skara/vcs/Hash.java ! vcs/src/main/java/org/openjdk/skara/vcs/Patch.java ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitCommitMetadata.java ! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java ! vcs/src/main/java/org/openjdk/skara/vcs/openjdk/convert/GitToHgConverter.java ! vcs/src/main/java/org/openjdk/skara/vcs/openjdk/convert/HgToGitConverter.java ! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java From ehelin at openjdk.java.net Mon Feb 24 14:28:25 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 24 Feb 2020 14:28:25 GMT Subject: RFR: git-jcheck: add pre-push support Message-ID: Hi all, please review this patch that adds support for the `--pre-push` and `--setup-pre-push-hook` to `git-jcheck`. Setting up a pre-push hook can beneficial for OpenJDK projects where contributors push directly (where they don't use `git-pr` and pull requests). Testing: - Manual testing on Linux x64 Thanks, Erik ------------- Commits: - 87dd7851: git-jcheck: add pre-push support Changes: https://git.openjdk.java.net/skara/pull/470/files Webrev: https://webrevs.openjdk.java.net/skara/470/webrev.00 Stats: 65 lines in 1 file changed: 50 ins; 1 del; 14 mod Patch: https://git.openjdk.java.net/skara/pull/470.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/470/head:pull/470 PR: https://git.openjdk.java.net/skara/pull/470 From rwestberg at openjdk.java.net Mon Feb 24 14:29:44 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 24 Feb 2020 14:29:44 GMT Subject: RFR: git-jcheck: add pre-push support In-Reply-To: References: Message-ID: <8U8g1BaEwODfx0Eor-03PmLV9ZqXNbmV4Vrd9eUrSTY=.21391155-543c-4f9c-966b-954b5a708111@github.com> On Mon, 24 Feb 2020 14:21:09 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds support for the `--pre-push` and > `--setup-pre-push-hook` to `git-jcheck`. Setting up a pre-push hook can > beneficial for OpenJDK projects where contributors push directly (where they > don't use `git-pr` and pull requests). > > Testing: > - Manual testing on Linux x64 > > Thanks, > Erik Looks good, just be consistent with the dash. :) cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java line 119: > 118: .fullname("setup-pre-push-hook") > 119: .helptext("Set up a pre push hook that runs jcheck") > 120: .optional(), Suggestion: .helptext("Set up a pre-push hook that runs jcheck") ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/470 From ehelin at openjdk.java.net Mon Feb 24 15:02:07 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 24 Feb 2020 15:02:07 GMT Subject: [Integrated] RFR: git-jcheck: add pre-push support In-Reply-To: References: Message-ID: Changeset: bc37f619 Author: Erik Helin Date: 2020-02-24 15:01:50 +0000 URL: https://git.openjdk.java.net/skara/commit/bc37f619 git-jcheck: add pre-push support Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java From ehelin at openjdk.java.net Mon Feb 24 15:03:34 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 24 Feb 2020 15:03:34 GMT Subject: [Rev 01] RFR: git-jcheck: add pre-push support In-Reply-To: References: Message-ID: > Hi all, > > please review this patch that adds support for the `--pre-push` and > `--setup-pre-push-hook` to `git-jcheck`. Setting up a pre-push hook can > beneficial for OpenJDK projects where contributors push directly (where they > don't use `git-pr` and pull requests). > > Testing: > - Manual testing on Linux x64 > > Thanks, > Erik The pull request has been updated with 1 additional commit. ------------- Added commits: - c0c0789d: Use consistent spelling of pre-push Changes: - all: https://git.openjdk.java.net/skara/pull/470/files - new: https://git.openjdk.java.net/skara/pull/470/files/87dd7851..c0c0789d Webrevs: - full: https://webrevs.openjdk.java.net/skara/470/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/470/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/470.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/470/head:pull/470 PR: https://git.openjdk.java.net/skara/pull/470 From rwestberg at openjdk.java.net Mon Feb 24 15:18:05 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 24 Feb 2020 15:18:05 GMT Subject: [Rev 01] RFR: Handle links already deleted In-Reply-To: References: Message-ID: > Hi all, > > Please review this small change that gracefully handles removing Jira links that have already been deleted. > > Best regards, > Robin The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Added commits: - eb30e832: Adapt to latest upstream changes - df597cb0: Merge remote-tracking branch 'upstream/master' into jira_remove_unknown_link - bc37f619: git-jcheck: add pre-push support - b090b57c: vcs: add Hash::zero - 0e9e8412: Make the rest request error transform optional Changes: - all: https://git.openjdk.java.net/skara/pull/467/files - new: https://git.openjdk.java.net/skara/pull/467/files/2d237d75..eb30e832 Webrevs: - full: https://webrevs.openjdk.java.net/skara/467/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/467/webrev.00-01 Stats: 147 lines in 23 files changed: 58 ins; 17 del; 72 mod Patch: https://git.openjdk.java.net/skara/pull/467.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/467/head:pull/467 PR: https://git.openjdk.java.net/skara/pull/467 From rwestberg at openjdk.java.net Mon Feb 24 15:35:57 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 24 Feb 2020 15:35:57 GMT Subject: [Integrated] RFR: Handle links already deleted In-Reply-To: References: Message-ID: <80939a3b-fa37-4564-9bad-b5dc3b0c7f16@openjdk.org> Changeset: d451a265 Author: Robin Westberg Date: 2020-02-24 15:35:34 +0000 URL: https://git.openjdk.java.net/skara/commit/d451a265 Handle links already deleted Reviewed-by: ehelin ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java From rwestberg at openjdk.java.net Tue Feb 25 10:44:10 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 25 Feb 2020 10:44:10 GMT Subject: RFR: Implement shared caching for rest requests Message-ID: Hi all, Please review this change that implements caching for rest GET requests, as supported by at least GitHub. Best regards, Robin ------------- Commits: - 4f961967: Implement shared caching for rest requests Changes: https://git.openjdk.java.net/skara/pull/471/files Webrev: https://webrevs.openjdk.java.net/skara/471/webrev.00 Stats: 220 lines in 10 files changed: 196 ins; 2 del; 22 mod Patch: https://git.openjdk.java.net/skara/pull/471.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/471/head:pull/471 PR: https://git.openjdk.java.net/skara/pull/471 From rwestberg at openjdk.java.net Tue Feb 25 11:34:48 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 25 Feb 2020 11:34:48 GMT Subject: RFR: Adhere to GitHub's search rate limit Message-ID: Hi all, Please review this change that ensures that searches are not performed too often, to adhere to the special rate limit applied to search queries. Best regards, Robin ------------- Commits: - cdfcbb5b: Adhere to GitHub's search rate limit Changes: https://git.openjdk.java.net/skara/pull/472/files Webrev: https://webrevs.openjdk.java.net/skara/472/webrev.00 Stats: 20 lines in 1 file changed: 20 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/472.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/472/head:pull/472 PR: https://git.openjdk.java.net/skara/pull/472 From rwestberg at openjdk.java.net Tue Feb 25 11:57:10 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 25 Feb 2020 11:57:10 GMT Subject: RFR: Improve rate limit logging Message-ID: <3Oay6ts7tEmWYs29Rh0ukLpgGPRmqrAJztDE_rU0z3s=.60cf7bb9-560c-4353-ac44-27af9dc0920b@github.com> Hi all, Please review this small change that improves the rate limit logging. Best regards, Robin ------------- Commits: - 80cf3cdc: Improve rate limit logging Changes: https://git.openjdk.java.net/skara/pull/473/files Webrev: https://webrevs.openjdk.java.net/skara/473/webrev.00 Stats: 21 lines in 1 file changed: 11 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/skara/pull/473.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/473/head:pull/473 PR: https://git.openjdk.java.net/skara/pull/473 From rwestberg at openjdk.java.net Tue Feb 25 12:39:20 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 25 Feb 2020 12:39:20 GMT Subject: [Rev 01] RFR: Include commit messages in mail body for new revision emails In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that includes the commit messages in the mail body when a new revision email is sent out, which should improve quoting. > > Best regards, > Robin The pull request has been updated with 2 additional commits. ------------- Added commits: - d7af0669: Update tests - d6109c67: Text updates Changes: - all: https://git.openjdk.java.net/skara/pull/466/files - new: https://git.openjdk.java.net/skara/pull/466/files/dbd4dc67..d7af0669 Webrevs: - full: https://webrevs.openjdk.java.net/skara/466/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/466/webrev.00-01 Stats: 126 lines in 4 files changed: 70 ins; 18 del; 38 mod Patch: https://git.openjdk.java.net/skara/pull/466.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/466/head:pull/466 PR: https://git.openjdk.java.net/skara/pull/466 From ehelin at openjdk.java.net Tue Feb 25 13:15:13 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 25 Feb 2020 13:15:13 GMT Subject: RFR: Implement shared caching for rest requests In-Reply-To: References: Message-ID: On Tue, 25 Feb 2020 10:39:29 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that implements caching for rest GET requests, as supported by at least GitHub. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/471 From ehelin at openjdk.java.net Tue Feb 25 13:15:43 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 25 Feb 2020 13:15:43 GMT Subject: RFR: Adhere to GitHub's search rate limit In-Reply-To: References: Message-ID: On Tue, 25 Feb 2020 11:30:01 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that searches are not performed too often, to adhere to the special rate limit applied to search queries. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/472 From ehelin at openjdk.java.net Tue Feb 25 13:16:13 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 25 Feb 2020 13:16:13 GMT Subject: RFR: Improve rate limit logging In-Reply-To: <3Oay6ts7tEmWYs29Rh0ukLpgGPRmqrAJztDE_rU0z3s=.60cf7bb9-560c-4353-ac44-27af9dc0920b@github.com> References: <3Oay6ts7tEmWYs29Rh0ukLpgGPRmqrAJztDE_rU0z3s=.60cf7bb9-560c-4353-ac44-27af9dc0920b@github.com> Message-ID: On Tue, 25 Feb 2020 11:53:19 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that improves the rate limit logging. > > Best regards, > Robin Thanks for fixing, looks great! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/473 From rwestberg at openjdk.java.net Tue Feb 25 13:20:19 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 25 Feb 2020 13:20:19 GMT Subject: [Integrated] RFR: Implement shared caching for rest requests In-Reply-To: References: Message-ID: <96b60b90-2b49-48be-a339-671351dcfbf2@openjdk.org> Changeset: f806af12 Author: Robin Westberg Date: 2020-02-25 13:20:01 +0000 URL: https://git.openjdk.java.net/skara/commit/f806af12 Implement shared caching for rest requests Reviewed-by: ehelin ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubApplication.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabHost.java ! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraHost.java ! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraVault.java ! network/src/main/java/org/openjdk/skara/network/RestRequest.java + network/src/main/java/org/openjdk/skara/network/RestRequestCache.java ! network/src/test/java/org/openjdk/skara/network/RestRequestTests.java From rwestberg at openjdk.java.net Tue Feb 25 13:20:31 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 25 Feb 2020 13:20:31 GMT Subject: [Integrated] RFR: Adhere to GitHub's search rate limit In-Reply-To: References: Message-ID: <7369e625-a7df-4fc2-96e1-e47a2ba2d8e1@openjdk.org> Changeset: d435e278 Author: Robin Westberg Date: 2020-02-25 13:20:16 +0000 URL: https://git.openjdk.java.net/skara/commit/d435e278 Adhere to GitHub's search rate limit Reviewed-by: ehelin ! forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java From rwestberg at openjdk.java.net Tue Feb 25 13:20:58 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 25 Feb 2020 13:20:58 GMT Subject: [Integrated] RFR: Improve rate limit logging In-Reply-To: <3Oay6ts7tEmWYs29Rh0ukLpgGPRmqrAJztDE_rU0z3s=.60cf7bb9-560c-4353-ac44-27af9dc0920b@github.com> References: <3Oay6ts7tEmWYs29Rh0ukLpgGPRmqrAJztDE_rU0z3s=.60cf7bb9-560c-4353-ac44-27af9dc0920b@github.com> Message-ID: Changeset: 8f13965c Author: Robin Westberg Date: 2020-02-25 13:20:41 +0000 URL: https://git.openjdk.java.net/skara/commit/8f13965c Improve rate limit logging Reviewed-by: ehelin ! network/src/main/java/org/openjdk/skara/network/RestRequest.java From ehelin at openjdk.java.net Tue Feb 25 14:59:29 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 25 Feb 2020 14:59:29 GMT Subject: RFR: git-jcheck: add support for multiple pre-push hooks Message-ID: Hi all, please review this patch that adds support for multiple kinds of pre-push hooks to `git-jcheck`. A user can now set up either the "branches" pre-push hook and/or the "commits" pre-push hook via `git jcheck --setup-pre-push-hooks=commits,branches`. The "commits" pre-push hook will run all commits about to pushed throught `git-jcheck`. The "branches" pre-push hook will check that you are not pushing to a branch in your personal fork that is also present in the upstream repository (rarely a good idea). Testing: - Manual testing of pre-push hooks and `git-jcheck` on Linux x64 Thanks, Erik ------------- Commits: - fa996599: git-jcheck: add support for multiple pre-push hooks Changes: https://git.openjdk.java.net/skara/pull/474/files Webrev: https://webrevs.openjdk.java.net/skara/474/webrev.00 Stats: 118 lines in 3 files changed: 96 ins; 10 del; 12 mod Patch: https://git.openjdk.java.net/skara/pull/474.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/474/head:pull/474 PR: https://git.openjdk.java.net/skara/pull/474 From rwestberg at openjdk.java.net Wed Feb 26 07:06:32 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 26 Feb 2020 07:06:32 GMT Subject: RFR: git-jcheck: add support for multiple pre-push hooks In-Reply-To: References: Message-ID: On Tue, 25 Feb 2020 14:55:23 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds support for multiple kinds of pre-push hooks > to `git-jcheck`. A user can now set up either the "branches" pre-push hook > and/or the "commits" pre-push hook via `git jcheck > --setup-pre-push-hooks=commits,branches`. The "commits" pre-push hook will run > all commits about to pushed throught `git-jcheck`. The "branches" > pre-push hook will check that you are not pushing to a branch in your personal > fork that is also present in the upstream repository (rarely a good idea). > > Testing: > - Manual testing of pre-push hooks and `git-jcheck` on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/474 From rwestberg at openjdk.java.net Wed Feb 26 08:07:07 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 26 Feb 2020 08:07:07 GMT Subject: RFR: Improve combining of nested review replies Message-ID: Hi all, Please review this change that improves combining review comment replies. As GitHub allows replying in batches to multiple review comments, such replies should be combined into a single email when possible. Best regards, Robin ------------- Commits: - 0859c0bc: Improve combining of nested review replies Changes: https://git.openjdk.java.net/skara/pull/475/files Webrev: https://webrevs.openjdk.java.net/skara/475/webrev.00 Stats: 51 lines in 2 files changed: 33 ins; 4 del; 14 mod Patch: https://git.openjdk.java.net/skara/pull/475.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/475/head:pull/475 PR: https://git.openjdk.java.net/skara/pull/475 From ehelin at openjdk.java.net Wed Feb 26 08:09:53 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 26 Feb 2020 08:09:53 GMT Subject: [Rev 01] RFR: git-jcheck: add support for multiple pre-push hooks In-Reply-To: References: Message-ID: <2icfdru1qa4Tn1svznjPmaMKKxfuz9KtlYoOdRYOd0U=.f08b0819-ede0-40da-9bbc-492212bb6fa4@github.com> > Hi all, > > please review this patch that adds support for multiple kinds of pre-push hooks > to `git-jcheck`. A user can now set up either the "branches" pre-push hook > and/or the "commits" pre-push hook via `git jcheck > --setup-pre-push-hooks=commits,branches`. The "commits" pre-push hook will run > all commits about to pushed throught `git-jcheck`. The "branches" > pre-push hook will check that you are not pushing to a branch in your personal > fork that is also present in the upstream repository (rarely a good idea). > > Testing: > - Manual testing of pre-push hooks and `git-jcheck` on Linux x64 > > Thanks, > Erik The pull request has been updated with 1 additional commit. ------------- Added commits: - ce4c723d: Make git-sync avoid "branches" pre-push hook Changes: - all: https://git.openjdk.java.net/skara/pull/474/files - new: https://git.openjdk.java.net/skara/pull/474/files/fa996599..ce4c723d Webrevs: - full: https://webrevs.openjdk.java.net/skara/474/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/474/webrev.00-01 Stats: 11 lines in 2 files changed: 9 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/474.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/474/head:pull/474 PR: https://git.openjdk.java.net/skara/pull/474 From ehelin at openjdk.java.net Wed Feb 26 08:09:53 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 26 Feb 2020 08:09:53 GMT Subject: [Rev 01] RFR: git-jcheck: add support for multiple pre-push hooks In-Reply-To: References: Message-ID: <7bROwB0cY3Gf8Pbc_XGdcGKXPQrHRrYbjcGfl3VhL-Q=.8adbbcb6-eaa3-4ee4-ba27-50129e5f7d1a@github.com> On Wed, 26 Feb 2020 07:04:25 GMT, Robin Westberg wrote: >> The pull request has been updated with 1 additional commit. > > Looks good! @rwestberg thanks! I just realized that `git-sync` will not work if the "branches" pre-push hook is used ?? I just pushed a new commit that fixes this with a slightly hacky workaround, please have a look! ------------- PR: https://git.openjdk.java.net/skara/pull/474 From rwestberg at openjdk.java.net Wed Feb 26 08:11:41 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 26 Feb 2020 08:11:41 GMT Subject: [Rev 01] RFR: git-jcheck: add support for multiple pre-push hooks In-Reply-To: <2icfdru1qa4Tn1svznjPmaMKKxfuz9KtlYoOdRYOd0U=.f08b0819-ede0-40da-9bbc-492212bb6fa4@github.com> References: <2icfdru1qa4Tn1svznjPmaMKKxfuz9KtlYoOdRYOd0U=.f08b0819-ede0-40da-9bbc-492212bb6fa4@github.com> Message-ID: On Wed, 26 Feb 2020 08:09:53 GMT, Erik Helin wrote: >> Hi all, >> >> please review this patch that adds support for multiple kinds of pre-push hooks >> to `git-jcheck`. A user can now set up either the "branches" pre-push hook >> and/or the "commits" pre-push hook via `git jcheck >> --setup-pre-push-hooks=commits,branches`. The "commits" pre-push hook will run >> all commits about to pushed throught `git-jcheck`. The "branches" >> pre-push hook will check that you are not pushing to a branch in your personal >> fork that is also present in the upstream repository (rarely a good idea). >> >> Testing: >> - Manual testing of pre-push hooks and `git-jcheck` on Linux x64 >> >> Thanks, >> Erik > > The pull request has been updated with 1 additional commit. Looks good, perhaps would be cleaner to pass the state with an environment variable (to avoid leaving marker files in case the process is killed), but should hopefully not be an issue. ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/474 From ehelin at openjdk.java.net Wed Feb 26 10:04:53 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 26 Feb 2020 10:04:53 GMT Subject: [Rev 01] RFR: git-jcheck: add support for multiple pre-push hooks In-Reply-To: References: <2icfdru1qa4Tn1svznjPmaMKKxfuz9KtlYoOdRYOd0U=.f08b0819-ede0-40da-9bbc-492212bb6fa4@github.com> Message-ID: On Wed, 26 Feb 2020 08:09:35 GMT, Robin Westberg wrote: >> The pull request has been updated with 1 additional commit. > > Looks good, perhaps would be cleaner to pass the state with an environment variable (to avoid leaving marker files in case the process is killed), but should hopefully not be an issue. Yeah, I wanted to use environment variables, but it became so ugly to pass then all down through `Repository::push` for this one thing... ------------- PR: https://git.openjdk.java.net/skara/pull/474 From ehelin at openjdk.java.net Wed Feb 26 10:05:35 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 26 Feb 2020 10:05:35 GMT Subject: [Integrated] RFR: git-jcheck: add support for multiple pre-push hooks In-Reply-To: References: Message-ID: <326e2eda-d41f-4ca1-a458-cda8adb74ede@openjdk.org> Changeset: 5016be29 Author: Erik Helin Date: 2020-02-26 10:05:13 +0000 URL: https://git.openjdk.java.net/skara/commit/5016be29 git-jcheck: add support for multiple pre-push hooks Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitFork.java ! cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java ! cli/src/main/java/org/openjdk/skara/cli/GitSync.java ! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrCreate.java From ehelin at openjdk.java.net Wed Feb 26 10:16:25 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 26 Feb 2020 10:16:25 GMT Subject: RFR: Improve combining of nested review replies In-Reply-To: References: Message-ID: On Wed, 26 Feb 2020 08:02:47 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that improves combining review comment replies. As GitHub allows replying in batches to multiple review comments, such replies should be combined into a single email when possible. > > Best regards, > Robin Nice feature, looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/475 From rwestberg at openjdk.java.net Wed Feb 26 11:01:59 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 26 Feb 2020 11:01:59 GMT Subject: [Integrated] RFR: Improve combining of nested review replies In-Reply-To: References: Message-ID: <2bf37166-a43e-4320-923b-7ac981f91f1a@openjdk.org> Changeset: b20675b5 Author: Robin Westberg Date: 2020-02-26 11:01:41 +0000 URL: https://git.openjdk.java.net/skara/commit/b20675b5 Improve combining of nested review replies Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From rwestberg at openjdk.java.net Wed Feb 26 14:37:27 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 26 Feb 2020 14:37:27 GMT Subject: RFR: Wrap long lines in generated email bodies Message-ID: <3-_0NbocB5FDAa09_rm2ZBE-46MBj8l1k0KobfiRA6E=.c91298e5-3c7f-4b1d-9cf3-2fac7d8d85fe@github.com> Hi all, Please review this change that wraps long lines in generated emails, to make them look nicer in the archives. Best regards, Robin ------------- Commits: - 8c82a4e3: Initial implementation Changes: https://git.openjdk.java.net/skara/pull/476/files Webrev: https://webrevs.openjdk.java.net/skara/476/webrev.00 Stats: 134 lines in 3 files changed: 133 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/476.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/476/head:pull/476 PR: https://git.openjdk.java.net/skara/pull/476 From rwestberg at openjdk.java.net Wed Feb 26 15:21:26 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 26 Feb 2020 15:21:26 GMT Subject: [Rev 01] RFR: Wrap long lines in generated email bodies In-Reply-To: <3-_0NbocB5FDAa09_rm2ZBE-46MBj8l1k0KobfiRA6E=.c91298e5-3c7f-4b1d-9cf3-2fac7d8d85fe@github.com> References: <3-_0NbocB5FDAa09_rm2ZBE-46MBj8l1k0KobfiRA6E=.c91298e5-3c7f-4b1d-9cf3-2fac7d8d85fe@github.com> Message-ID: <-NCnlKu010FzjlMtsy1M5SacUB9nxYWpzulTIiaPfFk=.9b9e8ecd-3d12-436a-b1f8-34201a17370f@github.com> > Hi all, > > Please review this change that wraps long lines in generated emails, to make them look nicer in the archives. > > Best regards, > Robin The pull request has been updated with 1 additional commit. ------------- Added commits: - bd93d618: Fix failing test Changes: - all: https://git.openjdk.java.net/skara/pull/476/files - new: https://git.openjdk.java.net/skara/pull/476/files/8c82a4e3..bd93d618 Webrevs: - full: https://webrevs.openjdk.java.net/skara/476/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/476/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/476.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/476/head:pull/476 PR: https://git.openjdk.java.net/skara/pull/476 From rwestberg at openjdk.java.net Wed Feb 26 15:37:30 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 26 Feb 2020 15:37:30 GMT Subject: RFR: 289: Notifier and mailing list bridge does not recognize RFR email prefixes Message-ID: Hi all, Please review this change that fixes a problem where generated RFR emails that are prefixed with branch or repository names are not found by the notifier and the mailing list bridge. Best regards, Robin ------------- Commits: - a25eb6d2: Find prefixed RFR conversations Changes: https://git.openjdk.java.net/skara/pull/477/files Webrev: https://webrevs.openjdk.java.net/skara/477/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-289 Stats: 5 lines in 4 files changed: 1 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/477.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/477/head:pull/477 PR: https://git.openjdk.java.net/skara/pull/477 From ehelin at openjdk.java.net Wed Feb 26 16:29:52 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 26 Feb 2020 16:29:52 GMT Subject: RFR: 289: Notifier and mailing list bridge does not recognize RFR email prefixes In-Reply-To: References: Message-ID: On Wed, 26 Feb 2020 15:30:44 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that fixes a problem where generated RFR emails that are prefixed with branch or repository names are not found by the notifier and the mailing list bridge. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/477 From rwestberg at openjdk.java.net Thu Feb 27 06:44:00 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 06:44:00 GMT Subject: [Integrated] RFR: 289: Notifier and mailing list bridge does not recognize RFR email prefixes In-Reply-To: References: Message-ID: <08521fa4-62ad-460c-a821-9e1b86ed1602@openjdk.org> Changeset: 776aa0a9 Author: Robin Westberg Date: 2020-02-27 06:43:43 +0000 URL: https://git.openjdk.java.net/skara/commit/776aa0a9 289: Notifier and mailing list bridge does not recognize RFR email prefixes Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBot.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBotTests.java ! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java ! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java From rwestberg at openjdk.java.net Thu Feb 27 08:39:35 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 08:39:35 GMT Subject: RFR: Only set auth headers once when decoding paginated results Message-ID: Hi all, Please review this small change that removes a redundant auth header setting when automatically decoding paginated results from a rest request. Best regards, Robin ------------- Commits: - 5227f6d6: Only set auth headers once Changes: https://git.openjdk.java.net/skara/pull/478/files Webrev: https://webrevs.openjdk.java.net/skara/478/webrev.00 Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/478.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/478/head:pull/478 PR: https://git.openjdk.java.net/skara/pull/478 From ehelin at openjdk.java.net Thu Feb 27 08:39:35 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 08:39:35 GMT Subject: RFR: Only set auth headers once when decoding paginated results In-Reply-To: References: Message-ID: On Thu, 27 Feb 2020 08:34:41 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that removes a redundant auth header setting when automatically decoding paginated results from a rest request. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/478 From ehelin at openjdk.java.net Thu Feb 27 08:41:03 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 08:41:03 GMT Subject: RFR: git-pr: add "URL" column to "git pr list" Message-ID: Hi all, please review this small patch that adds a URL column to `git pr list`. Testing: - Manual testing of `git pr list` Thanks, Erik ------------- Commits: - 51dd886a: git-pr: add "URL" column to "git pr list" Changes: https://git.openjdk.java.net/skara/pull/479/files Webrev: https://webrevs.openjdk.java.net/skara/479/webrev.00 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/479.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/479/head:pull/479 PR: https://git.openjdk.java.net/skara/pull/479 From rwestberg at openjdk.java.net Thu Feb 27 08:41:03 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 08:41:03 GMT Subject: RFR: git-pr: add "URL" column to "git pr list" In-Reply-To: References: Message-ID: On Thu, 27 Feb 2020 08:35:09 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that adds a URL column to `git pr list`. > > Testing: > - Manual testing of `git pr list` > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/479 From ehelin at openjdk.java.net Thu Feb 27 08:44:21 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 08:44:21 GMT Subject: [Integrated] RFR: git-pr: add "URL" column to "git pr list" In-Reply-To: References: Message-ID: Changeset: 3b4883b0 Author: Erik Helin Date: 2020-02-27 08:43:56 +0000 URL: https://git.openjdk.java.net/skara/commit/3b4883b0 git-pr: add "URL" column to "git pr list" Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrList.java From rwestberg at openjdk.java.net Thu Feb 27 08:45:13 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 08:45:13 GMT Subject: [Integrated] RFR: Only set auth headers once when decoding paginated results In-Reply-To: References: Message-ID: Changeset: 5d1fbcf3 Author: Robin Westberg Date: 2020-02-27 08:44:51 +0000 URL: https://git.openjdk.java.net/skara/commit/5d1fbcf3 Only set auth headers once when decoding paginated results Reviewed-by: ehelin ! network/src/main/java/org/openjdk/skara/network/RestRequest.java From ehelin at openjdk.java.net Thu Feb 27 08:44:48 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 08:44:48 GMT Subject: RFR: cli: rename git-status to git-info Message-ID: Hi all, please review this patch that renames `git pr status` to `git pr info`. The patch also adds a bunch flags to `git pr info` for querying information about a pull request. For example: $ git pr info 479 --title --url URL: https://github.com/openjdk/skara/pull/479 Title: git-pr: add "URL" column to "git pr list" If no switches are provided, then all information is shown about a pull request: $ git pr info 479 URL: https://github.com/openjdk/skara/pull/479 Title: git-pr: add "URL" column to "git pr list" Author: edvbld Branch: master Labels: cli, ready, rfr Assignees: - Reviewers: rwestberg Contributors: - Status: READY Issue: - Checks: - jcheck: OK Commits: - 51dd886a: git-pr: add "URL" column to "git pr list" Testing: - Manual testing of `git pr info` on Linux x64 Thanks, Erik ------------- Commits: - e2568069: cli: rename git-status to git-info Changes: https://git.openjdk.java.net/skara/pull/480/files Webrev: https://webrevs.openjdk.java.net/skara/480/webrev.00 Stats: 697 lines in 5 files changed: 587 ins; 108 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/480.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/480/head:pull/480 PR: https://git.openjdk.java.net/skara/pull/480 From ehelin at openjdk.java.net Thu Feb 27 09:03:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 09:03:19 GMT Subject: [Integrated] RFR: cli: rename git-status to git-info In-Reply-To: References: Message-ID: Changeset: b8e1e15a Author: Erik Helin Date: 2020-02-27 09:03:00 +0000 URL: https://git.openjdk.java.net/skara/commit/b8e1e15a cli: rename git-status to git-info Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java + cli/src/main/java/org/openjdk/skara/cli/pr/GitPrInfo.java - cli/src/main/java/org/openjdk/skara/cli/pr/GitPrStatus.java + forge/src/main/java/org/openjdk/skara/forge/PullRequestBody.java + forge/src/test/java/org/openjdk/skara/forge/PullRequestBodyTests.java From ehelin at openjdk.java.net Thu Feb 27 09:04:52 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 09:04:52 GMT Subject: RFR: cli: rename git-status to git-info In-Reply-To: References: Message-ID: On Thu, 27 Feb 2020 08:55:06 GMT, Robin Westberg wrote: >> Hi all, >> >> please review this patch that renames `git pr status` to `git pr info`. The >> patch also adds a bunch flags to `git pr info` for querying information about a >> pull request. For example: >> >> $ git pr info 479 --title --url >> URL: https://github.com/openjdk/skara/pull/479 >> Title: git-pr: add "URL" column to "git pr list" >> >> If no switches are provided, then all information is shown about a pull request: >> >> $ git pr info 479 >> URL: https://github.com/openjdk/skara/pull/479 >> Title: git-pr: add "URL" column to "git pr list" >> Author: edvbld >> Branch: master >> Labels: cli, ready, rfr >> Assignees: - >> Reviewers: rwestberg >> Contributors: - >> Status: READY >> Issue: - >> Checks: >> - jcheck: OK >> Commits: >> - 51dd886a: git-pr: add "URL" column to "git pr list" >> >> Testing: >> - Manual testing of `git pr info` on Linux x64 >> >> Thanks, >> Erik > > Looks good, guess the PR body parser should be used in more places! Yeah, I'm planning to do a little bit of searching around to see where we can use the parser ?? Thanks for reviewing! ------------- PR: https://git.openjdk.java.net/skara/pull/480 From rwestberg at openjdk.java.net Thu Feb 27 08:57:13 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 08:57:13 GMT Subject: RFR: cli: rename git-status to git-info In-Reply-To: References: Message-ID: On Thu, 27 Feb 2020 08:40:56 GMT, Erik Helin wrote: > Hi all, > > please review this patch that renames `git pr status` to `git pr info`. The > patch also adds a bunch flags to `git pr info` for querying information about a > pull request. For example: > > $ git pr info 479 --title --url > URL: https://github.com/openjdk/skara/pull/479 > Title: git-pr: add "URL" column to "git pr list" > > If no switches are provided, then all information is shown about a pull request: > > $ git pr info 479 > URL: https://github.com/openjdk/skara/pull/479 > Title: git-pr: add "URL" column to "git pr list" > Author: edvbld > Branch: master > Labels: cli, ready, rfr > Assignees: - > Reviewers: rwestberg > Contributors: - > Status: READY > Issue: - > Checks: > - jcheck: OK > Commits: > - 51dd886a: git-pr: add "URL" column to "git pr list" > > Testing: > - Manual testing of `git pr info` on Linux x64 > > Thanks, > Erik Looks good, guess the PR body parser should be used in more places! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/480 From rwestberg at openjdk.java.net Thu Feb 27 10:41:28 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 10:41:28 GMT Subject: [Rev 02] RFR: Wrap long lines in generated email bodies In-Reply-To: <3-_0NbocB5FDAa09_rm2ZBE-46MBj8l1k0KobfiRA6E=.c91298e5-3c7f-4b1d-9cf3-2fac7d8d85fe@github.com> References: <3-_0NbocB5FDAa09_rm2ZBE-46MBj8l1k0KobfiRA6E=.c91298e5-3c7f-4b1d-9cf3-2fac7d8d85fe@github.com> Message-ID: > Hi all, > > Please review this change that wraps long lines in generated emails, to make them look nicer in the archives. > > Best regards, > Robin The pull request has been updated with 1 additional commit. ------------- Added commits: - 01efb128: Test and fix a few special cases Changes: - all: https://git.openjdk.java.net/skara/pull/476/files - new: https://git.openjdk.java.net/skara/pull/476/files/bd93d618..01efb128 Webrevs: - full: https://webrevs.openjdk.java.net/skara/476/webrev.02 - incr: https://webrevs.openjdk.java.net/skara/476/webrev.01-02 Stats: 81 lines in 2 files changed: 55 ins; 13 del; 13 mod Patch: https://git.openjdk.java.net/skara/pull/476.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/476/head:pull/476 PR: https://git.openjdk.java.net/skara/pull/476 From neugens at openjdk.java.net Thu Feb 27 11:09:02 2020 From: neugens at openjdk.java.net (Mario Torre) Date: Thu, 27 Feb 2020 11:09:02 GMT Subject: RFR: 290: Goodies to help keeping the fork up2date Message-ID: add git-sync to the README ------------- Commits: - f2bfacf4: add git-sync to the README Changes: https://git.openjdk.java.net/skara/pull/481/files Webrev: https://webrevs.openjdk.java.net/skara/481/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-290 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/481.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/481/head:pull/481 PR: https://git.openjdk.java.net/skara/pull/481 From ehelin at openjdk.java.net Thu Feb 27 11:19:31 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 11:19:31 GMT Subject: RFR: git-fork: use --fast-forward instead of --pull when syncing Message-ID: Hi all, please review this small patch that makes `git fork` use `--fast-forward` when running `git-sync` instead of `--pull`. Using `--fast-forward` ensures that all branches in the newly cloned repository will be up to date. Testing: - Manual testing of `git fork` on Linux x64 Thanks, Erik ------------- Commits: - 7073b65e: git-fork: use --fast-forward instead of --pull when syncing Changes: https://git.openjdk.java.net/skara/pull/482/files Webrev: https://webrevs.openjdk.java.net/skara/482/webrev.00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/482.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/482/head:pull/482 PR: https://git.openjdk.java.net/skara/pull/482 From ehelin at openjdk.java.net Thu Feb 27 11:26:01 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 11:26:01 GMT Subject: RFR: 290: Goodies to help keeping the fork up2date In-Reply-To: References: Message-ID: On Thu, 27 Feb 2020 10:50:30 GMT, Mario Torre wrote: > add git-sync to the README Looks good, thanks for fixing! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/481 From ehelin at openjdk.java.net Thu Feb 27 11:35:32 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 11:35:32 GMT Subject: [Integrated] RFR: 290: Goodies to help keeping the fork up2date In-Reply-To: References: Message-ID: Changeset: 710d5057 Author: Mario Torre Committer: Erik Helin Date: 2020-02-27 11:35:04 +0000 URL: https://git.openjdk.java.net/skara/commit/710d5057 290: Goodies to help keeping the fork up2date Reviewed-by: ehelin ! README.md From rwestberg at openjdk.java.net Thu Feb 27 12:09:20 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 12:09:20 GMT Subject: RFR: git-fork: use --fast-forward instead of --pull when syncing In-Reply-To: References: Message-ID: <3bHL5QtFQy7ClQjEGYJ5-EC0GHJmiJFE5H3buG3_akc=.e9716e37-224a-4320-987e-010690fc989c@github.com> On Thu, 27 Feb 2020 11:15:23 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes `git fork` use `--fast-forward` when > running `git-sync` instead of `--pull`. Using `--fast-forward` ensures that all > branches in the newly cloned repository will be up to date. > > Testing: > - Manual testing of `git fork` on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/482 From rwestberg at openjdk.java.net Thu Feb 27 12:11:50 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 12:11:50 GMT Subject: RFR: 291: Intermittent test failure in RestRequestTests.cachedSeparateAuth Message-ID: Hi all, Please review this small fix for an intermittent test issue. Best regards, Robin ------------- Commits: - f688acf9: Fix intermittent test issue Changes: https://git.openjdk.java.net/skara/pull/483/files Webrev: https://webrevs.openjdk.java.net/skara/483/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-291 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/483.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/483/head:pull/483 PR: https://git.openjdk.java.net/skara/pull/483 From rwestberg at openjdk.java.net Thu Feb 27 11:12:56 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 11:12:56 GMT Subject: RFR: 290: Goodies to help keeping the fork up2date In-Reply-To: References: Message-ID: On Thu, 27 Feb 2020 10:50:30 GMT, Mario Torre wrote: > add git-sync to the README Please ignore the failing linux build and test, it's caused by an intermittent failure tracked by https://bugs.openjdk.java.net/browse/SKARA-291 ------------- PR: https://git.openjdk.java.net/skara/pull/481 From rwestberg at openjdk.java.net Thu Feb 27 12:37:37 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 12:37:37 GMT Subject: [Rev 01] RFR: 291: Intermittent test failure in RestRequestTests.cachedSeparateAuth In-Reply-To: References: Message-ID: <_kWubJ2ywmWTRMbLQVRg37cHTY1y1lTnDIjI6CDDXyc=.a354f042-ba41-46c3-9993-e064475650de@github.com> > Hi all, > > Please review this small fix for an intermittent test issue. > > Best regards, > Robin The pull request has been updated with 1 additional commit. ------------- Added commits: - 7f347ec7: Now with the actual fix Changes: - all: https://git.openjdk.java.net/skara/pull/483/files - new: https://git.openjdk.java.net/skara/pull/483/files/f688acf9..7f347ec7 Webrevs: - full: https://webrevs.openjdk.java.net/skara/483/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/483/webrev.00-01 Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/483.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/483/head:pull/483 PR: https://git.openjdk.java.net/skara/pull/483 From ehelin at openjdk.java.net Thu Feb 27 13:13:44 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 13:13:44 GMT Subject: [Integrated] RFR: git-fork: use --fast-forward instead of --pull when syncing In-Reply-To: References: Message-ID: <57e12af5-61f2-46d8-a1d7-8fce7b3acba8@openjdk.org> Changeset: 6b7e7875 Author: Erik Helin Date: 2020-02-27 13:13:30 +0000 URL: https://git.openjdk.java.net/skara/commit/6b7e7875 git-fork: use --fast-forward instead of --pull when syncing Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitFork.java From ehelin at openjdk.java.net Thu Feb 27 13:17:53 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 13:17:53 GMT Subject: [Rev 02] RFR: Wrap long lines in generated email bodies In-Reply-To: References: <3-_0NbocB5FDAa09_rm2ZBE-46MBj8l1k0KobfiRA6E=.c91298e5-3c7f-4b1d-9cf3-2fac7d8d85fe@github.com> Message-ID: <1cKsVESLnSMRn9mRtNXLjMCJhNUoNkmctQnzCfJYQs4=.5d87d9bb-0d91-4f2e-b276-e58fb256d967@github.com> On Thu, 27 Feb 2020 10:41:28 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this change that wraps long lines in generated emails, to make them look nicer in the archives. >> >> Best regards, >> Robin > > The pull request has been updated with 1 additional commit. Nice feature, looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/476 From ehelin at openjdk.java.net Thu Feb 27 13:18:32 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 13:18:32 GMT Subject: [Rev 01] RFR: Include commit messages in mail body for new revision emails In-Reply-To: References: Message-ID: On Tue, 25 Feb 2020 12:39:20 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this change that includes the commit messages in the mail body when a new revision email is sent out, which should improve quoting. >> >> Best regards, >> Robin > > The pull request has been updated with 2 additional commits. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/466 From ehelin at openjdk.java.net Thu Feb 27 13:19:02 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 13:19:02 GMT Subject: [Rev 01] RFR: 291: Intermittent test failure in RestRequestTests.cachedSeparateAuth In-Reply-To: <_kWubJ2ywmWTRMbLQVRg37cHTY1y1lTnDIjI6CDDXyc=.a354f042-ba41-46c3-9993-e064475650de@github.com> References: <_kWubJ2ywmWTRMbLQVRg37cHTY1y1lTnDIjI6CDDXyc=.a354f042-ba41-46c3-9993-e064475650de@github.com> Message-ID: <1Ecql4O3iwKukPILQmrPdJAvtMWcnfAA_bYa8PQm0Hw=.c3a63b7b-5cbb-4e55-9e1a-6769aea2f995@github.com> On Thu, 27 Feb 2020 12:37:37 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this small fix for an intermittent test issue. >> >> Best regards, >> Robin > > The pull request has been updated with 1 additional commit. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/483 From rwestberg at openjdk.java.net Thu Feb 27 13:27:29 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 13:27:29 GMT Subject: [Integrated] RFR: 291: Intermittent test failure in RestRequestTests.cachedSeparateAuth In-Reply-To: References: Message-ID: <90f782f8-9872-4a0f-834b-742b865d3cc2@openjdk.org> Changeset: 170ee1e8 Author: Robin Westberg Date: 2020-02-27 13:27:09 +0000 URL: https://git.openjdk.java.net/skara/commit/170ee1e8 291: Intermittent test failure in RestRequestTests.cachedSeparateAuth Reviewed-by: ehelin ! network/src/test/java/org/openjdk/skara/network/RestRequestTests.java From rwestberg at openjdk.java.net Thu Feb 27 13:28:13 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 13:28:13 GMT Subject: [Integrated] RFR: Wrap long lines in generated email bodies In-Reply-To: <3-_0NbocB5FDAa09_rm2ZBE-46MBj8l1k0KobfiRA6E=.c91298e5-3c7f-4b1d-9cf3-2fac7d8d85fe@github.com> References: <3-_0NbocB5FDAa09_rm2ZBE-46MBj8l1k0KobfiRA6E=.c91298e5-3c7f-4b1d-9cf3-2fac7d8d85fe@github.com> Message-ID: <7fd6249e-e0c0-4360-8236-6dff8e732381@openjdk.org> Changeset: d8f9a355 Author: Robin Westberg Date: 2020-02-27 13:27:54 +0000 URL: https://git.openjdk.java.net/skara/commit/d8f9a355 Wrap long lines in generated email bodies Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java + email/src/main/java/org/openjdk/skara/email/WordWrap.java + email/src/test/java/org/openjdk/skara/email/WordWrapTests.java From rwestberg at openjdk.java.net Thu Feb 27 13:34:44 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 13:34:44 GMT Subject: [Rev 02] RFR: Include commit messages in mail body for new revision emails In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that includes the commit messages in the mail body when a new revision email is sent out, which should improve quoting. > > Best regards, > Robin The pull request has been updated with a new target base due to a merge or a rebase. ------------- Commits: - 240cffd5: Merge remote-tracking branch 'upstream/master' into commits_in_body_v2 - d7af0669: Update tests - d6109c67: Text updates - dbd4dc67: Initial version Changes: https://git.openjdk.java.net/skara/pull/466/files Webrev: https://webrevs.openjdk.java.net/skara/466/webrev.02 Stats: 235 lines in 4 files changed: 142 ins; 19 del; 74 mod Patch: https://git.openjdk.java.net/skara/pull/466.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/466/head:pull/466 PR: https://git.openjdk.java.net/skara/pull/466 From ehelin at openjdk.java.net Thu Feb 27 13:35:50 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 13:35:50 GMT Subject: RFR: git-pr: integrate should handle sponsor messages Message-ID: Hi all, please review this small patch that makes `git pr integrate` handle replies from the bots about the PR needing a sponsor. Thanks, Erik ------------- Commits: - 040c3bb1: git-pr: integrate should handle sponsor messages Changes: https://git.openjdk.java.net/skara/pull/484/files Webrev: https://webrevs.openjdk.java.net/skara/484/webrev.00 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/484.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/484/head:pull/484 PR: https://git.openjdk.java.net/skara/pull/484 From rwestberg at openjdk.java.net Thu Feb 27 13:36:04 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 13:36:04 GMT Subject: RFR: git-pr: integrate should handle sponsor messages In-Reply-To: References: Message-ID: On Thu, 27 Feb 2020 13:30:38 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes `git pr integrate` handle replies from > the bots about the PR needing a sponsor. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/484 From rwestberg at openjdk.java.net Thu Feb 27 14:03:04 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 14:03:04 GMT Subject: [Integrated] RFR: Include commit messages in mail body for new revision emails In-Reply-To: References: Message-ID: Changeset: f0d04633 Author: Robin Westberg Date: 2020-02-27 14:02:50 +0000 URL: https://git.openjdk.java.net/skara/commit/f0d04633 Include commit messages in mail body for new revision emails Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From ehelin at openjdk.java.net Thu Feb 27 15:00:44 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 15:00:44 GMT Subject: RFR: git-pr: add the sponsor subcommand Message-ID: Hi all, please review this patch that adds the `git pr sponsor` subcommand. The command `git pr sponsor` can be used for integrating pull requests that needs sponsoring. Thanks, Erik ------------- Commit messages: - git-pr: add the sponsor subcommand Changes: https://git.openjdk.java.net/skara/pull/485/files Webrev: https://webrevs.openjdk.java.net/skara/485/webrev.00 Stats: 107 lines in 2 files changed: 107 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/485.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/485/head:pull/485 PR: https://git.openjdk.java.net/skara/pull/485 From rwestberg at openjdk.java.net Thu Feb 27 15:08:39 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 27 Feb 2020 15:08:39 GMT Subject: RFR: git-pr: add the sponsor subcommand In-Reply-To: References: Message-ID: <4qG_lEkYVCuSvcPOkjZAMFsT-yW2brAdRz403Csosuw=.9f26d7ad-6acb-4423-82df-7c051ce8c3b0@github.com> On Thu, 27 Feb 2020 14:33:32 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `git pr sponsor` subcommand. The command > `git pr sponsor` can be used for integrating pull requests that needs > sponsoring. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/485 From ehelin at openjdk.java.net Thu Feb 27 16:01:07 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 16:01:07 GMT Subject: [Integrated] RFR: git-pr: integrate should handle sponsor messages In-Reply-To: References: Message-ID: <815c3c9f-04c5-41df-b97c-76834b89c29b@openjdk.org> Changeset: 3cbddf02 Author: Erik Helin Date: 2020-02-27 16:00:50 +0000 URL: https://git.openjdk.java.net/skara/commit/3cbddf02 git-pr: integrate should handle sponsor messages Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrIntegrate.java From ehelin at openjdk.java.net Thu Feb 27 16:01:35 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 27 Feb 2020 16:01:35 GMT Subject: [Integrated] RFR: git-pr: add the sponsor subcommand In-Reply-To: References: Message-ID: Changeset: d931228e Author: Erik Helin Date: 2020-02-27 16:01:15 +0000 URL: https://git.openjdk.java.net/skara/commit/d931228e git-pr: add the sponsor subcommand Reviewed-by: rwestberg ! cli/src/main/java/org/openjdk/skara/cli/GitPr.java + cli/src/main/java/org/openjdk/skara/cli/pr/GitPrSponsor.java From rwestberg at openjdk.java.net Fri Feb 28 07:15:38 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 28 Feb 2020 07:15:38 GMT Subject: RFR: Use @mentions to improve email threading Message-ID: Hi all, Please review this change that looks for an `@mention` marker in comments, to select which comment to use as the parent when creating a threaded email. Best regards, Robin ------------- Commit messages: - Add support for review comment threads as well - Find mentions in plain comments Changes: https://git.openjdk.java.net/skara/pull/486/files Webrev: https://webrevs.openjdk.java.net/skara/486/webrev.00 Stats: 161 lines in 2 files changed: 160 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/486.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/486/head:pull/486 PR: https://git.openjdk.java.net/skara/pull/486 From rwestberg at openjdk.java.net Fri Feb 28 08:17:28 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 28 Feb 2020 08:17:28 GMT Subject: RFR: Add gradle wrapper properties file to help IDEs Message-ID: Hi all, Please review this change that adds a gradle-wrapper.properties file that describes the required version of Gradle. This will make IDEs such as IntelliJ able to open the project out of the box. Best regards, Robin ------------- Commit messages: - Add gradle wrapper properties file to help IDEs Changes: https://git.openjdk.java.net/skara/pull/487/files Webrev: https://webrevs.openjdk.java.net/skara/487/webrev.00 Stats: 23 lines in 1 file changed: 23 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/487.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/487/head:pull/487 PR: https://git.openjdk.java.net/skara/pull/487 From rwestberg at openjdk.java.net Fri Feb 28 08:57:31 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 28 Feb 2020 08:57:31 GMT Subject: RFR: Preserve paragraph breaks when word wrapping Message-ID: Hi all, Please review this change that ensures that paragraph breaks are preserved when breaking long lines. Best regards, Robin ------------- Commit messages: - Preserve paragraph breaks Changes: https://git.openjdk.java.net/skara/pull/488/files Webrev: https://webrevs.openjdk.java.net/skara/488/webrev.00 Stats: 6 lines in 2 files changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/488.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/488/head:pull/488 PR: https://git.openjdk.java.net/skara/pull/488 From ehelin at openjdk.java.net Fri Feb 28 09:07:12 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 28 Feb 2020 09:07:12 GMT Subject: RFR: Add gradle wrapper properties file to help IDEs In-Reply-To: References: Message-ID: On Fri, 28 Feb 2020 08:13:40 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that adds a gradle-wrapper.properties file that describes the required version of Gradle. > This will make IDEs such as IntelliJ able to open the project out of the box. > Best regards, > Robin Looks good! We are gonna need a few more file to get IntelliJ to "just work", but I will fix that in a follow-up patch. ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/487 From rwestberg at openjdk.java.net Fri Feb 28 09:06:40 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 28 Feb 2020 09:06:40 GMT Subject: [Integrated] RFR: Add gradle wrapper properties file to help IDEs In-Reply-To: References: Message-ID: Changeset: 1f14c173 Author: Robin Westberg Date: 2020-02-28 09:06:20 +0000 URL: https://git.openjdk.java.net/skara/commit/1f14c173 Add gradle wrapper properties file to help IDEs Reviewed-by: ehelin + gradle/wrapper/gradle-wrapper.properties From ehelin at openjdk.java.net Fri Feb 28 09:24:45 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 28 Feb 2020 09:24:45 GMT Subject: RFR: Preserve paragraph breaks when word wrapping In-Reply-To: References: Message-ID: On Fri, 28 Feb 2020 08:53:43 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that paragraph breaks are preserved when breaking long lines. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/488 From rwestberg at openjdk.java.net Fri Feb 28 09:24:57 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 28 Feb 2020 09:24:57 GMT Subject: [Integrated] RFR: Preserve paragraph breaks when word wrapping In-Reply-To: References: Message-ID: Changeset: ca1bbe51 Author: Robin Westberg Date: 2020-02-28 09:24:42 +0000 URL: https://git.openjdk.java.net/skara/commit/ca1bbe51 Preserve paragraph breaks when word wrapping Reviewed-by: ehelin ! email/src/main/java/org/openjdk/skara/email/WordWrap.java ! email/src/test/java/org/openjdk/skara/email/WordWrapTests.java From rwestberg at openjdk.java.net Fri Feb 28 09:25:54 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 28 Feb 2020 09:25:54 GMT Subject: [Integrated] RFR: Use @mentions to improve email threading In-Reply-To: References: Message-ID: Changeset: 7d37ea9b Author: Robin Westberg Date: 2020-02-28 09:25:28 +0000 URL: https://git.openjdk.java.net/skara/commit/7d37ea9b Use @mentions to improve email threading Reviewed-by: ehelin ! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java ! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java From ehelin at openjdk.java.net Fri Feb 28 09:24:11 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 28 Feb 2020 09:24:11 GMT Subject: RFR: Use @mentions to improve email threading In-Reply-To: References: Message-ID: On Thu, 27 Feb 2020 15:32:43 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that looks for an `@mention` marker in comments, to select which comment to use as the parent > when creating a threaded email. > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/486