RFR: 251: Bypass PR update cache when the cooldown period expires for a bridge candidate
Robin Westberg
rwestberg at openjdk.java.net
Tue Feb 4 09:19:52 UTC 2020
On Fri, 31 Jan 2020 13:28:29 GMT, Erik Helin <ehelin at openjdk.org> wrote:
>> Hi all,
>>
>> Please review this change that ensures that the mailing list bridge bot retries the bridge operation if it was initially delayed due to the configured cooldown period.
>>
>> Best regards,
>> Robin
>
> bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/CooldownQuarantine.java line 46:
>
>> 45: public synchronized boolean inQuarantine(PullRequest pr) {
>> 46: var uniqueId = getUniqueId(pr);
>> 47:
>
> Suggestion:
>
> var uniqueId = pr.webUrl();
Sounds reasonable!
-------------
PR: https://git.openjdk.java.net/skara/pull/388
More information about the skara-dev
mailing list