RFR: 257: Proper setting of custom fields in Jira issues

[Erik Helin]

On Tue, 4 Feb 2020 12:05:33 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that properly sets custom fields when creating Jira issues.
> 
> Best regards,
> Robin

Looks good! Just a minor nit: since this patch was created the `JSON` API has gotten the possibility to query `JSONValue` objects for their type using `is*` methods (e.g. `isObject()`). If you merge master into this PR then you will be able to use these new methods ��

issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java line 204:

> 203:         }
> 204:         if (unfiltered instanceof JSONObject) {
> 205:             if (unfiltered.asObject().contains("id")) {

Suggestion:

        if (unfiltered.isObject()) {

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/392