RFR: Add toString methods to all WorkItems

Robin Westberg rwestberg at openjdk.java.net
Thu Feb 6 10:52:56 UTC 2020


On Thu, 6 Feb 2020 10:47:09 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that adds proper `toString` implementations to
> all classes implementing `WorkItem` (to get better logging).
> 
> Thanks,
> Erik

Looks good, just one pre-existing inconsistent spacing issue.

bots/mirror/src/main/java/org/openjdk/skara/bots/mirror/MirrorBot.java line 88:

> 87:     public String toString() {
> 88:         return "MirrorBot@" + from.name() + "-> " + to.name();
> 89:     }

Suggestion:

        return "MirrorBot@" + from.name() + " -> " + to.name();

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/403


More information about the skara-dev mailing list