RFR: git-pr: status cannot handle rfr label correctly

Robin Westberg rwestberg at openjdk.java.net
Tue Feb 11 06:38:23 UTC 2020

On Mon, 10 Feb 2020 15:35:17 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this small pull request that updates how the status for a pull
> request is calculated. We changed a while back to keep the "rfr" label on pull
> requests that are ready (a PR is still "ready for review" even if it already has
> been reviewed). `git pr status` wasn't updated however, so it printed the wrong
> status for pull requests. This patch fixes this issue, so `git pr status` once
> again works correctly.
> Testing:
> - Manual testing of `git pr status` and `git pr list`
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/419

More information about the skara-dev mailing list