RFR: Always set commit_id and comments when adding review

Robin Westberg rwestberg at openjdk.java.net
Tue Feb 11 06:38:44 UTC 2020


On Mon, 10 Feb 2020 14:42:14 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that ensures that we always set the fields
> `commit_id` and `comments` when adding a review to a GitHub pull request.
> 
> Testing:
> - Manual testing using `git pr approve`
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/418


More information about the skara-dev mailing list