RFR: contributor command: better validation of input
Robin Westberg
rwestberg at openjdk.java.net
Tue Feb 11 09:13:21 UTC 2020
On Tue, 11 Feb 2020 09:03:36 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
>
> please review this patch that adds a bit more strict validation of the input to
> the `/contributor add` command. This is done to ensure that the resulting
> `Co-authored-by` trailer in the final commit message will be approved by jcheck.
>
> Testing:
> - Added two additional unit tests for validation
> - `make test` passes on Linux x64
>
> Thanks,
> Erik
Looks good!
-------------
Marked as reviewed by rwestberg (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/421
More information about the skara-dev
mailing list