RFR: Fix parsing of editor commandline in git-pr

[Erik Helin]

On Tue, 11 Feb 2020 07:44:06 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Thanks Christopher! I agree, if it is possible to have quotation marks around the binary in `core.editor`, then we should support that. Looking at your patch, what do you think about doing something perhaps a bit simpler than a regular expression:
>> 
>> var parts = editor.split(" ");
>> if (parts.length > 0) {
>>     var binary = parts[0];
>>     // Binary might be wrapped in quotes on Windows
>>     if (binary.startsWith(""") && binary.endsWith(""")) {
>>         parts[0] = binary.substring(1, binary.length() - 1);
>>     }
>> }
>> var pb = new ProcessBuilder(parts);
> 
>> Thanks Christopher! I agree, if it is possible to have quotation marks around the binary in `core.editor`, then we should support that. Looking at your patch, what do you think about doing something perhaps a bit simpler than a regular expression:
>> 
>> ```java
>> var parts = editor.split(" ");
>> if (parts.length > 0) {
>>     var binary = parts[0];
>>     // Binary might be wrapped in quotes on Windows
>>     if (binary.startsWith(""") && binary.endsWith(""")) {
>>         parts[0] = binary.substring(1, binary.length() - 1);
>>     }
>> }
>> var pb = new ProcessBuilder(parts);
>> ```
> 
> Hm, I agree that something simpler and more explicit than such a regexp would be desirable. But, as for your suggestion, what if the binary path contains blanks? Then it would be distributed along parts[0...n]. Furthermore, the options for the editor could also be quoted items with blanks in it. So, I guess the regexp would handle all that.

Ah right, my UNIX brain forgot about paths with spaces in them �� Yes, seems like we need the regular expression here. Just a quick question on the last part of the regex, `\\s*`, will that turn into groups? I wanted to make sure that we execute the editor _with_ all the arguments the user might have added.

-------------

PR: https://git.openjdk.java.net/skara/pull/259