RFR: pr-bot: throw on unexpected jcheck issues

Robin Westberg rwestberg at openjdk.java.net
Tue Feb 11 10:00:39 UTC 2020


On Tue, 11 Feb 2020 09:50:46 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please _carefully_ review this patch that throws `IllegalStateException` for
> some jcheck issues that shouldn't happen for commits that the PR bot has
> created. I think I have gone through all cases, but would appreciate careful
> reviewing here ��
> 
> Testing:
> - `make test` passes on Linux x64
> 
> Thanks,
> Erik

After careful consideration, I declare this to be looking good.

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/423


More information about the skara-dev mailing list