RFR: test-bot: better logging for IOException
Robin Westberg
rwestberg at openjdk.java.net
Wed Feb 12 11:27:02 UTC 2020
On Wed, 12 Feb 2020 11:15:36 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
>
> please review this small patch that updates the logging for the test bot when it
> receives an `IOException`.
>
> Testing:
> - `make test` passes on Linux x64
>
> Thanks,
> Erik
Looks good, just a minor comment.
bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestBot.java line 100:
> 99: log.info("Could not retrieve test jobs for PR: " + desc);
> 100: log.info(e.getMessage());
> 101: }
Perhaps use log.throwing here?
-------------
Marked as reviewed by rwestberg (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/430
More information about the skara-dev
mailing list