RFR: git-webrev: show commit messages

Robin Westberg rwestberg at openjdk.java.net
Mon Feb 17 12:14:15 UTC 2020

On Mon, 17 Feb 2020 10:48:48 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that adds commit messages to webrevs (if applicable).
> The current `MetadataFormatter` is a bit bare-bones, I plan to enhance it in
> future patches. I had to implement a few overloads of `commitMetadata` to
> support this feature, hence the changes to `vcs`.
> Testing:
> - Added unit tests for `commitMetadata`
> - Manual testing of `git-webrev` for both Git and Mercurial repositories
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/441

More information about the skara-dev mailing list