[Rev 01] RFR: git-webrev: show commit messages

Erik Helin ehelin at openjdk.java.net
Mon Feb 17 15:34:03 UTC 2020

> Hi all,
> please review this patch that adds commit messages to webrevs (if applicable).
> The current `MetadataFormatter` is a bit bare-bones, I plan to enhance it in
> future patches. I had to implement a few overloads of `commitMetadata` to
> support this feature, hence the changes to `vcs`.
> Testing:
> - Added unit tests for `commitMetadata`
> - Manual testing of `git-webrev` for both Git and Mercurial repositories
> Thanks,
> Erik

The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.


Added commits:
 - 584b709f: Support for Mercurial 5.3
 - 26b47534: Merge branch 'master' into git-pr-commit-message
 - 2ef003b5: Refactor notifier bot constructors
 - a0b9185b: 279: Optionally only update project-specific issues
 - 7f3f4b2e: 270: Remove ignored reviews from the summary
 - 4c469bf0: Add HostUserDetails::email
 - 57f1d634: Make Host::user return Optional<String>
 - c23c574f: vcs: add support for Mercurial 5.3

  - all: https://git.openjdk.java.net/skara/pull/441/files
  - new: https://git.openjdk.java.net/skara/pull/441/files/33a8ded3..584b709f

 - full: https://webrevs.openjdk.java.net/skara/441/webrev.01
 - incr: https://webrevs.openjdk.java.net/skara/441/webrev.00-01

  Stats: 992 lines in 28 files changed: 777 ins; 22 del; 193 mod
  Patch: https://git.openjdk.java.net/skara/pull/441.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/441/head:pull/441

PR: https://git.openjdk.java.net/skara/pull/441

More information about the skara-dev mailing list