[Rev 01] RFR: Add checkout instructions to PR body

Jorn Vernee jvernee at openjdk.java.net
Tue Feb 18 10:44:18 UTC 2020

On Tue, 18 Feb 2020 07:54:51 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Nice work! Just a small nit, you can use a Markdown [thematic break](https://spec.commonmark.org/0.29/#thematic-break) instead of using the `<hr />` HTML tag directly.
> It seems like the test `org.openjdk.skara.bots.pr.ContributorTests > prBodyUpdates` is failing on both Linux and Mac. I think you have to change these two lines:
> - https://github.com/openjdk/skara/blob/master/bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java#L335
>    `                if (line.equals("## Contributors")) {`
> - https://github.com/openjdk/skara/blob/master/bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java#L355
>    `                assertNotEquals("## Contributors", line);`

@edvbld Thanks Erik,

That test is being skipped when running on Windows and I'm seeing a lot of "STANDARD_ERROR"s in the build log for the workflow, so not sure if this was a false negative.

I gave the latest version a run on WSL. There are a lot of failing tests if I do that, unrelated to this PR, but at least the particular test is now passing.


PR: https://git.openjdk.java.net/skara/pull/434

More information about the skara-dev mailing list