RFR: csr bot: use pull request cache

Erik Helin ehelin at openjdk.java.net
Tue Feb 18 13:48:08 UTC 2020

On Tue, 18 Feb 2020 13:38:19 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Hi all,
>> please review this patch that makes the CSR bot use the pull request cache. The
>> CSR bot now has two phases, the first phase simply checks if any updated has
>> gotten the "csr" label. The addition of a "csr" label can only happen by
>> comments being added to the PR, so the `PullRequestCache` will return these PRs
>> are requiring an update.
>> The second phase then loops through all pull requests that have the CSR label
>> and check if the CSR request has been resolved.
>> Testing:
>> - `make test` passes on Linux x64
>> Thanks,
>> Erik
> bots/csr/src/main/java/org/openjdk/skara/bots/csr/CSRBot.java line 76:
>> 75:                 hasCSRLabel.add(pr.id());
>> 76:             }
>> 77:         }
> Perhaps check if the CSR_LABEL is gone but the PR is in hasCSRLabel, in case it was manually removed?

Good idea, will fix!


PR: https://git.openjdk.java.net/skara/pull/451

More information about the skara-dev mailing list